Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-01-08
15:16:58 efried stephenfin: regarding the ImageMetaProps updates... I'm not sure.
15:18:20 efried I always thought of image meta props the same as flavor extra specs -- a bag of random key/values that we can "enhance" without microversion changes -- except for some reason (that I never understood, never asked about) we actually have OVOs for image meta props, which need to be updated.
15:19:31 efried but like extra specs, I would have expected them to show up in a REST payload like the others
15:20:07 efried and be settable like anything else
15:21:49 openstackgerrit Eric Fried proposed openstack/nova-specs master: Spec: Ussuri: Encrypted Emulated Virtual TPM https://review.opendev.org/686804
15:21:57 sean-k-mooney efried: yes the can be extended without microverion changes
15:22:07 efried stephenfin, gibi, sean-k-mooney: with just that update about the API check --^
15:22:12 sean-k-mooney but the image metadata object is an ovo
15:22:22 sean-k-mooney so it will alter the object version
15:22:52 efried right; stephenfin is asking whether the new fields will be visible/settable via the API, and I don't see why not?
15:23:10 sean-k-mooney we do not allow arbiary keys to be set in the image metadata
15:23:16 sean-k-mooney but it should be visable yes
15:23:24 sean-k-mooney we dont allow you to downgrade the ovo
15:23:39 sean-k-mooney to strip out new keys and get an older version
15:24:11 efried by "arbitrary" you mean keys that we haven't explicitly registered, which is why we register them. But anything we've registered, you can set
15:24:28 sean-k-mooney yes
15:24:38 sean-k-mooney although this is set in glance not nova obviously
15:28:10 efried right, and then we pull in a copy of the meta and store it with the instance record, which is why this object exists in nova in the first place.
15:28:33 efried not sure why we needed it for image meta but not flavor extra specs tho
15:28:43 sean-k-mooney yes more or less
15:28:53 efried or rather, why we couldn't leave it out for image meta like we left it out for extra specs.
15:28:58 sean-k-mooney we did not have it for the image metadata orgithily
15:29:04 sean-k-mooney it was just a dict of strings
15:29:11 dansmith efried: you can use flavor extra specs for other things though right?
15:29:16 dansmith and schedule on them with things like the json filter?
15:29:35 sean-k-mooney but we stadarised it wehn we made the nova image an objec t in juno i think
15:29:54 sean-k-mooney dansmith: you used to be able to do the same with the image metadata
15:29:57 dansmith I think the problem with image props came because people were using them as a covert conduit between the user (which can set them) and the virt driver and bypassing nova
15:29:59 efried I'm not sure I understand a distinction dansmith. We've been using image meta props for scheduling decisions as long as I've been involved
15:30:18 efried okay, right, I was going to ask whether it had something to do with admin/flavor vs user/image.
15:30:39 dansmith efried: also, the problem is that image properties live a long time and we had a huge problem with virt drivers using different props for the same thing.. flavor extra specs are admin-only and we can force people to fix them during an upgrade
15:31:39 efried Okay. If there's a reason, so be it. I don't super care to challenge the status quo, since it's easy to add properties. Really just curious why they were different.
15:32:11 efried but back to stephenfin's question, which seems odd to me as worded
15:32:22 sean-k-mooney well the topic of makeing the extra specs versioned like the image meta has come up before
15:32:40 dansmith I think the "images live forever and are controlled by users" is the reason
15:32:42 sean-k-mooney but then we dont have a place to do the current non standdard thngs
15:33:10 efried Right, we've always punted on it because of the nonstandard things, things we don't know about etc.
15:33:22 efried which is one of the challenges stephenfin is facing with the validation effort.
15:33:54 dansmith yeah, it's also why I have a hard time getting excited about that
15:34:13 sean-k-mooney ya so we could always add a seperate sandardsed metadata filed that was versioned and leve extra specs for the unversioned stuff but its never really been urgent enough
15:34:17 dansmith I know we need to do it,
15:34:18 dansmith but it's always been a big bag of stuff
16:04:11 efried gibi: Could I ask you to review this please https://review.opendev.org/#/c/699050/ ? It bumps us to using placement 1.35, sets a request_level_params next to requested_resources in the RequestSpec, and lets us unwind the request filter hacks where we were transiently modifying the flavor extra specs.
16:04:40 efried ...and Dan is +2.
16:11:21 sean-k-mooney bauzas: https://review.opendev.org/#/c/700529/
16:11:55 bauzas sean-k-mooney: that's a different bug but okay
16:12:48 sean-k-mooney yes its a similar cause the _copy_resources function does create a copy and instead modifyes the stats
16:12:49 openstackgerrit Victor Morales proposed openstack/nova master: Update Testing NUMA documentation https://review.opendev.org/701301
16:43:14 stephenfin I'm seeing a lot of failures in the nova-next job, all due to 'Multiple possible networks found, use a Network ID to be more specific.'
16:43:33 stephenfin I feel we have a bug open against this. Anyone know of one?
16:44:03 artom stephenfin, it does ring a bell...
16:50:57 efried stephenfin: Yeah, this cropped up again recently and was fixed again. I could dig, but probably asking in -neutron would be the fastest way to get to the bottom.
16:53:53 stephenfin efried: Yeah, I'll do that
16:56:03 openstackgerrit Merged openstack/nova master: Update Testing NUMA documentation https://review.opendev.org/701301
17:03:27 openstackgerrit Sylvain Bauza proposed openstack/nova master: Avoid PlacementFixture silently swallowing kwargs https://review.opendev.org/695180
17:03:27 openstackgerrit Sylvain Bauza proposed openstack/nova master: Add a placement audit command https://review.opendev.org/670112
17:21:57 gibi efried: added https://review.opendev.org/#/c/699050/ to my queue
17:22:09 gibi efried: I will look at it tomorrow morning
17:22:28 efried thanks gibi!
17:28:59 mriedem efried: since i reviewed that before, i've +2ed the latest since it lgtm, but will let someone else approve
17:29:28 efried mriedem: okay, cool, thank you.
17:32:44 efried stephenfin: in case you missed it, vTPM spec is updated as discussed earlier. But I was curious about your comment about viewing/setting the image meta props.
17:41:13 openstackgerrit Matt Riedemann proposed openstack/nova master: doc: define boot from volume in the glossary https://review.opendev.org/699009
18:23:54 openstackgerrit Dustin Cowles proposed openstack/nova master: Provider Config File: Enable loading and merging of provider configs https://review.opendev.org/693460
18:29:09 openstackgerrit Dan Smith proposed openstack/nova master: Add a workaround config toggle to refuse ceph image upload https://review.opendev.org/657078
18:29:33 dansmith efried: ^this is left over from a couple PTGs ago. You were +2 on it and I just tweaked a few things you and mriedem pointed out
18:38:14 efried ...
18:56:13 efried dansmith: pretty much ready to +2 that; if you could just respond to those couple of comments please.
18:56:28 efried And would prefer at least the backtick change be made. I'm here to re-look quickly.
18:59:36 dansmith efried: I'll fix the backticks, section naming and s/ceph/rbd.
18:59:55 efried cool
19:01:39 efried dansmith: I was referring to the suggestion of adding compute_driver=libvirt as a related option.
19:02:15 dansmith oh, missed that too I guess
19:02:27 dansmith I had made a few of these changes right when the feedback came in like a year ago
19:02:28 efried I don't consider that blocking, just .. yeah, wanted to make sure you had at least seen it
19:02:32 dansmith and then went back to finish just now, so..
19:02:37 efried nbd
19:04:06 openstackgerrit Dan Smith proposed openstack/nova master: Add a workaround config toggle to refuse ceph image upload https://review.opendev.org/657078
19:04:23 dansmith efried: ^
19:07:36 efried dansmith: missed the rename in the reno; and while you're respinning, a quick change to the conf help.
19:08:01 dansmith oh doh
19:08:53 dansmith lol
19:09:28 dansmith the backticks thing I looked a line below to see if the went in or out and then didn't do what I saw
19:09:34 efried heh
19:09:42 openstackgerrit Dan Smith proposed openstack/nova master: Add a workaround config toggle to refuse ceph image upload https://review.opendev.org/657078
19:09:45 dansmith how about this one? JEEZ
19:10:02 efried this is why we recommend avoiding the hard liquor during work hours.
19:10:11 efried Fortified wine max.
19:10:36 efried +2
19:10:47 efried I really should have racked up some -1s for stackalytics there.
19:11:35 dansmith heh
19:42:20 openstackgerrit sean mooney proposed openstack/os-vif master: move os-vif-ovs to be a non legacy job. https://review.opendev.org/701601
19:58:30 openstackgerrit sean mooney proposed openstack/os-vif master: optimise tempest testing https://review.opendev.org/701607
20:21:51 mriedem since i got a ping, i left comments on https://review.opendev.org/#/c/657078/
20:29:41 openstackgerrit Victor Coutellier proposed openstack/nova master: Non-admin user can filter their instances by AZs https://review.opendev.org/701609
20:30:43 openstackgerrit Victor Coutellier proposed openstack/nova master: Non-admin user can filter their instances by AZs https://review.opendev.org/701609
20:43:49 openstackgerrit Dan Smith proposed openstack/nova master: Add a workaround config toggle to refuse ceph image upload https://review.opendev.org/657078
20:57:39 efried dansmith: Remind me where it's written that microversion requires spec? I thought http://specs.openstack.org/openstack/nova-specs/readme.html but no
20:58:18 dansmith uh, on the walls? I dunno
21:05:57 sean-k-mooney efried: i think it was more a micorversion bump is an api change and all api changes need a spec

Earlier   Later