| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-12-12 | |||
| 19:15:12 | dansmith | I don't, but I didn't see whatever he was referring to | |
| 19:15:44 | sean-k-mooney | stephens unicode house 🏠 | |
| 19:16:17 | sean-k-mooney | which you proably didnt also see there because i just copy pasted it | |
| 19:16:49 | dansmith | I see the house, I just don't know what a boaring house is..or what a studded paddle has to do with it | |
| 19:16:53 | dansmith | but whatevs | |
| 19:17:02 | mriedem | stephen said he liked the pain, | |
| 19:17:08 | mriedem | i made an S&M joke | |
| 19:17:14 | mriedem | and now we're here | |
| 19:17:30 | dansmith | and a boaring house is like a S&M dungeon? | |
| 19:17:54 | sean-k-mooney | no its just me misspelling boring | |
| 19:18:23 | dansmith | oh | |
| 19:18:56 | mriedem | alternative to me waiting for stephen or the gib in the morning to re-approve, if someone else wants to eyeball PS56 to PS57 here and confirm that the only things i changed are what i called out https://review.opendev.org/#/c/637316/57 i'll re-approve and unblock the other 4 or so approved changes after that in the gate | |
| 19:19:21 | mriedem | since it takes a couple of days to merge code i'd like to start the recheck bus now | |
| 19:20:59 | dansmith | 57 was just changes due to rebase? | |
| 19:21:05 | mriedem | yes | |
| 19:21:17 | sean-k-mooney | im looking at it now so far it looks identical | |
| 19:21:43 | mriedem | caused by this https://review.opendev.org/#/c/697694/1 | |
| 19:22:36 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Add BFV wrinkle to TestNovaManagePlacementHealAllocations https://review.opendev.org/698531 | |
| 19:22:36 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Add --instance option to heal_allocations https://review.opendev.org/698529 | |
| 19:24:37 | sean-k-mooney | mriedem: ya so i dont see any change other then the ones you noted | |
| 19:24:57 | mriedem | ack thanks sean-k-mooney and dansmith | |
| 19:25:12 | mriedem | bottom 6 cross-cell changes are on their way which is nice | |
| 19:25:51 | sean-k-mooney | yep it is | |
| 19:27:07 | sean-k-mooney | ok im goign to get dinner and likely call it a day. o/ | |
| 19:28:23 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Do not reschedule on ExternalNetworkAttachForbidden https://review.opendev.org/694179 | |
| 19:30:58 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Create instance action when burying in cell0 https://review.opendev.org/694165 | |
| 19:38:35 | efried | sean-k-mooney: I'll try to get to it in the next couple hours. | |
| 19:38:47 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add NodeOwnerFilter https://review.opendev.org/697331 | |
| 19:44:14 | mriedem | dansmith: in order to avoid a compute service version check workaround thing, what do you think about just checking for vcenter here in U and remove in V? https://review.opendev.org/#/c/695220/3/nova/compute/api.py@3881 | |
| 19:44:44 | dansmith | mriedem: seriously? | |
| 19:44:45 | mriedem | won't work for any out of tree cluster driver that supports same-host cold migration but....so what? | |
| 19:45:10 | mriedem | well, what's the alternative? get the compute service version and if old, fallback to existing behavior? | |
| 19:45:17 | mriedem | that was my original thought | |
| 19:45:32 | dansmith | I definitely don't want to start a trend of putting virt-specific hacks into upper layers | |
| 19:45:57 | mriedem | ok so do what i have documented there as the todo | |
| 19:46:07 | mriedem | check service versoin, if old fallback to use the config | |
| 19:46:10 | mriedem | remove that in V | |
| 19:46:15 | dansmith | yes | |
| 19:46:18 | mriedem | alright then | |
| 19:46:35 | dansmith | as you should | |
| 19:47:03 | dansmith | let it be remembered for all time, the last thing mriedem tried to do was an api-level hack for vmware | |
| 19:47:14 | dansmith | can you self paddle? | |
| 19:47:21 | mriedem | can a bear shit in the woods? | |
| 19:47:26 | dansmith | heh | |
| 19:47:26 | dansmith | nevermind, don't answer | |
| 20:00:33 | sean-k-mooney | hehe if only this was archive publicly for al time | |
| 20:00:44 | sean-k-mooney | *all | |
| 20:11:17 | KeithMnemonic | mriedem do you have a few to help me with a different marker issue. this one is in master as well and easily reproducible | |
| 20:12:40 | KeithMnemonic | not sure if it is just how horizon handles it or is it something in nova. under instances, there is not a prev/next button that came from this patch https://review.opendev.org/#/c/498018/34 | |
| 20:12:50 | KeithMnemonic | s/not/now | |
| 20:13:21 | KeithMnemonic | so that patch added a prev button, prior there was only next. but if you jump forward and back a few times you see it does not work as expected | |
| 20:14:09 | KeithMnemonic | seems to be due to the original list is not sorted or the sort is not maintained after doing 'next' than 'prev' | |
| 20:15:46 | KeithMnemonic | for example i have 5 instances test-1 through test-5. i set the "items per page" under admin settings to 2 | |
| 20:17:25 | KeithMnemonic | if i jump fresh to instances i see test-5, test-4, if i click next i get test-2, test-1. if i click prev, i get test test-3 and test-1 | |
| 20:17:44 | KeithMnemonic | so horizon is using marker= and prev_marker= and that seems to not work well | |
| 20:18:01 | KeithMnemonic | has anyone else seen this? | |
| 20:18:09 | mriedem | prev_marker isn't a thing in nova | |
| 20:18:20 | KeithMnemonic | so something horizon bonked? | |
| 20:18:38 | mriedem | maybe they aren't providing the full query params to maintain a consistent sort order, i.e. not passing the sort_key/sort_dir params when paging? | |
| 20:23:29 | KeithMnemonic | could be maybe somewhere in here https://opendev.org/openstack/horizon/src/branch/master/horizon/tables/base.py#L699 | |
| 20:25:09 | mriedem | idk | |
| 20:25:14 | mriedem | don't really have time to dig into that | |
| 20:26:14 | KeithMnemonic | no problem let me go bother horizon, thanks for confirming | |
| 20:26:57 | mriedem | but it does look like they are losing the sort key/dir | |
| 20:29:05 | efried | sean-k-mooney: https://review.opendev.org/#/c/674072/ +A, nice work on those tests. (See inline though.) | |
| 20:31:41 | mriedem | a couple of low-hanging bugs if someone wants something to play with | |
| 20:31:43 | openstack | Launchpad bug 1856241 in OpenStack Compute (nova) "Compute API in nova - servers_links should link to paging doc" [Undecided,New] | |
| 20:31:43 | mriedem | https://bugs.launchpad.net/nova/+bug/1856241 | |
| 20:31:46 | mriedem | https://bugs.launchpad.net/nova/+bug/1856240 | |
| 20:31:47 | openstack | Launchpad bug 1856240 in OpenStack Compute (nova) "wait_for_versioned_notifications gives unhelpful error message "ValueError: Not a text type application/octet-stream" on timeout" [Undecided,Confirmed] | |
| 20:57:10 | jroll | melwitt: re https://bugzilla.redhat.com/show_bug.cgi?id=1688838 - I feel like cpu_arch used to be required, but not 100%. looks like we intentionally made it not required here, at least: https://review.opendev.org/#/c/620634/ | |
| 20:57:11 | openstack | bugzilla.redhat.com bug 1688838 in openstack-nova "Ironic should not treat cpu_arch as mandatory" [Medium,New] - Assigned to mwitt | |
| 20:59:38 | openstackgerrit | Eric Fried proposed openstack/nova master: DRY: Build ImageMetaPropsPayload from ImageMetaProps https://review.opendev.org/698803 | |
| 20:59:47 | efried | dansmith: question in here ^ for you | |
| 21:00:00 | efried | sean-k-mooney: that ^ passes tests :) | |
| 21:01:58 | dansmith | efried: if the question is whether they need to be instances or classes, they need to be the former | |
| 21:02:21 | dansmith | the instance is what contains things like nullable=, default=, etc | |
| 21:02:34 | dansmith | and just because those don't have any of those set (currently) doesn't affect what the rest of the code is expecting | |
| 21:02:51 | efried | The question is whether they need to be discrete instances for every field of every object, or whether I could just copy in the instances from the other class. | |
| 21:03:30 | efried | int1: f, | |
| 21:03:30 | efried | fields = { | |
| 21:03:30 | efried | class MyObj(...): | |
| 21:03:30 | efried | f = IntegerField() | |
| 21:03:30 | efried | like, could I theoretically do this: | |
| 21:03:31 | efried | } | |
| 21:03:31 | efried | int2: f, | |
| 21:03:52 | dansmith | oh, well, I'll have to go look, | |
| 21:03:59 | dansmith | but the convention is obviously for each to be new | |
| 21:04:11 | dansmith | I can't remember if we stash any object-specific state in the field | |
| 21:04:19 | efried | Okay. Then prolly leave the code as it is now | |
| 21:05:12 | efried | thanks | |
| 21:06:23 | openstackgerrit | Eric Fried proposed openstack/nova master: DRY: Build ImageMetaPropsPayload from ImageMetaProps https://review.opendev.org/698803 | |
| 21:06:31 | efried | done, and changed the TODO to a NOTE | |
| 21:27:54 | sean-k-mooney | efried: oh i forgot the has. i just ran the test i added | |
| 21:27:58 | sean-k-mooney | *hash | |
| 21:28:16 | efried | sean-k-mooney: yahbut, see my fup | |
| 21:28:41 | efried | was going to say maybe you want to squash; but really they are quite different things, so let's keep them separate. | |
| 21:28:57 | efried | plus I don't want to lose the ability to +2 yours :P | |
| 21:29:22 | sean-k-mooney | yep i did i was wondering about that | |
| 21:29:34 | sean-k-mooney | if we do the follow up then we might as well nuke the object | |