Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-10-30
15:11:39 mriedem note that those are just docs...not code
15:11:40 efried oh, that's just a doc thing? (/me doesn't really understand policy)
15:11:41 efried got it.
15:11:57 mriedem right, the policy rule is real, the API method / route stuff is docs
15:12:38 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add functional test for two-cell scheduler behaviors https://review.opendev.org/452006
15:13:13 mriedem ah gdi, fake_nodes
15:13:33 efried melwitt, mriedem: +W. If you want to hit any of that other stuff in the fup too, feel free, but none of it was super important.
15:14:08 melwitt ok, thanks
15:14:20 gibi mriedem: fix is on the way, and then I will +2 it
15:14:27 efried - the fact that the host_status field is omitted, not included as ""
15:14:27 efried - the name of the policy rule
15:14:27 efried melwitt: also, wouldn't hurt to update the bp text for at least these two things:
15:15:01 efried (there turned out to be no spec for this, right?)
15:15:03 melwitt ah, right, will do
15:15:09 efried thx
15:15:10 melwitt yeah no spec
15:15:25 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add functional test for two-cell scheduler behaviors https://review.opendev.org/452006
15:18:32 dansmith mriedem: question for you in there, and figure I'm standing by for you to remove that comment and split the patches if you're going to
15:19:27 mriedem i'll split the patches if needed but not keen to if i can help it, at least for the volume GET stuff since that touches a lot of unit tests. the config option docs and such are easy to split out though, but also minor.
15:19:48 dansmith mriedem: yep I figured, hence my comment about it :)
15:20:05 dansmith it's easy enough to see what test changes are related to the refactor so I'm not too concerned
15:20:15 dansmith mriedem: are you planning to backport this?
15:26:42 mriedem dansmith: replied, it's about pinning the instance to the default 'nova' zone which is a no-no
15:27:04 mriedem dansmith: backporting it would probably be difficult, at least past train
15:28:01 mriedem i guess it depends on how much people/distros need it, but it's extremely latent and from talking to smorrison about this he says his users just have to always specify an az
15:28:05 dansmith mriedem: okay, I didn't think about the cinder default being 'nova'
15:28:17 dansmith mriedem: sure, was just curious
15:29:38 mriedem actually it won't even backport cleanly to train b/c of https://review.opendev.org/#/c/667133/
15:29:58 mriedem that's pretty trivial to resolve though
15:33:33 openstackgerrit Matt Riedemann proposed openstack/nova master: Add support matrix for Delete (Abort) on-going live migration https://review.opendev.org/625781
15:35:01 artom mriedem, can https://review.opendev.org/#/c/649419/ be expected to merge? I want to know if I can backport it internally to Newton
15:35:06 dansmith mriedem: yeah, it's cool, I just kinda thought you'd be wanting that, is all
15:35:09 artom Or should I stick to the merged pike version
15:37:22 openstackgerrit Matthew Booth proposed openstack/nova master: Allow alternate implementations of mount/umount in _HostMountState https://review.opendev.org/692174
15:37:22 openstackgerrit Matthew Booth proposed openstack/nova master: Cleanup libvirt test_mount unit tests https://review.opendev.org/692173
15:38:20 mriedem artom: ask your stable core brethren
15:39:03 artom lyarwood, around? plz to be lookink at https://review.opendev.org/#/c/649419/ :)
15:39:20 mriedem dansmith: i'm cool with not backporting it and letting it bake on master. if let's say some edge distro product thing needed it then i could be convinced to backport...
15:39:26 openstack artom: Error: Error getting bugzilla.redhat.com bug #1633909: NotPermitted
15:39:26 artom lyarwood, it would facilitate the backport for https://bugzilla.redhat.com/show_bug.cgi?id=1633909, which we want for OSP10z14
15:39:31 dansmith mriedem: heh
15:39:36 artom openstack, apologies
15:40:18 artom Ah, he took the whole day off as PTO
15:40:27 mriedem there are others
15:40:52 mriedem there is one in france always saying he's happy to review backports
15:41:55 artom He's on PTO as well
15:42:00 mriedem jesus
15:42:02 dansmith artom: I can hit that if you want
15:42:13 artom dansmith, thank you :)
15:42:23 dansmith seems reasonable, it's a nasty issue, if we still care about it
15:42:34 artom melwitt, you were next on the list! But dansmith preempted tht
15:42:37 artom *that
15:42:42 melwitt woohoo
15:42:48 openstackgerrit Eric Fried proposed openstack/nova master: Only allow one scheduler service in tests https://review.opendev.org/682486
15:44:15 dansmith artom: I just couldn't stand to see where it was going with mriedem calling out all the team
15:44:47 artom dansmith, ... it was going to melwitt :P
15:45:31 dansmith artom: right, who I figured was stranded with no services in the third world country we call California
15:45:38 artom And on fire.
15:46:31 melwitt haha
15:46:33 mriedem you can always bug tonyb https://review.opendev.org/#/admin/groups/540,members
15:47:49 openstackgerrit Eric Fried proposed openstack/nova master: Only allow one scheduler service in tests https://review.opendev.org/682486
15:48:04 melwitt I have learned to greatly appreciate when I have internet access
15:48:39 mriedem my grandpappy always said internet is a privilege not a right
15:49:29 mriedem you know this has to be done: https://southpark.cc.com/clips/x2wsii/is-there-internet-here
15:51:33 melwitt lol
15:51:53 dansmith that's pretty much how I picture california in my head
15:54:17 melwitt that was me driving to different coffee shops and libraries looking for wifi. first three places I tried didn't have internet
15:55:22 melwitt "is there internet here??"
15:55:25 artom melwitt, actually, you might still be on the hook for https://review.opendev.org/#/c/649419/ and the patch above it, looks like dansmith didn't +W
15:55:39 artom Two RH +2s for a non-RH backport is cool, right?
15:55:47 melwitt yeah
15:55:55 dansmith artom: yeah I figured if she was around she'd be hitting it after I'm done
15:56:10 artom I misled her by explicitly told her you'd preempted her
15:56:12 artom Mea culpa
15:56:43 melwitt :)
16:02:12 dansmith mriedem: aren't you respinning the az one to remove the bulk comment? that's why I didn't +2
16:08:18 mriedem dansmith: yeah i will, was busy abandoning old patches from my dashboard
16:15:07 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Reset vm_state to original value if rebuild claim fails https://review.opendev.org/692185
16:19:03 melwitt mriedem: do you remember how is REQUIRES_LOCKING related to NeutronFixture? I couldn't find a note about it in nova/test.py https://review.opendev.org/649419
16:21:08 mriedem melwitt: i think it's related to https://review.opendev.org/#/c/649385/ and how if you're using nova-net you have to require locking b/c of the network manager
16:21:13 mriedem but it's been a long time since i did that backport
16:21:27 melwitt ok, was just curious
16:22:32 openstackgerrit Matt Riedemann proposed openstack/nova master: Default AZ for instance if cross_az_attach=False and checking from API https://review.opendev.org/469675
16:22:33 mriedem dansmith: ^
16:46:12 openstackgerrit Eric Fried proposed openstack/nova master: Use SDK for add/remove instance info from node https://review.opendev.org/659691
16:46:18 openstackgerrit Eric Fried proposed openstack/nova master: Use SDK for getting network metadata from node https://review.opendev.org/670213
16:57:21 AJaeger nova stable cores, please review https://review.opendev.org/692032 to update train opensuse job so that Infra can retire openSUSE 15.0
17:09:21 mriedem done
17:17:05 openstackgerrit Matt Riedemann proposed openstack/nova master: Reset vm_state to original value if rebuild claim fails https://review.opendev.org/692185
17:18:13 artom melwitt, dansmith thanks you folks for the backport reviews!
18:09:26 openstack Launchpad bug 1850682 in OpenStack Compute (nova) "functional tests in rocky randomly fail with "Build of instance was re-scheduled: Cannot modify readonly field uuid"" [Undecided,New]
18:09:26 mriedem dansmith: i think i found a justification for https://review.opendev.org/#/c/669545/ now - https://bugs.launchpad.net/nova/+bug/1850682
18:10:10 dansmith aight
18:10:48 openstackgerrit Matt Riedemann proposed openstack/nova master: Nova compute: add in log exception to help debug failures https://review.opendev.org/669545
18:18:03 openstackgerrit Eric Fried proposed openstack/nova master: Use annotated ddt for test_cpu_policy_constraint https://review.opendev.org/692205
18:19:03 artom Some sort of timeout
18:19:14 artom And their stupid interface means hitting the back button loses all you bug text
18:19:38 artom It's still saved by firefox as part of the POST request though, so if I just keep hitting refresh and re-sending...
18:22:17 openstackgerrit Artom Lifshitz proposed openstack/nova master: Avoid error 500 on shelve task_state race https://review.opendev.org/692206
18:24:13 artom There we go

Earlier   Later