| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-10-23 | |||
| 21:21:15 | mriedem | melwitt: unrelated to this? https://review.opendev.org/#/c/220622/ | |
| 21:21:44 | melwitt | mriedem: that fixes one of the two spots | |
| 21:22:17 | mriedem | so are you talking about this? https://zuul.opendev.org/t/openstack/build/8b011c8d92134f27ab59a8d392267b2e/log/controller/logs/screen-n-novnc-cell1.txt.gz#31 | |
| 21:22:23 | mriedem | INFO nova.console.websocketproxy [-] 213.32.72.99 - - [23/Oct/2019 19:12:55] 213.32.72.99: Path: '?token=badacaffcc2-6d65-4bc4-a2f5-4081318d0433' | |
| 21:22:30 | melwitt | yes that's the other one | |
| 21:22:38 | melwitt | and that's logged from websockify underneath | |
| 21:22:44 | mriedem | i feel like i remember something recently about a bug with logging and the websockify stuff but can't put my finger on it | |
| 21:23:08 | melwitt | orly? ok. it has always emitted the 'Path:' there but now the token auth is in the path | |
| 21:24:56 | mriedem | wonder if there is a way to plumb a flag down to tell it not to log the path or mask certain keys | |
| 21:25:15 | mriedem | it's not a cve since this is just in the logs | |
| 21:25:18 | melwitt | yeah, I have to go take a gander | |
| 21:25:46 | melwitt | and review the patch you linked. looks pretty simple | |
| 21:26:20 | mriedem | and i have to go sit through maleficent 2, taking one for the team | |
| 21:26:23 | mriedem | speaking of bad stuff | |
| 21:26:39 | melwitt | lol | |
| 21:34:02 | efried | dansmith: what's your stance on testing requirements for the cyborg interaction? tempest > functional > unit, to the point where if there's tempest we can live without functional? | |
| 22:03:41 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: YAML file loading and schema validation https://review.opendev.org/673341 | |
| 22:03:42 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: Merge provider configs to provider tree https://review.opendev.org/676522 | |
| 22:03:42 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs https://review.opendev.org/676029 | |
| 23:58:30 | openstackgerrit | melanie witt proposed openstack/nova master: Add new policy rule for viewing host status UNKNOWN https://review.opendev.org/679181 | |
| #openstack-nova - 2019-10-24 | |||
| 01:02:05 | mriedem_afk | efried: imo, we have fixtures for all external services we interact with heavily for the most part (cinder/neutron/glance) so functional testing with a cyborg fixture is going to be a lot faster and simpler than waiting for tempest plugin integration tests that are just going to be using a fake driver in cyborg anyway | |
| 02:31:56 | openstackgerrit | Merged openstack/nova stable/rocky: Fix exception translation when creating volume https://review.opendev.org/688089 | |
| 03:29:12 | openstackgerrit | Son Pham proposed openstack/nova-specs master: recheck https://review.opendev.org/690789 | |
| 04:57:59 | openstackgerrit | melanie witt proposed openstack/nova master: Add new policy rule for viewing host status UNKNOWN https://review.opendev.org/679181 | |
| 06:33:58 | bauzas | good morning Nova | |
| 06:44:37 | openstackgerrit | pengyuesheng proposed openstack/os-resource-classes master: Switch to Ussuri jobs https://review.opendev.org/690857 | |
| 06:47:19 | openstackgerrit | pengyuesheng proposed openstack/os-vif master: Switch to Ussuri jobs https://review.opendev.org/690860 | |
| 07:06:07 | openstackgerrit | Merged openstack/nova master: Fix listing deleted servers with a marker https://review.opendev.org/690429 | |
| 07:06:13 | openstackgerrit | Merged openstack/nova stable/queens: Retrun 400 if invalid query parameters are specified https://review.opendev.org/676028 | |
| 08:30:28 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Ignore volume exceptions during post_live_migration https://review.opendev.org/682622 | |
| 13:34:41 | mriedem | melwitt: thanks for fixing http://grafana.openstack.org/d/-iKINcImz/ceph-failure-rate?orgId=1 - nova master looks good now | |
| 13:53:26 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Make nova-next multinode and drop tempest-slow-py3 https://review.opendev.org/683988 | |
| 14:19:51 | openstackgerrit | Merged openstack/os-resource-classes master: Switch to Ussuri jobs https://review.opendev.org/690857 | |
| 14:56:49 | openstackgerrit | Eric Fried proposed openstack/os-resource-classes master: Stop testing with py2 https://review.opendev.org/690996 | |
| 14:59:21 | openstackgerrit | Eric Fried proposed openstack/os-traits master: Stop testing with py2 https://review.opendev.org/690997 | |
| 15:01:42 | melwitt | mriedem: np. re: train and the other stable branches, when I browsed on https://graphite.opendev.org I couldn't seen to find any jobs for our stable/train branch and no data for stein and rocky. is graphite no longer the thing to look at or? I just didn't know what was going on, so I stuck to only updating master for now | |
| 15:09:01 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use admin neutron client to query ports for binding https://review.opendev.org/690999 | |
| 15:13:02 | mriedem | melwitt: yeah i noticed the same when i was poking through graphite this morning looking at those stable branches | |
| 15:13:15 | mriedem | i'm also not sure why glance isn't showing anything on master since the jobs for glance are correct | |
| 15:13:24 | mriedem | there is just no data in graphite for some reason | |
| 15:13:32 | melwitt | yeah, so I was concerned that if I added train, it wouldn't work. I need to ask -infra | |
| 15:13:38 | melwitt | oh hm | |
| 15:24:20 | openstackgerrit | Merged openstack/os-vif master: Switch to Ussuri jobs https://review.opendev.org/690860 | |
| 15:29:48 | mriedem | melwitt: just a few things in your host_status policy patch https://review.opendev.org/#/c/679181/ | |
| 15:30:41 | melwitt | thanks | |
| 15:33:03 | melwitt | how to do that | |
| 15:33:03 | melwitt | I'll try to adjust the sleep thing like you suggested. I had based it on this https://github.com/openstack/nova/blob/master/nova/tests/functional/test_server_group.py#L420 after having some trouble setting the down time lower. but I didn't try the sleep 0.5 thing. but, as I'm typing this, I think we have a way of advancing time in tests with oslo.timeutils. so that would be an ideal way to make this better. I'm gonna see if I can find | |
| 15:33:57 | melwitt | and if that works, I can propose a change to improve test_server_group as well since it's a 10 second slow thing too | |
| 15:34:19 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use admin neutron client to gather port resource requests https://review.opendev.org/691005 | |
| 15:42:50 | mriedem | ah yeah i forgot about the oslo timeutils stuff | |
| 15:48:25 | mriedem | novaclient 16.0.0 extension list removal also breaks osc https://github.com/openstack/python-openstackclient/blob/45af14ca72b44c03f14189ac61a29253faf03bd7/openstackclient/common/extension.py#L94 | |
| 15:48:26 | mriedem | weee | |
| 16:46:50 | KeithMnemonic | mriedem , melwitt can i ask you some more about the osc thing from yesterday. the simple fix mriedem is not resolving it. i seems to be as you said with how find_resource does the search. but trying to capture/analyze this is ran into something that is probably obvious here but not to me. I can curl compute/servers/detail?deleted=True and get a list of deleted, if I add in the marker to the same curl i get | |
| 16:46:51 | KeithMnemonic | a 401 Unauthroized. any thoughts on why that happens? | |
| 16:47:14 | KeithMnemonic | same token,.... | |
| 16:47:40 | KeithMnemonic | only diff id &marker= . for non deleted it also works with the same token | |
| 16:47:53 | KeithMnemonic | and a marker | |
| 17:05:52 | KeithMnemonic | i figured that part out | |
| 17:15:02 | mriedem | idk off the top of my head why you'd get a 401 in that case | |
| 17:35:28 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Helper to start computes with different HostInfos https://review.opendev.org/686832 | |
| 17:35:29 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration https://review.opendev.org/672595 | |
| 17:35:30 | openstack | bug 1845146 in OpenStack Compute (nova) train "NUMA aware live migration failed when vCPU pin set" [High,Fix committed] https://launchpad.net/bugs/1845146 - Assigned to Dan Smith (danms) | |
| 17:35:30 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: NUMA LM: Add func test for bug 1845146 https://review.opendev.org/687404 | |
| 17:38:58 | openstack | bug 1845146 in OpenStack Compute (nova) train "NUMA aware live migration failed when vCPU pin set" [High,Fix committed] https://launchpad.net/bugs/1845146 - Assigned to Dan Smith (danms) | |
| 17:38:58 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: NUMA LM: Add func test for bug 1845146 https://review.opendev.org/687404 | |
| 17:45:08 | openstackgerrit | Eric Fried proposed openstack/os-resource-classes master: Stop testing with py2 https://review.opendev.org/690996 | |
| 17:45:16 | openstackgerrit | Eric Fried proposed openstack/os-traits master: Stop testing with py2 https://review.opendev.org/690997 | |
| 17:59:57 | KeithMnemonic | mriedem i figures out the 401, user error, but your simple fix is not so simple it seems | |
| 18:08:46 | henriqueof | I tried migrating a instance and reverting back now the instance is in error state, how can I recover it? | |
| 18:37:42 | KeithMnemonic | mriedem, the issue is how find_resource works, even if you pass in deleted it does not find it correctly | |
| 19:16:57 | melwitt | #thanks nova api-ref, for existing <3 | |
| 19:16:59 | openstackstatus | melwitt: Added your thanks to Thanks page (https://wiki.openstack.org/wiki/Thanks) | |
| 19:50:06 | mriedem | melwitt: can you hit these few stable/train changes? https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:stable/train one is a regression fix (which makes 2 since train GA) so i'll probably do a release next week | |
| 19:50:21 | melwitt | sure | |
| 19:51:54 | mriedem | thanks | |
| 20:20:48 | openstackgerrit | melanie witt proposed openstack/nova master: Add new policy rule for viewing host status UNKNOWN https://review.opendev.org/679181 | |
| 20:21:50 | melwitt | my functional test magnum opus ^ | |
| 20:24:54 | openstackgerrit | melanie witt proposed openstack/nova master: Add new policy rule for viewing host status UNKNOWN https://review.opendev.org/679181 | |
| 20:27:22 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs https://review.opendev.org/676029 | |
| 20:27:23 | openstackgerrit | Dustin Cowles proposed openstack/nova master: Provider Config File: Merge provider configs to provider tree https://review.opendev.org/676522 | |
| 20:29:29 | efried | gyee: We can talk in #openstack-doc if you like (about sphinx-feature-classification) | |
| 20:36:19 | mriedem | easy bug fix here https://review.opendev.org/#/c/682622/ | |
| 20:37:12 | mriedem | gibi: just a few things for your patches to enable evacuate with ports + resource requests | |
| 20:37:42 | mriedem | i can be convinced to address those in a follow up if you want | |
| 20:54:15 | efried | melwitt: what was decided about https://blueprints.launchpad.net/nova/+spec/nova-manage-db-purge-task-log ? | |
| 20:54:32 | efried | wishlist bug? | |
| 20:54:37 | efried | So I can kill the bp? | |
| 20:59:11 | efried | nova meeting in #openstack-nova in one minute | |
| 21:00:08 | mriedem | i'll be there boss! | |
| 21:06:20 | gyee | efried, you have a pretty look traceback I presume? :-) | |
| 21:06:56 | efried | gyee: I'll have to unwind my test env to reproduce it, but it wasn't terribly hard. At that point I can... throw you a tarball? | |
| 21:08:17 | gyee | sure | |
| 21:09:20 | mriedem | efried: i was going to request reviews on https://review.opendev.org/#/q/topic:bug/1824435+status:open in the meeting, | |
| 21:09:27 | mriedem | it's a bug fix for an upgrade issue since i think rocky | |
| 21:09:38 | mriedem | *stein | |
| 21:11:01 | efried | looking | |
| 21:20:59 | efried | melwitt, mriedem: +A | |
| 21:21:08 | efried | I remember when we looked at this in April | |
| 21:21:15 | efried | good sleuthing, melwitt | |
| 21:24:44 | mriedem | now to start the backport train to train | |