| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-10-10 | |||
| 14:35:21 | openstackgerrit | Balazs Gibizer proposed openstack/nova stable/pike: Functional reproduce for bug 1833581 https://review.opendev.org/687917 | |
| 14:35:34 | sean-k-mooney | but i think that would need spcial os images | |
| 14:35:42 | sean-k-mooney | since i think you need to boot with xen | |
| 14:35:59 | sean-k-mooney | so if we did decide we need ci to add xen feature to libvirt dirver | |
| 14:36:07 | sean-k-mooney | that would be the parth forward | |
| 14:36:38 | openstackgerrit | Balazs Gibizer proposed openstack/nova stable/pike: Error out interrupted builds https://review.opendev.org/687918 | |
| 14:36:45 | sean-k-mooney | e.g. the peoson that proposed the patch would work to get a libvirt xen job running with infra | |
| 14:37:07 | sean-k-mooney | the alternive is just to consider all libvirt/xen feature as experimental and subject to breaking | |
| 14:37:23 | sean-k-mooney | or just not accpet them i guess | |
| 14:38:43 | mriedem | sean-k-mooney: this is a first time contributor | |
| 14:38:53 | mriedem | i don't expect them to stand up first party libvirt+xen ci | |
| 14:38:56 | mriedem | nor maintain it | |
| 14:39:14 | sean-k-mooney | right.. ya. looking at the patch it looks relitivly trial | |
| 14:39:20 | sean-k-mooney | *trivial | |
| 14:39:25 | mriedem | i commented as such on the review | |
| 14:40:05 | mriedem | if we don't accept this because of lack of ci on libvirt+xen, i could argue that we shouldn't accept the libvirt+lxc patch to make cloud-init work | |
| 14:40:13 | sean-k-mooney | i would prefer to mark any libvirt virt-type that has no ci as experimental personally | |
| 14:40:31 | sean-k-mooney | mriedem: well we do plan to have the lxc job right | |
| 14:40:33 | sean-k-mooney | but yes | |
| 14:40:42 | mriedem | who is we? | |
| 14:40:53 | mriedem | i'm not actively making that happen | |
| 14:40:58 | sean-k-mooney | well you wrote a lxc job right | |
| 14:41:04 | mriedem | i farted something out | |
| 14:41:11 | sean-k-mooney | oh ok | |
| 14:41:13 | mriedem | i could just as easily abandon it | |
| 14:42:03 | sean-k-mooney | so as long as the maintaince of libvirt/xen and libvirt/lxc is not high i dont really have a proablem with either | |
| 14:42:19 | sean-k-mooney | as long as we comunifcate the lack of testing to end users | |
| 14:42:29 | sean-k-mooney | which i think we already do | |
| 14:43:33 | mriedem | maintaining the xenapi driver isn't hard either but we've deprecated that | |
| 14:43:37 | mriedem | anyway, i threw it on the meeting agenda | |
| 14:44:15 | sean-k-mooney | well the last type i looke the xen server side fo that stilll need python 2 to work | |
| 14:44:31 | sean-k-mooney | infact when i looked at the start of stine it still need 2.6 | |
| 14:44:37 | mriedem | i think you are confusing the guest image stuff which used to be pinned to like 2.4 | |
| 14:44:51 | sean-k-mooney | maybe | |
| 14:44:59 | mriedem | the driver itself clearly works with py3 otherwise we'd have had to blacklist all of it's unit tests | |
| 14:45:06 | sean-k-mooney | i was looking a kolla-ansible thread on xen suppport | |
| 14:45:33 | sean-k-mooney | they were having issue with xen due to some pinned python stuff | |
| 14:49:22 | openstack | Launchpad bug 1826269 in kolla-ansible "kolla-ansible xen fails with package." [Undecided,In progress] - Assigned to James (james-o-benson) | |
| 14:49:22 | sean-k-mooney | this might have been the issue i was thinking ov https://bugs.launchpad.net/kolla-ansible/+bug/1826269 | |
| 14:55:19 | openstackgerrit | Dan Smith proposed openstack/nova master: Add cache_image() support to the compute/{rpcapi,api,manager} https://review.opendev.org/687138 | |
| 14:55:19 | openstackgerrit | Dan Smith proposed openstack/nova master: Add cache_image() driver method and libvirt implementation https://review.opendev.org/687137 | |
| 14:55:20 | openstackgerrit | Dan Smith proposed openstack/nova master: Add image caching API for aggregates https://review.opendev.org/687140 | |
| 14:55:20 | openstackgerrit | Dan Smith proposed openstack/nova master: Add cache_images() to conductor https://review.opendev.org/687139 | |
| 14:55:21 | openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Add image precaching docs for aggregates https://review.opendev.org/687348 | |
| 15:12:43 | dansmith | mriedem: so on the api thing, are you asking me to stop catching the non-nova exceptions in conductor api so that they bubble up? | |
| 15:24:03 | mriedem | those should probably be 500s right? | |
| 15:24:13 | mriedem | e.g. if we can't auth to glance or glance is down | |
| 15:24:19 | mriedem | we shouldn't 400 in that case | |
| 15:25:21 | dansmith | well, that's one reason it could happen, but I dunno what all else | |
| 15:25:22 | mriedem | i would think there are 2 obvious errors we could get from glance which would be (1) the image doesn't exist and (2) the user doesn't have access to the image, but i'd think that would result in a 404 from glance (not sure if it'd be a 403) | |
| 15:25:23 | dansmith | but I guess so | |
| 15:25:55 | dansmith | so unrelated to that, | |
| 15:26:06 | dansmith | in fixing up the not-using-microversion problem in the api patch, | |
| 15:26:26 | dansmith | I subclassed the aggregates test for my two new tests, and now I'm getting this: https://pastebin.com/3McztMky | |
| 15:26:36 | dansmith | which seems to be in some really ancient code, so I can't imagine it has changed recently | |
| 15:26:41 | dansmith | but it's auth-related | |
| 15:26:52 | dansmith | does that resonate with you? | |
| 15:27:06 | mriedem | i bet efried would know off the top of his head since he was just ripping that out | |
| 15:27:25 | dansmith | I was going to ping him until I saw the code was really old | |
| 15:27:43 | dansmith | but yeah | |
| 15:27:45 | mriedem | is that using the admin_api or api? | |
| 15:27:56 | dansmith | admin, but just like the test I subclassed, which runs fine | |
| 15:27:59 | mriedem | i wouldn't expect a keyerror though, i'd expect a 403 | |
| 15:28:11 | mriedem | is that code up or still local? | |
| 15:29:00 | efried | dansmith: unless you have https://review.opendev.org/#/c/687416/ or above in your sandbox... | |
| 15:29:06 | dansmith | I wonder if it's because I'm doing the microversion wrong, hang on.. just realized the parent doesn't have a dot in the version | |
| 15:29:20 | mriedem | yeah so if the api fixture was created with version v2, | |
| 15:29:24 | mriedem | and you're passing a microversion header, | |
| 15:29:29 | mriedem | i'd think something is going to blow up there | |
| 15:29:32 | dansmith | yeah, that's it.. so in here: https://review.opendev.org/#/c/687140/5/nova/tests/functional/test_aggregates.py | |
| 15:29:39 | mriedem | yar | |
| 15:29:49 | dansmith | I misread it as api_version and effectively changed v2 to v2.80 and it explodes that obscure way | |
| 15:30:38 | dansmith | am I supposed to be able to set api_major_version='v2.80' ? | |
| 15:31:14 | mriedem | no | |
| 15:31:20 | mriedem | it's the thing that goes into the fixture init | |
| 15:31:24 | mriedem | either v2 or v2.1 | |
| 15:31:52 | mriedem | https://review.opendev.org/#/c/687140/6/nova/tests/functional/integrated_helpers.py@437 | |
| 15:31:55 | dansmith | cool, well I have confirmed that it's failing as expected (I guess ;D) | |
| 15:32:34 | dansmith | okay, microversion= works, got it | |
| 15:32:46 | dansmith | a teensy bit obscure in the failure mode | |
| 15:33:12 | mriedem | obviously the fixture or TestOpenStackClient or whatever could detect that you're trying to send a microversion header to a v2(.0) route and blow up in a more obvious way | |
| 15:33:17 | efried | what I can contribute to the conversation is, if you see x-server-management-url in a traceback, it's breaking in test code, nothing to do with real life. | |
| 15:33:48 | efried | the microversion and api_major_version class members are for template substitutions afaiu | |
| 15:33:58 | mriedem | hells nah | |
| 15:34:01 | efried | the latter also used to construct the auth url | |
| 15:34:04 | mriedem | they are for the api fixture and resulting client | |
| 15:34:22 | dansmith | efried: yeah I know it's just test stuff | |
| 15:34:31 | efried | if you want to send a request at a specific microversion, I think you still need to use a kwarg to your API method. | |
| 15:34:49 | mriedem | well, | |
| 15:34:54 | mriedem | the api fixture client stuff handles that | |
| 15:35:16 | mriedem | self.api = self.useFixture(nova_fixtures.OSAPIFixture('v2.1')).api | |
| 15:35:24 | mriedem | self.api.microversion = '2.80' | |
| 15:35:26 | mriedem | something like that | |
| 15:35:27 | efried | oh, I guess the fixture also uses the microversion as the default if you don't specify a kwarg. | |
| 15:35:32 | mriedem | correct | |
| 15:36:22 | efried | the aforementioned series rips some of that magic out of the test-only paths so it happens more like it would in real life. But I don't think what you're doing would be affected (other than to fail differently if you f it up) | |
| 15:48:50 | openstackgerrit | Dan Smith proposed openstack/nova master: Add cache_images() to conductor https://review.opendev.org/687139 | |
| 15:48:51 | openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Add image precaching docs for aggregates https://review.opendev.org/687348 | |
| 15:48:51 | openstackgerrit | Dan Smith proposed openstack/nova master: Add image caching API for aggregates https://review.opendev.org/687140 | |
| 15:49:14 | dansmith | mriedem: okay, conductor/api now lets non-nova exceptions up to the top | |