Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-09-12
22:19:44 stephenfin oh thank God
22:19:56 stephenfin I was terrified I'd accidentally rebase vpmem :-D
22:20:39 sean-k-mooney ok so now in thery i can create a job that depens on pcpu+vpmem and numa LM right in my testing changes
22:21:10 sean-k-mooney since artom rebased LM there shoudl be no conflict anymore right
22:21:17 stephenfin correct
22:21:38 sean-k-mooney im going to check that locally.
22:22:09 sean-k-mooney also i really like git at times like this
22:23:39 efried stephenfin: that's weird, how did https://review.opendev.org/#/c/671793/ end up with a -2 from me on it? Usually that only happens if you wound up identical to an earlier PS that was -2
22:24:10 sean-k-mooney ya i can merge https://review.opendev.org/674895 with https://review.opendev.org/#/c/640021
22:24:12 stephenfin Looks like it was one of your procedural -2s
22:24:25 stephenfin I suspect git thinks the diff is the same
22:24:29 stephenfin as an earlier PS
22:25:06 sean-k-mooney ya if gerrit detect there is no change via a rebase it keps +/- 1/2
22:25:28 sean-k-mooney that stops peole just rebasign to clear negitive reviews
22:25:41 stephenfin I wish Gerrit had some way to view just the diff between two versions side-by-side without all the additional context introduced in between
22:26:01 stephenfin As it is, I've to open different versions of the review in different tabs and toggle between them
22:26:07 sean-k-mooney thats a 4 way diff and i think the new ui can do it
22:26:13 stephenfin o rly?
22:26:29 sean-k-mooney apparently althogh i have not see it in partice
22:26:49 sean-k-mooney im sure we could still break it
22:27:55 melwitt git review -m <review num>,PSold-PSnew will do it, fwiw
22:27:59 sean-k-mooney you creat it by taking the origin patch angainst base and the updatdate patch against new base then diff the two diffs
22:28:49 melwitt https://docs.openstack.org/infra/git-review/usage.html
22:29:22 sean-k-mooney i dont know if that ignore change intoduce by rebasing
22:29:46 stephenfin it does not :(
22:30:04 sean-k-mooney but the process i discribe should do that
22:30:30 melwitt it did for me last time I tried it a few days ago
22:30:38 stephenfin at least if I do 'git review -m 671793,24-25' I see all the vpmem stuff introduced
22:30:43 stephenfin maybe I've an old version of git-review
22:31:10 sean-k-mooney melwitt: it will do it if you dont rebase between 4 and 10
22:31:26 melwitt I mean I did a diff after a rebase between
22:31:55 stephenfin sean-k-mooney: yeah, 'git format-patch HEAD~N > (old|new); diff -r old/ new/' would do the trick
22:32:20 stephenfin melwitt: I imagine the difference could be that that rebase didn't introduce changes to the files you were touching
22:32:32 stephenfin but that's a complete guess
22:32:54 melwitt it did, otherwise it wouldn't be useful right? I went to do it in git-review after seeing the diff in gerrit a mess with rebase stuff
22:33:52 efried stephenfin: looks like manual rebases on four of those? You're +A all the way.
22:33:53 sean-k-mooney well i just get an error when i run stephens example
22:34:06 stephenfin efried: That's what I was seeing too
22:34:50 stephenfin Sweet. Anything else I need to do or is it home time?
22:34:52 efried I do what stephenfin does - open two tabs and toggle.
22:35:07 melwitt but anyway, I'm getting the same result as you with your example :\ I don't get why this acts inconsistent depending on the change
22:35:12 efried and yes, rumor has it the newer gerrit has a 4-way. aspiers is always wishing misty-eyed for it.
22:35:53 sean-k-mooney it is very pretty
22:35:54 efried maybe fungi is getting that set up for us once he gets his shoes back on
22:36:59 fungi no shoes needed with new gerrit
22:37:23 fungi it's like the plushest 1970s era orange shag carpet
22:39:30 sean-k-mooney fungi: its a diff that only show you what changed between two patche set ignoring anything that came form a rebase
22:39:35 melwitt there's a heineken light? eesh. as if normal heineken wasn't bad enough
22:39:50 fungi yeah, i'm probably a beer snob but i wouldn't touch heineken anything with a 3m pole
22:40:22 sean-k-mooney fungi: normally i only dirink stouts or poters if im drinking beer
22:40:38 fungi (currently enjoying o'connor brewing's "el guapo" agave ipa)
22:40:39 sean-k-mooney but this was all i had in the fridge
22:40:40 melwitt I'm obsessed with hazy ipas lately
22:41:34 fungi those can indeed be tasty
22:41:34 melwitt in colder weather I go for stouts and porters
22:42:03 melwitt with the exception of north coast's old no 38, I will drink that anytime
22:42:32 fungi i do prefer drier varieties like pale ales, but especially when doing yardwork in the summer
22:43:24 sean-k-mooney hot summer days are cider weather
22:45:11 stephenfin sean-k-mooney: Spoken like a true Tipp wan
22:46:06 sean-k-mooney of course i was born in the town where bulmer/magnars cider is from
22:46:42 sean-k-mooney although i prefer dry cider in general
22:49:43 openstackgerrit Matt Riedemann proposed openstack/nova master: Cleanup reno live-migration-with-PCI-device https://review.opendev.org/681942
22:50:59 mriedem hmm, i was going to avoid mentioning things in the cycle highlights about deprecating the xenapi driver, consoleauth and cells v1, but wondering if i should mention that the placement-in-nova code was removed
22:51:36 mriedem i've avoided mentioning things like that as "highlights"
22:52:02 sean-k-mooney if you mentioned it as remvoed you should mention cells v1 as removed
22:52:10 sean-k-mooney deprecation of xen is more a lowlight
22:52:13 mriedem cells v1 was optional and not many used it,
22:52:17 mriedem placement-in-nova was not optional
22:52:29 mriedem nor was consoleauth really
22:52:37 mriedem anyway, from a marketing perspective those aren't highlights
22:52:50 efried mriedem: if you'd rather put a positive spin, focus on "extracted placement is required"
22:53:05 sean-k-mooney was the removeal of placmenet done with a release note
22:53:10 mriedem that's not really marketing
22:53:19 stephenfin does the prelude form part of the marketing?
22:53:20 mriedem sean-k-mooney: yes, i'm scanning the release notes for highlights
22:53:25 mriedem stephenfin: no,
22:53:33 mriedem that's why i think ^ is all good prelude stuff b/c it's big,
22:53:38 mriedem but it's not marketing shit that sales people would undersatnd
22:53:46 melwitt yeah, I was gonna say, I agree none of those are highlights but they are prelude material
22:53:47 stephenfin I agreed
22:53:49 stephenfin *agree
22:53:51 mriedem if i'm selling train, why do i care if nova uses placement in nova or external
22:53:53 sean-k-mooney mriedem: i expect the placement release note will mark it graduation to a sperate service as a highlight
22:53:54 efried sales schmales, this is open source beyotch
22:54:06 stephenfin efried: Not according to cdent :-D
22:54:29 efried mriedem: because it's way faster?
22:54:34 cdent aw man, don't invoke me for that
22:54:45 stephenfin sorry, cdent
22:54:53 melwitt sean-k-mooney: well, I think we already used "you can run with extracted placement" as a highlight last cycle
22:55:03 melwitt re: graduation to separate service
22:55:03 cdent for cycle highlights we justsaid that
22:55:06 cdent whoops
22:55:20 cdent we said "extracted placement must be used"
22:55:39 cdent and then talked about nfv
22:55:39 efried okay, I gotta go teach people how to beat each other up. No rest for the wicked and all that. Thanks all for the long hours and general ass-kicking today.
22:55:46 cdent because it's, like, the rage
22:56:35 sean-k-mooney cdent: ye had some pretty big feature this release
22:56:57 cdent sean-k-mooney: I'm only being half serious, see: https://review.opendev.org/681197
22:57:19 sean-k-mooney cdent: nfv does corralate with rage however
23:05:12 mriedem efried: et al nova cycle highlights https://review.opendev.org/#/c/681943/1

Earlier   Later