| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-09-12 | |||
| 13:28:24 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/stein: Log notifications if assertion in _test_live_migration_force_complete fails https://review.opendev.org/681743 | |
| 13:28:29 | efried | sean-k-mooney: open a bug? | |
| 13:29:01 | sean-k-mooney | sure | |
| 13:32:11 | mriedem | gibi: sorry about all of that _reschedule_resize_or_reraise noise | |
| 13:32:15 | mriedem | i had the logic obviously wrong | |
| 13:35:47 | efried | I'm going to get a nap while the gate cranks. Back in... say, 3.5h. | |
| 13:35:50 | dansmith | gate looks constipated | |
| 13:35:56 | dansmith | heh | |
| 13:36:16 | efried | dansmith: there was a dep problem overnight, resolved now, but everything is backed up, yes. | |
| 13:36:50 | bauzas | dansmith: we checked whether we should provide the gate a pill, but looks like the issue is solved | |
| 13:37:12 | gibi | mriedem: no worries. I needed my fresh mind the morning to figure out what is going on. | |
| 13:37:51 | gibi | mriedem, bauzas: I will be on and off in the coming 2-3 hours. But I will be back for the night to finish up things if needed | |
| 13:38:07 | bauzas | http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22ERROR%3A%20Could%20not%20find%20a%20version%20that%20satisfies%20the%20requirement%20configparser%5C%22 | |
| 13:38:14 | dansmith | bauzas: go natural: https://www.youtube.com/watch?v=Ku42Iszh9KM | |
| 13:38:33 | bauzas | gibi: like I said, I'm also dragged due to some internal bug scrub duty | |
| 13:38:49 | bauzas | :( | |
| 13:38:51 | mriedem | gibi: ok, i did spot a race in the new functional test in the sriov patch, so i'm going to -1 for that, but i can probably just fix and rebase the series myself | |
| 13:39:15 | mriedem | bauzas: you can't tell your management / team lead that today is f'ing upstream feature freeze? | |
| 13:39:19 | mriedem | and get a 1 day break? | |
| 13:39:35 | bauzas | dansmith: I wish you knew some french folks named "Les Nuls" so I could share you some video | |
| 13:39:57 | dansmith | heh | |
| 13:40:10 | mriedem | if bauzas can't review the rest of the bw provider migrate series i'll see if i can get melwitt to help out | |
| 13:40:24 | bauzas | mriedem: this duty should be around 1 hour or 2 | |
| 13:40:28 | bauzas | but then I'll have meeting | |
| 13:40:33 | bauzas | yay | |
| 13:40:54 | mriedem | is there a manager standing next to you with a gun to your head saying you have to do bug duty over FF? | |
| 13:40:59 | mriedem | can you tell them you're a nova core? | |
| 13:41:05 | mriedem | one of the remaining few? | |
| 13:41:09 | bauzas | my dog is barking at me | |
| 13:41:24 | mriedem | whatever, this is why i have no hope for "we'll do it in U" | |
| 13:42:07 | bauzas | mriedem: that's why you'll never see me saying "Ussuri" | |
| 13:42:16 | bauzas | mriedem: "Unicorn" sounds a way better release name | |
| 13:42:35 | bauzas | (more appropriate at least) | |
| 13:43:57 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Include both VCPU and PCPU in core quota count https://review.opendev.org/681374 | |
| 13:43:58 | openstackgerrit | Stephen Finucane proposed openstack/nova master: fakelibvirt: Make 'Connection.getHostname' unique https://review.opendev.org/681060 | |
| 13:43:58 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801 | |
| 13:43:59 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895 | |
| 13:43:59 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Mock 'libvirt_utils.file_open' properly https://review.opendev.org/681061 | |
| 13:44:00 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove single-use classmethod https://review.opendev.org/681751 | |
| 13:44:00 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Additional functional tests for pinned instances https://review.opendev.org/681750 | |
| 13:44:39 | alex_xu | stephenfin: need you kick the first one https://review.opendev.org/#/c/678447/14 | |
| 13:44:41 | stephenfin | dansmith: In case you didn't see the scrollback, we modified the solution in https://review.opendev.org/671801 slightly | |
| 13:44:48 | stephenfin | alex_xu: just done | |
| 13:44:53 | alex_xu | stephenfin: thanks | |
| 13:45:04 | stephenfin | though I realize I missed some of your comments | |
| 13:45:22 | artom | bauzas, want me to do the bugs thing? | |
| 13:45:28 | artom | bauzas, so you can concentrate on w/e? | |
| 13:45:31 | stephenfin | alex_xu: However, https://review.opendev.org/#/c/671801/ should be ready for your viewing pleasure too | |
| 13:45:42 | bauzas | artom: how is your series ? | |
| 13:45:48 | alex_xu | stephenfin: got it | |
| 13:45:55 | artom | bauzas, merged (well, merging, because gate) | |
| 13:46:06 | stephenfin | bauzas: Want to look at https://review.opendev.org/#/c/681750/, pretty please? | |
| 13:46:07 | artom | (Otherwise I wouldn't have offered) | |
| 13:46:21 | stephenfin | (I split it out to make https://review.opendev.org/#/c/671801/ smaller) | |
| 13:46:29 | bauzas | artom: cool then okay, we could switch | |
| 13:46:45 | bauzas | stephenfin: I can | |
| 13:46:47 | artom | bauzas, ack, I'll handle the bugs, do your nova core job | |
| 13:47:08 | bauzas | stephenfin: did your reorganised your series ? | |
| 13:47:16 | bauzas | oh wait no | |
| 13:47:20 | stephenfin | nope, just broke some things out | |
| 13:47:28 | artom | The "out" is ket | |
| 13:47:30 | artom | *key | |
| 13:48:36 | dansmith | stephenfin: I didn't but I'll try to circle back in a bit | |
| 13:49:41 | alex_xu | stephenfin: I didn't find that part for sean-k-mooney said host both have pcpu and vcpu | |
| 13:50:43 | stephenfin | alex_xu: We test it implicitly here https://review.opendev.org/#/c/671801/47/nova/tests/functional/libvirt/test_numa_servers.py@364 | |
| 13:50:55 | stephenfin | Both of those hosts have both PCPU and VCPU inventory | |
| 13:51:33 | stephenfin | and we still get PCPU as expected https://review.opendev.org/#/c/671801/47/nova/tests/functional/libvirt/test_numa_servers.py@460 | |
| 13:51:44 | stephenfin | and https://review.opendev.org/#/c/671801/47/nova/tests/functional/libvirt/test_numa_servers.py@489 | |
| 13:53:49 | mriedem | gibi: i've gone through the updates, i'll rebase and fix the small things and then i'll be +2 up the stack | |
| 13:53:54 | alex_xu | emm...let me check | |
| 13:54:14 | bauzas | mriedem: cool, I'll look at the series once i'm done with a couple of changes from stephenfin | |
| 13:55:11 | mriedem | efried_afk: so we're pushing PCPU in before the scheduler and quotas stuff is approved? https://review.opendev.org/#/c/671793/ | |
| 13:56:10 | mriedem | i think for train the quotas one is pretty straight-forward, counting from placement will work the same as counting from nova, | |
| 13:56:16 | mriedem | but the scheduler patch looks like it's still in flux | |
| 13:56:20 | stephenfin | the quota stuff has got a tentative ack from melwitt, and the scheduler stuff has the same from efried and alex_xu | |
| 13:56:22 | stephenfin | see here | |
| 13:56:29 | stephenfin | https://review.opendev.org/#/c/681719/ | |
| 13:57:05 | dansmith | even still, if we were to land that first patch and get stuck on the rest, we've got a config option that claims to enable something that doesn't, which is uncool | |
| 13:58:05 | stephenfin | it'll do exactly what it says - you just won't be able to use the things it provides (PCPUs) | |
| 13:58:19 | gibi | mriedem: thanks a lot! | |
| 13:58:39 | bauzas | stephenfin: can you please tell me why we need this https://review.opendev.org/#/c/681750/1/nova/tests/unit/virt/libvirt/fake_imagebackend.py ? | |
| 13:58:52 | mriedem | i hope there is going to be some "so you want to use PCPUs" admin doc at some point b/c there are a ton of moving parts | |
| 13:59:17 | bauzas | mriedem: I feel there are some docs that absolutely need to be written | |
| 13:59:20 | stephenfin | bauzas: There's a check deep in the libvirt code for that. If it's not done, it complains with "function doesn't have attribute SUPPORTS_CLONE" | |
| 13:59:33 | bauzas | mriedem: in particular given the upgrade plan we took a while to agree this morning | |
| 13:59:50 | stephenfin | bauzas: I'm not the only one who found that. This is from the vPMEM series https://review.opendev.org/#/c/678470/35/nova/tests/unit/virt/libvirt/fake_imagebackend.py | |
| 13:59:51 | mriedem | stephenfin: there should probably be a comment on that in the fake imagebackend code then | |
| 14:00:02 | bauzas | stephenfin: what mriedem said | |
| 14:00:15 | bauzas | because I have no idea why you need this | |
| 14:00:23 | mriedem | pretty gross that the virt agnostic image backend fixture has to have libvirt specific stuff in it | |
| 14:00:56 | mriedem | bauzas: stephenfin loves to doc so i'm sure he doesn't have a problem documenting all the things | |
| 14:01:22 | bauzas | mriedem: the upgrade strategy is a bit tricky, I'm just saying we need to carefully doc it | |
| 14:01:35 | bauzas | based on the fact we'll provide some options | |
| 14:01:38 | stephenfin | mriedem: It's a libvirt-specific image backend fixture - look at the filename | |
| 14:01:51 | stephenfin | it's for mocking out nova/virt/libvirt/imagebackend.py | |
| 14:02:56 | mriedem | stephenfin: you're right, sorry - i was thinking of https://review.opendev.org/#/c/678470/35/nova/tests/unit/image/fake.py | |
| 14:03:36 | stephenfin | all g | |
| 14:03:43 | stephenfin | I wonder what the comment should be though | |
| 14:04:10 | stephenfin | I mean, it's an attribute of the Image base class in nova/virt/libvirt/imagebackend.py | |
| 14:04:26 | stephenfin | and this function is a stub for that class (or some subclass) | |