| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-09-10 | |||
| 13:46:29 | mriedem | efried: rebuild+evacuate and resize+cold-migrate are confusing in that they share code but don't do the exact same things | |
| 13:46:40 | mriedem | but are like 90% the same | |
| 13:47:37 | mriedem | efried: do we need a "what's the difference between evacuate and rebuild" thing in the contributor docs? | |
| 13:47:41 | mriedem | b/c that's probably pretty easy to write up | |
| 13:47:58 | efried | that must be why luyao was conflating rebuild+evacuate wrt allocations. That must fall in the 10% that's different. | |
| 13:48:13 | mriedem | part of it yeah | |
| 13:48:16 | efried | mriedem: I'll admit I didn't even go looking for a doc on this. | |
| 13:48:25 | mriedem | there likely isn't one | |
| 13:48:33 | mriedem | but this isn't the first time this has come up, | |
| 13:48:34 | efried | There was that one blog post | |
| 13:48:37 | efried | "one" | |
| 13:48:41 | mriedem | so instead of explaining it each time, one could just link to a doc | |
| 13:48:45 | jangutter | efried: http://www.danplanet.com/blog/2016/03/03/evacuate-in-nova-one-command-to-confuse-us-all/ this one? | |
| 13:48:56 | mriedem | not really the same | |
| 13:49:03 | efried | that looks familiar jangutter | |
| 13:49:06 | mriedem | that's about nova client commands that live migrate all instances off a host | |
| 13:49:13 | openstackgerrit | Adam Spiers proposed openstack/nova master: Improve SEV documentation and other minor tweaks https://review.opendev.org/681254 | |
| 13:49:30 | luyao | efried: yes, actually I found evacuting instance has two groups of allocations, and I thought rebuild is the same. | |
| 13:49:45 | mriedem | "After a compute host has failed, rebuild my instance from the original image in another place, keeping my name, uuid, network addresses, and any other allocated resources that I had before." | |
| 13:50:35 | efried | anyway, I envision some kind of table with all these related operations on one axis, an things like "same/different destination host", "what happens to allocations", "instance/migration UUIDs", etc on the other. | |
| 13:51:37 | mriedem | that's a much bigger doc if you're trying to lump in all move operations, | |
| 13:51:45 | openstackgerrit | sean mooney proposed openstack/nova master: [WIP] add cyborg tempest job https://review.opendev.org/670999 | |
| 13:51:46 | mriedem | because you'd have to consider resize on the same host, which is complicated in different ways | |
| 13:51:48 | efried | mriedem: is there a todo list on which that ^ could be registered so it is not forgotten, but not started until after FF? We need you for more urgent things this week. | |
| 13:51:52 | sean-k-mooney | Sundar: that ^ should test with the correct deps. im going back to testing artoms code | |
| 13:52:07 | mriedem | efried: i'm not signing up to write a doc with all of the axis of evil, | |
| 13:52:20 | mriedem | writing up something quick and easy about "what's the difference between rebuild and evacuate" is pretty easy for me to crank out | |
| 13:52:27 | efried | even so | |
| 13:52:32 | mriedem | a bug is good enough for that | |
| 13:52:41 | mriedem | docs bug, link to the irc question that started tihs | |
| 13:52:48 | efried | ack | |
| 13:53:27 | sean-k-mooney | mriedem: im going to add back in the instnace.refresh locally and add some logging to see what teh numa toplogy blob look like before and after. | |
| 13:53:44 | sean-k-mooney | mriedem: artom is in dad taxi mode currently but he should be back soon ish | |
| 13:55:20 | Sundar | Thanks, sean-k-mooney | |
| 13:55:20 | sean-k-mooney | although looking at that funciton im not clear why that helps | |
| 13:56:21 | efried | https://bugs.launchpad.net/nova/+bug/1843439 | |
| 13:56:23 | openstack | Launchpad bug 1843439 in OpenStack Compute (nova) "doc: Rebuild vs. Evacuate (and other move-ish ops)" [Low,Confirmed] - Assigned to Matt Riedemann (mriedem) | |
| 13:56:53 | efried | mriedem: there's a 'doc' tag and a 'docs' tag. Which one is real? | |
| 13:56:57 | efried | (I used both) | |
| 13:59:30 | bauzas | efried: IIRC, it was 'docs' 3 years ago | |
| 14:00:00 | bauzas | oops, I meant 'doc' | |
| 14:00:03 | bauzas | holy shit | |
| 14:00:26 | sean-k-mooney | its doc | |
| 14:00:30 | sean-k-mooney | https://wiki.openstack.org/wiki/Nova/BugTriage#Tag_Owner_List | |
| 14:00:31 | bauzas | efried: yeah, I'm correct : https://bugs.launchpad.net/nova/+bugs?field.tag=doc vs. https://bugs.launchpad.net/nova/+bugs?field.tag=docs | |
| 14:01:29 | efried | bauzas: are tags autovivified or do they need to be explicitly created somewhere? | |
| 14:01:39 | bauzas | efried: nope, you can add anyone | |
| 14:01:40 | mriedem | there is an official list | |
| 14:01:40 | efried | Like, could we go through the latter four bugs and remove 'docs' and that tag would disappear? | |
| 14:01:49 | mriedem | anyone can add any tag, | |
| 14:01:49 | bauzas | efried: I'm just updating the 4 'docs' | |
| 14:01:50 | sean-k-mooney | efried: if you go to the wiki i likned | |
| 14:01:55 | bauzas | s/docs/doc | |
| 14:01:57 | mriedem | but the list of official tags that auto-complete is curated | |
| 14:01:58 | sean-k-mooney | there is a link to manage the offical tags | |
| 14:01:59 | efried | cool | |
| 14:02:12 | efried | mriedem: oh, in that case both 'docs' and 'doc' must be in there | |
| 14:02:14 | sean-k-mooney | https://bugs.launchpad.net/nova/+manage-official-tags | |
| 14:02:17 | efried | because both autocompleted for me | |
| 14:02:24 | sean-k-mooney | no idea how to use that however | |
| 14:02:24 | mriedem | https://bugs.launchpad.net/nova/+manage-official-tags | |
| 14:02:42 | mriedem | you move things in or out of the 'official tags' column | |
| 14:02:49 | bauzas | efried: mriedem: I removed usage for 'docs' https://bugs.launchpad.net/nova/+bugs?field.tag=docs | |
| 14:03:02 | efried | okay, I'm removing 'docs' from official... | |
| 14:03:11 | bauzas | and yeah, I just removed 'docs' from the official list | |
| 14:03:15 | bauzas | heh, jinxed | |
| 14:03:39 | efried | sorted | |
| 14:03:41 | mriedem | i just added "documentation" | |
| 14:03:41 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove custom comparison methods https://review.opendev.org/472285 | |
| 14:03:47 | mriedem | and "docify" | |
| 14:03:47 | efried | you're a bastard | |
| 14:04:02 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove custom comparison methods https://review.opendev.org/472285 | |
| 14:04:13 | efried | gibi: Did I see something about a grenade failure - should I wait to recheck stuff? | |
| 14:04:28 | bauzas | efried: mriedem: either way, it's been a long time since I triaged a single bug in Launchpad, floor is yours, folks | |
| 14:04:30 | gibi | efried: don't have to wait | |
| 14:04:36 | efried | thanks | |
| 14:04:38 | gibi | efried: it was a failure in an open review | |
| 14:04:44 | efried | o good :) | |
| 14:04:51 | gibi | efried: which I respinned with a fix | |
| 14:05:19 | efried | I'm going to need to bring in a ringer for this vpmem patch https://review.opendev.org/#/c/678455/ | |
| 14:05:29 | efried | I can handle the rest, but that one is beyond me. | |
| 14:05:53 | efried | stephenfin is already lined up for it. alex_xu is a co-author. | |
| 14:06:34 | efried | sean-k-mooney, kashyap, aspiers, artom: I would proxy a +2 from one of you if you're able --^ | |
| 14:06:53 | alex_xu | also the vpmem CI is pretty close https://review.opendev.org/#/c/679640/14 \o/ | |
| 14:06:54 | kashyap | efried: vPMEM? | |
| 14:07:22 | efried | kashyap: Yeah, that patch is just "do shit efried doesn't understand to the libvirt xml" | |
| 14:07:32 | efried | so I don't think you need to understand vpmem | |
| 14:07:45 | sean-k-mooney | efried: the pmem seriese. i can take a look if kashyap cant | |
| 14:07:48 | kashyap | efried: It's been forever on my to-read list, but I was pulled into urgent downstream stuff last/this week | |
| 14:07:59 | bauzas | efried: once I'm done with gibi's series and stephenfin's cpu-resources, I could give some look at https://review.opendev.org/#/q/topic:bp/virtual-persistent-memory | |
| 14:08:44 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fixing broken links https://review.opendev.org/681206 | |
| 14:09:09 | efried | Thanks folks. bauzas kashyap sean-k-mooney in the interest of focusing resources, if it's possible to start with https://review.opendev.org/#/c/678455/ rather than going through the whole series, that's the one where we have a known reviewer gap. | |
| 14:09:33 | alex_xu | bauzas: kashyap sean-k-mooney thanks also | |
| 14:09:53 | bauzas | efried: honestly, reviewing the series needs me looking from the start, but I can surely just look at the patches without really commenting them | |
| 14:10:05 | sean-k-mooney | yes if that is the one that need to be reviewed i can start there in about 5 mins | |
| 14:10:08 | kashyap | efried: Nod; that's what I clicked on | |
| 14:10:55 | gibi | stephenfin: a question about the cpu series. The vcpu_pins_set can be and empty string and the nova will use every host cpu for the vcpus. Does this behaviour preserved for the cpu_shared_set and cpu_dedicated_set ? | |
| 14:11:52 | efried | gibi: iiuc no, you'll get an error if you try that. | |
| 14:12:04 | bauzas | gibi: good question, we haven't agreed on that in the spec | |
| 14:13:20 | gibi | efried: so I can assume that when the vcpu_pin_set is removed then there will be no way to implicitly offer every host cpu as vcpu? But I have to explicitly list them in one of the new configs | |