| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-09-05 | |||
| 12:40:02 | kashyap | aspiers: Was AFK; reading now | |
| 12:41:22 | kashyap | aspiers: We might've discussed (on machine types as traits) ... although I'm fuzzy on what we talked, though | |
| 12:44:54 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: prepare func test env for moving servers with bandwidth https://review.opendev.org/655109 | |
| 12:44:54 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: update allocation in binding profile during migrate https://review.opendev.org/656422 | |
| 12:44:55 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add min service level check for migrate with bandwidth https://review.opendev.org/680394 | |
| 12:44:55 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Func test for migrate server with ports having resource request https://review.opendev.org/655113 | |
| 12:44:56 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add bandwidth min service level check of source compute https://review.opendev.org/680396 | |
| 12:44:56 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add bandwidth min service level check of source compute https://review.opendev.org/680395 | |
| 12:50:52 | kashyap | aspiers: Glad if you worked out a way to resolve the imports impasse. /me back to duking around with SB code | |
| 12:51:37 | openstackgerrit | Merged openstack/nova master: Add server sub-resource topology API https://review.opendev.org/621476 | |
| 12:51:53 | sean-k-mooney | kashyap: i think we have. and we discovered a 7 year old bit of tech debt to go clean up eventually. | |
| 12:52:18 | kashyap | sean-k-mooney: :D Which is? Also I saw in passing, that you wanted to "kill off designer.py" | |
| 12:52:30 | kashyap | IIRC, it was introduced with a purpose back in the day. | |
| 12:52:46 | sean-k-mooney | it was but we never finished it | |
| 12:53:05 | kashyap | (For making "policy" decisions.) | |
| 12:53:18 | sean-k-mooney | but that is not what i was refering too | |
| 12:53:21 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Make _rever_allocation nested allocation aware https://review.opendev.org/676138 | |
| 12:54:04 | sean-k-mooney | kashyap: i was refering to removing this | |
| 12:54:05 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/__init__.py#L15-L17 | |
| 12:54:33 | sean-k-mooney | because of that when you import anythin in nova.virt.libvit.* | |
| 12:54:50 | sean-k-mooney | it pulls in the dirver which pulls in half of nova | |
| 12:55:09 | sean-k-mooney | well not really but importin nova.virt.libvirt.utils | |
| 12:55:17 | sean-k-mooney | shoudl not have that silent side effect | |
| 12:55:24 | kashyap | sean-k-mooney: Ah, okay; I see what you mean | |
| 12:55:44 | kashyap | Thanks for the context | |
| 12:55:51 | sean-k-mooney | so we shoudl remove that at somepoint | |
| 12:56:04 | sean-k-mooney | but its been that way for 7 years+ | |
| 12:56:18 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Func test for migrate re-schedule with bandwidth https://review.opendev.org/676972 | |
| 12:56:18 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support reverting migration / resize with bandwidth https://review.opendev.org/676140 | |
| 12:56:48 | artom | aspiers, so the API-level check boils down to essentially "if 'q35' in machine_type"? | |
| 12:57:25 | artom | And actually yeah, we can't do anything else | |
| 12:57:46 | artom | It just dawned on me that calling libvirt_utils on anything other than the compute host doesn't make sense | |
| 12:57:50 | artom | Since it checks the CONF | |
| 12:58:02 | artom | For the machine type, which may not even be set on a controller | |
| 12:59:20 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add delete_on_termination to volume-attach API https://review.opendev.org/673133 | |
| 12:59:22 | sean-k-mooney | artom: yep | |
| 12:59:46 | sean-k-mooney | artom: even if it was set on the contoler i t would be wrong | |
| 13:00:13 | artom | sean-k-mooney, yep | |
| 13:01:12 | sean-k-mooney | the main api check we care about is for live migrate and suspend | |
| 13:01:51 | sean-k-mooney | the create server one is fine too but its not the main one | |
| 13:02:10 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow migrating server with port resource request https://review.opendev.org/671497 | |
| 13:02:10 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support migrating SRIOV port with bandwidth https://review.opendev.org/676980 | |
| 13:04:41 | aspiers | artom: exactly | |
| 13:07:53 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Do not query allocations twice in finish_revert_resize https://review.opendev.org/678827 | |
| 13:09:05 | brinzhang | mriedem: Beacause of https://review.opendev.org/#/c/621476/ hit the microversion 2.78, I was rebased it. Can you review https://review.opendev.org/#/c/673133/16 again? | |
| 13:09:59 | mriedem | brinzhang: yes | |
| 13:10:12 | mriedem | yonglihe: will you be working on adding support for microversion 2.78 to openstackclient as well? | |
| 13:10:56 | brinzhang | mriedem: About your comment in PS14, I update https://review.opendev.org/#/c/674243/20/nova/tests/functional/api_sample_tests/test_migrations.py@424, could you please review this again, and I will update it tomorrow. | |
| 13:12:22 | brinzhang | mriedem: Alex already leaving comments on https://review.opendev.org/#/c/674243 | |
| 13:12:26 | gmann | mriedem: i asked few more test to add in 673133 and in followup as it was +2 by you. as he need to rebase you want to fix those in followup or same commit? what ever is easy to get your +2 :) | |
| 13:13:33 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Allow resizing server with port resource request https://review.opendev.org/679019 | |
| 13:15:06 | mriedem | gmann: you asked for a test that already exists | |
| 13:15:09 | mriedem | test_attach_volume_pre_v278 | |
| 13:15:36 | gmann | mriedem: that is for POST API only i asked to test the same for GET (list and show) | |
| 13:16:12 | mriedem | ok | |
| 13:16:46 | brinzhang | mriedem: gmann: thanks | |
| 13:17:57 | luyao | dansmith: Hi, Dan, comments addressed, https://review.opendev.org/#/c/678447/ and https://review.opendev.org/#/c/678448/. Could you help confirm if it is right? | |
| 13:19:36 | mriedem | brinzhang: https://review.opendev.org/#/c/674243/20 is in merge conflict | |
| 13:21:00 | brinzhang | mriedem: yeah, beacause of https://review.opendev.org/#/c/621476/ hit the microversion 2.78 | |
| 13:22:10 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: update allocation in binding profile during migrate https://review.opendev.org/656422 | |
| 13:23:03 | brinzhang | mriedem: I will update it by tomorrow, and need your suggestion in https://review.opendev.org/#/c/674243/20/nova/tests/functional/api_sample_tests/test_migrations.py | |
| 13:24:26 | yonglihe | mriedem: the client code is under reviewing now. | |
| 13:24:58 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add bandwidth min service level check of source compute https://review.opendev.org/680395 | |
| 13:24:58 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add min service level check for migrate with bandwidth https://review.opendev.org/680394 | |
| 13:26:43 | mriedem | brinzhang: i'm likely not going to get to the migrations API change today | |
| 13:26:47 | mriedem | lots of other stuff to review | |
| 13:26:57 | mriedem | yonglihe: novaclient is, but what about openstackclient? | |
| 13:27:09 | mriedem | yonglihe: see: https://etherpad.openstack.org/p/compute-api-microversion-gap-in-osc - we don't want to add more gaps to osc | |
| 13:27:12 | bauzas | gibi: can I start looking at your updated change ? ^ | |
| 13:27:16 | yonglihe | o, i like to do that also. | |
| 13:27:55 | gibi | bauzas: the first 3 patches are ready | |
| 13:28:00 | bauzas | gibi: cool | |
| 13:28:06 | mriedem | yonglihe: the osc change likely won't land until ussuri but you can start on it, | |
| 13:28:12 | mriedem | maybe after we get closer on the novaclient change | |
| 13:28:26 | brinzhang | mriedem: Ok, tomorrow I will update it, and then wait for your time :) | |
| 13:28:34 | yonglihe | mriedem: Sure, i definitely need few days to do that. | |
| 13:29:54 | gibi | mriedem: I replied in https://review.opendev.org/#/c/656422/18/nova/compute/manager.py@2122 I diverged from your original suggestion a bit | |
| 13:30:37 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add bandwidth min service level check of source compute https://review.opendev.org/680396 | |
| 13:31:34 | sean-k-mooney | donnyd: i seam to be getting node failures when i use multi-numa-ubuntu-bionic-expanded and multi-numa-ubuntu-bionic | |
| 13:31:35 | yonglihe | mriedem: I take it as my task, for sure. thanks your remind. | |
| 13:31:50 | sean-k-mooney | donnyd: based on https://github.com/openstack/project-config/blob/master/nodepool/nl02.openstack.org.yaml#L348-L357 they shoudl be the correct lables | |
| 13:33:27 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: prepare func test env for moving servers with bandwidth https://review.opendev.org/655109 | |
| 13:36:15 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Func test for migrate server with ports having resource request https://review.opendev.org/655113 | |
| 13:37:27 | stephenfin | mriedem: Mind taking a look at that patch to validate CPU config options again today? https://review.opendev.org/#/c/680107/ | |
| 13:39:29 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Make _rever_allocation nested allocation aware https://review.opendev.org/676138 | |
| 13:39:30 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Func test for migrate re-schedule with bandwidth https://review.opendev.org/676972 | |
| 13:39:30 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support reverting migration / resize with bandwidth https://review.opendev.org/676140 | |
| 13:40:56 | stephenfin | bauzas: I split that "Differentiate between shared and dedicated CPUs" patch into two patches, btw :) https://review.opendev.org/#/c/680108/ and https://review.opendev.org/#/c/671800/ | |
| 13:41:37 | stephenfin | what kind of monster sharpens a _pen_? | |
| 13:41:56 | stephenfin | must be where you got the tattoos | |
| 13:42:13 | mriedem | gibi: sure that works | |
| 13:42:32 | gibi | mriedem: phee, I was a it worried | |
| 13:42:44 | sean-k-mooney | donnyd: actully it seams to be running now | |
| 13:43:12 | gibi | bauzas, mriedem: I think comments are fixed up until the first functional test. I'm working on that now | |
| 13:43:21 | bauzas | stephenfin: the OpenStack CLA doesn't require you to provide your filings | |
| 13:43:35 | bauzas | so I let you imagine whatever you want | |
| 13:43:47 | efried | sean-k-mooney: Can I please ask you to vet the libvirt xml stuff for vpmem here? https://review.opendev.org/#/c/678455/ | |
| 13:43:53 | bauzas | gibi: cool, later today if time allows me | |
| 13:44:42 | gibi | bauzas: thanks | |
| 13:46:26 | bauzas | mriedem: gibi: just one thing, hardly working on the placement audit command, are we hit by feature freeze or not ? | |