Posted	Nick	Remark
#openstack-nova - 2019-09-02
07:10:26	openstackgerrit	Luyao Zhong proposed openstack/nova master: Add resources dict into _Provider https://review.opendev.org/678449
07:10:27	openstackgerrit	Luyao Zhong proposed openstack/nova master: Claim resources in resource tracker https://review.opendev.org/678452
07:10:27	openstackgerrit	Luyao Zhong proposed openstack/nova master: Retrieve the allocations early https://review.opendev.org/678450
07:10:28	openstackgerrit	Luyao Zhong proposed openstack/nova master: libvirt: report VPMEM resources by provider tree https://review.opendev.org/678454
07:10:28	openstackgerrit	Luyao Zhong proposed openstack/nova master: libvirt: Enable driver configuring PMEM namespaces https://review.opendev.org/678453
07:10:29	openstackgerrit	Luyao Zhong proposed openstack/nova master: Parse vpmem related flavor extra spec https://review.opendev.org/678456
07:10:29	openstackgerrit	Luyao Zhong proposed openstack/nova master: libvirt: Support VM creation with vpmems and vpmems cleanup https://review.opendev.org/678455
07:10:30	openstackgerrit	Luyao Zhong proposed openstack/nova master: Add functional tests for virtual persistent memory https://review.opendev.org/678470
07:11:08	openstackgerrit	Brin Zhang proposed openstack/nova-specs master: Support re-configure deleted_on_termination in server https://review.opendev.org/580336
07:26:04	ileixe	Hi nova!
07:26:42	ileixe	Does anybody has an environment which assure CPU QoS within Nova?
07:27:18	ileixe	I mean have anybody ever used CPU pinning in production or something else to prevent noisy neighbors?
07:28:16	ileixe	I want to hear any experience which will be really appreciated for us
07:58:57	openstackgerrit	ya.wang proposed openstack/nova master: Support reporting multi CPU model traits https://review.opendev.org/670300
08:19:55	openstackgerrit	Matthew Booth proposed openstack/nova master: libvirt: Fix service-wide pauses caused by un-proxied libvirt calls https://review.opendev.org/677736
08:34:18	openstackgerrit	Brin Zhang proposed openstack/nova master: Add delete_on_termination to volume-attach API https://review.opendev.org/673133
09:15:31	stephenfin	alex_xu: Well, you can't migrate pinned instances at the moment anyway, so that's not an issue :)
09:16:10	stephenfin	alex_xu: However, assuming artom fixes it, we have that option to disable the translation feature in the scheduler
09:16:27	stephenfin	alex_xu: So if the operator sets that, the scheduler will keep requesting VCPUs
09:18:33	alex_xu	stephenfin: okay, I thought people my blind to live migrate dedicated instance in case they have same hardware :)
09:18:51	alex_xu	stephenfin: we don't have that option in the current version, right
09:19:22	alex_xu	stephenfin: probably we can ask people live migration the instance before upgrade if they want
09:19:33	stephenfin	No unless you explicitly set '[workarounds] enable_numa_live_migration'
09:19:36	stephenfin	*Not
09:19:56	alex_xu	oh, totally forget that option
09:20:17	stephenfin	alex_xu: nah, if all they do is upgrade their compute nodes, nothing will change. They'll still be reporting and consuming VCPUs
09:20:55	openstackgerrit	Gorka Eguileor proposed openstack/nova master: Use os-brick locking for volume attach and detach https://review.opendev.org/614190
09:20:57	stephenfin	Things only change when the operator sets cpu_dedicated_set or cpu_shared_set on the controller, and set the as-yet-unnamed option on the controller
09:21:41	stephenfin	when 'cpu_dedicated_set' is set, the compute node will start reporting PCPUs and transform existing inventory of pinned instances (if any) from VCPU to PCPU
09:21:50	alex_xu	right
09:21:52	stephenfin	not before that though
09:22:07	alex_xu	stephenfin: so we still have that workaround option, in case people need it
09:23:31	stephenfin	alex_xu: Yes, see https://review.opendev.org/#/c/671801/32/nova/conf/workarounds.py
09:23:42	stephenfin	I'm going to have to rename and move that though, of course
09:24:35	bauzas	stephenfin: you got hit by a merge conflict FWIW
09:24:36	bauzas	https://review.opendev.org/#/c/671793/16
09:24:45	stephenfin	yeah, I'll tackle that shortly
09:24:48	stephenfin	expecting a lot of those
09:25:54	alex_xu	stephenfin: ok, if the operator wants to upgrade the host os, then he can rolling upgrade the host os and nova-compute, without PCPU translating and cpu_dedicated_set. After all the nodes upgrade the new os and new nova-compute, then update the cpu_dedicated_set, to reshape the inventory, is that correct?
09:26:11	stephenfin	yes
09:26:19	alex_xu	so cool
09:26:44	alex_xu	stephenfin: we really document those somewhere, like release note upgrade section?
09:27:28	stephenfin	alex_xu: I've started here https://review.opendev.org/#/c/671793/16/releasenotes/notes/cpu-resources-d4e6a0c12681fa87.yaml
09:27:32	stephenfin	But I'll add more as I go
09:27:38	bauzas	alex_xu: yeah that's the plan
09:27:41	alex_xu	stephenfin: cool
09:27:49	bauzas	alex_xu: nothing changes unless the operator triggers it
09:28:07	alex_xu	bauzas: yea, that is much simpler
09:28:08	bauzas	but when they trigger, then it'll be a reshape
09:28:27	bauzas	stephenfin: and that also implies we need to provide some nova-status check command
09:28:37	bauzas	for upgrading to Unicorn
09:28:42	alex_xu	stephenfin: also something fun https://review.opendev.org/#/c/674895/22/nova/virt/libvirt/driver.py, due to I updated a wrong option
09:29:18	sean-k-mooney	alex_xu: dsid stephenfin answer your os upgrade question
09:29:31	alex_xu	sean-k-mooney: yes, perfectly answered
09:30:59	gibi	bauzas, stephenfin: hi! there are +2s from mriedem on the next couple patches in the support-move-ops-with-qos-ports series. starting here https://review.opendev.org/#/c/655110/
09:31:23	bauzas	gibi: yeah, I was planning to put my eyes on your series after stephenfin's one
09:31:32	gibi	bauzas: cool, thanks
09:44:39	yaawang	stephenfin: alex_xu Hi, I had update the patches of vCPU models selection, can you take a look if you have time :) https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/cpu-model-selection
09:45:27	alex_xu	yaawang: got it, will check it again
09:45:49	yaawang	alex_xu: thk :)
09:45:57	alex_xu	yaawang: np
10:06:16	openstackgerrit	sean mooney proposed openstack/nova master: Libvirt: report storage bus traits https://review.opendev.org/666914
10:06:17	openstackgerrit	sean mooney proposed openstack/nova master: Add transform_image_metadata request filter https://review.opendev.org/665775
10:06:17	openstackgerrit	sean mooney proposed openstack/nova master: libvirt: use domain capabilities to get supported device models https://review.opendev.org/666915
10:20:04	openstackgerrit	Brin Zhang proposed openstack/nova-specs master: Support set port vnic type to create server https://review.opendev.org/672400
10:25:04	openstackgerrit	Brin Zhang proposed openstack/nova-specs master: Support set port vnic type to create server https://review.opendev.org/672400
10:51:19	openstackgerrit	Stephen Finucane proposed openstack/nova master: trivial: Rewrap definitions of 'NUMACell' https://review.opendev.org/674395
10:51:20	openstackgerrit	Stephen Finucane proposed openstack/nova master: libvirt: Start checking compute usage in functional tests https://review.opendev.org/678902
10:51:20	openstackgerrit	Stephen Finucane proposed openstack/nova master: libvirt: Simplify 'fakelibvirt.HostInfo' object https://review.opendev.org/678861
10:51:21	openstackgerrit	Stephen Finucane proposed openstack/nova master: libvirt: Fold in argument to '_update_provider_tree_for_vgpu' https://review.opendev.org/676729
10:51:21	openstackgerrit	Stephen Finucane proposed openstack/nova master: objects: Rename 'fields' import to 'obj_fields' https://review.opendev.org/674103
10:51:22	openstackgerrit	Stephen Finucane proposed openstack/nova master: libvirt: '_get_(v|p)cpu_total' to '_get_(v|p)cpu_available' https://review.opendev.org/672693
10:51:22	openstackgerrit	Stephen Finucane proposed openstack/nova master: libvirt: Start reporting PCPU inventory to placement https://review.opendev.org/671793
10:51:23	openstackgerrit	Stephen Finucane proposed openstack/nova master: libvirt: Start reporting 'HW_CPU_HYPERTHREADING' trait https://review.opendev.org/675571
10:51:23	openstackgerrit	Stephen Finucane proposed openstack/nova master: hardware: Differentiate between shared and dedicated CPUs https://review.opendev.org/671800
10:51:24	openstackgerrit	Stephen Finucane proposed openstack/nova master: Add reshaper for PCPU https://review.opendev.org/674895
10:51:24	openstackgerrit	Stephen Finucane proposed openstack/nova master: Add support for translating CPU policy extra specs, image meta https://review.opendev.org/671801
10:54:26	openstackgerrit	Chris Dent proposed openstack/nova master: Use microversion in put allocations in test_report_client https://review.opendev.org/679622
11:10:52	stephenfin	alex_xu, bauzas: Still working on changing the scheduler config option and adding resize functional tests for cpu-resources, but I've moved all the trivial patches up to the front of the series, if you fancy taking a look (starts here https://review.opendev.org/#/c/678861/)
11:11:09	stephenfin	gibi: Yeah, that's on my list for today (t)
11:11:11	stephenfin	*(y)
11:11:37	gibi	stephenfin: thanks
11:49:33	openstackgerrit	Chris Dent proposed openstack/nova master: Tune up db.instance_get_all_uuids_by_hosts https://review.opendev.org/679627
11:59:24	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Nice to have test coverage for If1f465112b8e9b0304b8b5b864b985f72168d839 https://review.opendev.org/679629
12:07:35	aspiers	stephenfin: thanks for the reviews. BTW https://review.opendev.org/#/c/636334/ is missing W+1
12:08:14	aspiers	stephenfin: I'm working on adding the checks you requested, for live migration / suspend etc.
12:21:03	kashyap	aspiers: Nice, seems like the SEV work is almost merged.
12:21:14	aspiers	kashyap: Yes, pretty close now :)
12:21:56	aspiers	It's almost a year since I uploaded the Stein spec :-o
12:22:13	aspiers	So this has been a year-long project or more already
12:23:19	kashyap	It required a lot of 'supporting infra' work, which is also useful for other features (machine types rework; domCapabilities, etc)
12:23:28	aspiers	Right
12:23:42	aspiers	I'm glad it turned out to have other uses. Didn't anticipate that originally.
12:24:17	kashyap	aspiers: Unrelated - SEV _requires_ 'q35', isn't it?
12:25:28	aspiers	kashyap: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2019-07-30.log.html#t2019-07-30T09:21:35
12:25:30	aspiers	;-)
12:26:03	kashyap	aspiers: Haha, my memory is like the bumblebee's -- can't recall anything more than past 7 seconds
12:26:07	aspiers	XD
12:26:20	aspiers	Similar thing happened to me this morning
12:27:20	kashyap	aspiers: I asked because, the next question I was looking for was: is there a check in the code where: "if SEV && !q35 --> throw an error"

Earlier   Later