Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-08-21
20:40:14 mriedem yeah, just said that in the bug report,
20:40:19 mriedem i think it's just a simple upgrade reno yeah?
20:41:11 dansmith mriedem: well, more like the impact to tripleo, osa, etc
20:41:18 dansmith this potentially affects lots of manage commands
20:41:39 dansmith although this is really SHTF level fail cases, so nobody should really be depending on that
20:43:17 mriedem i counted simple_cell_setup, map_instances and heal_allocations as returning 1 in non-error cases
20:44:06 efried nobody should be relying on 1 being a real failure, because if they are, they're f'ed anyway.
20:44:21 dansmith mriedem: no, I mean cases in all the other commands that could raise
20:44:22 efried so I think this is a situation where it's okay to change it.
20:44:50 dansmith efried: that's my point, the only case would be somewhere that someone tests "is something done yet" by checking if something fails, and uses ret=1 to check
20:44:54 openstackgerrit Eric Fried proposed openstack/nova master: Revert "Filter UnsupportedServiceVersion warning" https://review.opendev.org/677825
20:45:17 efried right, which is invalid.
20:45:21 efried I'm agreeing with you
20:45:24 efried mark your calendar
20:46:08 dansmith I don't think it's invalid
20:46:31 openstackgerrit Matt Riedemann proposed openstack/nova master: Revert "Filter UnsupportedServiceVersion warning" https://review.opendev.org/677825
20:46:32 dansmith there are probably cases where there's no other way to tell if a thing is done yet or not
20:50:14 openstackgerrit Matt Riedemann proposed openstack/nova master: Revert "Filter UnsupportedServiceVersion warning" https://review.opendev.org/677825
20:50:33 mriedem efried: just rebased on top of the change mentioned in the commit
20:50:43 efried yeah, good plan
20:51:12 efried though the warning would be gone anyway since 0.34.0 is in u-c
21:06:41 openstackgerrit Matt Riedemann proposed openstack/nova master: Document archive_deleted_rows return codes https://review.opendev.org/677819
21:06:42 openstackgerrit Matt Riedemann proposed openstack/nova master: Change nova-manage unexpected error return code to 255 https://review.opendev.org/677832
21:14:56 openstackgerrit James E. Blair proposed openstack/nova master: Fix issues building PDF docs https://review.opendev.org/677028
21:16:50 openstackgerrit Matt Riedemann proposed openstack/nova master: Document map_instances return codes in table format https://review.opendev.org/677835
22:27:14 openstackgerrit Merged openstack/nova master: Deprecate Aggregate[Core|Ram|Disk]Filters https://review.opendev.org/673496
22:27:42 openstackgerrit Merged openstack/nova master: Re-use DB MetaData during archive_deleted_rows https://review.opendev.org/675218
#openstack-nova - 2019-08-22
00:12:42 openstackgerrit melanie witt proposed openstack/nova master: Handle websockify v0.9.0 in console proxy https://review.opendev.org/677856
01:22:25 openstackgerrit Brin Zhang proposed openstack/nova master: Add docstring to check_availability_zone function https://review.opendev.org/677858
02:06:46 openstackgerrit melanie witt proposed openstack/nova master: Handle websockify v0.9.0 in console proxy https://review.opendev.org/677856
02:21:36 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-services API policies https://review.opendev.org/648480
05:11:23 openstackgerrit Michael Still proposed openstack/nova master: Remove zVM requirement from the top level requirements. https://review.opendev.org/677870
05:28:27 openstackgerrit Merged openstack/nova master: Fix missing rule description in HACKING.rst https://review.opendev.org/677589
07:05:57 openstackgerrit Merged openstack/nova master: Add a hacking rule for non-existent assertions https://review.opendev.org/677596
07:09:53 alex_xu efried: sean-k-mooney this doesn't sounds right https://review.opendev.org/#/c/664420/42/nova/scheduler/request_filter.py@205, looks like we can't do the translate in request filter
07:29:33 openstackgerrit Bhagyashri Shewale proposed openstack/nova master: Ignore root_gb for BFV in simple tenant usage API https://review.opendev.org/612626
08:11:20 openstackgerrit Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851
08:12:54 openstackgerrit Merged openstack/nova master: Move final bridge commands to privsep. https://review.opendev.org/639580
08:13:05 openstackgerrit Merged openstack/nova master: Cleanup the _execute shim in nova/network. https://review.opendev.org/639581
08:13:21 openstackgerrit Merged openstack/nova master: We no longer need rootwrap. https://review.opendev.org/554438
08:13:38 openstackgerrit Merged openstack/nova master: Cleanup no longer required filters and add a release note. https://review.opendev.org/639826
08:13:49 openstackgerrit Merged openstack/nova master: Make a failure to purge_db fail in post_test_hook.sh https://review.opendev.org/677806
08:14:00 openstackgerrit Merged openstack/nova master: Split fake host capabilities into reusable variables https://review.opendev.org/677710
08:31:33 openstackgerrit Brin Zhang proposed openstack/nova master: Add delete_on_termination to volume-attach API https://review.opendev.org/673133
08:40:12 openstackgerrit Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851
08:49:42 shilpasd gibi: thanks for reviewing patches for 'isolate aggregates', will fix small nits
08:50:28 gibi shilpasd: I'm moving forward on that series right now, so you can expect more votes from me
08:51:23 shilpasd gibit: thanks
08:58:34 openstackgerrit Brin Zhang proposed openstack/nova master: Add user_id and project_id colume to Migration https://review.opendev.org/673990
09:26:49 openstackgerrit Brin Zhang proposed openstack/nova master: Filter migrations by user_id/project_id https://review.opendev.org/674243
09:31:35 openstackgerrit Brin Zhang proposed openstack/nova master: Add user_id and project_id colume to Migration https://review.opendev.org/673990
09:43:11 shilpasd gibi: https://review.opendev.org/#/c/671074/8/nova/objects/aggregate.py@472, we are accepting ignored_keys as [], to make function generalized, So based on 'value' one can get list of aggregates by using this function.
09:44:01 gibi shilpasd: do we call the function with such generalized parameters? or do you have a plan short term to add such a call?
09:45:28 openstackgerrit Brin Zhang proposed openstack/nova master: Add delete_on_termination to volume-attach API https://review.opendev.org/673133
09:47:00 shilpasd gibi: no any plan as such, ok, will address this comment, tnx
09:47:47 gibi shilpasd: I suggest not to add complexity that will not be used right now. If we figure out that we need a more generic call then we can make the necessary changes in the function any time
09:49:03 shilpasd gibi: sure Gibi, will work on review comments
09:49:13 gibi shilpasd: thanks
09:50:13 aspiers alex_xu: I think we need to talk to efried about https://review.opendev.org/#/c/664420/42/nova/scheduler/request_filter.py@206 and https://review.opendev.org/#/c/664420/42/nova/virt/hardware.py@1225
09:50:27 aspiers alex_xu: oh, you already said that
09:51:20 openstackgerrit Adam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420
10:28:02 stephenfin dansmith: Could I get your thoughts on https://review.opendev.org/#/c/537414/ today? I think it's sane, but maybe there's something I've missed or should be doing in addition
10:28:50 stephenfin alex_xu: Fancy hitting these trivial changes? https://review.opendev.org/#/c/671791/ https://review.opendev.org/#/c/675570/
10:33:28 stephenfin #success nova no longer needs rootwrap (well, except for starting privsep daemons and os-brick, for some strange reason)
10:33:30 openstackstatus stephenfin: Added success to Success page (https://wiki.openstack.org/wiki/Successes)
10:37:59 openstackgerrit Stephen Finucane proposed openstack/nova master: Address nits from privsep series https://review.opendev.org/677210
10:40:25 openstackgerrit Brin Zhang proposed openstack/nova master: Add delete_on_termination to volume-attach API https://review.opendev.org/673133
10:50:44 openstackgerrit Stephen Finucane proposed openstack/nova master: Update docstring of 'revert_resize' function https://review.opendev.org/665976
10:50:44 openstackgerrit Stephen Finucane proposed openstack/nova master: Recalculate 'RequestSpec.numa_topology' on resize https://review.opendev.org/662522
10:50:45 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Cleanup of '_test_resize' helper test https://review.opendev.org/664245
10:50:46 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Add '_setup_compute_services' helper https://review.opendev.org/663102
10:58:34 sean-k-mooney efried: o/ i have a process question for you. when can we submit blueprints/specs for approval for Ussuri. i think its normally after m3 but you mentions posible targeting stuff to U early a week or two back
11:00:41 sean-k-mooney from a downstream persective we will normally only consider a feature bacport if said feature is merged on master, and we will only commit to trying to backport it if the feature is approved and the design allows it to be
11:01:40 sean-k-mooney the context is i have a customer asking when we will know if we can backport https://review.opendev.org/#/c/674072/ and currenly we have said october/november but just trying to figure out if we can let them know before then.
11:01:41 openstackgerrit sahid proposed openstack/nova master: cellv2: fix update_cell to support cell0 https://review.opendev.org/672045
11:03:28 alex_xu aspiers: yea, that is really strange
11:03:50 alex_xu stephenfin: yea, checking
11:11:53 alex_xu stephenfin: done
11:12:00 stephenfin alex_xu: Thanks :)
11:12:14 alex_xu np
11:13:57 openstackgerrit Stephen Finucane proposed openstack/nova master: setup.cfg: Cleanup https://review.opendev.org/677969
11:13:57 openstackgerrit Stephen Finucane proposed openstack/nova master: WIP: Move DB dependencies to 'extras' https://review.opendev.org/677475
11:17:19 aspiers alex_xu: sorry, what's strange?
11:18:21 stephenfin alex_xu: There's one more non-functional change here actually, if you have time https://review.opendev.org/#/c/672336/ :)
12:12:02 shilpasd gibi: hi
12:12:23 gibi shilpasd: hi
12:13:56 shilpasd gibi: if we don't have traits sets either on flavor or image, then we should skip this filter, since https://review.opendev.org/#/c/667952/18/nova/tests/functional/test_aggregates.py@516 is failing if raise ValueError if ignored_keys is empty
12:15:03 shilpasd IMO, we should return false at https://review.opendev.org/#/c/671075/9/nova/scheduler/request_filter.py@79, if keys is empty
12:15:10 openstackgerrit Merged openstack/nova master: FUP for I5576fa2a67d2771614266022428b4a95487ab6d5 https://review.opendev.org/677769
12:15:16 shilpasd gibi: please confirm
12:17:15 shilpasd IMO we should skip filter if keys are empty
12:17:23 gibi shilpasd: if there is no traits in image or in flavor we still want to prevent the instance to land in an aggregate that needs to be isolated. isn't it?
12:19:31 gibi shilpasd: it is how I understand the spec https://review.opendev.org/#/c/609960/8/specs/train/approved/placement-req-filter-forbidden-aggregates.rst@20
12:19:58 shilpasd gibi: yes
12:19:59 gibi so if the keys are empty then we have to forbid every aggregates that has some kind of metadata set
12:20:28 shilpasd so we shouldn't raise ValueError in DB for ignored_keys empty
12:21:37 shilpasd https://review.opendev.org/#/c/671074/8/nova/objects/aggregate.py@472
12:22:43 gibi shilpasd: you are correct. so if there is no ignored_keys then we have to return every aggregate that has metadata.value set to "required"
12:23:04 gibi shilpasd: so my comment is wrong in https://review.opendev.org/#/c/671074/8/nova/objects/aggregate.py@472
12:23:37 shilpasd gibi: ok, will skip this

Earlier   Later