| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-08-20 | |||
| 14:13:14 | mriedem | we have a job in the experimental queue to test with pg on-demnd | |
| 14:13:21 | mriedem | i think cdent dabbles with pg as well | |
| 14:13:33 | stephenfin | openstack-discuss post time? | |
| 14:13:37 | mriedem | why? | |
| 14:13:48 | mriedem | it's already been discussed, several times, | |
| 14:13:52 | mriedem | including with a TC resolution years ago | |
| 14:14:02 | mriedem | and people came to the "meh, it's not hurting, so who cares" | |
| 14:14:55 | stephenfin | mnaser, aspiers and I, for a start | |
| 14:15:13 | stephenfin | idk, feels odd to keep testing something that no one uses or cares about | |
| 14:15:14 | mriedem | what is prompting this coming up? | |
| 14:15:34 | mriedem | we test and fix pg on demand when there is an issue someone reports, because there are people using it | |
| 14:15:38 | mnaser | i assume when i ran unit tests locally and psycopg2 failed to build cause i was missing headers | |
| 14:15:45 | mriedem | just because they aren't daily upstream contributors doesn't mean people are'nt using it, or that it's broken | |
| 14:15:48 | mnaser | so i was like "well i scanned the source code and couldnt find any references, why is it in requirements?" | |
| 14:16:00 | mnaser | and someone explianed something about some sort of test path that happened if the library was found | |
| 14:16:14 | mnaser | and someone asked cfriesen if they used postgres and here we are, afaik | |
| 14:16:18 | mriedem | it's really a bindep thing for the opportunistic schema migration tests | |
| 14:16:27 | mnaser | https://review.opendev.org/#/c/676684/ means we dont have to carry it anymore | |
| 14:16:32 | mriedem | we can just as easily remove mysql from test-requirements | |
| 14:18:00 | stephenfin | I must say it'd be nice not to need to install those to build our docs. What happened to the idea to move them into 'extras', like oslo.db does? | |
| 14:18:19 | stephenfin | I didn't know there were actually people using postgres though. I thought it was just cfriesen, tbh :) | |
| 14:19:42 | mriedem | prometheanfire also uses pg | |
| 14:19:44 | mriedem | and huawei | |
| 14:21:55 | mnaser | stephenfin: i think to build docs we use doc/requirements.txt now? | |
| 14:22:02 | mnaser | so you shouldn't need to install it.. i think? | |
| 14:22:12 | stephenfin | mnaser: apidoc :( | |
| 14:22:55 | stephenfin | that introspects the code so you need nova to be installed, which brings in all the dependencies | |
| 14:22:59 | mnaser | ah gotcha | |
| 14:23:10 | mriedem | we don't publish an api module index | |
| 14:23:10 | mnaser | hmm | |
| 14:23:12 | mriedem | in our docs | |
| 14:23:22 | mnaser | but we dont have psycopg in requirements, only in test-requirements i think | |
| 14:23:28 | mriedem | if we're building an api doc, it's a waste of time | |
| 14:23:28 | mnaser | no db driver exists in requirements afaik | |
| 14:24:03 | mriedem | mnaser: correct. -1 on the lower-constraints thing, otherwise i'd be +2. | |
| 14:24:10 | mriedem | might as well address efried's comments as well | |
| 14:24:47 | stephenfin | mriedem: We do. See doc/source/reference/services.rst and doc/source/reference/services.rst | |
| 14:25:04 | stephenfin | 41:.. automodule:: nova.manage | |
| 14:25:04 | stephenfin | 31:.. automodule:: nova.service | |
| 14:25:04 | stephenfin | doc/source/reference/services.rst | |
| 14:25:04 | stephenfin | 145:.. automodule:: nova.notifications.objects.base | |
| 14:25:04 | stephenfin | doc/source/reference/notifications.rst | |
| 14:25:26 | mriedem | oh god, we could just remove that | |
| 14:25:43 | stephenfin | no argument from me (y) | |
| 14:25:56 | mriedem | that's probably a relic from when you could extend that stuff via config out of tree | |
| 14:26:00 | mriedem | we removed that eons ago | |
| 14:26:13 | stephenfin | even the notifications stuff? | |
| 14:26:45 | mriedem | ew this https://docs.openstack.org/nova/latest/reference/notifications.html#the-nova-notifications-objects-base-module | |
| 14:27:12 | mriedem | that's actually useful for contributors adding new versioned notifications | |
| 14:27:23 | mriedem | is there a way to only build part of the api doc and not all of it? | |
| 14:28:04 | stephenfin | not that I'm aware of, but that autodoc package is really tough to grok | |
| 14:29:55 | openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: Move DB, virt driver deps to 'extras' https://review.opendev.org/677475 | |
| 14:29:59 | stephenfin | mnaser, mriedem, aspiers: WIP but I think that would do the trick ^ | |
| 14:30:41 | prometheanfire | if I had to do it again... | |
| 14:31:38 | efried | alex_xu, sean-k-mooney: I think we now need to write a crisp discussion-free version of the design points as refined. I recommend either creating a new etherpad or shunting the current content down and doing it above. | |
| 14:31:42 | aspiers | stephenfin: cool! how do you use extras? | |
| 14:31:51 | stephenfin | prometheanfire: I'd do it with you? 🎶 | |
| 14:32:10 | stephenfin | aspiers: 'cd nova; pip install .[mysql]' | |
| 14:32:25 | sean-k-mooney | efried: yes we do. | |
| 14:32:36 | aspiers | stephenfin: what is that voodoo syntax! :) | |
| 14:32:37 | stephenfin | or 'pip install .[mysql,postgres,foo]' | |
| 14:32:43 | sean-k-mooney | efried: over all do you think this is a workable direction | |
| 14:32:44 | aspiers | never seen that before | |
| 14:32:55 | alex_xu | efried: got it | |
| 14:33:21 | stephenfin | now you know :) | |
| 14:33:29 | sean-k-mooney | stephenfin: that is install the python module in the current folder with the [] extras packages listed in the brackets right | |
| 14:33:35 | stephenfin | fwiw, that's what pbr is doing for 'doc/requirements.txt' under the hood | |
| 14:33:40 | stephenfin | it just generates a docs extra | |
| 14:33:50 | stephenfin | sean-k-mooney: correctamundo | |
| 14:34:37 | stephenfin | it also works with packages for PyPI, e.g. 'pip install oslo.db[mysql]' | |
| 14:34:43 | stephenfin | *from | |
| 14:35:26 | sean-k-mooney | alex_xu: i think it would be useful if you used both pmem and vgpus as example of how this could be used | |
| 14:35:41 | alex_xu | sean-k-mooney: good idea | |
| 14:37:15 | efried | sean-k-mooney: Workable, yes. Whether it's going to get by mriedem and dansmith is another question. But let's have that crisp writeup for them to look at so they don't have to try to follow our chicken-scratch stream of consciousness | |
| 14:38:20 | openstackgerrit | Mohammed Naser proposed openstack/nova master: requirements: move to using psycopg2-binary https://review.opendev.org/676684 | |
| 14:38:33 | mnaser | mriedem: ^ good call on lower-constraints | |
| 14:42:02 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Libvirt: add support for vPMU configuration. https://review.opendev.org/671338 | |
| 14:43:09 | mriedem | sean-k-mooney: i fixed up some nits in the libvirt driver tests https://review.opendev.org/#/c/671338/13 | |
| 14:43:10 | mriedem | +2 | |
| 14:43:17 | mriedem | stephenfin: i'm +2 on the vpmu change now https://review.opendev.org/#/c/671338/13 | |
| 14:43:28 | stephenfin | (y) | |
| 14:43:29 | mriedem | sean-k-mooney: you still need to update this v | |
| 14:43:30 | mriedem | https://review.opendev.org/#/c/675182/2 | |
| 14:43:34 | sean-k-mooney | mriedem: thanks :) | |
| 14:43:44 | sean-k-mooney | is that the glance change | |
| 14:43:47 | mriedem | yes | |
| 14:43:56 | sean-k-mooney | its on the todo list for today | |
| 14:44:32 | sean-k-mooney | im just finishing up myu prefilter change based on stephenfin commenst | |
| 14:44:39 | sean-k-mooney | then ill update both glance patches | |
| 14:46:37 | sean-k-mooney | stephenfin: ill address your comments on the deprecation patch after all of that is done ^ | |
| 14:48:22 | mriedem | melwitt: so abandon https://review.opendev.org/#/c/675218/ at this point yeah? | |
| 14:49:18 | aspiers | alex_xu: does https://review.opendev.org/#/c/638680/46/nova/tests/functional/libvirt/test_report_cpu_traits.py@92 make sense now? | |
| 14:50:57 | mriedem | melwitt: actually https://review.opendev.org/#/c/507486/67/nova/db/sqlalchemy/api.py@5572 | |
| 14:52:07 | sean-k-mooney | aspiers im changeing how some of that works by the way. | |
| 14:52:08 | mriedem | meta = MetaData(get_engine(context=context, use_slave=True)) | |
| 14:52:08 | mriedem | heh yeah in PS65 you had this: | |
| 14:52:28 | aspiers | sean-k-mooney: some of which? | |
| 14:52:40 | sean-k-mooney | how the libvirt driver reports traits | |
| 14:52:52 | aspiers | sean-k-mooney: I'm just reviewing your patch now | |
| 14:53:38 | aspiers | sean-k-mooney: you mean https://review.opendev.org/#/c/666915/8/nova/virt/libvirt/driver.py ? | |