| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-08-19 | |||
| 14:51:18 | mriedem | complain yes, but not so much to want to review a bash script :) | |
| 14:52:19 | sean-k-mooney | efried: the specs are not too bad. recently started building releasenotes locally for some of my patches and was suprised at how long those take. | |
| 14:52:21 | dansmith | mriedem: I dropped some comments on the bottom two patches, but I'm still mulling my feelings about it, but am out of time before my next call | |
| 14:53:07 | dansmith | mriedem: it really seems like an unfortunate purpose-built call to do part of the work of the other two for a specific situation, which just feels wrong and very fragile | |
| 14:53:09 | dansmith | I know it's more work to refactor, and I don't really want to review *that* either | |
| 14:53:16 | dansmith | so I dunno | |
| 14:57:15 | mriedem | to refactor prep_resize? | |
| 14:57:58 | dansmith | well, all of them to do this as a single thing | |
| 14:58:12 | dansmith | I dunno, I'll try to think on it when I'm done with my next call | |
| 14:58:14 | mriedem | i think that would be gross in other ways | |
| 14:58:18 | mriedem | ack | |
| 14:58:26 | dansmith | this just seems like piling on another copy of a bunch of existing logic | |
| 15:05:52 | openstack | Launchpad bug 1815082 in OpenStack Compute (nova) ""DBNonExistentTable: (sqlite3.OperationalError) no such table: services" when starting nova-metadata under uwsgi" [Medium,In progress] - Assigned to Matt Riedemann (mriedem) | |
| 15:05:52 | frickler | mriedem: I'm cleaning up old patches and found https://bugs.launchpad.net/nova/+bug/1815082 , is that just forgotten or has it been resolved? | |
| 15:06:23 | mriedem | it has not been resolved | |
| 15:07:00 | mriedem | dansmith: well the whole cross-cell series was also agreed to be separate from trying to munge it into existing compute manager code for sanity | |
| 15:07:18 | sean-k-mooney | efried: comments in https://review.opendev.org/#/c/673356/1 | |
| 15:07:24 | mriedem | i've refactored and made common the obvious stuff along the way like the notification bits | |
| 15:10:47 | mriedem | frickler: i ran out of steam trying to debug it | |
| 15:35:57 | mriedem | efried: i can +2 now if sean is ok with a FUP or +2 after you address his comments, either way https://review.opendev.org/#/c/673356/ | |
| 15:37:46 | openstackgerrit | Eric Fried proposed openstack/nova-specs master: tox -e fast-specs https://review.opendev.org/673356 | |
| 15:38:20 | efried | sean-k-mooney, mriedem: Addressed some of the comments, but mostly for the sake of compromise. | |
| 15:38:31 | efried | shit | |
| 15:38:54 | openstackgerrit | Eric Fried proposed openstack/nova-specs master: tox -e fast-specs https://review.opendev.org/673356 | |
| 15:39:28 | frickler | mriedem: np, I'll keep it on my list, then. I've reduced my list of open patches to less than a screenful already with a bit of headroom even, that's enough for my summer cleanup ;) | |
| 15:53:31 | efried | mriedem: o hey mon, got a sec to help me with logstash? | |
| 15:53:53 | mriedem | yes | |
| 15:54:41 | efried | right?? | |
| 15:54:41 | efried | message:"TypeError: open: path should be string, bytes or os.PathLike, not _NormalAccessor" | |
| 15:54:41 | efried | mriedem: I was trying to logstash that kombu thing. I should be able to search for | |
| 15:55:18 | mriedem | got a link to a log with the failure? | |
| 15:55:36 | efried | https://zuul.opendev.org/t/openstack/build/369bc38f57134ece8befdf4f3d6d670e | |
| 15:57:05 | efried | mriedem: note that it's in tox-py37 (always), not sure if that's significant | |
| 15:57:34 | mriedem | since the console log is huge is it failing to publish logs to elasticsearch | |
| 15:57:35 | mriedem | ? | |
| 15:58:12 | mriedem | https://review.opendev.org/#/c/673356/1 | |
| 15:58:14 | mriedem | oops | |
| 15:58:25 | mriedem | 222.4M | |
| 15:59:16 | efried | so you mean, elasticsearch is only good if something blows up in a small way? | |
| 15:59:36 | mriedem | i wonder why job-output is not compressed | |
| 15:59:48 | mriedem | i don't see subsequent ansible task failures for compressing and publishing logs though | |
| 15:59:56 | efried | swift cutover something something | |
| 16:00:45 | mriedem | the b' is screwing with your query | |
| 16:01:23 | efried | that's going to be prevalent in py3* logs, tho | |
| 16:01:29 | mriedem | yes i know | |
| 16:01:30 | efried | And I'm not including the b'' in my search | |
| 16:01:31 | efried | should I be? | |
| 16:01:32 | mriedem | and it's always been a problem | |
| 16:01:35 | efried | o | |
| 16:01:47 | mriedem | message:"b'TypeError: open: path should be string, bytes or os.PathLike, not _NormalAccessor'" AND tags:"console" | |
| 16:01:47 | mriedem | so i'm using: | |
| 16:02:06 | mriedem | but that's not showing hits either, | |
| 16:02:12 | efried | I got hits | |
| 16:02:20 | efried | (this got resolved over the weekend, so you have to spread to last week) | |
| 16:02:30 | mriedem | i'm goign to 7 days | |
| 16:03:01 | mriedem | are you sure those are real hits? kibana has this weird thing where the first query results are always garbage | |
| 16:03:07 | efried | weird, I'm getting lots of hits with that sea... oh, 'and' is case-sensitive | |
| 16:03:07 | mriedem | and i have to hit the magnifying glass thing to re-query | |
| 16:03:25 | efried | so yeah, I'm getting nothing. | |
| 16:03:34 | mriedem | then we need to talk to clarkb | |
| 16:10:36 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Nova object changes for forbidden aggregates request filter https://review.opendev.org/671072 | |
| 16:11:21 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: DB API changes to get non-matching aggregates from metadata https://review.opendev.org/671074 | |
| 16:12:09 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Add a new request filter to isolate aggregates https://review.opendev.org/671075 | |
| 16:13:00 | openstackgerrit | Shilpa Devharakar proposed openstack/nova master: Enable request filter isolate_aggregates https://review.opendev.org/667952 | |
| 16:37:18 | openstackgerrit | Adam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection https://review.opendev.org/636334 | |
| 16:37:19 | openstackgerrit | Adam Spiers proposed openstack/nova master: Apply SEV-specific guest config when SEV is required https://review.opendev.org/644565 | |
| 16:37:19 | openstackgerrit | Adam Spiers proposed openstack/nova master: Add |
|
| 16:37:20 | openstackgerrit | Eric Fried proposed openstack/nova-specs master: tox -e fast-specs https://review.opendev.org/673356 | |
| 16:41:20 | openstackgerrit | Adam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420 | |
| 16:42:04 | openstackgerrit | Adam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection https://review.opendev.org/636334 | |
| 16:42:05 | openstackgerrit | Adam Spiers proposed openstack/nova master: Apply SEV-specific guest config when SEV is required https://review.opendev.org/644565 | |
| 16:42:05 | openstackgerrit | Adam Spiers proposed openstack/nova master: Add |
|
| 16:48:54 | openstackgerrit | Adam Spiers proposed openstack/nova master: Make it easier to run a selection of tests relevant to ongoing work https://review.opendev.org/677180 | |
| 16:54:52 | openstackgerrit | sean mooney proposed openstack/nova master: Libvirt: add support for vPMU configuration. https://review.opendev.org/671338 | |
| 16:55:14 | sean-k-mooney | mriedem: ^ should address your vpmu nits. im going to grab something to eat quickly but if you see anything else leave a comment and ill fix it in an hour or so | |
| 16:55:22 | openstackgerrit | Adam Spiers proposed openstack/nova master: Enable booting of libvirt guests with AMD SEV memory encryption https://review.opendev.org/666616 | |
| 17:01:44 | efried | Basically (IMO) we need *some* reasonable py37 coverage in there, and nova seemed as good as any. | |
| 17:01:44 | efried | mriedem: are you in favor of gating requirements on py37 using cross-nova? https://review.opendev.org/#/c/677071/5 | |
| 17:06:15 | mriedem | gmann: comments in your novaclient 2.75 change https://review.opendev.org/#/c/676275/ | |
| 17:07:43 | mriedem | is openstack-py37 voting on nova changes? | |
| 17:07:53 | mriedem | looks like yes | |
| 17:08:16 | mriedem | https://opendev.org/openstack/openstack-zuul-jobs/src/branch/master/zuul.d/jobs.yaml#L166 | |
| 17:09:13 | mriedem | so yeah +1 | |
| 17:09:37 | efried | thanks mriedem | |
| 17:13:39 | openstackgerrit | Matt Riedemann proposed openstack/nova master: doc: cleanup 2.75 REST API microversion history doc https://review.opendev.org/677259 | |
| 17:29:46 | openstackgerrit | Akihiro Motoki proposed openstack/nova master: PDF documentation build https://review.opendev.org/676730 | |
| 17:38:13 | openstackgerrit | Adam Spiers proposed openstack/nova-specs master: Allow deep-linking to memory reservation section of AMD SEV spec https://review.opendev.org/677264 | |
| 18:01:12 | aspiers | err, why is there no direct link from https://docs.openstack.org/nova/latest/ to https://docs.openstack.org/nova/latest/user/ ? | |
| 18:04:03 | efried | aspiers: fix it! | |
| 18:07:39 | aspiers | efried: I was wondering if it was deliberate | |
| 18:08:14 | aspiers | "Todo | |
| 18:08:17 | aspiers | The rest of this document should probably move to the admin guide." | |
| 18:08:51 | aspiers | The top-level page directly links to some of the stuff under doc/source/user/ | |
| 18:09:21 | efried | I can't imagine why the nova doc landing page wouldn't have a link to the user landing page anyway. | |
| 18:09:45 | aspiers | It does seem odd | |
| 18:09:53 | aspiers | but I find the whole doc organisation pretty confusing | |
| 18:10:12 | efried | agree | |
| 18:10:43 | efried | At some point donnyd was on a mission to reorganize, perhaps y'all could meet minds | |
| 18:11:16 | aspiers | when I've got this damn SEV series done | |
| 18:11:33 | aspiers | I'm pretty close now, just addressing your feedback on the tip of the series and then my backlog is clear I think | |