Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-08-16
15:55:47 openstackgerrit Merged openstack/nova stable/rocky: Add 'path' query parameter to console access url https://review.opendev.org/674916
15:55:54 openstackgerrit Merged openstack/nova master: Avoid timeout from service update api unit tests https://review.opendev.org/676923
15:56:01 efried I need to run for ~1h. donnyd is spinning us up an env where we can play with this more realtime-ish.
15:56:01 efried Could it really be that we got a spurious failure? That would seem a terrible coincidence. I'll recheck just in case.
15:56:01 efried Not sure if that /flavors/baremetal business is "normal" or not.
15:56:01 efried The devstack times out waiting for n-api to respond, which is weird, because n-api looks active https://zuul.opendev.org/t/openstack/build/8b81e6788f21493e861948ce60687e7b/log/controller/logs/screen-n-api.txt.gz
15:56:01 efried And yet, the nova side never seems to "get there".
15:56:01 efried I'm not very experienced looking at ironic logs (maybe we can bring in a ringer) but afaict we make requests for /nodes that return nothing (I assume 13 bytes is "no results") for a while, and then start returning stuff, whereupon we actually start requesting and receiving real data.
15:56:01 efried mordred, dustinc: I can't figure it out so far.
16:03:45 openstackgerrit Balazs Gibizer proposed openstack/nova master: Support migrating SRIOV port with bandwidth https://review.opendev.org/676980
16:10:18 dustinc efried: awesome, thanks
16:40:44 donnyd I should have something to use in a bit, maybe an hour or so
17:12:01 stephenfin yonglihe: Sorry, missed the ping. I'll take a look at that Monday, sure :)
17:23:00 openstackgerrit ya.wang proposed openstack/nova master: vCPU model selection https://review.opendev.org/670298
17:23:00 openstackgerrit ya.wang proposed openstack/nova master: Add compatibility checks for CPU mode and CPU models and extra flags https://review.opendev.org/670299
17:23:01 openstackgerrit ya.wang proposed openstack/nova master: Support report multi CPU model traits https://review.opendev.org/670300
17:42:15 sean-k-mooney hum look like gerrit is down
17:42:24 sean-k-mooney i think that is a sign
17:42:41 mnaser sean-k-mooney: wfm
17:43:15 sean-k-mooney nope cant open any of the links above
17:43:24 mnaser i can so many its your side :)
17:43:27 mnaser and also a sign :)
17:43:46 sean-k-mooney yep its friday and 6:43
17:43:53 sean-k-mooney time to not be working
18:07:38 openstackgerrit Merged openstack/nova master: libvirt: Mock libvirt'y things in setUp https://review.opendev.org/676727
18:52:06 efried_afk alex_xu: I had to give up on https://review.opendev.org/#/c/673151/ -- would you please review it when you get a chance?
19:12:12 openstackgerrit Merged openstack/nova master: Allow assertXmlEqual() to pass options to matchers.XMLMatches https://review.opendev.org/674628
19:12:19 openstackgerrit Merged openstack/nova master: Fix libvirt driver tests to use LibvirtConfigCapsGuest instances https://review.opendev.org/674629
19:12:52 artom dansmith, thanks for all the reviews - I won't get to them all this afternoon, obviously, but I'm aiming for Monday
19:13:01 dansmith ack
19:16:12 efried aspiers: https://review.opendev.org/#/c/638680/ qq if you're still around.
20:16:40 aspiers efried: yup?
20:16:59 efried aspiers: see inline, want to make sure caching-only-False is intentional
20:17:03 aspiers ok
20:22:49 openstackgerrit Adam Spiers proposed openstack/nova master: Track libvirt host/domain capabilities for multiple machine types https://review.opendev.org/673151
20:23:44 openstackgerrit Adam Spiers proposed openstack/nova master: Track libvirt host/domain capabilities for multiple machine types https://review.opendev.org/673151
20:24:38 aspiers efried: are there questions I can answer which would make reviewing https://review.opendev.org/#/c/673151/ a possibility for you?
20:25:02 aspiers efried: I really doubt I know significantly more than you in this area - you're probably just missing one or two key facts
20:25:42 efried aspiers: I am missing domain (so to speak) knowledge of libvirt+xml
20:25:47 efried like, the whole thing.
20:25:54 efried and machine types
20:25:57 efried and architectures
20:26:04 efried It's just all an enormous hole in my brain.
20:26:10 aspiers haha
20:26:20 aspiers it's really not that hard, honest :)
20:26:27 efried be like asking me to review, I dunno, a Windows kernel patch.
20:26:33 aspiers LOL
20:26:49 aspiers I doubt it
20:27:02 efried aspiers: But it's this one that I was asking about https://review.opendev.org/#/c/638680/41
20:27:08 efried specifically https://review.opendev.org/#/c/638680/41/nova/virt/libvirt/host.py@1186
20:27:45 aspiers oh, looks like I screwed it up
20:31:48 openstackgerrit James E. Blair proposed openstack/nova master: WIP: sphinx latex build tests https://review.opendev.org/677028
20:33:14 efried okay
20:44:04 openstackgerrit Adam Spiers proposed openstack/nova master: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported https://review.opendev.org/638680
20:44:21 efried ...which afaict is, we're talking to ironic okay, but for some reason the node.list is coming back with 0 nodes.
20:44:21 efried dustinc, mordred: Okay, donnyd set up us the cloud, and I've got it configured to reproduce the failure
20:44:34 efried so dustinc this might be where you need to jump in and debug.
20:49:17 openstackgerrit Adam Spiers proposed openstack/nova master: Extract new base class for provider usage functional tests https://review.opendev.org/676964
20:49:18 openstackgerrit Adam Spiers proposed openstack/nova master: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported https://review.opendev.org/638680
20:54:03 openstackgerrit Adam Spiers proposed openstack/nova master: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported https://review.opendev.org/638680
20:54:29 aspiers efried: what's the world record for the most patchsets in a nova review? :-o
20:54:40 aspiers am I even close yet?
20:54:58 aspiers seems like a very dubious achievement
20:55:16 efried you are nowhere close.
20:55:20 efried Well into three figures
20:55:22 aspiers hah, phew
20:55:24 aspiers wow
21:12:15 openstackgerrit Adam Spiers proposed openstack/nova master: Provide HW_CPU_X86_AMD_SEV trait when SEV is supported https://review.opendev.org/638680
21:12:15 openstackgerrit Adam Spiers proposed openstack/nova master: Extract new base class for provider usage functional tests https://review.opendev.org/676964
21:14:36 aspiers Damn, I intended to not work at all today, and here I am still going ... time for late dinner
21:14:49 aspiers Just desperate to get this damn series all to +2
21:16:56 efried aspiers: https://review.opendev.org/#/c/676964/3/nova/tests/functional/libvirt/test_report_cpu_traits.py show me where STUB_INIT_HOST is being used?
21:19:36 aspiers efried: ah sorry, it *is* in the next patch
21:19:54 efried It's not worth respinning stuff for, just want to make sure I'm not blind.
21:19:59 aspiers yeah
21:20:07 efried (I got glasses day before yesterday, for the first time in my life)
21:20:09 aspiers I ran my grep with the wrong commit checked out
21:20:22 aspiers hah, welcome to nerd club
21:20:28 aspiers I've been in it since I was 14 :-(
21:20:42 aspiers well, since I was born I suppose
21:27:31 aspiers OK, dinner
21:27:37 aspiers thanks and catch you next week! o/
21:27:51 efried mordred, dustinc: I found the bug
21:28:20 efried It looks like you can only run through the generator returned by conn.baremetal.nodes() once.
21:29:41 efried which, now that I think about it, makes sense.
21:29:57 efried I mean, now that I've seen this thing in action and think about it.
21:30:21 efried Because having done that I learned 1) that it's a generator, and 2) that it doesn't actually do anything, like go out over the wire, until you start iterating over it.
21:31:25 efried dustinc: Ima fix that up in the node.list patch (and rebase the rest on top, cause they definitely won't work without that) and let's see where we get to.
21:31:36 efried (that will probably break UT; but I'll leave you to fix that :P )
21:33:39 openstackgerrit Eric Fried proposed openstack/nova master: Use SDK for node.list https://review.opendev.org/656027
21:33:40 openstackgerrit Eric Fried proposed openstack/nova master: Use SDK for setting instance id https://review.opendev.org/659690
21:33:40 openstackgerrit Eric Fried proposed openstack/nova master: Use SDK for validating instance and node https://review.opendev.org/656028
21:33:41 openstackgerrit Eric Fried proposed openstack/nova master: Use SDK for getting network metadata from node https://review.opendev.org/670213
21:33:41 openstackgerrit Eric Fried proposed openstack/nova master: Use SDK for add/remove instance info from node https://review.opendev.org/659691
21:33:51 openstackgerrit Eric Fried proposed openstack/nova master: DNM: Test sdk Connection(strict_proxies) https://review.opendev.org/676926
21:34:38 efried I... don't actually know whether strict_proxies is gold here. But that last patch ^ ought to tell us.
21:42:49 efried Thanks for your help donnyd
22:04:49 donnyd glad I can be helpful efried
22:36:45 openstackgerrit Eric Fried proposed openstack/nova master: Limit get_sdk_adapter to requested service type https://review.opendev.org/674678
#openstack-nova - 2019-08-17
00:27:48 openstackgerrit Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851

Earlier   Later