Earlier  
Posted Nick Remark
#openstack-nova - 2019-06-27
17:04:56 efried oh, so he's around, just out "early" (relative to me). Cool.
17:05:02 dansmith yar
17:26:42 openstackgerrit Matt Riedemann proposed openstack/nova master: Add integration testing for heal_allocations https://review.opendev.org/667994
17:35:52 openstackgerrit Matt Riedemann proposed openstack/nova master: Add integration testing for heal_allocations https://review.opendev.org/667994
17:50:13 openstackgerrit Merged openstack/nova master: Remove global state from the FakeDriver https://review.opendev.org/656709
17:50:23 openstackgerrit Merged openstack/nova master: Enhance service restart in functional env https://review.opendev.org/512552
18:43:07 openstackgerrit Merged openstack/nova master: libvirt: flatten rbd images when unshelving an instance https://review.opendev.org/457886
19:47:56 openstackgerrit Merged openstack/nova master: reorder conditions in _heal_allocations_for_instance https://review.opendev.org/655458
21:33:45 openstackgerrit Merged openstack/nova master: Prepare _heal_allocations_for_instance for nested allocations https://review.opendev.org/637954
21:36:31 mriedem efried: https://review.opendev.org/#/c/637955/28 tag teamed
21:36:39 openstackgerrit Merged openstack/nova master: pull out put_allocation call from _heal_* https://review.opendev.org/655459
21:36:58 mriedem which do you want to be? https://toomanyposts.files.wordpress.com/2011/11/hartfound.jpg
21:37:55 efried dude, as long as I get to wear pink tights, who cares??
21:38:20 mriedem ok i'm bret then
21:39:29 sean-k-mooney has the follow up spec for numa with pmem been submited or is that for U
21:40:27 efried I haven't seen such a thing
21:40:42 mriedem that seems to be getting the cart way before the horse
21:41:05 sean-k-mooney the current spec says numa will be adress in a follow up spec
21:41:11 sean-k-mooney mriedem: not really
21:41:33 sean-k-mooney i think it makes sense to proced with the current spec that just merged
21:41:51 sean-k-mooney but im concerned the porsal i prolematic
21:43:09 sean-k-mooney specifcaly im really not ok with the driver generating numa object with out goign through the numa toplogy filter unless we ensure we dont restrit the guest ram and cpus to a numa node
21:43:50 sean-k-mooney if we generate a virtual numa node and do no affintiy to a host numa node fo any resoces it proably fine
22:04:14 openstackgerrit Eric Fried proposed openstack/nova master: Un-safe_connect and publicize get_providers_in_tree https://review.opendev.org/668062
22:08:23 openstackgerrit sean mooney proposed openstack/nova-specs master: Libvirt: add vPMU spec for train https://review.opendev.org/651269
23:27:46 alex_xu johnthetubaguy: mriedem_afk sean-k-mooney efried thanks for all the review, I will continue to look at the comment
#openstack-nova - 2019-06-28
00:14:15 openstackgerrit Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.opendev.org/614036
00:14:16 openstackgerrit Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.opendev.org/627892
00:14:16 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.opendev.org/631123
00:14:17 openstackgerrit Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.opendev.org/631581
00:14:18 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtDestTask https://review.opendev.org/627890
00:14:18 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293
00:14:18 openstackgerrit Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.opendev.org/633853
00:14:19 openstackgerrit Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.opendev.org/637605
00:14:19 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832
00:14:20 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891
00:14:21 openstackgerrit Matt Riedemann proposed openstack/nova master: Add power_on kwarg to ComputeDriver.spawn() method https://review.opendev.org/642590
00:14:21 openstackgerrit Matt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection https://review.opendev.org/642183
00:14:22 openstackgerrit Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.opendev.org/635646
00:14:22 openstackgerrit Matt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.opendev.org/635080
00:14:23 openstackgerrit Matt Riedemann proposed openstack/nova master: Execute CrossCellMigrationTask from MigrationTask https://review.opendev.org/635668
00:14:23 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field https://review.opendev.org/614035
00:14:24 openstackgerrit Matt Riedemann proposed openstack/nova master: Filter duplicates from compute API get_migrations_sorted() https://review.opendev.org/636224
00:14:24 openstackgerrit Matt Riedemann proposed openstack/nova master: Plumb allow_cross_cell_resize into compute API resize() https://review.opendev.org/635684
00:14:35 openstackgerrit Matt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API https://review.opendev.org/638269
00:14:35 openstackgerrit Matt Riedemann proposed openstack/nova master: Support cross-cell moves in external_instance_event https://review.opendev.org/658478
00:14:36 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Enable cross-cell resize in the nova-multi-cell job https://review.opendev.org/656656
00:35:30 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add placement request filter for disabled computes https://review.opendev.org/654596
00:51:11 openstackgerrit Matt Riedemann proposed openstack/nova master: Drop pre-cinder 3.44 version compatibility https://review.opendev.org/621061
00:51:12 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove 'MultiattachSupportNotYetAvailable' exception https://review.opendev.org/651315
00:51:12 openstackgerrit Matt Riedemann proposed openstack/nova master: Follow-up for I6a777b4b7a5729488f939df8c40e49bd40aec3dd https://review.opendev.org/664967
01:06:15 openstackgerrit Matt Riedemann proposed openstack/nova-specs master: Enable rebuild for instances in cell0 https://review.opendev.org/648686
01:17:48 bhagyashris mriedem, Sean-k-mooney, alex_xu: Hi, I would like your insights on https://review.opendev.org/#/c/612626/
01:26:57 openstackgerrit Merged openstack/nova-specs master: Enable rebuild for instances in cell0 https://review.opendev.org/648686
01:41:19 adriant Hello! Out of curiosity, was there ever a bug in Nova that stopped delete-on-terminate working specifically for volumes created from an instance snapshot?
01:42:04 adriant ^ we have a case where a volume made from a volume snapshot, delete-on-terminate works. The volume just goes away with the instance
01:42:41 adriant but a volume made from an instance snapshot, delete-on-terminate doesn't work. And the volume must be manually delete afterwards.
01:43:34 adriant we are running an old version of nova, so just curious if this was a known bug, and if it ever got fixed, or if this is just some weird combination of failures somewhere on our deployment
01:44:50 sean-k-mooney not that i see in launchpad
01:44:50 openstackgerrit Merged openstack/nova stable/stein: Noop CantStartEngineError in targets_cell if API DB not configured https://review.opendev.org/663030
01:44:57 openstackgerrit Merged openstack/nova stable/stein: Fix python3 compatibility of rbd get_fsid https://review.opendev.org/664512
01:45:02 adriant yeah, I didn't find anything either
01:46:08 sean-k-mooney to be clear your workflow is you boot a vm. create a snapshot then later boot another vm from the instnace shapshot with delete-on-terminate
01:46:14 adriant yes
01:46:39 adriant and if you instance make a volume snapshot of that instances root disk, and boot from that, it works as expected
01:46:42 adriant your*
01:46:43 sean-k-mooney that should be the same as a boot form a standard image really
01:47:29 adriant I know :P
01:47:33 adriant but somehow it isn't
01:50:40 adriant I'm just confirming that I can replicate it with a new instance
01:50:45 adriant but I've seen a client do it
01:58:48 yonglihe mriedem, sean-k-mooney: what i got from discuss, 1) use UUID instead of name for querying orphans instances 2) checking metadata (which is already done per Sean's suggest), 3) clean up if possible , if db record gone, i don't how to do that. for reap/poweroff/delete, we already had configuration options. 4) re-use/extending current period task instead of create new one.
01:59:46 yonglihe mriedem, sean-k-mooney: these changes seems quite a lot for this 2 patches. i want to make sure i'm on right track before i start it.
02:09:00 sean-k-mooney yonglihe: you likely do not need to have 2 seperate patches.
02:09:32 sean-k-mooney most of the chagnes in the first patch are not required.
02:10:04 sean-k-mooney yonglihe: melwitt: was suggeting we might be able to jsut create a fake instance object and reuse the existing destroy method in the driver
02:10:24 sean-k-mooney that occured to me als but i was not sure it that would be valid in all cases
02:12:29 sean-k-mooney but yes 1.) we would prefer to use uuids instead of names, 2.) for the libvirt dirver check the metadata(which you have already done) 3.) determin if we can clean up local resoces like disk or ports on a vswitch. 4.) combine you chagnes with the existing periodic task as a new confg option reap_unknown
02:27:09 yonglihe sean-k-mooney: sure, seems we cloud move on, it's gonna drop a lot and come up with new one, though. about clean up local resources, i might need reach for help, might trouble you -:)
02:31:30 sean-k-mooney the concern is if we jsut delete the domain we would leave the root disk and vswitch ports behind. and in that case the operator would not know what instance they belonged or if it wa safe to remvoe them
02:32:39 sean-k-mooney we might decide that is ok but if we can sanely clean up that would be nice to do
02:38:32 yonglihe we might need to add power_off_unknow in case admin want to keep them for investigating.
02:40:11 sean-k-mooney yes i think that would be fine and in that case no cleanup is needed
02:47:29 yonglihe I gonna add them both.
03:45:39 openstackgerrit sean mooney proposed openstack/nova master: [WIP] Libvirt: report storage bus traits https://review.opendev.org/666914
03:45:40 openstackgerrit sean mooney proposed openstack/nova master: Add transform_image_metadata request filter https://review.opendev.org/665775
03:45:40 openstackgerrit sean mooney proposed openstack/nova master: [WIP] use domain capablites to get supported device models https://review.opendev.org/666915
04:09:43 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Fix test_flavors to run with correct microversion https://review.opendev.org/666536
04:10:13 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add missing tests for flavor extra_specs mv 2.61 https://review.opendev.org/667600
04:10:30 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Multiple API cleanup changes https://review.opendev.org/666889
05:39:53 openstackgerrit Merged openstack/nova master: Fix test_flavors to run with correct microversion https://review.opendev.org/666536
06:51:10 gmann efried: can you re-approve this. it was rebased - https://review.opendev.org/#/c/667600/4
07:03:20 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Multiple API cleanup changes https://review.opendev.org/666889
07:49:45 kashyap lyarwood: Morning; stable/stein has merged, if you want to ACK its stable/rocky counterpart: https://review.opendev.org/#/c/667436/1
08:00:38 lyarwood kashyap: the same rules apply to stable as master fwiw so I can't just +2+W this, I'll recheck and leave it to others to +W.
08:01:40 kashyap lyarwood: Okay, thought I was under the illusion that johnthetubaguy had also ACKed the stable/rocky one
08:03:02 lyarwood kashyap: I think that was a different one no?
08:03:38 kashyap lyarwood: Which one was it? Strangely I recall there were 2 ACKs from John on this same change
08:03:49 kashyap Maybe he ACKed the Git/master one and I confused with it; /me goes to look
08:04:17 kashyap (No, never mind; I'll chalk it up to poor memory)

Earlier   Later