| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-06-25 | |||
| 14:33:13 | dansmith | I think those come from host caps | |
| 14:33:19 | kashyap | mnaser: Nit-pick: "nested virt" can mean QEMU or KVM in level-1 :-). I use nested KVM to distinguish the "no emulator" part. | |
| 14:33:27 | artom|gmtplus3 | mnaser, because I will be eternally grateful when they come :) | |
| 14:33:47 | mnaser | kashyap: oh cool, good to know | |
| 14:33:53 | mnaser | artom|gmtplus3: i'll keep that in mind then :) | |
| 14:34:44 | artom|gmtplus3 | mnaser, heh, I don't need to tell you how badly we're missing NUMA test coverage with real hardware :) | |
| 14:35:11 | kashyap | mnaser: So, as mriedem said, assuming you have 'nested' as '1' on bare metal, and then set the flavor property: | |
| 14:35:14 | kashyap | openstack flavor set 1 --property trait:HW_CPU_X86_VMX=required` | |
| 14:35:30 | kashyap | Then launching the level-1 guest (or "guest hypervisor") should have VMX exposed | |
| 14:35:47 | mriedem | yonglihe: regarding https://review.opendev.org/#/c/627765/ i remember hearing at the ptg that there were concerns that it duplicated too much of _cleanup_running_deleted_instances and asked if it could just be integrated into _cleanup_running_deleted_instances with new choices for the running_deleted_instance_action option, but i'm not sure how feasible that is (or beneficial) | |
| 14:37:12 | kashyap | mnaser: dansmith: By the way GCE officially supports nested KVM; they've even done (in the community) extensive security audit, FWIW. | |
| 14:37:37 | dansmith | kashyap: omg, I'm convinced. | |
| 14:38:19 | kashyap | Good; otherwise, you need to show data for not being convinced ;-) | |
| 14:38:32 | dansmith | kashyap: you don't remember this, | |
| 14:38:50 | dansmith | but when I joined redhat almost six years ago, my first interaction with you was you saying this exact thing | |
| 14:39:06 | dansmith | that nested virt was 110% ready for prime time and you were fine if your bank ran it | |
| 14:39:17 | dansmith | don't make me dig up the logs, 'cause I'll do it! | |
| 14:40:02 | kashyap | I'm pretty confident I don't make such superlative remarks. Do dig them up | |
| 14:40:20 | kashyap | I used to systematically file kernel bugs since 2013 for nested KVM | |
| 14:40:21 | dansmith | superlatives are mine :) | |
| 14:40:32 | kashyap | And 98% of them are resolved (https://kashyapc.fedorapeople.org/kernel-kvm-bugs.txt) | |
| 14:40:51 | kashyap | Sure, there are cases where it doesn't work; but what exists already works for good number of cases | |
| 14:41:06 | kashyap | Heck, even upstream kernel itself now has 'nested' flag enabled by default for Intel | |
| 14:41:36 | mnaser | ^ yeah, i've seen this updated lately too | |
| 14:41:51 | sean-k-mooney | it was enabled in 4.19 ish | |
| 14:42:06 | sean-k-mooney | maybe a little earlier | |
| 14:42:20 | kashyap | [https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1e58e5e] | |
| 14:42:27 | kashyap | ["KVM: VMX: enable nested virtualization by default | |
| 14:42:29 | kashyap | ] | |
| 14:42:49 | sean-k-mooney | there were some bug in both the ubuntu kernel however until 4.20 | |
| 14:43:02 | sean-k-mooney | fedora was broken too | |
| 14:43:09 | sean-k-mooney | but the upstream on was fine | |
| 14:43:17 | dansmith | heh, Celebrated-By.. that's one I haven't seen | |
| 14:43:59 | kashyap | dansmith: Then you will enjoy this: https://lwn.net/Articles/503829/ | |
| 14:44:08 | kashyap | A sample from the KM-long list: | |
| 14:44:12 | kashyap | - Signed-off-and-morning-tea-spilled-by: | |
| 14:44:12 | kashyap | - Fatfingered-by: | |
| 14:44:12 | kashyap | - Antagonized-by: | |
| 14:44:12 | kashyap | - Bitten-by-and-tested-by: | |
| 14:44:38 | dansmith | yup, nice | |
| 14:45:11 | artom|gmtplus3 | Drive-by: Shoo Ting | |
| 14:45:31 | kashyap | mnaser: Live migrating level-1 guest (level-2 can be migrated fine) is the remaining gnarly problem that is being worked on (both in KVM and QEMU) | |
| 14:46:22 | sean-k-mooney | so Most-Definitely-Acked-by: | |
| 14:46:24 | sean-k-mooney | Mostly-acked-by: | |
| 14:46:26 | sean-k-mooney | NACKed-by: | |
| 14:46:33 | sean-k-mooney | are used as +2 +1 and -1 | |
| 14:46:46 | sean-k-mooney | also i like More-or-less-tested-by | |
| 14:47:35 | mriedem | kashyap: what are the chances GCE has forked everything to make nested KVM work for just their cloud? | |
| 14:48:14 | dansmith | *gasp* | |
| 14:48:19 | dansmith | they would NEVER do such a thing, surely | |
| 14:49:14 | kashyap | mriedem: The chances are 100% sunny :D I see what you mean, they do have their kernel; that said ... they contribute most KVM-related stuff back to the upstream, and post results of security audit, too | |
| 14:50:52 | sean-k-mooney | mriedem: from my past experience with kvm it works beeter if you use a vanial upstream kernel then a disto packaged one although that has change in the last 12-18 months or so as i think distors have got better at testing nested virt or just break it less | |
| 14:52:43 | mriedem | hmm, me checks notes...sean says things from a distro are better since about the time he started working for a distro...yup it checks out | |
| 14:53:11 | sean-k-mooney | goes back to his ubunut based laptop... | |
| 14:53:20 | dansmith | mmm, ubunut | |
| 14:53:47 | dansmith | that has to be about the best ubuntu type I've seen | |
| 14:53:54 | sean-k-mooney | my devstack vms are centos | |
| 14:53:55 | dansmith | *typo, hah | |
| 14:54:32 | mriedem | did you know a cashew is not a nut? | |
| 14:54:36 | dansmith | artom|gmtplus3: like a fancy brazilian walnut laptop, or the *really* fancy "ubunut" laptop | |
| 14:54:48 | sean-k-mooney | :) | |
| 14:55:50 | sean-k-mooney | mriedem: that was most based on the fact that centos finally started to wrok with nested vert although canonica broke it in 18.04 which made me sad | |
| 14:55:51 | mriedem | lyarwood: just so you're aware, stable/stein and rocky are essentially blocked until these devstack changes land https://review.opendev.org/#/q/I0d7f9f2baaee2836a719f199939156bd4f53f778 | |
| 14:56:24 | artom|gmtplus3 | Oh, not the whole laptop, just the CPU: Hazwellnut architecture :D | |
| 14:56:58 | sean-k-mooney | haha i would totally by that | |
| 14:57:44 | lyarwood | mriedem: was that behind tempest-slow etc timing out due to the network tests taking ages? | |
| 14:58:35 | lyarwood | ah nvm it doesn't look like it is | |
| 15:00:28 | mriedem | the agent on the tempest-slow jobs blows up | |
| 15:01:19 | lyarwood | ah I see | |
| 15:02:46 | lyarwood | well thanks for the heads up, I've had a tab open to look at that all day, I'll get on with some reviews once that has started to land in stable. | |
| 15:04:59 | sean-k-mooney | dansmith: im always amazed by how many grammer and spelling issue my brain just completely ignores | |
| 15:05:46 | dansmith | sean-k-mooney: and they make it really difficult for me to concentrate on the content.. diff'rent strokes. | |
| 15:07:28 | sean-k-mooney | ya, it just show how differently we read. not that you have pointed them out they are obvious but without your commets my brain just fills in the gaps/corrects them on the fly unless i force myself to read word by word really slowly | |
| 15:08:01 | artom|gmtplus3 | Yeah, there's a "severity" boundary where it switches from "distracting but harmless" to "active sabotage" | |
| 15:10:14 | jangutter | artom|gmtplus3: the late, great Iain M Banks had one of the most frustratingly good stories that tripped that balance in "Feersum Endjinn" | |
| 15:10:43 | mriedem | yay everything i had in the gate last night failed with RETRY_LIMIT and now i get to recheck everything | |
| 15:10:53 | artom|gmtplus3 | jangutter, will read | |
| 15:12:16 | sean-k-mooney | jangutter: im kind of tempted to read that | |
| 15:14:45 | jangutter | I think he's much more known for the Culture work, but FE was a good diversion. Just be warned that some chapters are physically hard to read, intentionally. | |
| 15:15:14 | sean-k-mooney | i have no issue reading "Woak up. Got dresd. Had brekfast. Spoke wif Ergates thi ant who sed itz juss been wurk wurk wurk 4 u lately master Bascule, Y dont u ½ a holiday? & I agreed & that woz how we decided we otter go 2 c Mr Zoliparia in thi I-ball ov thi gargoyle Rosbrith. " | |
| 15:19:32 | efried | mriedem: would you please give this a quick look for sanity https://review.opendev.org/655985 before I invest in test? | |
| 15:23:09 | artom|gmtplus3 | sean-k-mooney, your brain is weird, I can barely parse that | |
| 15:29:08 | sean-k-mooney | artom|gmtplus3: "Woke up. Got dressed. Had breakfast. spoke with Ergates the ant, who said, it's just been work work work for you lately master Bascule, why dont you have a holiday? And i aggred, an that was how we decied we ought to go to see Mr Zoliparia in the eye ball of the gargoyle Rosbrith." :) | |
| 15:29:49 | artom|gmtplus3 | sean-k-mooney, aha, thi = the didn't register at all | |
| 15:29:59 | artom|gmtplus3 | I was thinking "thy", the old English possessive | |
| 15:30:39 | sean-k-mooney | o/ | |
| 15:34:36 | mriedem | efried: comments inline | |
| 15:42:52 | openstackgerrit | Matt Riedemann proposed openstack/nova master: (Re-)enable vnc console tests in nova-multi-cell job https://review.opendev.org/667388 | |
| 15:51:11 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova stable/stein: libvirt: Rework 'EBUSY' (SIGKILL) error handling code path https://review.opendev.org/667389 | |
| 16:09:29 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Functional reproduce for bug 1833581 https://review.opendev.org/667396 | |
| 16:09:30 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Functional reproduce for bug 1833581 https://review.opendev.org/667397 | |
| 16:09:30 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Error out interrupted builds https://review.opendev.org/666857 | |
| 16:09:30 | openstack | bug 1833581 in OpenStack Compute (nova) "instance stuck in BUILD state if nova-compute is restarted" [Low,In progress] https://launchpad.net/bugs/1833581 - Assigned to Balazs Gibizer (balazs-gibizer) | |
| 16:11:03 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Enhance service restart in functional env https://review.opendev.org/512552 | |
| 16:11:24 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add functional test coverage for bug 1724172 https://review.opendev.org/512553 | |
| 16:11:25 | openstack | bug 1724172 in OpenStack Compute (nova) rocky "Allocation of an evacuated instance is not cleaned on the source host if instance is not defined on the hypervisor" [Medium,Confirmed] https://launchpad.net/bugs/1724172 | |
| 16:12:06 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Functional reproduce for bug 1833581 https://review.opendev.org/667396 | |
| 16:12:07 | openstack | bug 1833581 in OpenStack Compute (nova) "instance stuck in BUILD state if nova-compute is restarted" [Low,In progress] https://launchpad.net/bugs/1833581 - Assigned to Balazs Gibizer (balazs-gibizer) | |
| 16:13:56 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Rewrite quotas documentation https://review.opendev.org/667165 | |
| 16:13:56 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Correct issues with 'openstack quota set' commands https://review.opendev.org/667164 | |