Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-06-17
16:05:41 openstackgerrit Stephen Finucane proposed openstack/nova master: hacking: Resolve E731 (do not assign a lambda expression, use a def) https://review.opendev.org/651554
16:05:42 openstackgerrit Stephen Finucane proposed openstack/nova master: hacking: Resolve E741 (ambiguous variable name) https://review.opendev.org/652103
16:05:42 openstackgerrit Stephen Finucane proposed openstack/nova master: hacking: Resolve W503 (line break occurred before a binary operator) https://review.opendev.org/651555
16:05:43 openstackgerrit Stephen Finucane proposed openstack/nova master: hacking: Resolve W605 (invalid escape sequence) https://review.opendev.org/652104
16:25:10 mriedem sean-k-mooney: alex_xu: i went through the pmem spec https://review.opendev.org/#/c/601596/ - lots of questions and comments
16:26:21 openstackgerrit Merged openstack/nova master: Ensure controllers all call super https://review.opendev.org/660950
16:27:26 sean-k-mooney mriedem: ok i need to finish review that spec again too. i have not done a full review since version 12
16:28:49 mriedem the biggest nagging feeling i get on that spec is it sounds like these are local block devices and should be modeled as BDMs
16:29:01 mriedem they really sound like the libvirt lvm image backend with the zero'ing out and such
16:29:16 sean-k-mooney they are presended to the guest as memory DIMs however
16:29:24 sean-k-mooney not as block devices
16:29:32 sean-k-mooney but form a host level they are similar
16:30:36 alex_xu mriedem: thanks a lot, I will go through them all tomorrow
16:32:36 mriedem sean-k-mooney: yeah i know, and i'm not saying he should change the spec, and modeling as bdms could cause confusion in a different way as well
16:32:48 sean-k-mooney one other usecase that is out of scope for Train but i expect to see in U is the option to use PMEM inplacem of ram as similarly to how we use hugepages or filebacked memroy. for the current usecase BDMs may make sense but im not sure if it will work for those usecase too in the future
16:33:00 mriedem i guess i just don't like new models and objects and such for new devices but i'm cranky
16:33:48 sean-k-mooney ill go through you review comments properly this week and try to digest it.
16:34:28 sean-k-mooney i do agree that we have to be carful with what happens if the config options chage
16:37:37 alex_xu yea, at least from hardware view, it still memory, not the block device
16:38:29 alex_xu sean-k-mooney: currently we have a config option which is for file backend memory
16:39:14 alex_xu but it isn't very flexible as I remember, I didn't think about that too much also, since that isn't the usecase we are looking for now also
16:49:24 mriedem oh yeah... https://docs.openstack.org/nova/latest/configuration/config.html#libvirt.file_backed_memory
16:51:17 mriedem if you changed that from true to false and restarted with guests on that host we'd have problems
16:51:28 mriedem er >0 to 0
17:24:18 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove file-backed memory live migration compat check https://review.opendev.org/665728
18:14:40 openstackgerrit Adam Spiers proposed openstack/nova master: Use fake flavor instead of empty dict in test https://review.opendev.org/662555
18:14:41 openstackgerrit Adam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection https://review.opendev.org/636334
18:14:41 openstackgerrit Adam Spiers proposed openstack/nova master: Pass extra_specs to flavor in vif tests https://review.opendev.org/662556
18:14:42 openstackgerrit Adam Spiers proposed openstack/nova master: Allow guest devices to include https://review.opendev.org/644564
18:14:42 openstackgerrit Adam Spiers proposed openstack/nova master: Add element to guest config for AMD SEV https://review.opendev.org/636318
18:14:43 openstackgerrit Adam Spiers proposed openstack/nova master: Use element when SEV is required https://review.opendev.org/662557
18:14:43 openstackgerrit Adam Spiers proposed openstack/nova master: Detect that SEV is required and enable iommu for devices https://review.opendev.org/644565
18:14:44 openstackgerrit Adam Spiers proposed openstack/nova master: Enable memory locking if SEV is requested https://review.opendev.org/662558
18:21:57 openstackgerrit Harald Jensås proposed openstack/nova master: cell_mapping - wrap IPv6 address in format_url https://review.opendev.org/664559
18:25:41 sean-k-mooney stephenfin: just an fyi the kolla-ansibel change for removing nova-consoleauth just merged https://review.opendev.org/#/c/661427/
18:26:13 sean-k-mooney Jeffrey4l: thanks for completing ^
18:29:39 hjensas dansmith: Thanks for the review on ^^, you where right and I want to apologize for the 'did you look at the bug' comment. wdyt about the new revision?
18:30:10 dansmith hjensas: you're still changing the existing format I think, but I'm in the middle of something else.. will comment in a few
18:30:42 hjensas dansmith: thanks, appriciated.
18:41:10 mriedem efried: would you agree with this? https://review.opendev.org/#/c/661237/9/nova/compute/api.py@1000
18:41:22 efried mriedem: looking
18:41:24 mriedem also, there is something really strange about the mock assertions he's making in this change which are passing but i'm not sure why
18:41:26 mriedem you might have ideas
18:43:27 efried mriedem: I agree with your comment on PlacementAPIConnectError. Commenting...
18:44:40 openstackgerrit Harald Jensås proposed openstack/nova master: cell_mapping - wrap IPv6 address in format_url https://review.opendev.org/664559
18:48:14 efried mriedem: I can play with that mock later on if you want me to.
18:48:47 mriedem i just did http://paste.openstack.org/show/753112/ and it's failing if i don't use the yielded cctxt
18:48:51 mriedem so i left a note about just doing that
18:49:06 efried Been in The Worst Chair in Taylor all day so far - power has been out at my house and this coffee shop clearly does not want to encourage long stays.
18:49:20 efried Apparently the power is back on, so I'll be moving shortly :)
18:49:38 mriedem but how have all of the overly loud overly personal conversations around you been going?
18:49:45 efried okay, I posted my comment agreeing with you about the exception
18:49:53 efried heh, quite entertaining.
18:50:29 efried Kids with a baby (was it theirs?)
18:50:29 efried A married couple fighting.
18:50:29 efried A job interview.
18:50:29 efried Old folks talking about how things ain't how they used to be.
19:09:37 sean-k-mooney gibi: is https://review.opendev.org/#/c/665715/1 for testing or do you intend it to actuly be a feature in the future?
19:26:43 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix enabled_filters default value in admin config docs https://review.opendev.org/665751
19:26:43 openstackgerrit Matt Riedemann proposed openstack/nova master: Deprecate RetryFilter https://review.opendev.org/663953
19:27:41 openstackgerrit Matt Riedemann proposed openstack/nova master: Deprecate RetryFilter https://review.opendev.org/663953
19:47:19 openstackgerrit Dustin Cowles proposed openstack/nova master: Introduces SDK to IronicDriver and uses for node.get https://review.opendev.org/642899
19:47:20 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK instead of ironicclient for validating instance and node https://review.opendev.org/656028
19:47:20 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK instead of ironicclient for node.list https://review.opendev.org/656027
19:47:21 openstackgerrit Dustin Cowles proposed openstack/nova master: WIP: Use SDK instead of ironicclient for add/remove instance info from node https://review.opendev.org/659691
19:47:21 openstackgerrit Dustin Cowles proposed openstack/nova master: Use SDK instead of ironicclient for setting instance id https://review.opendev.org/659690
20:42:20 openstackgerrit Merged openstack/nova-specs master: Update spec: filtering of alloc candidates by forbidden aggregates https://review.opendev.org/665605
21:24:28 openstackgerrit melanie witt proposed openstack/nova master: Log quota legacy method warning only if counting from placement https://review.opendev.org/665765
21:26:43 melwitt mriedem: I realized I accidentally made the log warning happen in cases it shouldn't in the counting quotas follow up patch https://review.opendev.org/#/c/662056/5/nova/quota.py@1315 fix is ^
21:30:32 mriedem melwitt: small thing in there
21:31:20 melwitt heh, thanks. I am just constantly doing that, adding the else: argh
21:32:30 openstackgerrit melanie witt proposed openstack/nova master: Log quota legacy method warning only if counting from placement https://review.opendev.org/665765
21:32:35 mriedem it tooks years of https://pmd.github.io/ forced on me
21:33:19 melwitt oh, neat
21:34:54 sean-k-mooney huh i didnt know there was an opensouce tool like that
21:35:27 sean-k-mooney i guess it makes sense but the only cross lanaguage cross plathform static analiser i knew of were closed souce
21:35:48 openstackgerrit Matt Riedemann proposed openstack/nova master: Clean up NumInstancesFilter related docs https://review.opendev.org/665768
22:39:41 Nick_A Trying to inject a password into a kvm guest using libvirt. nova.conf is set up with inject_partition = -1, inject_password = True, inject_key = True. Keys are working but not passwords. What might we be missing?
22:47:02 melwitt Nick_A: in addition to what's described in https://docs.openstack.org/nova/latest/admin/admin-password-injection.html I think you have to have the qemu guest agent package installed on the guest. not sure why that's not in the doc tho
22:52:04 melwitt and also hw_qemu_guest_agent=yes image property https://docs.openstack.org/nova/latest/admin/configuration/hypervisor-kvm.html#guest-agent-support
22:53:17 Nick_A melwitt we actually tried that already - it allows for updating of the password once the instance exists, but we can't seem to set it upon creation/rebuild
22:55:36 melwitt Nick_A: that seems unexpected. there might be a bug, or maybe I'm just not aware there's something additional needed for it to work for create/rebuild
22:59:37 openstackgerrit sean mooney proposed openstack/nova master: create initial image metadata prefilter https://review.opendev.org/665775
23:14:00 Nick_A Even the random password generated when we manually openstack server create doesn't work...
23:18:28 openstackgerrit Sam Morrison proposed openstack/nova stable/rocky: Fix double word hacking test https://review.opendev.org/665788
23:19:07 openstackgerrit Sam Morrison proposed openstack/nova stable/queens: Fix double word hacking test https://review.opendev.org/665790
23:45:45 openstackgerrit Merged openstack/nova master: Don't rely on SQLAlchemy collections magically initializing __dict__ https://review.opendev.org/661472
23:45:52 openstackgerrit Merged openstack/nova master: docs: remove the RamFilter from example https://review.opendev.org/665546
23:51:29 openstackgerrit sean mooney proposed openstack/os-traits master: add libvirt image metadata traits https://review.opendev.org/652996
23:51:32 openstackgerrit sean mooney proposed openstack/os-traits master: add GOP, NONE and VIRTIO grapics models https://review.opendev.org/665830
#openstack-nova - 2019-06-18
01:03:44 openstackgerrit Adam Spiers proposed openstack/nova master: Add extra spec parameter and image property for memory encryption https://review.opendev.org/664420
01:03:45 openstackgerrit Adam Spiers proposed openstack/nova master: Pass extra_specs to flavor in vif tests https://review.opendev.org/662556
01:03:45 openstackgerrit Adam Spiers proposed openstack/nova master: Use fake flavor instead of empty dict in test https://review.opendev.org/662555
01:03:46 openstackgerrit Adam Spiers proposed openstack/nova master: Add element to guest config for AMD SEV https://review.opendev.org/636318
01:03:46 openstackgerrit Adam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection https://review.opendev.org/636334
01:03:47 openstackgerrit Adam Spiers proposed openstack/nova master: Detect that SEV is required and enable iommu for devices https://review.opendev.org/644565
01:03:47 openstackgerrit Adam Spiers proposed openstack/nova master: Allow guest devices to include https://review.opendev.org/644564
01:03:48 openstackgerrit Adam Spiers proposed openstack/nova master: Enable memory locking if SEV is requested https://review.opendev.org/662558
01:03:48 openstackgerrit Adam Spiers proposed openstack/nova master: Use element when SEV is required https://review.opendev.org/662557
01:52:16 openstackgerrit Merged openstack/os-vif stable/queens: Prevent "qbr" Linux Bridge from replying to ARP messages https://review.opendev.org/655694

Earlier   Later