Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-06-14
15:50:51 efried @mock.patch("...", new=...) <== no arg
15:50:51 efried @mock.patch("...") <== causes an argument to be created to your method
15:50:51 efried sean-k-mooney: When using decorator:
15:50:54 efried yeah, what dansmith said
15:51:10 sean-k-mooney dansmith: oh ok that makes sense if you never want to use of check it
15:51:12 temka efried, that's *massively* useful
15:51:22 temka efried, I've been using _ where possible
15:51:36 dansmith sean-k-mooney: yeah, but it's also a good thing to verify that the person isn't skirting some checking they should be doing as a result :)
15:51:42 sean-k-mooney temka: in a fucntion signiture
15:51:46 efried temka: You mean it's a thing you didn't know, or you're agreeing that it's useful and you use it?
15:51:55 temka efried, yes ;)
15:51:56 sean-k-mooney efried: yes
15:52:08 temka sean-k-mooney, yeah, you can have def blah(self, _)
15:52:23 sean-k-mooney temka: yes that would be an instance -1 form me
15:52:33 temka sean-k-mooney, you'd be alone then :)
15:52:36 sean-k-mooney i really think that is poor api design
15:52:45 temka Only in unit tests
15:53:08 sean-k-mooney you are technically not overloading if you cange teh name to _
15:53:25 sean-k-mooney so even in unit tests you shoudl not do that
15:53:45 temka 13
15:53:45 temka [artom@zoe nova]$ grep def.*_\) -R nova/tests/ | wc -l
15:53:49 sean-k-mooney i guess you are doingit for function that will be used in place of a mock?
15:53:50 temka Wonder if all of those are mine
15:54:30 openstackgerrit Dan Smith proposed openstack/nova master: Add a test for the _joinedload_all helper https://review.opendev.org/665421
15:54:31 dansmith efried: ^
15:55:50 efried dansmith: +2, nice. Added cdent
15:56:08 sean-k-mooney temka: i wonder if the new=mock.Mock works the same way when your apply the decorator to a class
15:56:17 efried it does
15:56:30 sean-k-mooney normally that results in the moc being passed to all fucntion or in this case not being based
15:56:34 sean-k-mooney passed
15:58:17 sean-k-mooney is mriedemn around today
15:59:11 sean-k-mooney mriedemn: just droping off for the day but i adress your comments in https://review.opendev.org/#/c/647733/
15:59:23 dansmith sean-k-mooney: he's out today
15:59:30 sean-k-mooney ok no worries
15:59:43 sean-k-mooney i was just going to say if he spots anythin else ill adress it on monday
16:03:15 finucannot melwitt: Should I drag https://review.opendev.org/#/c/652967/ to the front of the series and add a bug link?
16:03:32 finucannot i.e. do we care enough about the XVP VNC proxy to both backporting?
16:03:48 finucannot *bother
16:04:24 melwitt finucannot: I was debating about it... because yeah it's a bug but we have like zero testing for this so it would have to be a testless bug fix else you'd have to figure out how to add testing for a thing no one's using. so I dunno
16:06:40 finucannot Yeah, we have zero tests for that and can probably remove it this cycle
16:06:51 melwitt oh and I would not expect to backport
16:07:08 finucannot Okay, then I don't need to worry about opening a bug for this so
16:07:44 finucannot BobBall said on the ML some time back that they're not using it anymore
16:11:04 melwitt yeah. I'd just leave it for now and see if mriedem complains
16:11:38 melwitt he's the expert on these type of complicated matters
16:12:09 sean-k-mooney mtreinish: tonyb[m] would ye be able to take a look at these trivial test only stable backport for me on os-vif. https://review.opendev.org/#/c/665196/ and https://review.opendev.org/#/c/665195/
16:17:58 openstackgerrit Stephen Finucane proposed openstack/nova master: nova-status: Remove consoleauth workaround check https://review.opendev.org/652968
16:17:58 openstackgerrit Stephen Finucane proposed openstack/nova master: xvp: Start using consoleauth tokens https://review.opendev.org/652967
16:17:59 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Remove ConsoleAuthToken.to_dict https://review.opendev.org/652970
16:17:59 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove nova-consoleauth https://review.opendev.org/652969
16:18:00 openstackgerrit Stephen Finucane proposed openstack/nova master: xvp: Remove use of '_LI' marker https://review.opendev.org/665425
16:18:00 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Rework nova console diagram https://review.opendev.org/660147
16:36:09 finucannot argparse is broken in so many little ways that it kind of hurts :(
16:37:02 temka moar liek arseparse, amirite?
16:37:15 finucannot temka++
16:38:17 cdent temka+++
16:38:29 cdent argparse is so very very ugh
16:40:56 finucannot It tries to be too clever
16:41:01 finucannot and fails miserably
16:41:52 finucannot fwiw, click (which is A+) is based on optparse and not argparse for just that reason
16:44:48 openstackgerrit Stephen Finucane proposed openstack/nova master: Always Set dhcp_server in network_info https://review.opendev.org/658362
16:47:23 efried finucannot: https://review.opendev.org/#/c/664396/ - missed one --?
16:48:33 finucannot my bad. On it
16:49:47 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Document how to revert, confirm a cold migration https://review.opendev.org/664396
16:49:48 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Update resize doc https://review.opendev.org/665412
16:50:03 finucannot efried: ^
16:51:18 efried finucannot: thx, +2
16:53:18 sean-k-mooney am i missing somthing
16:53:37 sean-k-mooney "openstack server migrate revert" is not a thing
16:54:03 sean-k-mooney nor is "openstack server migrate confirm"
16:54:42 sean-k-mooney you have to use openstack server resize --revert or openstack server resize --confirm
16:55:41 sean-k-mooney oh your adding them in the depnds on patch
16:56:46 openstackgerrit Stephen Finucane proposed openstack/nova master: This patch is to fix bug #1831657 https://review.opendev.org/663926
16:56:48 openstack bug 1831657 in OpenStack Compute (nova) "Instance migration/Instance resize with lvm volumes" [Medium,Triaged] https://launchpad.net/bugs/1831657 - Assigned to Dr. Clemens Hardewig (bringha1)
17:03:49 openstackgerrit Eric Fried proposed openstack/nova master: xenapi: Remove dead host_call_plugin method https://review.opendev.org/665434
17:05:45 efried finucannot: ^ totally unrelated to hacking patch IMO
17:07:35 finucannot efried: Separate patch is a-okay (though perhaps it should come first). My objection was to touching dead code in general
17:07:38 finucannot lookig
17:07:40 finucannot *looking
17:08:53 efried I definitely don't understand by looking at that code why it would be unreachable or whatever, which you clearly do at a glance (heh).
17:09:11 efried But the hacking rule seems straightforward to me, and uncontroversial, so I put the weird one after.
17:09:21 efried Could put them in parallel, but would have to resolve merge conflict then
17:12:57 mtreinish sean-k-mooney: +2
17:18:16 finucannot melwitt: Fancy sanity checking this patch https://review.opendev.org/#/c/662570/ (it's mriedem's)
17:18:40 melwitt finucannot: ah yep, meant to do that. looking
17:19:09 openstackgerrit Stephen Finucane proposed openstack/nova master: Removing the stale parameters documented for kombu https://review.opendev.org/664153
17:25:59 openstackgerrit Eric Fried proposed openstack/nova master: Raise if flavor and image disagree on hide_hypervisor_id https://review.opendev.org/663365
17:47:40 openstackgerrit Eric Fried proposed openstack/nova master: Clarify --before help text in nova manage https://review.opendev.org/661289
18:01:33 openstackgerrit melanie witt proposed openstack/nova master: Add 'path' query parameter to console access url https://review.opendev.org/649372
18:02:32 melwitt finucannot: updated ^
18:04:05 efried melwitt: your co-authored-by email address is wrong, intentional?
18:04:47 melwitt efried: no, that's my actual email because someone else owns melwitt@
18:05:04 efried oh, no kidding, and I just noticed after all these years.
18:06:13 melwitt haha, yeah I stubbornly wanted it to look like melwitt@ from a tidiness perspective but it's resulted in some people thinking they emailed me when they really didn't (oops)
21:52:49 openstackgerrit Merged openstack/nova master: Make RequestContext(instance_lock_checked) fail https://review.opendev.org/665003
21:52:59 openstackgerrit Merged openstack/nova master: Fix invalid privsep.readpty test https://review.opendev.org/656262
21:53:08 openstackgerrit Merged openstack/nova master: Add functional recreate test for bug 1829479 and bug 1817833 https://review.opendev.org/663737
21:53:09 openstack bug 1829479 in OpenStack Compute (nova) "The allocation table has residual records when instance is evacuated and the source physical node is removed" [Medium,Triaged] https://launchpad.net/bugs/1829479
21:53:10 openstack bug 1817833 in OpenStack Compute (nova) "Check compute_id existence when nova-compute reports info to placement" [Undecided,In progress] https://launchpad.net/bugs/1817833 - Assigned to xulei (605423512-j)
21:53:21 openstackgerrit Merged openstack/nova master: Mock time.sleep() in unit tests https://review.opendev.org/648762

Earlier   Later