| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-06-11 | |||
| 03:14:44 | openstackgerrit | Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851 | |
| 03:55:27 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix default values in update_cell command https://review.opendev.org/662383 | |
| 05:04:40 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix default values in update_cell command https://review.opendev.org/662383 | |
| 07:39:24 | openstackgerrit | Edward Hope-Morley proposed openstack/nova stable/stein: Fix python3 compatibility of rbd get_fsid https://review.opendev.org/664512 | |
| 07:40:07 | openstackgerrit | Edward Hope-Morley proposed openstack/nova stable/rocky: Fix python3 compatibility of rbd get_fsid https://review.opendev.org/664513 | |
| 08:31:54 | lyarwood | stephenfin / bauzas ; would you mind taking a look at https://review.opendev.org/#/c/663011/ & https://review.opendev.org/#/c/664036/ this morning please? | |
| 08:32:04 | stephenfin | sure | |
| 08:43:48 | kashyap | Nit-pick: please don't use "fup" as a summary, it's this IRC channel specifc lingo, and most people might not be aware of it. | |
| 08:44:14 | kashyap | s/"as a summary"/"in the summary of Git commits"/ | |
| 08:44:30 | aspiers | kashyap: it could also be misinterpreted as "f*** up" ;-) | |
| 08:44:33 | lyarwood | sigh | |
| 08:44:46 | kashyap | aspiers: That too. :D | |
| 08:45:04 | aspiers | my brain still does that every time I see it | |
| 08:45:05 | kashyap | aspiers: Really, I was confused when I heard it first time here. | |
| 08:45:14 | kashyap | I don't like it it at all. | |
| 08:45:19 | kashyap | s/it it/it/ | |
| 08:45:26 | lyarwood | fup is a prefectly useful summary tag for a commit IMHO | |
| 08:45:37 | kashyap | lyarwood: Really, who knows it? | |
| 08:45:44 | aspiers | lyarwood: fixup is only 2 bytes more, and far clearer | |
| 08:46:02 | lyarwood | meh | |
| 08:46:02 | stephenfin | Have to agree here | |
| 08:46:03 | kashyap | I bet if you ask any non-native speaker to guess that is, 10/10 won't be able to guess it. | |
| 08:46:11 | kashyap | Clarity is power. | |
| 08:46:12 | lyarwood | bike sheds need painting | |
| 08:46:21 | aspiers | it needs painting RED | |
| 08:46:23 | lyarwood | I'll continue to use it | |
| 08:46:27 | stephenfin | lyarwood: Question on https://review.opendev.org/#/c/664036/ | |
| 08:46:30 | kashyap | Not really; it's a death by thousand cuts | |
| 08:46:31 | lyarwood | ack looking | |
| 08:46:35 | stephenfin | other one is +W | |
| 08:48:29 | lyarwood | stephenfin: gah, why is it always so obvious when someone comments on my change | |
| 08:48:35 | lyarwood | stephenfin: I'll respin for the elif now | |
| 08:48:52 | stephenfin | It's the same for everyone else, I assure you :) | |
| 08:49:15 | stephenfin | Thoughts on the logging? Do we want to do a full run through first to catch potential issues, or just highlight them as we encounter them? | |
| 08:51:15 | lyarwood | stephenfin: just left a note, I don't think we care enough to loop through everything everytime to find invalid values. | |
| 08:51:26 | stephenfin | Cool | |
| 08:51:42 | lyarwood | stephenfin: worst case is that we can't find a mapping for our arch and find the invalid mappings that way | |
| 08:53:01 | aspiers | stephenfin: sorry, just remembered you asked me to look at a potential bug I might have caused with the machtype mapping stuff | |
| 08:53:38 | stephenfin | aspiers: I think lyarwood's patch has fixed it so we should be good | |
| 08:53:52 | aspiers | stephenfin: ah cool | |
| 08:54:13 | aspiers | stephenfin: feel free to add me to review | |
| 08:54:34 | stephenfin | aspiers: It was this comment https://review.opendev.org/#/c/663011/9/nova/virt/libvirt/utils.py@563 | |
| 08:55:23 | stephenfin | lyarwood has moved it to 'get_default_machine_type' so the potential mixup should be resolved | |
| 08:56:08 | lyarwood | on stephenfin's suggestion FWIW, thanks for that. | |
| 08:59:15 | kashyap | lyarwood: When we can't find a valid mapping, _do_ we print everything out? | |
| 08:59:35 | aspiers | lyarwood: there's still the {} default mapping bug stephenfin pointed out in https://review.opendev.org/#/c/663011/9/nova/virt/libvirt/utils.py@571 | |
| 09:01:25 | lyarwood | kashyap: no, just the invalid mappings | |
| 09:02:38 | kashyap | (Nod) | |
| 09:02:57 | openstackgerrit | Lee Yarwood proposed openstack/nova master: fup: Merge machine_type_mappings into get_default_machine_type https://review.opendev.org/664036 | |
| 09:04:35 | kashyap | Sigh; the crappy "fup" again | |
| 09:05:35 | lyarwood | As I said above, I'm going to continue using it. | |
| 09:06:22 | kashyap | Sure, at the cost of the death by shitty commit messages | |
| 09:33:16 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Cleanup of '_test_resize' helper test https://review.opendev.org/664245 | |
| 09:33:16 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Recalculate 'RequestSpec.numa_topology' on resize https://review.opendev.org/662522 | |
| 09:33:17 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Add '_setup_compute_services' helper https://review.opendev.org/663102 | |
| 09:41:39 | stephenfin | lyarwood: Can you put this through? https://review.opendev.org/#/c/657844/ | |
| 09:41:45 | stephenfin | (as a stable patch) | |
| 09:48:44 | lyarwood | stephenfin: ack, I'll look now | |
| 09:48:58 | lyarwood | stephenfin: ah no sorry, I'm not actually stable-maint | |
| 09:49:07 | lyarwood | stephenfin: only nova-stable-core | |
| 09:49:13 | stephenfin | Ah, I thought you were. Np | |
| 11:46:33 | openstackgerrit | Harald Jensås proposed openstack/nova master: cell_mapping - wrap IPv6 address in format_url https://review.opendev.org/664559 | |
| 11:46:55 | openstackgerrit | Brin Zhang proposed openstack/nova master: Specify availability_zone to unshelve https://review.opendev.org/663851 | |
| 11:55:32 | openstackgerrit | Lee Yarwood proposed openstack/nova master: fup: Merge machine_type_mappings into get_default_machine_type https://review.opendev.org/664036 | |
| 11:55:32 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Use SATA bus for cdrom devices when using Q35 machine type https://review.opendev.org/663011 | |
| 11:55:49 | lyarwood | ^ I've rebased these as both keep failing on nova.tests.unit.test_hacking.HackingTestCase.test_check_doubled_words in check queue and gate but are passing locally. stephenfin ^ any ideas? | |
| 12:12:09 | artom | lyarwood, you've seen https://bugs.launchpad.net/nova/+bug/1804062 I assume? | |
| 12:12:11 | openstack | Launchpad bug 1804062 in nova (Ubuntu Eoan) "test_hacking fails for python 3.6.7 and newer" [High,Triaged] | |
| 12:12:29 | artom | (It's in the comment immediately above your failing test) | |
| 12:15:14 | aspiers | am I right in thinking use of _LE() etc. is deprecated since Pike? as per https://docs.openstack.org/oslo.i18n/latest/user/usage.html | |
| 12:21:13 | artom | aspiers, think so, yeah | |
| 12:22:31 | lyarwood | artom: no missed that thanks, however this is on 2.7 oddly enough. | |
| 12:23:36 | lyarwood | ah https://bugs.launchpad.net/nova/+bug/1804062/comments/4 | |
| 12:23:37 | openstack | Launchpad bug 1804062 in nova (Ubuntu Eoan) "test_hacking fails for python 3.6.7 and newer" [High,Triaged] | |
| 12:24:06 | artom | lyarwood, I didn't really read it TBH, just kinda left it for you, like a cat leaving a mouse corpse | |
| 12:24:11 | sean-k-mooney | aspiers: we nolonger translate exception or logs | |
| 12:24:39 | sean-k-mooney | aspiers: only end user facing content | |
| 12:27:11 | stephenfin | sean-k-mooney: I thought we still translated exceptions but not logs? | |
| 12:27:36 | sean-k-mooney | stephenfin: not since pike as far as i am aware | |
| 12:28:05 | aspiers | AFAICS exceptions are translated according to https://docs.openstack.org/oslo.i18n/latest/user/usage.html | |
| 12:28:21 | sean-k-mooney | https://docs.openstack.org/oslo.i18n/latest/user/guidelines.html#log-translation | |
| 12:28:44 | sean-k-mooney | aspiers: excetions retruned from the api might be | |
| 12:28:51 | aspiers | right, logs != exceptions | |
| 12:28:56 | sean-k-mooney | excptions that are logged are not | |
| 12:29:12 | aspiers | obviously :) I mean exceptions which are raised | |
| 12:29:47 | sean-k-mooney | no what i mean is if you raise an excetip and also log it then the logged version is not translated | |
| 12:30:40 | aspiers | right | |
| 12:30:51 | aspiers | anyway the page you linked answers my questions so thanks for that | |
| 12:49:24 | yaawang | johnthetubaguy: Hi, are you good with the spec after updates? https://review.opendev.org/#/c/651681/ | |
| 13:17:00 | openstackgerrit | Hamdy Khader proposed openstack/os-vif master: OVS DPDK port representors support https://review.opendev.org/658786 | |
| 13:17:01 | openstackgerrit | Hamdy Khader proposed openstack/os-vif master: Fix mock of built in "open" function in unit tests https://review.opendev.org/664583 | |
| 13:23:17 | sean-k-mooney | mriedem: when you have a sec i need your advice on how we should be mocking "open" in os-vif if you can comment on https://review.opendev.org/#/c/664583/1/vif_plug_ovs/tests/unit/test_linux_net.py | |
| 13:23:28 | sean-k-mooney | that would be awsome | |
| 13:28:38 | openstackgerrit | Matthew Booth proposed openstack/nova master: Add functional test for bug 1550919 https://review.opendev.org/631294 | |
| 13:28:39 | openstackgerrit | Matthew Booth proposed openstack/nova master: libvirt: Don't delete disks on shared storage during evacuate https://review.opendev.org/578846 | |
| 13:28:39 | openstack | bug 1550919 in OpenStack Compute (nova) "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Matthew Booth (mbooth-9) | |
| 13:28:59 | mriedem | sean-k-mooney: i just said should probably be using the mock_open stuff that's part of mock rather than directly mocking the builtin | |
| 13:29:05 | mriedem | since i think that's what you're supposed to do | |
| 13:29:41 | sean-k-mooney | mriedem: ah ok i was not sure if there was more or not | |
| 13:29:42 | aspiers | mriedem: he is using mock_open() | |