Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-05-31
17:12:28 sean-k-mooney or just before it when it generates the new numa toplogy
17:14:33 openstackgerrit Stephen Finucane proposed openstack/nova master: WIP: Recalculate 'RequestSpec.numa_topology' on resize https://review.opendev.org/662522
17:14:56 stephenfin sean-k-mooney: ^ untested (completely) but something like that should do the trick, I imagine?
17:15:22 sean-k-mooney yes that is exactly what i was thinking too
17:15:44 stephenfin Nice
17:15:57 sean-k-mooney the one thing im not sure about however is should we but using the tempory mutation thing
17:16:12 stephenfin I'll try whip up a functional test for the on Monday^H^H^H Tuesday and see if I can reproduce it there
17:16:15 sean-k-mooney e.g. if we revert we need to make sure we go back to the old numa toplogy
17:16:15 stephenfin Possibly
17:16:45 stephenfin The fact that we're overwriting some RequestSpec fields already leads me to think we might be rolling back somewhere, but I haven't investigated
17:17:15 sean-k-mooney i think we nolonger persist the ignore_hosts field to the db
17:17:36 sean-k-mooney anyway that is at least a step in the right direction
17:23:46 openstackgerrit Eric Fried proposed openstack/nova master: Remove fake_libvirt_utils from virt driver tests. https://review.opendev.org/643894
17:23:47 openstackgerrit Eric Fried proposed openstack/nova master: Remove remaining vestiges of fake_libvirt_utils from unit tests. https://review.opendev.org/643896
17:23:47 openstackgerrit Eric Fried proposed openstack/nova master: Remove fake_libvirt_utils from libvirt imagebackend tests. https://review.opendev.org/643895
17:23:48 openstackgerrit Eric Fried proposed openstack/nova master: Remove fake_libvirt_utils users in functional testing. https://review.opendev.org/644793
17:23:54 efried stephenfin: done
18:08:56 openstackgerrit melanie witt proposed openstack/nova master: Add documentation for counting quota usage from placement https://review.opendev.org/653845
18:08:56 openstackgerrit melanie witt proposed openstack/nova master: Use instance mappings to count server group members https://review.opendev.org/638324
18:08:57 openstackgerrit melanie witt proposed openstack/nova master: Follow up for counting quota usage from placement https://review.opendev.org/662056
18:52:23 openstackgerrit Merged openstack/nova stable/stein: Fix live-migration when glance image deleted https://review.opendev.org/662152
18:53:18 mriedem dansmith: thanks, replied
18:53:39 mriedem dansmith: sounds like you're prefer me to go back to PS3 for the backports and leave the group_uuid stuff separately on master - if so, that's fine and i can do that
18:53:45 mriedem *you'd
18:59:00 dansmith mriedem: ah I didn't see that it was that way in a previous set.. I'm not super opposed, but just feels like the right thing to do
19:00:03 mriedem ok i'll split that one apart and make the func test change to pop request_spec from kwargs
19:01:18 artom dansmith, welcome back from PTO. I left you a steaming homecoming present: https://review.opendev.org/#/c/653498/
19:02:05 artom (It's the revert resize thing we had a hangouts about)
19:03:13 mriedem ....except much different
19:03:26 dansmith um, great?
19:04:04 mriedem something something very specific vif type / profile thing right?
19:04:11 mriedem b/c i have not tried to grok any of it
19:04:23 artom Well, the problem turned out to be specific
19:04:32 artom Hence the proposed solution is as well
19:04:52 mriedem and the generic solution we talked about on the hangout wouldn't have fixed it?
19:04:59 artom But yeah, it only happens (in this specific case) when Neutron uses OVS hybrid plug
19:05:09 mnaser two annoying Friday questions: why is the UEFI path hard-coded and why does it have no functional tests (lack of UEFI image?)
19:05:14 mriedem i.e. register the callback in compute manager before updating the port binding and calling the virt driver method
19:05:29 artom mriedem, no, because Neutron sends the event at different times depending on its internals
19:05:32 mriedem mnaser: it was bolted it years ago...
19:05:34 mriedem *in
19:06:13 artom mriedem, wait, say that again? Callback for what?
19:06:31 mriedem artom: the event
19:07:06 mriedem mnaser: https://bugs.launchpad.net/nova/+bug/1825386 is the first issue right?
19:07:07 mnaser because the fact centos and ubuntu both host it in different places is pretty gross right now
19:07:07 openstack Launchpad bug 1825386 in OpenStack Compute (nova) "nova is looking for OVMF file no longer provided by CentOS 7.6" [Undecided,New]
19:07:15 mnaser bahaha
19:07:16 mnaser yes
19:07:24 artom mriedem, you mean wrapping the call to update the port binding with wait_for_event?
19:07:55 mnaser okay, well I guess it's being addressed then
19:07:56 mriedem mnaser: so the workaround from kashyap in there is to create a link
19:08:06 mnaser fair nuff
19:08:09 mriedem mnaser: just b/c there is a bug doesn't mean it's being addressed :) you should know that
19:08:21 mriedem artom: yeah
19:08:34 mnaser well I think kashyap is doing this work
19:08:51 mnaser oh its not even approved yet
19:08:57 mriedem functional testing would catch that anyway
19:09:00 mriedem *wouldn't
19:09:05 artom mriedem, that only works if Neutron sends the event in response to the port binding update
19:09:07 mnaser it's probably trivial to make a config option I guess
19:09:17 artom Which it only does when OVS hybrid plug is in use
19:09:19 mnaser but having a config option with two defaults (i.e. aarch64 vs x86)... EH.
19:09:19 mriedem mnaser: or create a link in osa
19:09:30 mnaser yeah I think that seems like the likely path
19:09:31 mriedem but then all deployment tools have to do that
19:09:44 artom mriedem, the rest of the time, it's business as usual with waiting as we currently do in the virt driver
19:09:47 mnaser yeah it seems like having a config option is the right thing™
19:10:18 mriedem mnaser: every deployment tool will still have to make a change
19:10:22 mriedem either way
19:10:29 mriedem unless/until nova can auto-detect it
19:10:58 mriedem artom: ok it sounds like a similar issue with hard reboot depending on the type of vif (odl ovs doesn't send the event unless you change the port binding)
19:11:43 artom mriedem, not quite type of vif, but yeah. The real root cause here is Neutron not being consistent in when it sends the events
19:12:04 mriedem mnaser: regarding testing :) https://specs.openstack.org/openstack/nova-specs/specs/mitaka/implemented/boot-from-uefi.html#testing
19:12:18 mriedem damn those neutrinios
19:13:41 artom Since I'm not sure how realistic is to expect Neutron to change in the near future, the next best alternative is a hopefully-not-too-ugly Nova hack :/
19:16:32 mriedem i was joking, i like the neutrinos
19:17:00 artom Don't worry, I didn't rat you out
19:19:01 openstackgerrit Matt Riedemann proposed openstack/nova master: Add regression recreate test for bug 1830747 https://review.opendev.org/661822
19:19:02 openstackgerrit Matt Riedemann proposed openstack/nova master: Workaround missing RequestSpec.instance_group.uuid https://review.opendev.org/661786
19:19:02 openstack bug 1830747 in OpenStack Compute (nova) "Error 500 trying to migrate an instance after wrong request_spec" [High,In progress] https://launchpad.net/bugs/1830747 - Assigned to Matt Riedemann (mriedem)
19:26:42 openstackgerrit Merged openstack/nova stable/stein: cleanup evacuated instances not on hypervisor https://review.opendev.org/662189
19:28:46 openstackgerrit Matt Riedemann proposed openstack/nova master: Set/get group uuid when transforming RequestSpec to/from filter_properties https://review.opendev.org/662550
19:28:50 mriedem dansmith: there you go, all 3 ^
19:28:57 mriedem assuming you can fast approve the func test one
19:31:12 dansmith right on
19:33:15 mnaser mriedem: fwiw -- https://review.opendev.org/662552
19:34:01 mriedem delicious ansible
19:37:32 mriedem mnaser: question in there
19:37:40 openstackgerrit Boris Bobrov proposed openstack/nova master: Extract SEV-specific bits on host detection https://review.opendev.org/636334
19:37:41 openstackgerrit Boris Bobrov proposed openstack/nova master: Add iommu driver to devices https://review.opendev.org/644564
19:37:41 openstackgerrit Boris Bobrov proposed openstack/nova master: Add configs for AMD SEV https://review.opendev.org/636318
19:37:42 openstackgerrit Boris Bobrov proposed openstack/nova master: Use fake flavor instead of empty dict in test https://review.opendev.org/662555
19:37:42 openstackgerrit Boris Bobrov proposed openstack/nova master: Detect that SEV is required and enable iommu for devices https://review.opendev.org/644565
19:37:43 openstackgerrit Boris Bobrov proposed openstack/nova master: Use launchSecurity element when SEV was required https://review.opendev.org/662557
19:37:43 openstackgerrit Boris Bobrov proposed openstack/nova master: Pass extra_specs to flavor in vif tests https://review.opendev.org/662556
19:37:44 openstackgerrit Boris Bobrov proposed openstack/nova master: Enable memory locking if SEV is requested https://review.opendev.org/662558
19:39:00 mnaser mriedem: good call, done
19:42:08 mriedem melwitt: thing in https://review.opendev.org/#/c/638324/ which you can tack into your FUP change
20:00:52 openstackgerrit Eric Fried proposed openstack/nova master: Hide hypervisor id on windows guests https://review.opendev.org/579897
20:01:14 openstackgerrit Eric Fried proposed openstack/nova master: Hide hypervisor id on windows guests https://review.opendev.org/579897

Earlier   Later