Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-05-22
13:11:53 efried because we would get false positives
13:12:09 sean-k-mooney cdent: because we wont be testing with the released version or the version listed in upperconstriats
13:12:09 cdent meh
13:12:26 sean-k-mooney so we wont be testing with what people actullly will be deploying
13:12:30 efried right
13:12:34 efried and that would be bad.
13:12:47 sean-k-mooney we could do it in nova-next or a specific job
13:13:01 sean-k-mooney we just dont wnat to do that in all jobs
13:13:05 cdent or constraints in general
13:13:17 sean-k-mooney cdent: do you use arch
13:13:19 cdent hell, I'm going the whole way: I don't like
13:14:11 aarents efried: Hi, about https://review.opendev.org/#/c/659054 I had to rebase, it is ok now, can you have a look on it please?
13:14:23 sean-k-mooney hehe look im fine with deploying with os-traits from master as long as we have at least one job that is testing the released version
13:15:02 sean-k-mooney maybe there is a feature request here to zuul for a way to add peoject dynamiclaly per patch
13:15:36 efried sean-k-mooney: ^ this
13:15:38 sean-k-mooney e.g. Depends-on: xyw Require: openstack/os-traits
13:15:45 efried ooo
13:16:16 sean-k-mooney that said we still would not want to merge the patch without the release so not sure how useful that is
13:16:22 efried As it stands, I have to hand-edit .zuul.yaml. And for inherited jobs/templates, I would have to write whole derived jobs for them.
13:16:32 efried sean-k-mooney: It's useful for me to validate that my patch is correct.
13:16:56 efried Because as always I don't want to run all of the nova unit test and functional suites locally.
13:17:04 sean-k-mooney efried: right but outside of that not sure.
13:17:43 sean-k-mooney efried: i recently set up rtox to run my unit tests over ssh on my desktop. they now take ~ 2 mins to run
13:17:44 efried Sure, outside of that it's not very helpful, and needs to be negated once the dep merges, so I can't accidentally merge that patch.
13:18:14 efried aarents: looking...
13:18:15 sean-k-mooney efried: it woudl be useful for test only patch on top of the actul change
13:18:26 sean-k-mooney *test only -> DNM
13:19:59 cdent efried: clone yourself and fix the core problem: tests are too slow
13:20:24 openstack Launchpad bug 1829896 in OpenStack Compute (nova) "libvirt: "Instance failed to shutdown in 60 seconds." in the gate" [Undecided,New]
13:20:24 mriedem this contributes to ^ https://bugs.launchpad.net/nova/+bug/1829896
13:20:28 sean-k-mooney cdent: not if you throw 48 cores at them
13:21:20 cdent 48!? luxury
13:21:57 sean-k-mooney cdent: the full nova py37 tox env takes 72 seconds to run on my desktop or about 2 minutes totoal when you account for the tox startup time and report generation
13:22:16 cdent try the placement tests, I suspect you will go backwards in time
13:22:44 sean-k-mooney cdent: i decomisined the tower server i baught do some ci
13:24:21 sean-k-mooney ======
13:24:22 sean-k-mooney Totals
13:24:24 sean-k-mooney ======
13:24:26 sean-k-mooney Ran: 152 tests in 0.7772 sec.
13:24:28 sean-k-mooney - Passed: 152
13:24:30 sean-k-mooney - Skipped: 0
13:24:32 sean-k-mooney - Expected Fail: 0
13:24:34 sean-k-mooney - Unexpected Success: 0
13:24:36 sean-k-mooney - Failed: 0
13:24:38 sean-k-mooney Sum of execute time for each test: 0.4916 sec.
13:24:40 sean-k-mooney not quite
13:25:25 sean-k-mooney and the time output
13:25:29 sean-k-mooney real 0m5.681s
13:25:30 sean-k-mooney user 1m33.494s
13:25:32 sean-k-mooney sys 0m9.505s
13:26:00 sean-k-mooney that said before i got that working yesterday i would agree way to slow
13:28:30 gibi hehe this rtox python package implements what I have in bash for years. I independently named that bash script 'rtox'
13:29:39 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Support old & new versions of svm and avx traits https://review.opendev.org/660515
13:29:57 efried iiuc, ^ stands a chance of passing functional and tempest, but will still fail unit.
13:30:40 efried which does kind of defeat the purpose, as it's unit tests I've changed.
13:30:56 sean-k-mooney gibi: ya im proably goign to stop using it. the python version takes way to long to actully output to stdout
13:31:07 efried The tests I changed succeed locally though. shrug.
13:31:55 sean-k-mooney efried: wait why are we reported avx and svm in a vendor speficic way
13:32:54 sean-k-mooney oh we are not at least for AVX
13:32:56 efried because they're vendor-specific flags
13:33:12 sean-k-mooney efried: you ment VMX not AVX
13:33:14 efried point is, we weren't, but we should have been, so now we are.
13:33:27 efried oh, did I misspell something? :P
13:33:42 sean-k-mooney :)
13:34:10 efried thanks sean-k-mooney, nice catch
13:34:10 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Support old & new versions of svm and vmx traits https://review.opendev.org/660515
13:34:19 sean-k-mooney are the only spelling mistakes i can spot instruction sets?
13:34:29 efried I'll take it.
13:34:49 efried we have plenty of other anal-retentive people to catch the rest.
13:35:04 efried community development ftw
13:35:11 sean-k-mooney that was more a self commentry on how deep the intel brainwashing must have penetrated :P
13:36:01 sean-k-mooney it bypassed my in ability to spell and inserted an instruction set filter into my brain lol
13:39:09 efried aarents: I feel like I must be forgetting some background on https://review.opendev.org/#/c/659054/
13:39:26 efried pieces of this look vaguely familiar. Have we talked about this before?
13:39:38 efried I can see I've not been on the review itself...
13:40:37 stephenfin efried: I assume you got sorted? I'm knee deep in crappy unit tests atm :)
13:40:54 efried stephenfin: Yes thanks.
13:41:06 efried got an answer anyway, if not sorted how I would like.
13:54:59 dansmith mriedem: do we still have a job that does a full archive after tempest?
13:56:37 dansmith I see mention in nova-next, but not sure where it's called
13:56:48 sean-k-mooney as in one that runs https://github.com/openstack/nova/blob/master/gate/post_test_hook.sh
13:57:09 dansmith ah yep
13:57:11 dansmith thanks
13:57:27 sean-k-mooney it looks like 3 https://github.com/openstack/nova/search?q=post_test_hook.sh&unscoped_q=post_test_hook.sh
13:58:47 mriedem nova-next is the one you're looking for
13:59:29 sean-k-mooney its done the live migration job too and the grenade version
13:59:41 mriedem not the same scripts dan is looking for
14:00:18 sean-k-mooney oh right they run a different post test hook
14:00:29 dansmith mriedem: okay the --before patch is too stale to have test output, but wanted to see what that run looks like
14:00:32 sean-k-mooney so ya nova-nextg
14:18:19 openstackgerrit Surya Seetharaman proposed openstack/python-novaclient master: Allow passing negative values for the locked search_opt in cs.servers.list https://review.opendev.org/659783
14:25:53 aarents efried: I think you where about to read this 2 days ago, but you saw that it was no more mergeable. never mind I need a core having a look on this since Matthew has "+1" do you know who can help me on this ? ( https://review.opendev.org/#/c/659054/ )
14:27:03 efried aarents: I'm reviewing it. I have some issues with the test. Working on formulating a solution...
14:28:20 aarents ok
14:28:22 aarents thanks
14:43:40 mriedem https://www.youtube.com/watch?v=SGZqDzb__bw
14:43:47 openstackgerrit Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.opendev.org/637605
14:43:47 openstackgerrit Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832
14:43:48 openstackgerrit Matt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection https://review.opendev.org/642183
14:43:48 openstackgerrit Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891

Earlier   Later