| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-05-17 | |||
| 17:07:53 | efried | def __init__(self, **kwargs): | |
| 17:07:53 | efried | class LibvirtConfigGuestFeatureACPI(LibvirtConfigObject): | |
| 17:07:53 | efried | but for LibvirtConfigGuestFeature, there's no reason e.g. the next one couldn't just be | |
| 17:08:11 | efried | similarly for the subsequent two. | |
| 17:08:12 | openstackgerrit | Doug Wiegley proposed openstack/nova master: Improve metadata server performance with large security groups https://review.opendev.org/656084 | |
| 17:08:14 | aspiers | Now that this conversation jogged my memory, I remember I was definitely emulating LibvirtConfigGuestFeature | |
| 17:08:20 | efried | etc etc | |
| 17:08:26 | aspiers | Yeah | |
| 17:08:34 | aspiers | Well like I said, I'm not religious about the base class at all | |
| 17:08:50 | aspiers | I originaly thought you were saying it was pointless for other reasons | |
| 17:08:51 | efried | yeah, if you were emulating... you could have just used that. | |
| 17:08:56 | efried | but I'd rather kill it. | |
| 17:09:01 | aspiers | fine | |
| 17:09:05 | aspiers | coming right up in PS5 | |
| 17:09:08 | efried | In fact, I'm going to propose a patch to get rid of all that other cruft and see if it breaks the world. | |
| 17:10:01 | sean-k-mooney | im expecting an rm -rf of the nova subdiretory | |
| 17:10:04 | aspiers | lol | |
| 17:10:17 | aspiers | sean-k-mooney: that would be one way of getting rid of all the bugs ;) | |
| 17:10:43 | aspiers | "Perfection is achieved, not when there is nothing more to add, but when there is nothing left to take away." | |
| 17:11:14 | aspiers | not sure St Exupery meant it quite like that though | |
| 17:12:01 | sean-k-mooney | well we have almost reached perfrection of cellsv1 in that case | |
| 17:14:47 | aspiers | efried: I can remove that cruft if you want | |
| 17:14:55 | efried | aspiers: I'm already working on it. | |
| 17:14:59 | aspiers | ok | |
| 17:15:18 | aspiers | efried: didn't anyone tell you PTLs aren't allowed to code? ;-p | |
| 17:15:24 | efried | sore point | |
| 17:15:30 | aspiers | strictly no fun allowed | |
| 17:15:53 | aspiers | just feeling smug cos I temporarily escaped endless meetings | |
| 17:15:55 | aspiers | I'm sure it won't last | |
| 17:16:57 | openstackgerrit | Adam Spiers proposed openstack/nova master: Add infrastructure for invoking libvirt's getDomainCapabilities API https://review.opendev.org/655268 | |
| 17:17:22 | aspiers | and now a rebase for good measure ... | |
| 17:17:30 | openstackgerrit | Adam Spiers proposed openstack/nova master: Add infrastructure for invoking libvirt's getDomainCapabilities API https://review.opendev.org/655268 | |
| 17:21:34 | aspiers | efried: I'm around for a while in case there are any remaining things you want addressed in that | |
| 17:21:51 | efried | aspiers: 2 mins and I'll have another look. | |
| 17:22:22 | aspiers | kewl | |
| 17:23:04 | openstackgerrit | Eric Fried proposed openstack/nova master: Remove no-op intermediary libvirt config classes https://review.opendev.org/659848 | |
| 17:23:06 | efried | aspiers: ^ | |
| 17:24:51 | efried | aspiers: +2. Now you get to rebase the others on top :) | |
| 17:24:58 | efried | shouldn't be too hard | |
| 17:24:59 | aspiers | efried: already started | |
| 17:25:01 | aspiers | nah it's not | |
| 17:41:27 | sean-k-mooney | aspiers: v6 of https://review.opendev.org/#/c/655268 looks good to me. if i want to reuse this for the device model based schduleing i will need to extend the config parsing logic accordingly but tha that shoudl be quite clean to do | |
| 17:41:37 | aspiers | sean-k-mooney: cool | |
| 17:42:42 | openstackgerrit | Adam Spiers proposed openstack/nova master: Add detection of SEV support from QEMU/AMD-SP/libvirt on AMD hosts https://review.opendev.org/633855 | |
| 17:42:49 | aspiers | efried: there's the first rebase ^^^ | |
| 17:43:15 | aspiers | sean-k-mooney: ^^^ in case you want to see the first example of a real customer of that API | |
| 17:43:36 | sean-k-mooney | yep ill try an review the full sev series next week. | |
| 17:43:47 | sean-k-mooney | but for now time to go get food | |
| 17:43:50 | sean-k-mooney | o/ | |
| 17:43:55 | aspiers | sean-k-mooney: thanks, it's still incomplete but working on it | |
| 17:43:58 | aspiers | o/ | |
| 17:51:04 | efried | aspiers: Once kashyap and/or sean-k-mooney have +1ed https://review.opendev.org/#/c/633855/ I'll send it. | |
| 17:51:23 | openstackgerrit | Adam Spiers proposed openstack/nova master: Add new "supports_amd_sev" capability to libvirt driver https://review.opendev.org/638680 | |
| 17:51:31 | aspiers | efried: thanks, and there's the next one on top of that ^^^ | |
| 17:51:36 | sean-k-mooney | efried: by the way really small change but can you comment on my comment in the commit message regarding bug vs specless blueprint | |
| 17:51:38 | sean-k-mooney | https://review.opendev.org/#/c/658785/4 | |
| 17:52:18 | efried | sean-k-mooney: looking | |
| 17:56:04 | efried | sean-k-mooney: I would need a better explanation of wtf this patch is doing. | |
| 17:56:30 | sean-k-mooney | efried: we support hardware offlwoad ovs with kernel ovs today | |
| 17:56:38 | efried | keeping in mind that my eyes glaze over any time I hear ovs or dpdk | |
| 17:56:41 | sean-k-mooney | this is part fo making it work with ovs-dpdk too | |
| 17:57:06 | efried | Let me put it this way: what would the reno say? | |
| 17:57:11 | sean-k-mooney | so this is just passign the ovs datapath type wich we have in teh vif to os-vif | |
| 17:57:15 | efried | What will the user notice? | |
| 17:58:25 | sean-k-mooney | opereators will now by able to deploy ovs-dpdk with hardwar offloads for nvf/telco deployment that need hi data rates and a fast fallback path when a feature is not supported in hardware | |
| 17:59:13 | sean-k-mooney | we could skip the reno i guess but it would be nice to call this out in 1 of nova, os-vif or neutron | |
| 17:59:31 | sean-k-mooney | the patch to enable it in all 3 repos are equally short however | |
| 18:00:20 | efried | sean-k-mooney: Okay, so a bug definitely doesn't seem appropriate; it sounds like a feature to me. | |
| 18:00:28 | sean-k-mooney | this prettymuch almost works already | |
| 18:00:46 | sean-k-mooney | ya i was thinking that too but its also a tiny change | |
| 18:00:55 | sean-k-mooney | hence sepcless blueprint | |
| 18:00:58 | efried | Right, so if it's truly tiny, a specless blueprint would be fine. | |
| 18:01:00 | efried | imo | |
| 18:01:17 | sean-k-mooney | well that patch is the total cahnge needed to nova | |
| 18:01:21 | efried | what would the operator need to do to make things happen? | |
| 18:01:29 | efried | (is the kind of thing I would want the bp to say) | |
| 18:01:39 | efried | is there an API change? | |
| 18:02:02 | efried | configs that affect? | |
| 18:02:05 | efried | docs that need to be updated? | |
| 18:02:07 | sean-k-mooney | just install ovs-dpdk on a host with a melonox nic that support hardware offloand and have the right version of nova and neutron | |
| 18:02:23 | sean-k-mooney | there is not api change or change to iamge or flaovr | |
| 18:02:46 | sean-k-mooney | you use the feature the same way as hardware offloaded kernel ovs | |
| 18:03:04 | openstackgerrit | Adam Spiers proposed openstack/nova master: Extract SEV-specific bits on host detection https://review.opendev.org/636334 | |
| 18:03:19 | sean-k-mooney | i am not sure if we have docs for that but assuming we do the might want to be updated | |
| 18:03:37 | efried | neat. So yeah, a specless blueprint sounds appropriate to me. Though I guess the problem is that you can't file a single blueprint against multiple projects? | |
| 18:03:40 | aspiers | ALL YOUR REBASE ARE BELONG TO US | |
| 18:03:49 | sean-k-mooney | efried: https://docs.openstack.org/neutron/rocky/admin/config-ovs-offload.html shoudl be updated | |
| 18:03:58 | sean-k-mooney | but that is in neutron | |
| 18:04:16 | aspiers | that's probably the best joke I ever made </tragically_proud_moment> | |
| 18:04:28 | sean-k-mooney | efried: yep which is why i was questioning should it be an rfe bug | |
| 18:04:33 | efried | aspiers: Cause you know I'm all about rebase, 'bout rebase... | |
| 18:04:49 | efried | sean-k-mooney: Is that a thing? Then sure. | |
| 18:04:49 | sean-k-mooney | but specless blueprint for nova and rfe bugs that is shared for os-vif/nueton is fine too | |
| 18:04:51 | aspiers | damn, instantly upstaged, just like that | |
| 18:05:03 | sean-k-mooney | efried: its what neutron uses for all feature requests | |
| 18:05:11 | efried | heh, okay. | |
| 18:05:14 | efried | wfm | |
| 18:05:15 | sean-k-mooney | we dont use rfe bugs in nova | |
| 18:05:29 | sean-k-mooney | its litrally just a rfe tag on the bug | |
| 18:06:01 | sean-k-mooney | cool anyway really going this time o/ | |