Posted	Nick	Remark
#openstack-nova - 2019-05-13
15:04:30	johnthetubaguy	one alternative is to error with conflict when ports that have a floating ip are changed via that API, as we know something odd happens
15:04:56	sean-k-mooney	johnthetubaguy: i was thinking something similar
15:05:12	sean-k-mooney	but i was not sure we were allowed to
15:05:46	sean-k-mooney	personally i would prefer that you were requried to disassociate the fip first
15:06:02	johnthetubaguy	its borderline...
15:06:16	sean-k-mooney	but again that would need a micro version too right
15:07:47	sean-k-mooney	what we could do is just remove the fixed ip but not the port id from the floating ip
15:08:11	johnthetubaguy	hmm, I though that is what happened today?
15:08:22	johnthetubaguy	oh wait, I see what you mean now
15:08:52	johnthetubaguy	hmm, that is probably more surprising at this point
15:09:02	sean-k-mooney	if the port has multiple fixed ips and you dont specify one when setting the fip assocation it just uses the first
15:09:27	johnthetubaguy	hmm, re-reading
15:09:48	sean-k-mooney	so if the port has multiple fixed ips i dont know if you would expect it to be retarged to one of the others or not
15:12:40	artom	efried, https://review.opendev.org/#/c/603955/12/specs/train/approved/nova-cyborg-interaction.rst@249
15:12:47	artom	See PS11, L250
15:13:31	efried	thanks artom
15:14:11	sean-k-mooney	anyway i can see the logic of removing the fip association and also of not. since we dont know what we should do i feel raising an error is best but honestly i would be fine with doing nothing and not merging the patch also.
15:14:29	dansmith	sean-k-mooney: johnthetubaguy that was last touched by the owner in 2017 right?
15:14:36	dansmith	I think we can probably just ignore it
15:16:50	johnthetubaguy	dansmith: oops, I see even the +2 was from 2017 now...
15:16:59	dansmith	johnthetubaguy: yeah :)
15:17:08	openstackgerrit	Matthew Booth proposed openstack/nova master: Fix retry of instance_update_and_get_original https://review.opendev.org/658845
15:17:10	sean-k-mooney	dansmith: mriedem rebased it in april i wonder if he had a customer ask about it
15:17:19	mriedem	nope
15:18:04	sean-k-mooney	in that case ya we canb proably just abandon it
15:18:12	johnthetubaguy	I was trying to find some low hanging +Ws (facepalm)
15:18:15	mriedem	i likely saw it at the top of http://status.openstack.org/reviews/#nova during the forum and just rebased it to see if it still worked
15:18:29	dansmith	johnthetubaguy: a noble goal :)
15:18:34	johnthetubaguy	ah, similar, found it in the review dashboard
15:19:03	johnthetubaguy	abandoned it, its a distraction for sure
15:19:52	openstackgerrit	Merged openstack/nova master: Trivial: Adds comments and tests for scheduler https://review.opendev.org/658516
15:20:34	mriedem	as noted in the review, the remove_fixed_ip_from_instance (and add counterpart) were added to mirror nova-net functionality and i think i pointed out (now years ago) that it was more or less super janky
15:20:40	ganso	mriedem: Hi Matt, I fixed the functional test and ran it against queens and rocky (https://review.opendev.org/#/c/658136 and https://review.opendev.org/#/c/658834) and unfortunately it seems the fix that merged in rocky does not solve the issue
15:24:10	mriedem	ok
15:28:34	mriedem	johnthetubaguy: super old bug for the same api https://bugs.launchpad.net/nova/+bug/1533260
15:28:35	openstack	Launchpad bug 1533260 in OpenStack Compute (nova) "Unexpected API Error is returned, when trying to add fixed IP to an instance in ERROR state" [Medium,Confirmed]
15:28:43	mriedem	well, same set of apis
15:29:50	mriedem	https://review.opendev.org/#/c/163864/ was the super old re-write of the apis
15:30:24	mriedem	abandoned in 2016 with "does anyone use this? don't think so"
15:31:35	johnthetubaguy	yeah, although that fix looks fine, but meh.
15:32:55	mriedem	"The more I think about, maybe the existing behaviour is correct. I need to catch up with mriedem about this."
15:32:59	mriedem	july 4 2016
15:33:17	mriedem	i was knee deep in grilled meats and explosives
15:35:58	mriedem	ganso: i'll pull your rocky test down and play with it to see if i can figure out what's going on
15:36:14	ganso	mriedem: thanks Matt! =)
15:36:35	mriedem	sean-k-mooney: in case you didn't notice, i got a recreate on https://review.opendev.org/#/c/653506/ stacked above it and cleaned it up, should be good to go now
15:36:59	mriedem	also figured out what i was doing wrong in the cross-cell resize series that was hitting that, so once i got that fixed i got a clean run in the multi cell job for cross-cell cold migration
15:51:26	openstackgerrit	Balazs Gibizer proposed openstack/os-traits master: Add REPORT_PARENT_INTERFACE_NAME_FOR_SRIOV_NIC trait https://review.opendev.org/658852
16:07:46	canori01	hello, I am running nova 18.0.2 and setting disk-cachemodes to writeback
16:08:05	canori01	However, the instance xml says none. Is this intended behavior?
16:09:14	sean-k-mooney	mriedem: hi sorry was in a meeting
16:09:56	sean-k-mooney	mriedem: im just grabing lunch but ill read through comment you left thanks for looking at this in depth
16:20:34	gibi	efried: I'm going to be away til Wednesday next week so I'm wondering if I should pul the heal port allocation from the runway slot
16:45:52	openstackgerrit	Matthew Booth proposed openstack/nova master: Fix retry of instance_update_and_get_original https://review.opendev.org/658845
16:48:08	openstackgerrit	Merged openstack/os-vif master: Replace git.openstack.org URLs with opendev.org URLs https://review.opendev.org/655068
16:53:32	openstackgerrit	Rodolfo Alonso Hernandez proposed openstack/os-vif stable/queens: add upper_constraints support https://review.opendev.org/658780
17:23:47	openstackgerrit	Merged openstack/nova master: Cleanup update_instance cell mapping handling https://review.opendev.org/467380
17:35:15	openstackgerrit	Merged openstack/nova master: Remove cells v2 transition code from update_instance https://review.opendev.org/467382
17:35:22	openstackgerrit	Merged openstack/nova master: api-ref: 'os-hypervisors' doesn't reflect overcommit ratio https://review.opendev.org/611604
17:44:37	efried	gibi: Probably a good idea.
18:30:02	openstackgerrit	Artom Lifshitz proposed openstack/nova master: [DNM] Testing links to inline comments, ignore https://review.opendev.org/658887
18:30:20	artom	Crap, that was supposed to go to downstream gerrit :(
18:32:36	sean-k-mooney	am it did
18:32:59	sean-k-mooney	oh you posted it upstream then downstream
18:36:49	artom	I learn from my mistakes :D
18:37:27	artom	For posterioriy, @a<line number> links to the "before"/left pane.
19:37:16	openstackgerrit	Daniel Speichert proposed openstack/nova-specs master: Directly download and upload images to RBD https://review.opendev.org/658903
19:37:17	openstackgerrit	Surya Seetharaman proposed openstack/nova master: [WIP] Add 'power-update' external event to listen to ironic https://review.opendev.org/645611
19:39:46	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add Migration.cross_cell_move and get_by_uuid https://review.opendev.org/614012
19:39:46	openstackgerrit	Matt Riedemann proposed openstack/nova master: Update usage in RT.drop_move_claim during confirm resize https://review.opendev.org/641806
19:39:47	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.opendev.org/614036
19:39:48	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add CrossCellMigrationTask https://review.opendev.org/631581
19:39:48	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add TargetDBSetupTask https://review.opendev.org/627892
19:39:48	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add Instance.hidden field https://review.opendev.org/631123
19:39:49	openstackgerrit	Matt Riedemann proposed openstack/nova master: Execute TargetDBSetupTask https://review.opendev.org/633853
19:39:50	openstackgerrit	Matt Riedemann proposed openstack/nova master: WIP: Add prep_snapshot_based_resize_at_dest compute method https://review.opendev.org/633293
19:39:50	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add can_connect_volume() compute driver method https://review.opendev.org/621313
19:39:51	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add prep_snapshot_based_resize_at_source compute method https://review.opendev.org/634832
19:39:51	openstackgerrit	Matt Riedemann proposed openstack/nova master: WIP: Add PrepResizeAtDestTask https://review.opendev.org/627890
19:39:52	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add PrepResizeAtSourceTask https://review.opendev.org/627891
19:39:52	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add nova.compute.utils.delete_image https://review.opendev.org/637605
19:39:53	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add power_on kwarg to ComputeDriver.spawn() method https://review.opendev.org/642590
19:39:53	openstackgerrit	Matt Riedemann proposed openstack/nova master: Refactor ComputeManager.remove_volume_connection https://review.opendev.org/642183
19:39:54	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add FinishResizeAtDestTask https://review.opendev.org/635646
19:39:54	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add finish_snapshot_based_resize_at_dest compute method https://review.opendev.org/635080
19:39:55	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add Destination.allow_cross_cell_move field https://review.opendev.org/614035
19:40:06	openstackgerrit	Matt Riedemann proposed openstack/nova master: Support cross-cell moves in external_instance_event https://review.opendev.org/658478
19:40:06	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add CrossCellWeigher https://review.opendev.org/614353
19:40:07	openstackgerrit	Matt Riedemann proposed openstack/nova master: WIP: Enable cross-cell resize in the nova-multi-cell job https://review.opendev.org/656656
19:40:07	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add cross-cell resize policy rule and enable in API https://review.opendev.org/638269
19:40:08	openstackgerrit	Matt Riedemann proposed openstack/nova master: Robustify attachment tracking in CinderFixtureNewAttachFlow https://review.opendev.org/658904
19:41:11	mriedem	dansmith: i've hit a not-so-fun snag in pre-validating the target host wrt attached volumes in the cross-cell resize stuff and i'd like to brain dump
19:41:25	dansmith	okay
19:42:06	mriedem	so we want to try and connect the volume on the dest host to see if it will work before starting the whole process,
19:42:22	mriedem	to do that, i need to update the volume attachment with the dest host connector to get the connection_info dict that the virt driver uses,
19:42:58	mriedem	the problem is, at the point i'm doing that, the source host volume attachment still exists and cinder pukes saying you essentially can't have more than one connected attachment for the same volume at the same time
19:43:26	mriedem	which makes sense i guess, and is not something we hit in a normal move because we delete the source host attachment before finishing on the dest
19:44:02	mriedem	granted normal resize could fail the same thing today - if you can't connect the volume on the dest after we've transferred the disks and stuff
19:44:34	dansmith	cross-cell is actually easier in this case because you have two separate instances and attachments on the nova side
19:44:56	dansmith	normal resize would need to stash that in case it needs to revert right? or maybe just ask cinder again.. tbh, I dunno how that attachment stuff works really :)

Earlier   Later