| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-04-25 | |||
| 22:03:09 | mriedem | so if we did the sdk thing, cyborg integration could be the guinea pig, and then i'd think cinder since we haven't ksa'd our cinder stuff yet | |
| 22:04:14 | efried | I was going to do placement first, because it would be a transparent swap under the covers - we don't have a placementclient, so we would just set up SchedulerReportClient._client as the Connection.placement proxy (which is an Adapter subclass) instead of the raw Adapter. | |
| 22:04:25 | efried | get/put/etc primitives come along for free. | |
| 22:04:59 | efried | I PoC'd this already and it works seamlessly in tempest. It just blows up all the unit and functional tests until I figure out fixtures (see above) | |
| 22:05:21 | mriedem | ok | |
| 22:05:49 | efried | ...and then ironicclient, because we have lots of support for that from the ironic team, and dtantsur|afk is a sdk core who can help to some extent | |
| 22:06:26 | efried | and I have a guy coming on board (hi dustinc) who's trying to be involved in ironic who has started looking at it. | |
| 22:07:07 | efried | but yeah, could look into tackling cinder early, I see the benefit since it got left behind with ksa. | |
| 22:07:16 | efried | never could figure that f'in thing out. | |
| 22:15:06 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Correct signature on fake_get_availability_zones https://review.opendev.org/655806 | |
| 22:21:29 | mriedem | dansmith: so i'm going to rev this multi-cell job patch to disable the failing test here until there is a bug fix - while doing that, what do you think about just making the job non-voting in the check queue for a bit until we're happy with it through the ptg? | |
| 22:21:57 | dansmith | mriedem: I'm good with whatever, but it seems like non-voting to collect data is what we would normally do | |
| 22:28:02 | mriedem | ack | |
| 22:28:03 | mriedem | done | |
| 22:28:20 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova-multi-cell job https://review.opendev.org/655222 | |
| 22:28:21 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Enable n-novnc in nova-multi-cell job https://review.opendev.org/655711 | |
| 22:52:24 | openstackgerrit | melanie witt proposed openstack/nova master: Use futurist.ThreadPoolExecutor in scatter_gather_cells https://review.opendev.org/650172 | |
| 23:06:40 | efried | o/ see y'all tomorrow | |
| 23:41:19 | artom | ||
| 23:56:51 | rm_work | so, is it possible to run nova unit tests with tox on OSX? anyone manage this? or is it just impossible (seems that pyinotify is not compatible with osx so the env build just fails) | |
| #openstack-nova - 2019-04-26 | |||
| 01:23:34 | mriedem | dims: didn't you used to run nova unit tests in osx? ^ | |
| 01:50:53 | mnaser | I usually run them.. I haven't had troubles | |
| 01:51:10 | mnaser | i.. don't usually run the whole suite tho | |
| 01:54:50 | mriedem | tsk | |
| 02:10:52 | dims | mriedem : right as mnaser said, not the full suite ... a while ago | |
| 02:28:10 | openstackgerrit | Merged openstack/python-novaclient master: Drop py35 tests https://review.opendev.org/643873 | |
| 02:32:34 | openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Change the default value of swap in the show flavor details API https://review.opendev.org/648919 | |
| 04:44:41 | openstackgerrit | melanie witt proposed openstack/nova master: Add 'path' query parameter to console access url https://review.opendev.org/649372 | |
| 05:13:35 | openstackgerrit | Merged openstack/nova master: Don't run tempest/devstack jobs on nova/test.py only changes https://review.opendev.org/655121 | |
| 06:42:30 | openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Change the default value of swap in the show flavor details API https://review.opendev.org/648919 | |
| 08:28:40 | openstackgerrit | Merged openstack/nova master: Delete require_instance_exists_using_uuid https://review.opendev.org/650994 | |
| 08:33:58 | slaweq | hi nova developers :) | |
| 08:34:25 | slaweq | can someone familiar with nova-metadata take a look at my comment in https://bugs.launchpad.net/neutron/+bug/1821912/comments/12 ? | |
| 08:34:26 | openstack | Launchpad bug 1821912 in neutron "intermittent ssh failures in various scenario tests" [High,Confirmed] | |
| 08:34:45 | gibi | efried: thanks for the onboarding slide update | |
| 08:35:08 | slaweq | I'm not sure what's exectly happend (or not happend) on nova's side there so any help would be useful | |
| 08:35:32 | slaweq | gibi: efried: if You would have some time, maybe You can take a look at ^ :) | |
| 08:35:34 | slaweq | thx in advance | |
| 08:47:22 | openstackgerrit | ya.wang proposed openstack/nova-specs master: Add spec for expose-auto-converge-post-copy https://review.opendev.org/651681 | |
| 08:48:14 | gibi | slaweq: hi! looking... (but not super familiar with the metadata part of nova) | |
| 08:48:25 | slaweq | gibi: thx a lot | |
| 09:08:14 | openstackgerrit | Stephen Finucane proposed openstack/nova master: test_rpc: "deepcopy" global options https://review.opendev.org/655843 | |
| 09:20:15 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Prevent "qbr" Linux Bridge from replying to ARP messages https://review.opendev.org/655332 | |
| 09:26:57 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Always disconnect volumes after libvirtError exceptions https://review.opendev.org/655712 | |
| 09:27:18 | lyarwood | mdbooth: ^ and the one below it might interest you btw, simple bugfixes. | |
| 09:29:32 | kashyap | aspiers: Hi, when you're about, some more design comments upcoming for the getDomCapabilities() patch | |
| 09:30:30 | kashyap | aspiers: Talking to libvirt folks, they strongly suggest to not cache the capabilities at all. I will write some details and possible suggestions in the patch. | |
| 09:33:51 | aspiers | kashyap: ok | |
| 09:34:21 | kashyap | aspiers: In short, if you want to start thinking about it: we're suggested to query domCapabilities once at the beginning of building domain XML process, but then forget them right after | |
| 09:34:37 | kashyap | I asked the libvirt dev to also comment in this bug: https://bugzilla.redhat.com/show_bug.cgi?id=1683471 | |
| 09:34:39 | openstack | bugzilla.redhat.com bug 1683471 in libvirt "getDomainCapabilities claims SEV is supported for pc-i440fx-1.4 machine type" [Unspecified,Closed: notabug] - Assigned to libvirt-maint | |
| 09:34:59 | aspiers | kashyap: but this is the point I already made in the comment - that approach totally fails in the OpenStack world | |
| 09:35:13 | kashyap | In the doc string, right? | |
| 09:35:21 | aspiers | kashyap: because we need to know stuff before placement time, not just at launch time | |
| 09:35:54 | aspiers | kashyap: https://review.opendev.org/#/c/655268/2/nova/virt/libvirt/host.py@690 | |
| 09:36:17 | aspiers | I suspect the libvirt folks were only thinking of the single hypervisor paradigm when they designed this | |
| 09:36:19 | kashyap | aspiers: Right, I'm still thinking, how to resolve that | |
| 09:37:13 | aspiers | but anyway, what is the problem with memoizing? it's not caching to disk | |
| 09:37:22 | aspiers | which caps would actually change? | |
| 09:39:36 | kashyap | aspiers: For example, when QEMU is updated, you get new features | |
| 09:39:50 | kashyap | (And as you know domCapabilities are machine type dependent.) | |
| 09:40:27 | aspiers | Didn't we already talk about this? When qemu is updated, nova-compute would be restarted, so the memoization vanishes | |
| 09:40:58 | openstack | bugzilla.redhat.com bug 1683471 in libvirt "getDomainCapabilities claims SEV is supported for pc-i440fx-1.4 machine type" [Unspecified,Closed: notabug] - Assigned to libvirt-maint | |
| 09:40:58 | kashyap | aspiers: Meanwhile: https://bugzilla.redhat.com/show_bug.cgi?id=1683471#c11 | |
| 09:41:21 | kashyap | aspiers: Oh, right. Forgive me if I forget something, I'm still somewhat ill, and not fully functional. | |
| 09:41:28 | aspiers | kashyap: np! :) | |
| 09:43:04 | kashyap | aspiers: Mind mentioning that in the docstring? The point when libvirt/QEMU gets updated, the Compute agent needs restarting, and the memoization vanishes | |
| 09:43:05 | aspiers | kashyap: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2019-04-23.log.html#t2019-04-23T12:42:11 | |
| 09:43:13 | ltyrex | does someone remember which table has the CPU pinning mapping in Openstack? | |
| 09:43:56 | aspiers | kashyap: sure, happy to | |
| 09:44:21 | kashyap | Thanks, I was revisiting the IRC log. | |
| 09:45:21 | gibi | slaweq: replied in the bug https://bugs.launchpad.net/neutron/+bug/1821912/comments/13 | |
| 09:45:22 | openstack | Launchpad bug 1821912 in neutron "intermittent ssh failures in various scenario tests" [High,Confirmed] | |
| 09:45:49 | gibi | slaweq: it feels like something was wrong with the VM hosting the devstack during the time period | |
| 09:46:33 | slaweq | gibi: thx a lot | |
| 09:46:47 | slaweq | gibi: I saw it but wasn't sure if that rabbitmq issue can be related somehow | |
| 09:49:05 | openstackgerrit | Eric Fried proposed openstack/nova master: Correct signature on fake_get_availability_zones https://review.opendev.org/655806 | |
| 09:51:25 | gibi | slaweq: there is gap in the log for the same time in the dstat log as well http://logs.openstack.org/47/653947/3/gate/tempest-slow-py3/629abee/controller/logs/screen-dstat.txt.gz#_Apr_25_14_56_44_349844 | |
| 09:52:18 | gibi | slaweq: seem like the VM did not got execution time so every service was slowed to halt | |
| 09:58:56 | kashyap | aspiers: Added some notes in the change; ruthlessly correct me if something is wrong :-) | |
| 09:59:03 | aspiers | I am doing ;-) | |
| 10:00:12 | kashyap | (Just a heads-up: won't be very responsive this afternoon due to prior committments; will read the change once my queue is free.) | |
| 10:00:18 | aspiers | np | |
| 10:05:47 | openstackgerrit | caoyuan proposed openstack/os-traits master: Replace git.openstack.org URLs with opendev.org URLs https://review.opendev.org/655066 | |
| 10:06:22 | aspiers | kashyap: very nice notes, thanks. I'm incorporating the missing points into the docstring | |
| 10:07:00 | aspiers | kashyap: believe it or not the C API *does* allow omitting some parameters, whereas they are mandatory in Python | |
| 10:07:10 | aspiers | kashyap: again replying in Gerrit | |
| 10:07:20 | aspiers | gotta dash to an appointment now though, back a bit later | |
| 10:16:34 | openstackgerrit | sean mooney proposed openstack/nova master: libvirt: auto detach/attach sriov ports on migration https://review.opendev.org/629589 | |
| 10:25:06 | slaweq | gibi: yes, that may be this | |
| 11:01:26 | openstackgerrit | sean mooney proposed openstack/nova master: [WIP] Libvirt: add nfv job https://review.opendev.org/652197 | |
| 11:21:51 | openstackgerrit | Stephen Finucane proposed openstack/nova master: test_rpc: Stop f****** with global state https://review.opendev.org/655843 | |
| 11:30:18 | kashyap | aspiers: I should've read the C API closer (instead of skimming) -- I think it incorporates some sane defaults. I'll believe you, of course | |
| 11:38:11 | kashyap | aspiers: BTW, it's a bug -- the virConnectGetDomainCapabilities() allowing skipping params, while its Python binding not :-) | |
| 11:38:20 | kashyap | aspiers: A libvirt dev is pushing a patch upstream | |
| 11:39:41 | kashyap | s/skipping parms/skipping _some_ params/ | |
| 11:52:47 | aspiers | kashyap: you mean a bug in the Python binding? that's what I suspected | |
| 11:54:46 | kashyap | aspiers: Bug in the C API, from the sounds of it. | |
| 11:55:04 | aspiers | ? | |
| 11:55:32 | kashyap | If you run `virsh domcapabilities`, the C API is run with with NULL, NULL, NULL, 0 | |