| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-04-25 | |||
| 09:25:35 | aspiers | it's not normal to need 2 rechecks, right? | |
| 09:30:31 | aspiers | kashyap: any idea? https://review.opendev.org/#/c/655268/2 keeps getting V-1 for no good reason AFAICS | |
| 09:31:01 | kashyap | aspiers: Sometimes is completely "normal" to require more than 2 rechecks :-( | |
| 09:31:07 | aspiers | :-( | |
| 09:31:35 | aspiers | This is an awesome technique for dealing with troublesome CI https://cfp.all-systems-go.io/ASG2018/talk/207/ | |
| 09:31:51 | aspiers | I think until OpenStack has something like that, flakey gates will always remain common | |
| 09:31:54 | kashyap | I don't have any bright ideas (besides "recheck and pray to the JuJu at the bottom of the sea"). I've experienced the same in the past. | |
| 09:32:45 | aspiers | Using ML means the "flakes" can be clustered automatically (unsupervised) which then means it's crystal clear which flakes cause the most failures and require the most human attention to fix | |
| 09:33:07 | aspiers | That way we could get to the long tail of weird corner cases quicker | |
| 09:33:39 | aspiers | e.g. one flake might cause 30% of failures, and another 0.3% | |
| 09:33:56 | aspiers | but until you gather stats on that, it's hard to know where to put effort | |
| 09:34:27 | aspiers | elastic recheck aims for that of course, but it requires manual maintenance | |
| 09:35:38 | kashyap | aspiers: Yeah, suggest it on the 'openstack-discuss' list, if you have a minute to write the email | |
| 10:03:27 | aspiers | kashyap: might be better to find mtreinish and the infra folks in Denver next week first | |
| 10:03:36 | aspiers | I've already reached out to the cockpit project | |
| 10:03:41 | aspiers | no reply yet | |
| 10:04:32 | aspiers | kashyap: when you get a moment, reviews on https://review.opendev.org/#/c/655268/ and https://review.opendev.org/#/c/633855/ would be much appreciated ;-) | |
| 10:05:08 | kashyap | aspiers: Will do. Currently doing something I promised efried that I'll address (in my own spec, though) today. Trying to keep the word. :D | |
| 10:05:35 | aspiers | sure, good luck with it :) | |
| 10:26:06 | openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Standardize CPU resource tracking https://review.opendev.org/555081 | |
| 10:33:18 | openstackgerrit | Adam Spiers proposed openstack/os-resource-classes master: Add MEM_ENCRYPTION_CONTEXT resource class https://review.opendev.org/655665 | |
| 10:46:38 | openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Standardize CPU resource tracking https://review.opendev.org/555081 | |
| 10:46:49 | stephenfin | sean-k-mooney: You're mostly happy with ^ at this point, I assume? | |
| 10:47:16 | sean-k-mooney | ya mostly | |
| 10:47:23 | stephenfin | I've added more words and fixed the typos to assuage efried's concerns (I hope) | |
| 10:47:36 | sean-k-mooney | i was going to suggest using a different threath the HW_CPU_HYPERTHREADING | |
| 10:47:43 | sean-k-mooney | but its already in os traits | |
| 10:47:50 | sean-k-mooney | e.g. HW_CPU_SMT | |
| 10:48:00 | stephenfin | sean-k-mooney: We could just _not_ use that? | |
| 10:48:18 | sean-k-mooney | then we have another dead trait in plamcent | |
| 10:48:20 | stephenfin | Or even remove it if no-one else is using it yet | |
| 10:48:24 | sean-k-mooney | *os-traits | |
| 10:48:55 | sean-k-mooney | stephenfin: we cant remove traits from os-traits | |
| 10:49:06 | sean-k-mooney | its an add only model | |
| 10:49:23 | stephenfin | if no one is using it anywhere though? | |
| 10:49:26 | sean-k-mooney | to simplfy db updates | |
| 10:49:27 | stephenfin | and never has | |
| 10:49:32 | stephenfin | Oh, there's a DB involved | |
| 10:49:33 | sean-k-mooney | even then | |
| 10:49:36 | sean-k-mooney | ya | |
| 10:49:42 | aspiers | stephenfin: you're repeating an earlier discussion ;-) | |
| 10:49:48 | aspiers | this is now mentioned in http://specs.openstack.org/openstack/nova-specs/specs/train/approved/amd-sev-libvirt-support.html | |
| 10:49:56 | aspiers | I asked the exact same question a few days ago | |
| 10:50:01 | sean-k-mooney | yep | |
| 10:50:03 | stephenfin | Fair. I'd also be ok with a dead trait, tbh, but I also don't care that much | |
| 10:50:16 | sean-k-mooney | im fine with hte hyperthreaing one | |
| 10:50:25 | aspiers | I think dead traits can be hidden to the point that they're only visible in the os-traits code where hardly anyone looks | |
| 10:50:29 | sean-k-mooney | people use it as a generic term even if it is a threadmark | |
| 10:50:34 | aspiers | well I suppose they're visible via introspection too | |
| 10:50:40 | stephenfin | fwiw, I tried to use SMT in the documentation e.g. https://docs.openstack.org/nova/pike/admin/cpu-topologies.html | |
| 10:51:03 | sean-k-mooney | yes i know and you gave a talk on the topic | |
| 10:51:36 | stephenfin | indeed :) | |
| 10:51:59 | sean-k-mooney | so ya i was in the middel of reading v27 | |
| 10:52:08 | sean-k-mooney | ill skim through v28 | |
| 10:52:34 | stephenfin | Yeah, spotted an issue with my description of that trait, actually :) | |
| 10:52:50 | stephenfin | I must admit, I really don't like Gerrit for doc reviews :-\ | |
| 10:53:03 | sean-k-mooney | why | |
| 10:53:16 | stephenfin | It's too hard to keep track of conversations | |
| 10:53:24 | sean-k-mooney | you jut have to wait a bit and collect the changes | |
| 10:53:26 | aspiers | stephenfin: that's because we're using an ancient Gerrit | |
| 10:53:33 | aspiers | Gerrit 2.16 is awesome | |
| 10:53:43 | stephenfin | aspiers: Oh yeah? Anything specific? | |
| 10:53:45 | sean-k-mooney | we are using 2.13 | |
| 10:53:49 | stephenfin | The polymer UI? | |
| 10:53:54 | aspiers | stephenfin: much more than that | |
| 10:54:28 | aspiers | https://review.gerrithub.io/q/status:open | |
| 10:55:07 | sean-k-mooney | whats so different about that | |
| 10:55:10 | aspiers | https://youtu.be/WsPhoPGUsss?t=9m47s | |
| 10:55:32 | aspiers | https://youtu.be/WsPhoPGUsss?t=19m10s | |
| 10:55:37 | sean-k-mooney | that is just the polomer ui + a theme | |
| 10:55:40 | aspiers | nope | |
| 10:56:17 | stephenfin | aspiers: Oh, nice | |
| 10:56:19 | aspiers | this is just one of many specific improvements | |
| 10:56:28 | aspiers | I can't list them all for you | |
| 10:56:31 | stephenfin | Resolvable comments are indeed one of the things I'd like | |
| 10:56:38 | stephenfin | I like that in gdocs | |
| 10:58:06 | aspiers | also bear in mind those videos are 1.5 years old now | |
| 10:58:19 | stephenfin | yeah, so things will have moved on a lot since then | |
| 10:58:21 | aspiers | OpenStack really REALLY needs a Gerrit upgrade | |
| 10:58:45 | stephenfin | I imagine the infra folks are snowed under with the opendev migration but this sure would be a nice next step | |
| 10:58:47 | sean-k-mooney | aspiers: we used to have some downstream only changes | |
| 10:59:05 | sean-k-mooney | because we need to fix bug that had not merged upstream | |
| 10:59:07 | aspiers | stephenfin: yeah. it will happen | |
| 10:59:18 | stephenfin | big changes in 3.0 too, from the looks of things https://www.gerritcodereview.com/3.0.html | |
| 10:59:19 | sean-k-mooney | im not sure what is left to get upstream at this point | |
| 10:59:25 | aspiers | sean-k-mooney: if a patch to 2.13 hasn't landed by now, it never will | |
| 10:59:45 | sean-k-mooney | aspiers: yes which may mean we never update | |
| 10:59:59 | aspiers | sean-k-mooney: highly doubt that | |
| 11:00:20 | sean-k-mooney | there were one or two that we need to work at our scalse in the past the got push back which stop openstack updating | |
| 11:00:25 | aspiers | clarkb / corvus / fungi started working on it a long time ago | |
| 11:00:38 | sean-k-mooney | but i think most of that has gone upstream now | |
| 11:00:49 | aspiers | sean-k-mooney: yeah, we're not the biggest Gerrit user | |
| 11:01:03 | aspiers | there are several other huge scale installs | |
| 11:01:08 | aspiers | I met them all at the conference | |
| 11:01:19 | sean-k-mooney | i think we were 6 years ago when i started on openstack | |
| 11:01:21 | aspiers | and the others are all head in terms of HA too | |
| 11:01:30 | aspiers | ahead | |
| 11:01:38 | aspiers | Google is heavily investing in Gerrit | |
| 11:01:46 | aspiers | they have a team of 20 or so IIRC | |
| 11:02:13 | aspiers | stephenfin: 3.0 is more about ditching the dead stuff which everyone will have migrated off of by 2.16 | |