| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-04-16 | |||
| 21:39:15 | mriedem | yeah | |
| 21:39:18 | mriedem | until you archive | |
| 21:39:20 | mnaser | I don't remember the openstack api returning deleted records | |
| 21:39:24 | mnaser | but til I guess | |
| 21:39:34 | melwitt | I think that might be the only case when it does | |
| 21:39:38 | mriedem | there is no guarantee that you'll get results because it depends on how the cloud is setup to archive | |
| 21:39:42 | mnaser | of course | |
| 21:39:49 | mnaser | I just didn't know there was an actual api way | |
| 21:40:36 | mriedem | right, so the only way to hit this i think is to filter on all_tenants and deleted, which at least thankfully is admin-only | |
| 21:40:36 | melwitt | and I agree all of the options suck. I kind of liked the last option mriedem put on the bug but that doesn't help if the migration was only run once (and completed). or maybe the migration could hard delete the marker instance itself if it completed. still, if multiple runs are needed it sucks | |
| 21:40:40 | mriedem | could break some internal tools | |
| 21:40:44 | mriedem | but shouldn't break external users | |
| 21:43:08 | mnaser | tbh | |
| 21:43:18 | mnaser | all_tenants+deleted will probably hurt a lot in a bigger environment anyways | |
| 21:43:40 | mriedem | as in spanking your dbs? | |
| 21:44:30 | imacdonn | or just making a lot of output | |
| 21:45:07 | mnaser | both | |
| 21:45:12 | imacdonn | up to api.max_limit, I guess | |
| 21:45:15 | mnaser | hits the db hard, hits tons of apis hard too | |
| 21:45:26 | melwitt | yeah, was gonna say max_limit save the day | |
| 21:45:57 | mnaser | yeah we have "don't do it™" rule but that might be a good stop gap | |
| 21:51:05 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Exclude fake marker instance when listing servers https://review.openstack.org/653158 | |
| 21:51:09 | mriedem | well here is one option ^ | |
| 21:52:20 | imacdonn | the fact that the fake UUID is defined in virtual_interface makes it slightly more icky :/ | |
| 21:53:35 | mriedem | mnaser: btw, remind me to bring this up the next time you ask that the online data migrations use markers to be more efficient :) | |
| 21:53:50 | mnaser | mriedem: bahaha | |
| 21:54:03 | mnaser | I think I liked the idea jaypipes proposed of using different migration repos like keystone does | |
| 21:54:10 | mnaser | but I think that means you can't batch them | |
| 21:54:11 | melwitt | lol, touche | |
| 21:54:47 | dansmith | mnaser: the point of that suggestion was to *not* batch them | |
| 21:54:59 | dansmith | mnaser: it also doesn't really work well for translations we have to do in python, which is a lot of them | |
| 21:55:15 | mnaser | ah yes I see | |
| 21:55:18 | mnaser | its a lot of rebuilding data | |
| 21:55:19 | dansmith | it just helps us avoid re-running them on presumed idempotentcy | |
| 21:55:28 | mnaser | rather than drop column for add column | |
| 21:55:31 | dansmith | and we could solve that pretty easily with something else | |
| 21:55:39 | mnaser | a .... marker? | |
| 21:55:40 | mnaser | :-P | |
| 21:55:46 | dansmith | doesn't have to be in-band | |
| 21:55:57 | mriedem | speaking of online data migrations, want to drop this old one now? https://review.openstack.org/#/c/651001/ | |
| 21:56:03 | mnaser | yeah | |
| 21:56:06 | dansmith | just a feature flag sort of "I've converted all the flavors, stop asking me" | |
| 21:56:08 | dansmith | problem is, | |
| 21:56:13 | mriedem | we could also be better about following up and cleaning these things up | |
| 21:56:28 | dansmith | if you end up with some older services by accident, you create old data, and stop running the migrations afterwards with no way of cleaning them up | |
| 21:56:37 | dansmith | mriedem: yup | |
| 21:57:52 | mnaser | I guess something that could be neat is opt-in soft delete | |
| 21:57:56 | mnaser | or opt-out | |
| 21:58:32 | mnaser | that'd probably make life a lot simpler and those online data migrations won't hurt as much, as imho you probably rarely find a million (running) instance cloud, but much more likely to have million (in total) vms | |
| 21:58:33 | dansmith | opt-out from ever showing deleted would be okay, because it's equivalent (api-wise) to running archive in a tight loop in the background | |
| 21:58:54 | dansmith | but opt-out from the soft deleting at all is harder to do | |
| 21:59:19 | efried | aspiers: Sorry, I missed you again. Left comments on the SEV review. | |
| 21:59:27 | aspiers | thanks! | |
| 22:22:04 | mriedem | huh this is fun https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/server.html#server-create | |
| 22:22:13 | mriedem | --config-drive <config-drive-volume>|True | |
| 22:22:17 | mriedem | Use specified volume as the config drive, or ‘True’ to use an ephemeral drive | |
| 22:22:26 | mriedem | as far as i know, that's not at all how that parameter works in the API | |
| 22:24:21 | mriedem | dansmith: has nova ever supported passing a volume id for the config drive to server create? | |
| 22:24:31 | dansmith | nfi | |
| 22:24:42 | dansmith | but no, doesn't sound familiar to me | |
| 22:29:57 | mriedem | maybe some special sauce from 2012 https://review.openstack.org/#/c/3994/ | |
| 22:40:55 | imacdonn | mriedem: speaking of cleaning up after migrations .... I wonder if something should be done to handle those null security_groups rows that would have been created for anyone who has already run the migrations while instances exist ... | |
| 22:43:18 | mriedem | definitely maybe | |
| 22:43:33 | imacdonn | seems like the sort of thing that could come back to bite later :/ | |
| 22:49:59 | eandersson | Yo | |
| 22:50:01 | eandersson | https://github.com/openstack/nova/commit/35f49f403534e174578dcd1b9ab33daf6f14c3e8 | |
| 22:50:06 | eandersson | We need this in stable/rocky | |
| 22:50:28 | eandersson | ironic_url does not actually do anything in the ironicclient for Rocky | |
| 22:50:33 | eandersson | So ironic does not respect regions at all | |
| 22:50:43 | eandersson | TheJulia, ^ | |
| 22:56:14 | mriedem | eandersson: and that's due to https://review.openstack.org/#/c/359061/ in python-ironicclient in rocky? | |
| 22:57:38 | eandersson | actually it's odd | |
| 22:57:47 | eandersson | convert_keystoneauth_opts should fix that | |
| 22:58:22 | mriedem | i'm not sure how easy it is to backport that given it's dependent on ironicclient >= 2.4.0 | |
| 22:59:13 | eandersson | Yea - let me do a bit more research | |
| 23:00:47 | TheJulia | eandersson: I was just about to link tot he discussion http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2019-04-16.log.html#t2019-04-16T22:39:49 | |
| 23:00:57 | TheJulia | to the | |
| 23:14:48 | melwitt | mriedem: fyi, I got some more reviews on https://review.openstack.org/611974, even got a +1 from melissaml. should be good to go | |
| 23:17:40 | mriedem | i can't handle that at this late hour | |
| 23:17:49 | mriedem | but will star it | |
| 23:18:35 | openstackgerrit | Adam Spiers proposed openstack/nova-specs master: Re-approve AMD SEV support for Train https://review.openstack.org/641994 | |
| 23:21:13 | openstackgerrit | melanie witt proposed openstack/nova master: Fix assert in test_libvirt_info_scsi_with_unit https://review.openstack.org/653168 | |
| 23:21:35 | melwitt | mriedem: thanks. I got antsy with some of the pike changes going to the gate | |
| 23:37:09 | aspiers | kashyap: definitely need your input on https://review.openstack.org/#/c/641994/6/specs/train/approved/amd-sev-libvirt-support.rst@123 :) | |
| #openstack-nova - 2019-04-17 | |||
| 00:01:06 | openstackgerrit | Merged openstack/nova stable/rocky: Override the 'get' method in DriverBlockDevice class https://review.openstack.org/647651 | |
| 00:06:19 | alex_xu | francoisp_: already add it my review list, will try to reach it | |
| 00:25:59 | mriedem | cfriesen: jackding: wee stein regression https://bugs.launchpad.net/nova/+bug/1825020 | |
| 00:26:00 | openstack | Launchpad bug 1825020 in OpenStack Compute (nova) "resize of instance, that was booted from volume, trigger image size check then fails resize" [Undecided,New] | |
| 01:24:37 | melwitt | aspiers: something odd for your morrow http://eavesdrop.openstack.org/irclogs/%23openstack-placement/%23openstack-placement.2019-04-17.log.html#t2019-04-17T00:13:06 | |
| 01:26:01 | melwitt | tl;dr placement rejecting a PUT of the COMPUTE_NET_ATTACH_INTERFACE trait from nova compute. I don't understand how that could be happening | |
| 01:54:12 | openstackgerrit | Merged openstack/nova stable/pike: Fix functional tests for USE_NEUTRON https://review.openstack.org/649385 | |
| 01:54:20 | openstackgerrit | Merged openstack/nova stable/pike: Add functional regression test for bug 1669054 https://review.openstack.org/649386 | |
| 01:54:22 | openstack | bug 1669054 in OpenStack Compute (nova) pike "RequestSpec.ignore_hosts from resize is reused in subsequent evacuate" [Medium,In progress] https://launchpad.net/bugs/1669054 - Assigned to Matt Riedemann (mriedem) | |
| 02:06:03 | openstackgerrit | Merged openstack/nova stable/pike: Do not persist RequestSpec.ignore_hosts https://review.openstack.org/649387 | |
| 02:32:32 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Exclude fake marker instance when listing servers https://review.openstack.org/653158 | |
| 02:32:33 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add post-test wrinkle to list deleted servers before archive https://review.openstack.org/653131 | |
| 02:54:17 | openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs master: Spec for API inconsistency cleanup https://review.openstack.org/603969 | |
| 02:57:12 | mriedem | melwitt: regarding the change in behavior for quota usage calculations pre and post pike with counting, you might want to report a bug just to capture the change in behavior just so we can at least document it if we want outside of mailing list threads and code review comments | |
| 02:57:47 | mriedem | i was thinking something like if we fleshed out the quota docs reference page we could / should the big shift in design with counting in pike but could also list that as a known issue | |
| 02:58:21 | mriedem | https://docs.openstack.org/nova/latest/user/quotas.html | |