| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-03-18 | |||
| 14:49:55 | mriedem | lbragstad: a question and some nits in https://review.openstack.org/#/c/643960/ | |
| 14:50:57 | lbragstad | awesome - i'll take a look | |
| 14:53:35 | kashyap | mriedem: So, on cache mode change for Nova guests: (a) The existing Nova help text is broken: it claims "writethrough" as the default, it is not the case; (b) My patch doesn't change the _default_ -- see my last comment here: https://review.openstack.org/#/c/641981/7 | |
| 15:00:15 | kashyap | It seems you've added that help text from an IBM help doc (commit: 3d9a76bd71159a3e8ce0acdb27ec76381b1024fc) | |
| 15:00:47 | mriedem | kashyap: yes, i fleshed out the help from libvirt and ibm help docs because before that it was a one-line unhelpful help string | |
| 15:01:11 | kashyap | mriedem: Yeah, I see your intention was good. I'm trying to find the new URL of that IBM doc | |
| 15:01:36 | kashyap | Because QEMU's default has been 'writeback' (for guests) for ages; not sure why the IBM doc claimed it to be 'writethrough' | |
| 15:02:05 | mdbooth | Can anybody tell me which package provides the 'openssl' binary on Ubuntu? | |
| 15:02:54 | mriedem | umm, openssl? | |
| 15:03:23 | mdbooth | mriedem: That's what it's called on Fedora. Just wanted to ensure it's not called something else in foreign parts. | |
| 15:03:29 | mriedem | http://lmgtfy.com/?q=ubuntu+openssl+package | |
| 15:04:00 | kashyap | mriedem: Hehe, I seem to have already debunked the IBM doc 2014! -- https://www.redhat.com/archives/libvirt-users/2014-August/msg00060.html (Behavior of disk caching with qcow2 disks | |
| 15:04:46 | mdbooth | Or however that translates when you make it brown | |
| 15:07:14 | openstackgerrit | Matthew Booth proposed openstack/nova master: Add missing test bindep on openssl https://review.openstack.org/644238 | |
| 15:07:14 | openstackgerrit | Matthew Booth proposed openstack/nova master: Remove eventlet hub workaround for monotonic clock https://review.openstack.org/644237 | |
| 15:16:56 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Use 'writeback' QEMU cache mode for Nova instances https://review.openstack.org/641981 | |
| 15:16:56 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: smbfs: Use 'writeback' QEMU cache mode https://review.openstack.org/643377 | |
| 15:16:56 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: vzstorage: Use 'writeback' QEMU cache mode https://review.openstack.org/643376 | |
| 15:19:13 | openstackgerrit | Gorka Eguileor proposed openstack/nova master: Fix unnecessary locking when connecting volumes https://review.openstack.org/614190 | |
| 15:20:18 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Use 'writeback' QEMU cache mode when 'none' is not viable https://review.openstack.org/641981 | |
| 15:20:35 | kashyap | bauzas: mriedem: efried: The above patch doesn't need a rel eng; we aren't changing the default - I updated the commit message to reflect that. | |
| 15:21:27 | kashyap | (And fixed the wrong info in the Nova conf doc, which came in via another misinfo from IBMs's doc, which disappeared) | |
| 15:23:37 | kashyap | Huh, let me reorder them patches correctly. Sorry for the noise. | |
| 15:25:29 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: vzstorage: Use 'writeback' QEMU cache mode https://review.openstack.org/643376 | |
| 15:25:29 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Use 'writeback' QEMU cache mode when 'none' is not viable https://review.openstack.org/641981 | |
| 15:25:30 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: smbfs: Use 'writeback' QEMU cache mode https://review.openstack.org/643377 | |
| 15:27:26 | gibi | melwitt, mriedem: the bandwidth documentation patch for neutron is ready to review https://review.openstack.org/#/c/640390 | |
| 15:30:04 | mriedem | gibi: ok, should probably get mlavalle to review that since he worked on it | |
| 15:32:12 | gibi | mriedem: sure | |
| 15:32:26 | gibi | I just wanted to note that it is not wip any more | |
| 15:54:18 | tssurya | thanks gmann | |
| 16:16:52 | kashyap | efried: Just to tie-up the loose end: your observation was correct earlier -- self._disk_cachemode does _not_ get fed in by the CONF.libvirt.disk_cachemodes | |
| 16:20:24 | kashyap | mdbooth: Thanks for the review, again. It's like a whack-a-mole. Just when I think I fixed all occurrences... | |
| 16:21:09 | mriedem | aspiers: efried: i'm doing some testing in devstack with the compute capabilites as traits stuff and i'm not seeing where / when a sighup is needed https://review.openstack.org/#/c/538498/22/releasenotes/notes/driver-capabilities-to-traits-152eb851cd016f4d.yaml | |
| 16:21:46 | mdbooth | kashyap: Hehe. | |
| 16:22:14 | mdbooth | kashyap: Incidentally, if at all possible can you avoid rebasing? | |
| 16:23:09 | kashyap | mdbooth: Sure. I was fixing commit messages by re-ordering patches, and forgot to put them back in the same order one of the times | |
| 16:23:28 | mdbooth | Ack | |
| 16:23:29 | kashyap | (Once I needed a genuine rebase due to that "compress" flag landing) | |
| 16:24:19 | tssurya | mriedem: whenever you have time and if you remember, do you know why we didn't go ahead with https://review.openstack.org/#/c/218975 ? I can't find it in the history in case there was any opposition | |
| 16:24:47 | mdbooth | kashyap: Did you see your release note build failure, btw? | |
| 16:25:21 | kashyap | mdbooth: I didn't, will look in the AM. Have to bike to my Dutch class shortly, and stay alert for 3 1/2 hours... | |
| 16:25:32 | mdbooth | kashyap: That's on the bottom patch, so you're going to have to beg for your +2s back. | |
| 16:25:39 | mriedem | tssurya: go ahead with that patch or the alternative discussed between myself and alaski? | |
| 16:25:57 | tssurya | go ahead with that patch I mean | |
| 16:26:03 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Prepare _heal_allocations_for_instance for nested allocations https://review.openstack.org/637954 | |
| 16:26:03 | tssurya | to add the config | |
| 16:26:03 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor _heal_allocations_for_instance to make place for port healing https://review.openstack.org/637953 | |
| 16:26:04 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: cache neutron ports in heal allocation https://review.openstack.org/638207 | |
| 16:26:04 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: nova-manage: heal port allocations https://review.openstack.org/637955 | |
| 16:26:07 | mriedem | see the comments between myself and laski :) | |
| 16:26:08 | kashyap | Thanks for the heads-up. mdbooth: And yes, I'll add a rel note. | |
| 16:28:01 | tssurya | mriedem: shoot my bad sorry :) | |
| 16:29:19 | mriedem | tssurya: are you hitting an issue with baremetal nodes? | |
| 16:29:46 | tssurya | mriedem: the power sync stuff https://review.openstack.org/#/c/636132/ | |
| 16:30:04 | tssurya | working on it since we need it downstream | |
| 16:30:10 | tssurya | so was going through the history | |
| 16:30:24 | mriedem | ok you're aware of https://github.com/openstack/nova/commit/19cb8280232fd3b0ba0000a475d061ea9fb10e1a right? | |
| 16:30:40 | tssurya | yea | |
| 16:44:48 | cfriesen | process question...when does the stein branch get created? | |
| 16:46:38 | edleafe | cfriesen: usually when RC1 is cut | |
| 16:53:26 | mriedem | cfriesen: iow thursday | |
| 16:54:04 | cfriesen | thx, was just looking at the release timeline. | |
| 16:54:44 | efried | mriedem: Set your association refresh interval to 0 and you'll need that SIGHUP | |
| 16:55:03 | efried | mriedem: I reckon we're deprecating that option soon | |
| 16:55:34 | efried | I think we maybe wanted to give CERN a little while to play first | |
| 16:55:34 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove put_allocations() from report client https://review.openstack.org/644292 | |
| 16:56:35 | mdbooth | Eurgh: http://logs.openstack.org/52/626952/5/check/openstack-tox-py37/47f5826/job-output.txt.gz | |
| 16:56:57 | mdbooth | eventlet monkey patching for command line tools which import nova? | |
| 16:57:08 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add docs for compute capabilities as traits https://review.openstack.org/644293 | |
| 16:57:12 | mriedem | efried: oh.....well i guess i need to update this then ^ but that wasn't mentioned in the reno | |
| 16:57:44 | mdbooth | It really would be better to monkey patch at specific entry points :/ | |
| 16:59:12 | efried | mriedem: hm, the default there is five minutes, was there any science behind "60 seconds" or was that anecdotal? | |
| 17:01:07 | mriedem | anecdotal | |
| 17:01:11 | mriedem | i'm trying again now | |
| 17:01:13 | mriedem | with resource_provider_association_refresh=0 | |
| 17:03:09 | mdbooth | What's api-paste.ini used for, and what are the implications of making changes there? | |
| 17:04:58 | cdent | mdbooth: it configures middleware used by the api | |
| 17:05:21 | cdent | the difficulty with make changes there is that it is in that hybrid realm of config file and also stuff that's required | |
| 17:05:38 | mdbooth | cdent: So changes to the one we have in tree would have deployment implications? | |
| 17:05:44 | cdent | yes | |
| 17:05:48 | mdbooth | Eurgh | |
| 17:05:53 | cdent | However, we have changed it in the past | |
| 17:05:56 | cdent | so it's not impossible | |
| 17:06:23 | mdbooth | I basically wanted to airlift it into a module which isn't called __init__.py | |
| 17:06:24 | cdent | there's been talk of trying to get rid of it for a long time (similar to policy-defaults-in-code) | |
| 17:06:37 | mriedem | rpms should mark that file as config so updates shouldn't overwrite it | |
| 17:06:49 | mdbooth | However, that would change a bunch of object paths, and therefore require changes in api-paste.ini | |
| 17:07:18 | mriedem | api-paste.ini at this point is mostly just a relic | |
| 17:07:20 | cdent | mdbooth: yeah, this is one of the places I fell down when doing my own roam through __init__ files | |
| 17:07:29 | mdbooth | Or... I could just move monkey patching to the top of it and leave it there... | |
| 17:07:31 | mriedem | when nova and openstack in general were more open to extension points | |
| 17:09:15 | mdbooth | My latest version of the monkey patching change moves monkey patching into nova/__init__.py, and also adds a couple of assertions which will explode if you've imported libraries with known problems before monkey patching | |
| 17:09:27 | mdbooth | Which sounded great, until I realised that command line tools also import nova | |
| 17:09:41 | mdbooth | testing, ftw | |
| 17:10:15 | mdbooth | So now I'm looking again at monkey patching only for certain entry points | |
| 17:10:38 | mdbooth | But we can't monkey patch lower than nova/api/openstack/... because __init__.py imports the world | |
| 17:10:59 | cdent | ayup | |
| 17:11:36 | mdbooth | I was hoping to move that out of the way, but that looks depressingly involved | |
| 17:21:42 | mriedem | efried: hmm, what am i missing with trying to hup n-cpu in devstack: sudo systemctl kill -s HUP devstack@n-cpu.service | |