Earlier  
Posted Nick Remark
#openstack-nova - 2019-03-07
15:40:36 mriedem sure
15:40:41 mriedem i'm targeting to get to https://review.openstack.org/#/c/633351/
15:49:33 jaypipes +1
15:52:19 bauzas mriedem: thanks for giving us the path to the legacy job for comparing, it helps
15:52:27 bauzas context being https://review.openstack.org/#/c/640181
15:53:15 openstackgerrit Dan Smith proposed openstack/nova master: Add user_id field to InstanceMapping https://review.openstack.org/633350
15:53:15 openstackgerrit Dan Smith proposed openstack/nova master: Add user_id column to the instance_mappings table https://review.openstack.org/633349
15:53:16 openstackgerrit Dan Smith proposed openstack/nova master: Add online data migration for populating user_id https://review.openstack.org/633351
15:53:16 openstackgerrit Dan Smith proposed openstack/nova master: Populate InstanceMapping.user_id during migrations and schedules https://review.openstack.org/638574
15:54:19 bauzas mriedem: I guess you just copy/pasted the job definition YAML ?
15:54:57 bauzas or do I really need to do my job and diff the files ?
15:56:29 sean-k-mooney luksky: sorry i was on a call. im just runnig to another one but you only need to run discover hosts wehn you add new nodes
15:57:07 efried mriedem, bauzas: done
15:57:18 sean-k-mooney luksky: and you only need to run nova-manage cellv2 discover_hosts on the contoler nodes not on the compute nodes
16:02:46 mriedem dansmith: i just went through https://review.openstack.org/#/c/633351/24 again while you rebased, see if my comments make sense
16:03:05 mriedem bauzas: yes i copied the playbook
16:03:10 mriedem and changed the name/description
16:03:53 bauzas mriedem: yeah so blame on you, you forced me to diff
16:04:19 jaypipes dansmith: sorry if I wasn't clear about the multi-column index earlier.
16:04:49 jaypipes dansmith: I've added a comment to the revision you just pushed. If we go with a (user_id, project_id) multi-column index, there's no need for a single-column (user_id) index.
16:05:08 dansmith jaypipes: oh I was sure you said to add both
16:06:08 jaypipes dansmith: tried to explain in that comment, sorry. if you added a (project_id, user_id) index, you'd also want a (user_id) single-column index.
16:06:27 dansmith wait, what?
16:06:39 dansmith oh, it matters the ordering of them?
16:06:45 jaypipes dansmith: yep
16:06:49 dansmith jesus
16:06:52 jaypipes :)
16:06:58 dansmith so, surely these will also be looked up via project only right?
16:07:06 dansmith oh, but we already have one on project
16:07:07 dansmith okay
16:07:12 jaypipes yes, but there is already a single-column on (project_id)
16:07:16 jaypipes single-column index
16:07:18 jaypipes yeagh
16:08:05 jaypipes dansmith: good article on the concepts here: https://www.vividcortex.com/blog/the-left-prefix-index-rule
16:08:48 luksky <sean-k-mooney>: thank You
16:08:52 dansmith jaypipes: don't push your progressive indexes on me
16:09:03 jaypipes heh :)
16:09:12 jaypipes dansmith: sorry for the misunderstanding
16:09:32 dansmith I guess I have to update this test now and fix the nova-manage too
16:14:42 openstackgerrit Balazs Gibizer proposed openstack/nova master: Use Selection object to fill request group mapping https://review.openstack.org/638711
16:20:36 mriedem efried: +1 thanks
16:21:25 mriedem stephenfin: this has you written all over it https://review.openstack.org/#/c/640181/
16:21:56 stephenfin sure thing
16:25:46 efried mriedem: updated with more information (mostly copy/paste) in the commit message.
16:27:25 openstackgerrit Matt Riedemann proposed openstack/nova master: Allow utime call to fail on qcow2 image base file https://review.openstack.org/641315
16:27:41 mriedem mdbooth: do you fancy addressing review comments on https://review.openstack.org/#/c/641315/ ?
16:27:51 mriedem i'd like to make sure people are on board with that before approving your revert
16:28:45 mriedem efried: beautiful
16:28:58 openstackgerrit Dan Smith proposed openstack/nova master: Add user_id column to the instance_mappings table https://review.openstack.org/633349
16:28:59 openstackgerrit Dan Smith proposed openstack/nova master: Add user_id field to InstanceMapping https://review.openstack.org/633350
16:29:00 openstackgerrit Dan Smith proposed openstack/nova master: Populate InstanceMapping.user_id during migrations and schedules https://review.openstack.org/638574
16:29:01 openstackgerrit Dan Smith proposed openstack/nova master: Add online data migration for populating user_id https://review.openstack.org/633351
16:29:19 mriedem cdent: regarding the placement extraction forum session proposal in https://etherpad.openstack.org/p/DEN-train-nova-brainstorming
16:29:38 mriedem cdent: i'm going to submit that and also propose you as co-presentor or whatever, ok?
16:33:08 mdbooth mriedem: Yep
16:34:06 mriedem mdbooth: thanks
16:34:06 mdbooth mriedem: I did wonder actually if we should confine it further to EPERM
16:34:34 mriedem maybe ask neil since he had the recreate
16:34:44 mdbooth ack
16:36:50 cdent mriedem: yeah, that's fine
16:36:59 mdbooth EACCES, not EPERM
16:44:25 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Fix nits in remote console guide https://review.openstack.org/641098
16:44:26 openstackgerrit Stephen Finucane proposed openstack/nova master: conf: Rename 'configuration drive' to 'config drive' https://review.openstack.org/641723
16:44:26 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Rework all things metadata'y https://review.openstack.org/640730
16:52:17 openstackgerrit Dan Smith proposed openstack/nova master: Add online data migration for populating user_id https://review.openstack.org/633351
16:53:05 openstackgerrit Matt Riedemann proposed openstack/nova master: Add online data migration for populating user_id https://review.openstack.org/633351
16:53:10 mriedem +2
16:53:16 mriedem dansmith: thanks for reving those
16:53:24 mriedem jaypipes: i'm +2 on the first 4 in that series now
16:53:30 dansmith aye
16:54:06 jaypipes aye aye. just wrapping up a meeting
17:10:09 openstackgerrit Dan Smith proposed openstack/nova master: Add online data migration for populating user_id https://review.openstack.org/633351
17:15:30 mriedem johnthetubaguy: are you going to be in denver? i was considering proposing a forum session to get people together about your unified limits spec https://review.openstack.org/#/c/602201/
17:15:51 mriedem even if you're not, i assume melwitt and/or jaypipes and/or lbragstad can help run that since i'm not qualified to run that session
17:16:02 mriedem but i don't know if jaypipes will be at the forum...
17:16:12 mriedem given his too cool for schoolness
17:16:52 lbragstad i haven't put together my schedule yet, but i'll try and be there for that
17:17:21 jaypipes mriedem: I will
17:17:35 jaypipes mriedem: can one be too uncool for school?
17:17:43 jaypipes mriedem: cuz I would be that.
17:18:13 mriedem that question is too philosophical for me to think about right now
17:18:43 mriedem dansmith: i'm sure you'd like to propose a "nova at the edge?!" forum session
17:18:50 mriedem you could even dress up like the edge
17:18:53 dansmith mriedem: I'm sure you're wrong
17:19:21 mriedem what if, we do a reenactment of the movie 'the edge' from the 90s though?
17:19:28 mriedem i'll be alec baldwin
17:19:53 dansmith :|
17:20:04 mriedem we need an anthony hopkins and a bear
17:20:24 mriedem bauzas: ...
17:20:43 dansmith https://www.youtube.com/watch?v=Dn8-4tjPxD8
17:20:55 bauzas hum, I can wait for shaving
17:21:04 mriedem https://www.dailymotion.com/video/x3s9vt2
17:21:12 dansmith keep thinking I need to be working that in .. the U2 edge thing is already played
17:21:34 mriedem if we're going to talk about stevie nicks i can't let the fajita roundup go unnoticed
17:26:42 aspiers kashyap (or anyone): need advice on how to reuse some code from libvirt.driver._get_machine_type() inside libvirt.host
17:27:13 kashyap aspiers: Afraid, I'm totally spent for the day :-( And about to go for some air and food
17:27:24 aspiers kashyap: OK maybe someone else can help
17:27:40 kashyap If it's on a particular review, think out loud. I'll see tomm.
17:27:52 aspiers no, it's on how to write my code
17:28:17 aspiers I want to reuse these two lines https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L4262

Earlier   Later