| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-03-06 | |||
| 18:43:01 | melwitt | mriedem: ok, thanks. I just went through it, also lgtm | |
| 18:45:22 | mriedem | melwitt: the rebuild from cell0 stuff could probably use more eyes but i've already been over it in parts and continued to find issues, so i'm just not really comfortable with pushing for that on the last day | |
| 18:46:01 | openstackgerrit | Merged openstack/nova master: Warn if group_policy is missing from flavor https://review.openstack.org/641289 | |
| 18:46:30 | melwitt | mriedem: got it | |
| 18:46:47 | openstackgerrit | sean mooney proposed openstack/nova master: Allow per-port modification of vnic_type and profile https://review.openstack.org/607365 | |
| 18:46:47 | openstackgerrit | sean mooney proposed openstack/nova master: Sep methods to free claimed and allocated devs https://review.openstack.org/616120 | |
| 18:46:48 | openstackgerrit | sean mooney proposed openstack/nova master: SR-IOV Live migration indirect port support https://review.openstack.org/620115 | |
| 18:46:48 | openstackgerrit | sean mooney proposed openstack/nova master: Add get_instance_pci_request_from_vif https://review.openstack.org/619929 | |
| 18:46:49 | openstackgerrit | sean mooney proposed openstack/nova master: libvirt: auto detach/attach sriov ports on migration https://review.openstack.org/629589 | |
| 18:46:56 | dansmith | melwitt: what's the party line on the privsep stuff? | |
| 18:47:21 | sean-k-mooney | stephenfin: ^ they are all rebased and typos adressed. | |
| 18:47:56 | sean-k-mooney | stephenfin: i tested it before the rebase so it should all be working but ill restack and test again | |
| 18:49:04 | melwitt | dansmith: I don't know the details but from earlier chat it looked like there's a lot of questions/issues. I'll re-read | |
| 18:49:29 | dansmith | melwitt: well, there are questions on a class of them, but that's a small subset | |
| 18:49:48 | dansmith | melwitt: re-ordering the patches would free up a bunch that are already +W | |
| 18:50:07 | dansmith | I'm mostly interested in whether or not we care about the current half-baked situation we're in (I do) | |
| 18:50:28 | dansmith | they're not fixes, so kinda seem like they should go in front of FF to me, and they're not no-risk | |
| 18:50:47 | dansmith | it'd be nice to make some more progress, especially since mikal just updated them (IMHO) | |
| 18:51:12 | sean-k-mooney | there is what 7-10 left | |
| 18:51:13 | melwitt | dansmith: ah, I see. I agree they should go in front of FF and I think it would be good to merge the straightforward ones by ore-ordering | |
| 18:52:04 | dansmith | melwitt: okay I hadn't seen you in that stack much so wasn't sure if you were ignoring them for specific reasons or just because they're not interesting.. maybe a ptl statement on the bottom one about "let's try to get a chunk of these merged before FF tomorrow" then ? | |
| 18:52:10 | sean-k-mooney | oh 18 but 3 are +w and could merge if we reorder | |
| 18:52:30 | dansmith | I guess I could also reorder a few for mikal and we could do some before he wakes up even | |
| 18:52:47 | melwitt | dansmith: no, I recently went in there and approved one, which unblocked a small stack of them. haven't been ignoring them purposely | |
| 18:52:51 | dansmith | sean-k-mooney: yeah and more proabably I just stopped walking up the stack | |
| 18:52:58 | dansmith | okay | |
| 18:53:15 | dansmith | lemme reorder them and see what I can free up easily | |
| 18:53:20 | eandersson | mriedem, the soft-anti-affinity issue was because the keystone endpoint was still v2/ and not v2.1/ | |
| 18:53:23 | eandersson | just fyi | |
| 18:54:01 | mriedem | melwitt: why create a new test class for this? https://review.openstack.org/#/c/633350/12/nova/tests/functional/db/test_instance_mapping.py | |
| 18:54:04 | melwitt | dansmith: I think they're valuable and want to get what progress we can there. I'll add a comment | |
| 18:54:20 | mriedem | eandersson: ah..yeah we even have a troubleshooting entry for that in our docs from when oath upgraded to ocata | |
| 18:54:43 | mriedem | eandersson: https://docs.openstack.org/nova/latest/admin/support-compute.html#requested-microversions-are-ignored | |
| 18:54:55 | mriedem | eandersson: heh for that exactly same problem :) | |
| 18:55:04 | mriedem | *exact | |
| 18:55:08 | eandersson | It was just an odd one, as it worked before. =] | |
| 18:55:31 | eandersson | Plus does not help that we haven't had a weekend yet :p | |
| 18:55:40 | eandersson | Upgrading from Mitaka to Rocky... not easy lol | |
| 18:56:11 | melwitt | mriedem: don't have a great reason. at first, I had modeled it after the bdm uuid addition/migration, which used a separate class for the test cases. and I wasn't sure if it was sufficiently different from the rest of the tests and should be separated or not. I can lump it with the rest, no problem | |
| 18:56:14 | eandersson | Moving to Cells V2 has been super smooth so far thou | |
| 18:56:29 | mriedem | eandersson: that's good to hear | |
| 18:56:34 | mriedem | the cells thing that is | |
| 18:56:38 | eandersson | :p | |
| 18:56:50 | eandersson | We still have a lot of unaccounted performance issues that we are troubleshooting. | |
| 18:56:52 | mriedem | too bad you're late to submit a "upgrading from mitaka to rocky at blizzzzard" talk at the summit | |
| 18:56:57 | eandersson | haha | |
| 18:57:33 | mriedem | its not just cells v2 you're biting off, it's also placement | |
| 18:57:45 | mriedem | so you might be hitting some perf issues due to not scaling that out enough, | |
| 18:57:51 | mriedem | or nova-compute being way too chatty | |
| 18:58:03 | eandersson | It actually looks pretty good so far on the nova side, but something is talking to Neutron a lot more. | |
| 18:58:24 | dansmith | yeah that shouldn't be cells-related I don't think | |
| 18:58:30 | eandersson | Yea - don't think so either | |
| 18:58:33 | mriedem | are you doing a lot of live migrations from rocky? | |
| 18:58:35 | dansmith | eandersson: glad to hear things aren't terrible :) | |
| 18:58:49 | eandersson | We haven't dared to test live migration yet :p | |
| 18:59:13 | mriedem | ok because the only big new neutron-related thing in rocky i can think of is https://specs.openstack.org/openstack/nova-specs/specs/rocky/implemented/neutron-new-port-binding-api.html | |
| 18:59:28 | dansmith | eandersson: are you trying to move to multiple cells or just upgrading to the point where it's required for a single one? | |
| 18:59:35 | eandersson | single one for now | |
| 18:59:41 | dansmith | gotcha | |
| 18:59:48 | eandersson | we want to move to multiple cells | |
| 18:59:52 | eandersson | but wasn't a priority | |
| 19:00:17 | dansmith | one thing at a time, for sure | |
| 19:00:29 | melwitt | mriedem: replied on the review. I think maybe I was thinking since it's special and temporary handling, maybe keep it separate for more obvious removal later. but none of that is strong reasoning. just wasn't sure what to do | |
| 19:01:51 | melwitt | eandersson: ++ also glad to hear things aren't terrible with cells :P | |
| 19:08:25 | mriedem | melwitt: there is something that needs fixing here https://review.openstack.org/#/c/638574/ | |
| 19:08:56 | melwitt | mriedem: ok, on it | |
| 19:09:45 | openstackgerrit | Dan Smith proposed openstack/nova master: Move cleaning conntrack to privsep. https://review.openstack.org/624594 | |
| 19:09:45 | openstackgerrit | Dan Smith proposed openstack/nova master: Move arping to privsep. https://review.openstack.org/624593 | |
| 19:09:46 | openstackgerrit | Dan Smith proposed openstack/nova master: Cleanup the exec_ebtables code a little. https://review.openstack.org/635434 | |
| 19:09:46 | openstackgerrit | Dan Smith proposed openstack/nova master: Move killing processes to privsep. https://review.openstack.org/635432 | |
| 19:09:47 | openstackgerrit | Dan Smith proposed openstack/nova master: Privsepify ipv4 forwarding enablement. https://review.openstack.org/635431 | |
| 19:09:47 | openstackgerrit | Dan Smith proposed openstack/nova master: Move slight bonkers IP management to privsep. https://review.openstack.org/624592 | |
| 19:09:48 | openstackgerrit | Dan Smith proposed openstack/nova master: Privsep the ebtables modification code. https://review.openstack.org/635435 | |
| 19:09:48 | openstackgerrit | Dan Smith proposed openstack/nova master: Move FP device creation and deletion to privsep. https://review.openstack.org/635433 | |
| 19:09:49 | openstackgerrit | Dan Smith proposed openstack/nova master: Move iptables rule fetching and setting to privsep. https://review.openstack.org/636508 | |
| 19:09:49 | openstackgerrit | Dan Smith proposed openstack/nova master: Move adding vlans to interfaces to privsep. https://review.openstack.org/635436 | |
| 19:09:50 | openstackgerrit | Dan Smith proposed openstack/nova master: Move router advertisement daemon restarts to privsep. https://review.openstack.org/639281 | |
| 19:09:50 | openstackgerrit | Dan Smith proposed openstack/nova master: Move dnsmasq restarts to privsep. https://review.openstack.org/639280 | |
| 19:09:51 | openstackgerrit | Dan Smith proposed openstack/nova master: Move setting of device trust to privsep. https://review.openstack.org/639283 | |
| 19:09:51 | openstackgerrit | Dan Smith proposed openstack/nova master: Move calls to ovs-vsctl to privsep. https://review.openstack.org/639282 | |
| 19:09:52 | openstackgerrit | Dan Smith proposed openstack/nova master: Cleanup the _execute shim in nova/network. https://review.openstack.org/639581 | |
| 19:09:52 | openstackgerrit | Dan Smith proposed openstack/nova master: Move final bridge commands to privsep. https://review.openstack.org/639580 | |
| 19:09:53 | openstackgerrit | Dan Smith proposed openstack/nova master: Cleanup no longer required filters and add a release note. https://review.openstack.org/639826 | |
| 19:09:53 | openstackgerrit | Dan Smith proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438 | |
| 19:10:00 | mriedem | makes you feel like a BIG MAN | |
| 19:10:31 | sean-k-mooney | :) | |
| 19:11:05 | melwitt | lol. | |
| 19:12:07 | sean-k-mooney | efried: do you want the good news or the bad news | |
| 19:12:39 | mriedem | i got you a puppy on the way home from work, | |
| 19:12:39 | dansmith | I have some draft comments on one of melwitt's in that stack too, I need to go find and finish that | |
| 19:12:43 | mriedem | but then i got hungry and ate it | |
| 19:13:12 | dansmith | melwitt: okay bottom four of that privsep set are +W | |
| 19:13:23 | dansmith | assuming I didn't break anything.. the rebases were not bad, but not trivial | |
| 19:13:38 | melwitt | dansmith: cool, thanks for doing that | |
| 19:13:52 | melwitt | I made a comment on the old bottom patch to explain | |
| 19:13:52 | dansmith | aye | |
| 19:13:57 | dansmith | oh okay | |
| 19:14:07 | sean-k-mooney | efried: the good news is your change passed the fucntional job that runs the ironic api test and and python-ironclinet was installed from git | |
| 19:14:48 | sean-k-mooney | efried: the bad news is the tempest job that ran teh senario tests failed with this error http://logs.openstack.org/21/641421/2/check/nova-ironic-client-tempest/8faf490/controller/logs/screen-n-cpu.txt.gz?level=TRACE#_Mar_06_18_04_20_985307 | |
| 19:17:27 | sean-k-mooney | efried: anyway you should be able to use that to test your chagnes looks like your just need to set the ironic api version | |