| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-02-28 | |||
| 15:40:48 | jangutter | cfriesen: because the computer likes repetition because the computer likes repetition (paranoia reference) | |
| 15:42:11 | jangutter | cfriesen: I found this ( https://docs.openstack.org/project-team-guide/dependency-management.html ) a while ago and I'm not 100% sure. | |
| 15:42:13 | openstackgerrit | Chris Friesen proposed openstack/nova master: Add emulated TPM support to Nova https://review.openstack.org/631363 | |
| 15:42:14 | openstackgerrit | Chris Friesen proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.openstack.org/639934 | |
| 15:44:08 | sean-k-mooney | cfriesen: proably pinned in upperconstraitns | |
| 15:44:25 | cfriesen | sean-k-mooney: turns out I missed updating lower_constraints | |
| 15:44:32 | sean-k-mooney | oh ok | |
| 15:45:27 | sean-k-mooney | i chekcked that but you had already fixed it when i did i guess | |
| 15:46:37 | cfriesen | sean-k-mooney: don't know if you saw my comment last night....this patch series ^ is working as far as local resize with emulated TPM. | |
| 15:46:51 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove port allocation during detach https://review.openstack.org/622421 | |
| 15:48:27 | sean-k-mooney | cfriesen: im reworking https://review.openstack.org/#/c/602432/ but that is next on my list | |
| 15:49:05 | cfriesen | cool. I'm working on adding more unit tests to bring it up to the proper level. | |
| 15:54:18 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add remove_resources_from_instance_allocation to report client https://review.openstack.org/639653 | |
| 15:54:19 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove port allocation during detach https://review.openstack.org/622421 | |
| 15:55:04 | gibi | mriedem, jaypipes: the bottom two patches are up to date ^^ (and I think they are ready to fly) | |
| 15:55:32 | mriedem | looking | |
| 15:55:37 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Test live migration with config drive https://review.openstack.org/567860 | |
| 16:01:31 | gibi | mriedem: regarding filing InstancePCIRequest.requester_id with flavor.flavorid or network_id . Which one do you prefere? Fill it properly (e.g. use flavor.flavorid) or keep it None and fill it only when it is needeD? | |
| 16:02:20 | mriedem | gibi: i haven't yet looked at how that is used, | |
| 16:02:33 | mriedem | and i saw avolkov asked about a requester_type, | |
| 16:03:02 | mriedem | my one worry is that we have something in that field which isn't a port_id, but we assume it's a port_id and then something fails later because it turns out it was a flavor or network | |
| 16:03:26 | mriedem | so maybe it's better to not set it for flavor/network in order to avoid confusion about when it can be used | |
| 16:04:12 | mriedem | i guess you are future-proofing for when flavor resources are in a RequestGroup in the RequestSpec? | |
| 16:04:22 | gibi | mriedem: InstancePCIRequest.requester_id is matched against RequestGroup.requester_id | |
| 16:04:35 | gibi | mriedem: in https://review.openstack.org/#/c/623543/34/nova/compute/manager.py | |
| 16:05:03 | gibi | so it is a bit of future proofing yes, but now I feel it would be better to keep it empty | |
| 16:05:29 | gibi | so I think I will remove the flavor.id and netwokr_id bits | |
| 16:05:33 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use aggregate_add_host in nova-manage https://review.openstack.org/640080 | |
| 16:05:40 | efried | mriedem: This bud's for you ^ | |
| 16:05:45 | efried | ...bud | |
| 16:06:27 | mriedem | gibi: that is probably safest | |
| 16:06:31 | efried | mriedem: LMK if you're on board with it conceptually and I'll fix up the testes. | |
| 16:06:36 | gibi | mriedem: OK, cool | |
| 16:07:16 | efried | mriedem: in particular, if you think I should split out the aggregate_add_host signature change. | |
| 16:07:21 | mriedem | gibi: worst case is we'd set the InstancePCIRequest.request_id to a flavor.flavorid (which makes sense if the pci request comes via the flavor), and then we try finding the matching request group mapping and it's not found, so we just wasted time looking for something that we never setup | |
| 16:07:37 | gibi | mriedem: agreed | |
| 16:07:40 | mriedem | well, i guess worst case is ^ and we log something like "couldn't find mapping" or raise or something | |
| 16:07:45 | gibi | mriedem: it was to early to add it | |
| 16:07:51 | mriedem | you're ahead of your time | |
| 16:07:55 | gibi | yeah | |
| 16:08:22 | mriedem | efried: i can't digest that right now | |
| 16:08:34 | efried | mriedem: No urgency | |
| 16:24:55 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Record requester in the InstancePCIRequest https://review.openstack.org/625310 | |
| 16:25:38 | gibi | jaypipes, mriedem: and the third one is up-to-date as well | |
| 16:29:28 | mriedem | gibi: +2 on https://review.openstack.org/#/c/622421/ - nits inline so it's up to you if you want to address those quick or follow up | |
| 16:30:04 | gibi | mriedem: I think I can respin it real quick | |
| 16:33:58 | gibi | mriedem: FYI ALLOCATIN for https://review.openstack.org/#/c/622421/32/nova/network/neutronv2/api.py@1734 need a rebase first. | |
| 16:34:52 | melwitt | o/ | |
| 16:35:49 | mriedem | gibi: yup | |
| 16:35:57 | mriedem | gibi: i'll fast re-approve your bottom change | |
| 16:36:04 | gibi | mriedem: coolio | |
| 16:36:05 | mriedem | cfriesen: comments in https://review.openstack.org/#/c/635350/ | |
| 16:36:50 | cfriesen | okay, will do | |
| 16:38:56 | mriedem | edleafe: i'm glad you picked up on the az name struggle in https://review.openstack.org/#/c/639874/ :) | |
| 16:40:03 | openstackgerrit | sean mooney proposed openstack/nova master: libvirt: delegate ovs plug to os-vif https://review.openstack.org/602432 | |
| 16:40:25 | edleafe | mriedem: As an east coast native, I felt slighted. :( | |
| 16:42:46 | mriedem | az=rochester-ne | |
| 16:42:47 | mriedem | there | |
| 16:42:51 | mriedem | locally sourced | |
| 16:43:19 | edleafe | no | |
| 16:43:20 | mriedem | az=building25-floor3-mens-br | |
| 16:43:33 | edleafe | az=teaneck-ne | |
| 16:45:31 | openstackgerrit | Chris Friesen proposed openstack/nova master: fix up numa-topology live migration hypervisor check https://review.openstack.org/635350 | |
| 16:46:52 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add remove_resources_from_instance_allocation to report client https://review.openstack.org/639653 | |
| 16:46:53 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Record requester in the InstancePCIRequest https://review.openstack.org/625310 | |
| 16:46:53 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove port allocation during detach https://review.openstack.org/622421 | |
| 16:47:17 | gibi | mriedem: fixed ^^ | |
| 16:50:28 | mriedem | ok +2 on https://review.openstack.org/#/c/622421/ now | |
| 16:50:31 | mriedem | jaypipes: ^ | |
| 16:52:30 | openstackgerrit | Merged openstack/nova master: docs: ComputeDriver.update_provider_tree in nova https://review.openstack.org/633375 | |
| 16:54:47 | cfriesen | can mock.patch.object change an object data member (not a function)? | |
| 16:57:37 | jaypipes | mriedem: yeah, I'm in-progress on that review. | |
| 16:58:21 | efried | cfriesen: Yes? | |
| 16:58:56 | cfriesen | efried: can you point me to an example? | |
| 16:59:40 | cfriesen | efried: do I use ".return_value" or something else? | |
| 16:59:41 | efried | cfriesen: http://paste.openstack.org/show/746513/ | |
| 16:59:47 | mriedem | gibi: just a question on https://review.openstack.org/#/c/625310/ | |
| 16:59:53 | gibi | looking | |
| 17:00:08 | cfriesen | efried: sweet, thanks | |
| 17:00:12 | efried | yw | |
| 17:00:33 | mriedem | cfriesen: you can also create the attribute if it might not exist | |
| 17:00:38 | mriedem | https://docs.python.org/3/library/unittest.mock.html#unittest.mock.patch create=True | |
| 17:00:43 | mriedem | normally shouldn't have to use that though | |
| 17:00:46 | gibi | mriedem: you are correct | |
| 17:01:05 | gibi | mriedem: it would be better to move the requester_id = request_net.port_id down where it is used | |
| 17:01:15 | gibi | mriedem: let me fix it | |
| 17:01:25 | mriedem | gibi: you might want to wait for jaypipes review to finish | |
| 17:02:04 | gibi | mriedem: OK | |
| 17:07:33 | openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Add support for microversion 2.70 - expose device tags https://review.openstack.org/636779 | |
| 17:07:39 | mriedem | melwitt: can you look at ^ again | |
| 17:07:46 | mriedem | takashin's comments should be addressed | |
| 17:08:13 | melwitt | yep, looking | |
| 17:09:09 | mriedem | dansmith: you want to send cells v1 docs to their watery grave? https://review.openstack.org/#/c/636718/ | |
| 17:10:02 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Avoid BadRequest error log on volume attachment https://review.openstack.org/640110 | |
| 17:10:03 | dansmith | mriedem: only if I can go with them | |
| 17:10:35 | mriedem | i'm struggling to make an under-the-sea merman joke here | |
| 17:11:02 | mriedem | https://i.imgur.com/qiJRWMM.gif | |
| 17:14:16 | melwitt | lol | |
| 17:14:59 | mriedem | gibi: oh i guess jay is reviewing the port detach / deallocate change, so feel free to respin the pci request one | |
| 17:15:29 | gibi | I did the fix locally, and I will publish it before I leave. which is in ~15 minutes | |