| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-02-26 | |||
| 13:27:48 | kashyap | aspiers: Thanks; I need to re-spin it 'soon' | |
| 13:27:58 | aspiers | :) | |
| 13:28:01 | mriedem | gmann: ssh setup between the compute nodes must be messed up | |
| 13:28:03 | aspiers | OK, back in ~1 hour | |
| 13:28:07 | kashyap | Sure. | |
| 13:28:14 | aspiers | maybe a bit more, since I'll also need lunch :) | |
| 13:28:20 | aspiers | and it's *very* sunny here ... | |
| 13:28:33 | kashyap | aspiers: I'm here for ~2-ish hours, then on flaky internet connections on trains | |
| 13:28:42 | aspiers | kashyap: OK | |
| 13:28:52 | aspiers | kashyap: BTW if you need more context / detail: https://specs.openstack.org/openstack/nova-specs/specs/stein/approved/amd-sev-libvirt-support.html | |
| 13:28:59 | kashyap | But we're in the same timezone, we can work it out. | |
| 13:29:09 | aspiers | ok cool | |
| 13:29:18 | kashyap | aspiers: Yeah, I saw it whoosh by in the past; just didn't have time to dig into it. | |
| 13:29:21 | kashyap | Thanks, though. | |
| 13:29:36 | aspiers | yw, catch you soon! | |
| 13:30:10 | gmann | mriedem: yeah, - http://logs.openstack.org/92/623992/1/check/tempest-multinode-full/45ca539/controller/logs/screen-n-cpu.txt.gz#_Feb_25_14_59_15_559635 | |
| 13:31:24 | mriedem | not sure what's going on there, would probably need to check the devstack code that sets up ssh between the nodes and see if there were any changes since queens | |
| 13:33:20 | gmann | ok, checking that on devstack side. | |
| 13:35:49 | mriedem | tssurya: yeah i agree | |
| 13:47:52 | jaypipes | sean-k-mooney: morning. making final os-vif push. | |
| 13:49:00 | sean-k-mooney | jaypipes: im going to update the help string on rodolfos ovsdb patch shortly to adress my own nit but otherwise it will be the same just and fyi | |
| 13:49:10 | jaypipes | roger | |
| 13:49:11 | tssurya | dansmith: good morning! would you have a look at the doc fix https://review.openstack.org/#/c/638173/ when you have time ? that's the only change left for the bp completion (and the openstack client changes..) | |
| 13:49:45 | tssurya | thanks in advacne | |
| 13:49:57 | tssurya | s/advacne/advance | |
| 13:51:33 | frickler | sean-k-mooney: just noticed when neutron released b2: there will still be comments be added to a bug when a release is made containing a fix, so you still can verify where that fix is released, just not directly by looking at the bug status | |
| 14:00:11 | sean-k-mooney | ralonsoh: very minor change https://review.openstack.org/#/c/482226/56/vif_plug_ovs/ovs.py is that ok with you | |
| 14:11:32 | jaypipes | stephenfin: hi doc guru :) do you know the answer to my question in the review comment on https://review.openstack.org/#/c/637009/? | |
| 14:13:13 | stephenfin | jaypipes: The Sphinx docs suck. I'm trying to fix them but it's slow. That's referenced here though https://www.sphinx-doc.org/en/1.7/ext/example_google.html | |
| 14:13:17 | stephenfin | Search for '#:' | |
| 14:13:23 | ralonsoh | sean-k-mooney, sure! | |
| 14:13:50 | stephenfin | We're not using that extension but the style is the same | |
| 14:14:11 | efried | bauzas: pong https://review.openstack.org/#/c/599208/ | |
| 14:14:12 | jaypipes | stephenfin: ah! it's a sphinx thing.. | |
| 14:14:15 | stephenfin | Oh, here we go http://www.sphinx-doc.org/en/master/usage/extensions/autodoc.html#directive-autoattribute | |
| 14:14:17 | jaypipes | sorry, totally missed that :( | |
| 14:14:23 | stephenfin | "For module data members and class attributes, documentation can either be put into a comment with special formatting (using a #: to start the comment instead of just #), or in a docstring after the definition. " | |
| 14:14:30 | jaypipes | I thought it was a pep thing. | |
| 14:14:43 | stephenfin | Nah, Sphinx magic taken from epydoc, I'd suspect | |
| 14:14:48 | stephenfin | Or Doxygen, maybe | |
| 14:14:50 | jaypipes | once again I am schooled by the illustrious stephenfin. | |
| 14:15:35 | jangutter | stephenfin, jaypipes: "#:" before or """ after.... drat, I hate choices. | |
| 14:15:38 | sean-k-mooney | jaypipes: i stopped questioning him on docs stuff a while ago. after 2 or 3 times it just gets embarassing when he is always right about my questions | |
| 14:15:38 | jaypipes | stephenfin: ty sir! | |
| 14:16:08 | jaypipes | sean-k-mooney: oh, I definitely don't question his answers :) I just ask away and trust. | |
| 14:16:48 | stephenfin | On a totally unrelated note, has anyone tried to read the argparse source? Oh boy | |
| 14:17:08 | jaypipes | stephenfin: better or worse than ConfigParser? :) | |
| 14:18:28 | zhubx | can someone give some suggestions for https://review.openstack.org/#/c/638080/ a bug fix. thanks | |
| 14:18:33 | stephenfin | Oh, that's bad, but this is worse :) | |
| 14:19:13 | stephenfin | (for reference, we can't do live-migration without a destination in openstackclient until that's fixed https://review.openstack.org/#/c/626949/) | |
| 14:19:32 | stephenfin | or we rewrite argparse | |
| 14:20:23 | sean-k-mooney | stephenfin: why because it does not allow the host to be optional? | |
| 14:20:29 | kashyap | zhubx: I agree with Matt Boot there. To avoid format detection, *always* explicitly specify the backing file format. | |
| 14:20:59 | sean-k-mooney | i assume you cant register an arge to optional take a paramater | |
| 14:21:21 | kashyap | zhubx: IOW, if you know the format, explicitly specify it | |
| 14:21:37 | bauzas | efried: nvm, working on the functest you asked | |
| 14:21:46 | bauzas | it will be a FUP | |
| 14:21:50 | bauzas | given you already +2d | |
| 14:23:06 | efried | bauzas: roger that. I'll be happy to +2 once I see that test. | |
| 14:23:41 | stephenfin | sean-k-mooney: Not quite | |
| 14:24:11 | yonglihe | alex_xu, jaypipes, i update topology API , so it's not depending on the server_group API: https://review.openstack.org/#/c/621476/ | |
| 14:24:52 | stephenfin | sean-k-mooney: You can say an optional parameter may or may not take an option, but if you also have a positional argument, it gets swallowed by the optional parameter regardless | |
| 14:25:44 | sean-k-mooney | ah and the instnace we are migratin is a postional arg and that gets eaten by --live | |
| 14:25:54 | stephenfin | 'zactly | |
| 14:26:08 | stephenfin | Only way to work around it is to add '--', but that breaks everyone | |
| 14:26:31 | stephenfin | So we need to fix argparse then vendor it til until if/when it's fixed upstream | |
| 14:26:42 | sean-k-mooney | that or add a --live-migrate as an alternitve to --live when you want to hit the schduler | |
| 14:27:21 | stephenfin | that would be more practical but not as pretty :) | |
| 14:27:27 | jaypipes | yonglihe: ack. I'll add that to my review queue. | |
| 14:30:50 | dansmith | tssurya: at first glance, stephenfin's grammar nits are things I would have complained about.. can you fix those real quick and I'll just +2+W (after I review) if everything else looks good? | |
| 14:31:33 | dansmith | or I could just do it I guess | |
| 14:31:36 | yonglihe | thanks, | |
| 14:32:53 | jaypipes | stephenfin: the Sarlacc pit beckons. I'll let you nudge https://review.openstack.org/#/c/482226/ off the skiff. | |
| 14:34:21 | efried | jaypipes clearly hasn't seen the movie | |
| 14:35:29 | jaypipes | efried: I have. I just choose to forge a very different plotline in my head. | |
| 14:35:54 | efried | jaypipes: you mean one where that whiny brat Luke gets his just desserts? | |
| 14:36:13 | jaypipes | efried: yes. and the Sarlacc itself gets a nice dessert in the desert. | |
| 14:36:24 | efried | well played sir. well played | |
| 14:39:13 | stephenfin | ralonsoh, sean-k-mooney: Quick one: you've marked this as done but I assume you're replying to me, and sean-k-mooney's comment is void because of his second comment? https://review.openstack.org/#/c/482226/54/vif_plug_ovs/ovs.py@60 | |
| 14:40:01 | sean-k-mooney | stephenfin: i fixed my nit in the help sting in v56 | |
| 14:40:14 | sean-k-mooney | so yes i assumed that ralonsoh was replying to you | |
| 14:40:20 | ralonsoh | stephenfin, yes, this "Done" was for you. ovsdb_connection must have a value | |
| 14:40:24 | stephenfin | Gotcha | |
| 14:40:43 | stephenfin | +W'd \o/ | |
| 14:42:07 | tssurya | dansmith: sure thing I'll correct those nits | |
| 14:42:20 | dansmith | tssurya: hang on I have a couple other things I'm adding | |
| 14:42:33 | tssurya | ah ok | |
| 14:43:15 | mriedem | heh i just addressed them | |
| 14:43:39 | tssurya | :) | |
| 14:46:30 | dansmith | tssurya: mriedem just published my comments | |
| 14:47:21 | tssurya | dansmith: thanks, on it | |
| 14:47:33 | dansmith | I'm standing by with my +2 finger | |
| 15:14:18 | spatel | sean-k-mooney: morning | |
| 15:14:50 | spatel | sean-k-mooney: do you have experience with cellv2 deployment? | |
| 15:14:50 | sean-k-mooney | spatel: o/ | |
| 15:15:17 | sean-k-mooney | spatel: dansmith is the expert but a little | |
| 15:15:35 | spatel | i have 150 new compute nodes waiting ready to go and i am just trying to think i of how to scale my cloud | |
| 15:15:43 | sean-k-mooney | spatel: mainly due to the fact all deployments are cellv2 deplpyment of one cell | |
| 15:16:16 | sean-k-mooney | spatel: you are considering if you should add another cell or not | |
| 15:16:22 | spatel | How difficult its going to be in running production cloud migrate over Cellv2? | |