| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-02-26 | |||
| 13:24:00 | kashyap | aspiers: Go for it. More important than staring at the screen. | |
| 13:24:16 | aspiers | kashyap: hehe glad we agree on that! biab | |
| 13:24:30 | kashyap | aspiers: Quick note is that let's not hardcode anything with: virConnectGetDomainCapabilities() | |
| 13:24:36 | kashyap | (Because we'll use it for other purposes.) | |
| 13:24:38 | gmann | mriedem: next question is should we make it enable and work for those stable branch or is it ok to run them from stable/rocky onwards ? | |
| 13:24:39 | kashyap | But let's talk later. | |
| 13:24:46 | aspiers | kashyap: you mean like hardcoding the arch or machine type? | |
| 13:24:50 | aspiers | or emulatorbin? | |
| 13:25:03 | mriedem | gmann: tempest-multinode-full or tempest-slow? that patch seems to be dealing with enabling tempest-slow on stable branches | |
| 13:25:17 | kashyap | aspiers: Machine type can _probably_ be hard-coded: as only Q35 supports it? | |
| 13:25:17 | gmann | mriedem: yes boih. | |
| 13:25:20 | gmann | both | |
| 13:25:36 | aspiers | kashyap: I was considering changing my patch so that the memoized _domaincaps is a dict of dicts mapping arch -> machine type -> caps XML | |
| 13:25:54 | aspiers | or yeah, maybe just arch -> caps | |
| 13:25:56 | mriedem | gmann: well we have the nova-live-migration job on stable so live migration must work | |
| 13:26:19 | kashyap | aspiers: Yeah, meonized _domaincaps sounds like a good start to me; but I want to think this through a bit more. | |
| 13:26:45 | aspiers | kashyap: emulatorbin can be obtained programmatically from the virConnectGetCapabilities() data we already have | |
| 13:26:53 | kashyap | I haven't had time to soak into the details yet. But I just wanted to make a quick note that for Secure Boot, we'll be using the getDomainCapabilities() | |
| 13:26:58 | aspiers | kashyap: it's already memoized, but only the results from a single API call | |
| 13:27:05 | kashyap | aspiers: Yep | |
| 13:27:15 | mriedem | gmann: i'm not sure what's going on with this http://logs.openstack.org/92/623992/1/check/tempest-multinode-full/45ca539/controller/logs/screen-n-cpu.txt.gz?level=TRACE#_Feb_25_14_57_07_488187 | |
| 13:27:25 | aspiers | kashyap: yep, I commented on your q35 spec noting the potential for reuse | |
| 13:27:27 | kashyap | aspiers: Also, on your `virsh` command from the scrollback, for non-Q35, I _do_ get "sev supported = no" on my Fedora-28: | |
| 13:27:30 | kashyap | $> virsh domcapabilities --virttype kvm --emulatorbin /usr/bin/qemu-kvm --arch x86_64 --machine pc-i440fx-1.4 | grep "sev supported" <sev supported='no'/> | |
| 13:27:46 | aspiers | that's what I would expect | |
| 13:27:48 | kashyap | aspiers: Thanks; I need to re-spin it 'soon' | |
| 13:27:58 | aspiers | :) | |
| 13:28:01 | mriedem | gmann: ssh setup between the compute nodes must be messed up | |
| 13:28:03 | aspiers | OK, back in ~1 hour | |
| 13:28:07 | kashyap | Sure. | |
| 13:28:14 | aspiers | maybe a bit more, since I'll also need lunch :) | |
| 13:28:20 | aspiers | and it's *very* sunny here ... | |
| 13:28:33 | kashyap | aspiers: I'm here for ~2-ish hours, then on flaky internet connections on trains | |
| 13:28:42 | aspiers | kashyap: OK | |
| 13:28:52 | aspiers | kashyap: BTW if you need more context / detail: https://specs.openstack.org/openstack/nova-specs/specs/stein/approved/amd-sev-libvirt-support.html | |
| 13:28:59 | kashyap | But we're in the same timezone, we can work it out. | |
| 13:29:09 | aspiers | ok cool | |
| 13:29:18 | kashyap | aspiers: Yeah, I saw it whoosh by in the past; just didn't have time to dig into it. | |
| 13:29:21 | kashyap | Thanks, though. | |
| 13:29:36 | aspiers | yw, catch you soon! | |
| 13:30:10 | gmann | mriedem: yeah, - http://logs.openstack.org/92/623992/1/check/tempest-multinode-full/45ca539/controller/logs/screen-n-cpu.txt.gz#_Feb_25_14_59_15_559635 | |
| 13:31:24 | mriedem | not sure what's going on there, would probably need to check the devstack code that sets up ssh between the nodes and see if there were any changes since queens | |
| 13:33:20 | gmann | ok, checking that on devstack side. | |
| 13:35:49 | mriedem | tssurya: yeah i agree | |
| 13:47:52 | jaypipes | sean-k-mooney: morning. making final os-vif push. | |
| 13:49:00 | sean-k-mooney | jaypipes: im going to update the help string on rodolfos ovsdb patch shortly to adress my own nit but otherwise it will be the same just and fyi | |
| 13:49:10 | jaypipes | roger | |
| 13:49:11 | tssurya | dansmith: good morning! would you have a look at the doc fix https://review.openstack.org/#/c/638173/ when you have time ? that's the only change left for the bp completion (and the openstack client changes..) | |
| 13:49:45 | tssurya | thanks in advacne | |
| 13:49:57 | tssurya | s/advacne/advance | |
| 13:51:33 | frickler | sean-k-mooney: just noticed when neutron released b2: there will still be comments be added to a bug when a release is made containing a fix, so you still can verify where that fix is released, just not directly by looking at the bug status | |
| 14:00:11 | sean-k-mooney | ralonsoh: very minor change https://review.openstack.org/#/c/482226/56/vif_plug_ovs/ovs.py is that ok with you | |
| 14:11:32 | jaypipes | stephenfin: hi doc guru :) do you know the answer to my question in the review comment on https://review.openstack.org/#/c/637009/? | |
| 14:13:13 | stephenfin | jaypipes: The Sphinx docs suck. I'm trying to fix them but it's slow. That's referenced here though https://www.sphinx-doc.org/en/1.7/ext/example_google.html | |
| 14:13:17 | stephenfin | Search for '#:' | |
| 14:13:23 | ralonsoh | sean-k-mooney, sure! | |
| 14:13:50 | stephenfin | We're not using that extension but the style is the same | |
| 14:14:11 | efried | bauzas: pong https://review.openstack.org/#/c/599208/ | |
| 14:14:12 | jaypipes | stephenfin: ah! it's a sphinx thing.. | |
| 14:14:15 | stephenfin | Oh, here we go http://www.sphinx-doc.org/en/master/usage/extensions/autodoc.html#directive-autoattribute | |
| 14:14:17 | jaypipes | sorry, totally missed that :( | |
| 14:14:23 | stephenfin | "For module data members and class attributes, documentation can either be put into a comment with special formatting (using a #: to start the comment instead of just #), or in a docstring after the definition. " | |
| 14:14:30 | jaypipes | I thought it was a pep thing. | |
| 14:14:43 | stephenfin | Nah, Sphinx magic taken from epydoc, I'd suspect | |
| 14:14:48 | stephenfin | Or Doxygen, maybe | |
| 14:14:50 | jaypipes | once again I am schooled by the illustrious stephenfin. | |
| 14:15:35 | jangutter | stephenfin, jaypipes: "#:" before or """ after.... drat, I hate choices. | |
| 14:15:38 | sean-k-mooney | jaypipes: i stopped questioning him on docs stuff a while ago. after 2 or 3 times it just gets embarassing when he is always right about my questions | |
| 14:15:38 | jaypipes | stephenfin: ty sir! | |
| 14:16:08 | jaypipes | sean-k-mooney: oh, I definitely don't question his answers :) I just ask away and trust. | |
| 14:16:48 | stephenfin | On a totally unrelated note, has anyone tried to read the argparse source? Oh boy | |
| 14:17:08 | jaypipes | stephenfin: better or worse than ConfigParser? :) | |
| 14:18:28 | zhubx | can someone give some suggestions for https://review.openstack.org/#/c/638080/ a bug fix. thanks | |
| 14:18:33 | stephenfin | Oh, that's bad, but this is worse :) | |
| 14:19:13 | stephenfin | (for reference, we can't do live-migration without a destination in openstackclient until that's fixed https://review.openstack.org/#/c/626949/) | |
| 14:19:32 | stephenfin | or we rewrite argparse | |
| 14:20:23 | sean-k-mooney | stephenfin: why because it does not allow the host to be optional? | |
| 14:20:29 | kashyap | zhubx: I agree with Matt Boot there. To avoid format detection, *always* explicitly specify the backing file format. | |
| 14:20:59 | sean-k-mooney | i assume you cant register an arge to optional take a paramater | |
| 14:21:21 | kashyap | zhubx: IOW, if you know the format, explicitly specify it | |
| 14:21:37 | bauzas | efried: nvm, working on the functest you asked | |
| 14:21:46 | bauzas | it will be a FUP | |
| 14:21:50 | bauzas | given you already +2d | |
| 14:23:06 | efried | bauzas: roger that. I'll be happy to +2 once I see that test. | |
| 14:23:41 | stephenfin | sean-k-mooney: Not quite | |
| 14:24:11 | yonglihe | alex_xu, jaypipes, i update topology API , so it's not depending on the server_group API: https://review.openstack.org/#/c/621476/ | |
| 14:24:52 | stephenfin | sean-k-mooney: You can say an optional parameter may or may not take an option, but if you also have a positional argument, it gets swallowed by the optional parameter regardless | |
| 14:25:44 | sean-k-mooney | ah and the instnace we are migratin is a postional arg and that gets eaten by --live | |
| 14:25:54 | stephenfin | 'zactly | |
| 14:26:08 | stephenfin | Only way to work around it is to add '--', but that breaks everyone | |
| 14:26:31 | stephenfin | So we need to fix argparse then vendor it til until if/when it's fixed upstream | |
| 14:26:42 | sean-k-mooney | that or add a --live-migrate as an alternitve to --live when you want to hit the schduler | |
| 14:27:21 | stephenfin | that would be more practical but not as pretty :) | |
| 14:27:27 | jaypipes | yonglihe: ack. I'll add that to my review queue. | |
| 14:30:50 | dansmith | tssurya: at first glance, stephenfin's grammar nits are things I would have complained about.. can you fix those real quick and I'll just +2+W (after I review) if everything else looks good? | |
| 14:31:33 | dansmith | or I could just do it I guess | |
| 14:31:36 | yonglihe | thanks, | |
| 14:32:53 | jaypipes | stephenfin: the Sarlacc pit beckons. I'll let you nudge https://review.openstack.org/#/c/482226/ off the skiff. | |
| 14:34:21 | efried | jaypipes clearly hasn't seen the movie | |
| 14:35:29 | jaypipes | efried: I have. I just choose to forge a very different plotline in my head. | |