Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-02-18
19:47:57 mordred mnaser: we pick the smallest flavor sorted by ram
19:48:05 mnaser *something* creates that flavor..
19:48:14 mordred mnaser: so I think I need to add an 'if' for disk != 0
19:48:41 mnaser yeah if you're not doing bfv and the flavor has disk == 0 then it should not use that flavor
19:49:21 mnaser but http://git.openstack.org/cgit/openstack-dev/devstack/tree/lib/nova#n1165
19:49:22 cdent devstack creates that flavor
19:49:24 cdent jinx
19:49:56 mnaser mordred: so i guess in openstacksdk world of things, it shouldn't pick a flavor that has disk_gb=0 when trying to bfv (as of train)
19:52:07 mordred mnaser: https://review.openstack.org/637618 Make sure we pick flavors with disk <-- I think that should do it yeah?
19:53:23 mnaser mordred: assuming python evaluates flavor.disk set to 0 as false then yes
19:53:31 mordred mnaser: we'll find out! :)
19:53:35 mnaser but i forget fundamental python rules
19:53:57 mnaser we're supposed to be experts but half the tabs i open are "how the f does X language do switch cases"
20:36:36 openstackgerrit Theodoros Tsioutsias proposed openstack/nova master: Introduce the PENDING instance state https://review.openstack.org/566473
20:36:37 openstackgerrit Theodoros Tsioutsias proposed openstack/nova master: Allow rebuild for instances in PENDING state https://review.openstack.org/637585
20:37:55 openstackgerrit Vlad Gusev proposed openstack/nova master: [WIP] libvirt: Add a default Virtio RNG device to guests https://review.openstack.org/616603
20:38:16 openstackgerrit Vlad Gusev proposed openstack/nova master: libvirt: Add a default Virtio RNG device to guests https://review.openstack.org/616603
20:57:13 mriedem weird that we send the resize.revert.(start|end) notifications from the source host during finish_revert_resize which is half of the actual revert
20:57:22 mriedem the start notification should happen on the dest host in revert_resize()
20:57:25 mriedem must not be a big deal
21:03:11 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add revert_snapshot_based_resize_at_dest compute method https://review.openstack.org/637630
21:10:25 openstackgerrit Artom Lifshitz proposed openstack/nova master: Introduce live_migration_claim() https://review.openstack.org/635669
21:10:26 openstackgerrit Artom Lifshitz proposed openstack/nova master: LM: Make dest send NUMAMigrateData to the source https://review.openstack.org/634828
21:10:26 openstackgerrit Artom Lifshitz proposed openstack/nova master: [WIP] Use live_migration_claim() to check dest resources https://review.openstack.org/634606
21:10:27 openstackgerrit Artom Lifshitz proposed openstack/nova master: LM: update NUMA-related XML on the source https://review.openstack.org/635229
21:10:36 artom ^^ It works. It actually works.
21:21:05 mriedem it also seems weird that the migration.status is changed to 'reverted' on the dest host before the revert is actually done on the source host
21:24:03 cdent this is what you get for looking under rocks
21:25:35 mriedem yeah, tends to happen when you re-write something based on old gorp
21:42:44 cdent goodnight
21:44:24 openstackgerrit Merged openstack/nova stable/rocky: Lock detach_volume https://review.openstack.org/637534
21:51:15 openstackgerrit Lee Yarwood proposed openstack/nova master: Restore connection_info after live migration rollback https://review.openstack.org/551349
22:11:46 mriedem huh, we don't call _update_scheduler_instance_info on finish_revert_resize - again, weird, since we've changed the instance.host
22:29:01 openstackgerrit Lee Yarwood proposed openstack/nova master: Use migration_status during volume migrating and retyping https://review.openstack.org/637224
22:54:36 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add revert_snapshot_based_resize_at_dest compute method https://review.openstack.org/637630
22:54:37 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add finish_revert_snapshot_based_resize_at_source compute method https://review.openstack.org/637647
23:01:12 mriedem dansmith: this is easy https://review.openstack.org/#/c/635315/ and unblocks a fix we've been talking about for a long time
#openstack-nova - 2019-02-19
01:16:03 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Bump compute service to indicate attach/detach root volume is supported https://review.openstack.org/614750
01:39:53 openstackgerrit Merged openstack/nova stable/queens: Lock detach_volume https://review.openstack.org/637535
01:44:40 openstackgerrit Adam Spiers proposed openstack/nova master: Fix fake DELETE in PlacementFixture https://review.openstack.org/637657
02:16:37 openstackgerrit melanie witt proposed openstack/nova master: Add online data migration for populating user_id https://review.openstack.org/633351
02:32:10 openstackgerrit Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474
03:44:28 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Bump compute service to indicate attach/detach root volume is supported https://review.openstack.org/614750
04:25:27 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient master: Fix output of interface-attach command https://review.openstack.org/637677
04:28:32 alex_xu melwitt: I probably didn't get what your mean about the unrelated between instance.project_id as target and removing project_only=True
04:29:29 alex_xu melwitt: I'm thinking make the instance.project_id as target should be the first step, then we can remove the project_only=True. so...that I'm thinking they are related
04:37:47 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix resetting non-persistent fields when saving obj https://review.openstack.org/636271
06:37:54 openstackgerrit Yongli He proposed openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474
06:40:01 openstackgerrit Yongli He proposed openstack/nova master: Add server subresouce toplogy API https://review.openstack.org/621476
06:49:16 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Bump compute service to indicate attach/detach root volume is supported https://review.openstack.org/614750
06:49:59 bauzas good morning Nova
06:54:07 openstackgerrit Yongli He proposed openstack/nova master: Add server subresouce toplogy API https://review.openstack.org/621476
06:59:27 openstackgerrit Yongli He proposed openstack/nova master: Add server subresouce toplogy API https://review.openstack.org/621476
07:38:45 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix cleaning up console tokens https://review.openstack.org/637716
09:04:15 openstackgerrit Yongli He proposed openstack/nova master: Add server subresouce toplogy API https://review.openstack.org/621476
09:12:25 kashyap This needs a final +W, if anyone wants to put this through: https://review.openstack.org/#/c/632507/ (libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Stein")
09:14:21 gibi kashyap: I'm here but I cannot help :)
09:14:27 kashyap Heh, I know.
09:14:36 kashyap That's why I didn't ping anyone explicitly :-)
09:15:02 gibi :)
09:16:03 kashyap gibi: I _think_ this is related to my patch, isn't it: http://logs.openstack.org/78/637578/1/check/nova-tox-functional-py35/14da3dc/testr_results.html.gz
09:16:18 kashyap Coming from https://review.openstack.org/#/c/637578 ("libvirt: Omit needless check on 'CONF.serial_console'")
09:18:12 gibi kashyap: fells like there is a connection. Is it always fails for your patch?
09:18:34 kashyap Don't know yet
09:23:12 kashyap It is this test 'test_volume_swap_server_with_error' from nova/tests/functional/notification_sample_tests/test_instance.py
09:26:41 kashyap gibi: But the "IndexError: list index out of range
09:26:43 kashyap "
09:27:12 kashyap ... give me a déjà vu, as I fixed similar errors in unit tests in main patch.
09:27:31 kashyap Usually lowering the index of devices by one, because we removed one needless serial device.
09:28:39 gibi kashyap: that index out of range is a missing notification that is probably caused by the stack trace before it
09:28:42 gibi File "/home/zuul/src/git.openstack.org/openstack/nova/nova/compute/manager.py", line 5688, in _init_volume_connection
09:28:45 gibi new_cinfo['serial'] = new_volume_id
09:28:47 gibi TypeError: 'tuple' object does not support item assignment
09:31:20 kashyap gibi: What's your `tox` command-line?
09:31:37 gibi tox -e functional-py35
09:32:35 gibi kashyap: I cannot reproduce the failure locally
09:33:11 kashyap Hmm
09:33:38 gibi but the stacktrace is there in the log even if the test does not fail
09:33:48 kashyap Ah, I see.
09:33:49 gibi no I will check for the stack trace without your patch
09:33:59 kashyap gibi: One more: did you apply the main bump patch as well?
09:34:59 gibi kashyap: I checked out your Omit patch so I have the whole series
09:35:05 kashyap Ah, good.
09:35:49 gibi kashyap: the stacktrace is there even on master without your series
09:35:56 gibi so it is something unrelated
09:36:11 kashyap Okay, noted. Thanks for the quick check.
09:36:26 kashyap Wonder then should I 'recheck', as this could be a spurious failure?
09:36:42 gibi bottom line, the test fail in your patch due to some timing issue in the notification test, unrelated to that there is a ugly stack trace in the log even if it passes, all unrelated to your patch
09:36:50 gibi kashyap: yep, recheck it is
09:37:58 kashyap Noted, thanks for the quick double-check, feel a bit saner now
09:38:55 openstackgerrit Lee Yarwood proposed openstack/nova master: compute: Reject resize requests when the source host is down https://review.openstack.org/623489
09:39:34 lyarwood sean-k-mooney: ^ I think you looked at this a while ago, should be ready for another review if you have time today.
09:40:43 gibi kashyap: filed a bug not to forget to look at that stacktrace https://bugs.launchpad.net/nova/+bug/1816538
09:40:44 openstack Launchpad bug 1816538 in OpenStack Compute (nova) "test_volume_swap_server_with_error produce a suspicious stack trace" [Undecided,New]
09:40:56 kashyap Ah, excellent, thanks
09:50:15 openstackgerrit Sylvain Bauza proposed openstack/nova master: Use the correct mdev allocated from the pGPU https://review.openstack.org/636591
09:50:16 openstackgerrit Sylvain Bauza proposed openstack/nova master: Add functional test for libvirt vgpu reshape https://review.openstack.org/631559
09:50:16 openstackgerrit Sylvain Bauza proposed openstack/nova master: libvirt: implement reshaper for vgpu https://review.openstack.org/599208
09:58:13 kashyap stephenfin: When you can: https://review.openstack.org/#/c/632507/
09:59:11 kashyap gibi: Remind me again, if I touch-up the commit message, will I lose all the +2s / +1s?

Earlier   Later