| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-02-11 | |||
| 13:49:19 | bauzas | unless the operators changes it back to the original type | |
| 13:49:26 | bauzas | so we don't have a problem atm | |
| 13:49:29 | gibi | bauzas: so the operator needs to delete / migrate away the instances first | |
| 13:49:42 | gibi | then change the tyee | |
| 13:49:43 | gibi | type | |
| 13:49:43 | bauzas | yeah, or change the type back to the original | |
| 13:49:53 | gibi | bauzas: OK, that makes it even stricter | |
| 13:50:01 | gibi | bauzas: and here strict is good, I think | |
| 13:50:02 | bauzas | no, he can change without needing to delete | |
| 13:50:23 | gibi | bauzas: yeah, if he want to change back then he can without delete | |
| 13:50:26 | bauzas | that's just only if he really wants to change from one type to the other | |
| 13:50:32 | bauzas | yeah | |
| 13:50:32 | gibi | bauzas: yeas | |
| 13:50:35 | gibi | cool | |
| 13:50:50 | gibi | maybe we want to document this behavior somehow for the deployer | |
| 13:50:51 | bauzas | now, with the change, lemme think | |
| 13:50:53 | gibi | to avoud surprise | |
| 13:51:00 | bauzas | gibi: we did it already | |
| 13:51:07 | gibi | bauzas: then I rest my case | |
| 13:51:09 | gibi | :) | |
| 13:51:46 | bauzas | oh wait, no actually | |
| 13:51:47 | bauzas | https://docs.openstack.org/nova/latest/admin/virtual-gpu.html | |
| 13:52:05 | bauzas | I could add a note in https://docs.openstack.org/nova/latest/admin/virtual-gpu.html#enable-gpu-types-compute | |
| 13:52:54 | gibi | bauzas: making that note solves my comment in your patch | |
| 13:53:14 | bauzas | gibi: that said, I need to think on how it works with nested RPs | |
| 13:53:42 | bauzas | for the moment, it does work because allocations are made against the same RP | |
| 13:53:50 | bauzas | oh wait | |
| 13:54:05 | bauzas | even if people change types, they won't change the pGPU | |
| 13:54:22 | bauzas | so allocations will still be made against the right pGPUI | |
| 13:54:42 | bauzas | actually, something is missing :( | |
| 13:54:51 | bauzas | holy shit | |
| 13:54:59 | bauzas | we have an allocation against one pGPU | |
| 13:55:17 | fried_rice | n-sch meeting in 5 minutes in #openstack-meeting-alt | |
| 13:55:19 | bauzas | but then libvirt creates the mdev (or uses some mdev) from any pGPU | |
| 13:55:26 | bauzas | which is a problem | |
| 13:55:33 | bauzas | for correctly counting allocations | |
| 13:55:47 | bauzas | shit shit shit | |
| 13:55:53 | bauzas | gibi: thanks for making me think of it | |
| 13:59:43 | gibi | bauzas: you are welcome :) | |
| 14:12:24 | openstackgerrit | Hamdy Khader proposed openstack/os-vif master: Add VIFPortProfileSmartNIC profile https://review.openstack.org/636061 | |
| 14:21:02 | openstackgerrit | Surya Seetharaman proposed openstack/nova-specs master: Support server power state update through external event https://review.openstack.org/636132 | |
| 14:28:37 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix deps for api-samples tox env https://review.openstack.org/633620 | |
| 14:28:38 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add microversion to expose virtual device tags https://review.openstack.org/631948 | |
| 14:28:38 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Make VolumeAttachmentsSampleV249 test other methods https://review.openstack.org/633621 | |
| 14:39:32 | bauzas | mriedem: FWIW, gibi made me think of a problem with the reshape series | |
| 14:39:45 | bauzas | mriedem: that's uncommented yet, but I'll need to respin | |
| 14:41:53 | mriedem | you've yet to respin anyway right? | |
| 14:42:05 | mriedem | so respin your local respin | |
| 14:43:05 | mriedem | bauzas: gibi: are you able to summarize the issue? | |
| 14:43:10 | mriedem | so i don't have to read scrollback? | |
| 14:43:27 | bauzas | mriedem: tl;dr: | |
| 14:43:38 | bauzas | we will have inventories per pGPU | |
| 14:43:56 | bauzas | placement will choose one child RP and make an allocation to it | |
| 14:44:07 | bauzas | then it goes down to the driver | |
| 14:44:16 | bauzas | which picks randomly at the moment | |
| 14:44:34 | bauzas | the last sentence has to change | |
| 14:44:53 | bauzas | the driver has to pick one of the available mdevs from the pGPU related to the allocation | |
| 14:45:00 | mriedem | driver.spawn() gets the allocations, so we just have to reconcile the local inventory in the driver to what was allocated and pick that mdev yeah? | |
| 14:45:05 | bauzas | or allocations would diverge from actual usage | |
| 14:45:14 | bauzas | mriedem: yup that | |
| 14:45:43 | bauzas | mriedem: we need to lookup the child RP from the allocation and find an allocable mdev from it | |
| 14:45:52 | bauzas | not a big deal, but still has to be done | |
| 14:46:12 | openstackgerrit | garyk proposed openstack/nova master: Better handle live migration abort https://review.openstack.org/635440 | |
| 14:46:17 | mriedem | does that need to be done separately from the reshaper patch, like as a dependency - even though it won't do anything until the reshape is done? | |
| 14:46:23 | mriedem | because that reshaper patch is already big | |
| 14:46:31 | bauzas | yeah I was considering this | |
| 14:46:38 | mriedem | i'd split them if possible | |
| 14:46:41 | bauzas | we could drop a -2 | |
| 14:46:46 | mriedem | 1. handled nested in spawn, 2. do reshapes | |
| 14:46:48 | bauzas | and only +W once all are accepted | |
| 14:46:54 | bauzas | or yeah, that | |
| 14:46:57 | bauzas | whatever | |
| 14:47:45 | mriedem | to remind me, the child RP is a pGPU on the compute node right? | |
| 14:48:04 | mriedem | and len(mdevs) is total VGPU inventory per pGPU child provider | |
| 14:48:53 | openstackgerrit | sean mooney proposed openstack/nova master: [DNM] libvirt: delegate ovs plug to os-vif https://review.openstack.org/602432 | |
| 14:48:58 | sean-k-mooney | ignore ^ im just testing something | |
| 14:52:12 | bauzas | mriedem: correct, with the slight detail that total = len(mdevs) + pGPU.'available_instances' (which changes over the time) | |
| 14:52:34 | bauzas | that's why we need to count mdevs for the inventory | |
| 14:52:55 | bauzas | as "available instances" is a value that has a very different meaning | |
| 14:54:29 | openstackgerrit | sean mooney proposed openstack/nova master: [DNM] libvirt: delegate ovs plug to os-vif https://review.openstack.org/602432 | |
| 14:54:56 | sean-k-mooney | still ignore ^ needed to fix merge confict to get gate jobs to run. | |
| 14:56:44 | mriedem | gibi: do you want to re-approve https://review.openstack.org/#/c/634767/ since it was rebased? | |
| 14:57:07 | gibi | mriedem: done | |
| 14:57:34 | mriedem | thanks | |
| 15:13:52 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Ignore VolumeAttachmentNotFound exception in compute.manager https://review.openstack.org/632657 | |
| 15:24:54 | jackding | mdbooth_: Could you please revisit https://review.openstack.org/#/c/616692/ since your last -1? It | |
| 15:32:30 | gibi | hey cores, can somebody push in https://review.openstack.org/#/c/633776/ it is a follow up and mriedem already +2 on it | |
| 15:42:49 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix race in test_volume_swap_server_with_error https://review.openstack.org/634334 | |
| 15:43:46 | sean-k-mooney | gibi: ya that makes sense. it conflict with a tone of patches so it would be good to merge sooner rather then later | |
| 15:44:33 | gibi | sean-k-mooney: exactly | |
| 15:55:01 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Raise InstanceFaultRollback for UnableToMigrateToSelf from _prep_resize https://review.openstack.org/633227 | |
| 16:04:57 | sean-k-mooney | stephenfin: before you hit the sriov migration seires want to quickly look at gibi's patch https://review.openstack.org/634334. its a faily small change | |
| 16:05:05 | stephenfin | ack | |
| 16:05:15 | gibi | stephenfin: thanks | |
| 16:08:57 | stephenfin | sean-k-mooney: Right link? That's mriedem's change you linked | |
| 16:09:10 | stephenfin | wait - I see what you were referring to | |
| 16:16:50 | efried | Is there an etherpad for the PTG yet? | |
| 16:17:26 | efried | mriedem, melwitt, cdent, other people who might know. ^ | |
| 16:17:44 | sean-k-mooney | efried: not that im aware of | |
| 16:18:00 | mriedem | https://etherpad.openstack.org/p/nova-ptg-train | |