Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-11-29
15:15:28 rambo_li__ :)
15:16:07 mriedem ok i will mark the other blueprint as superseded
15:17:51 rambo_li__ mriedem:goodbye
15:18:01 mriedem rambo_li__: good night
15:18:26 mriedem melwitt: johnthetubaguy: am i missing something or does this spec intentionally not support the block device limit for boot from volume? https://review.openstack.org/#/c/597306/
15:19:09 mriedem because it doesn't mention boot from volume with >26 bdms, and if we support that for attach volume, i expect people are going to want it for bfv later - so if there is good reason for not supporting it on bfv that should probably be amended to the spec
15:21:11 openstack Launchpad bug 1677217 in OpenStack Compute (nova) " AggregateImagePropertiesIsolation filter return unwanted compute nodes" [Undecided,In progress] - Assigned to Md Nadeem (mail2nadeem92)
15:21:11 mriedem phasespace: also see https://bugs.launchpad.net/nova/+bug/1677217
15:37:54 openstackgerrit Matthew Booth proposed openstack/nova master: Address nits from change I5619728d https://review.openstack.org/620941
15:37:54 openstack bug 1550919 in OpenStack Compute (nova) "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Matthew Booth (mbooth-9)
15:37:54 openstackgerrit Matthew Booth proposed openstack/nova master: Add BFV, ephemeral, and swap test cases for bug 1550919 https://review.openstack.org/620917
15:39:39 openstackgerrit Matthew Booth proposed openstack/nova master: libvirt: Don't delete disks on shared storage during evacuate https://review.openstack.org/578846
15:45:54 artom What are those "Cannot load <field> in the base class" errors again? I remember getting a few of them when writing tests for new code
15:48:11 artom Do they happen because you forgot to load a field with expected_attrs? Or does that only exist for Instances?
15:48:16 artom dansmith, ^^ awake yet?
15:48:40 dansmith artom: it means you're trying to lazy-load a field for which there is no handler
15:49:09 dansmith lazy-loading isn't magic, the object has to implement it specifically, because it may or may not mean "go back to the database"
15:49:17 artom dansmith, ah, there we go, thanks!
15:59:42 phasespace mriedem: thanks!
16:13:53 openstackgerrit Monty Taylor proposed openstack/nova master: Use ksa adapter for cinder client https://review.openstack.org/508345
16:14:34 mordred mriedem_afk, efried: ^^ there's an initial stab at updating that patch
16:16:26 openstackgerrit Monty Taylor proposed openstack/nova master: Use ksa adapter for cinder client https://review.openstack.org/508345
16:17:50 efried mordred: ack
16:22:17 mriedem_afk i do have this easy peasy workaround for sorrison now too https://review.openstack.org/#/c/620738/
16:36:13 mordred mriedem: yes. I like that - I'm going to rebase the other thing on top of it
16:38:44 openstackgerrit Monty Taylor proposed openstack/nova master: Use ksa adapter for cinder client https://review.openstack.org/508345
16:57:15 mriedem mdbooth: you're getting lucky in https://review.openstack.org/#/c/620917/ because of defaults in the cinder fixture and api code
16:58:22 openstackgerrit Jack Ding proposed openstack/nova-specs master: Select cpu model from a list of cpu models https://review.openstack.org/620959
17:03:23 mdbooth \o/ I'm lucky :)
17:07:38 mdbooth mriedem: Thanks, will fix.
17:11:45 mriedem i also left some comments in https://review.openstack.org/#/c/620941/ - if we were to move that functional test module to a non-regressions location (since it's not a regression), i would think you'd want to do that before proposing backports and such, but just something to think about
17:17:11 mdbooth mriedem: Ok. Agree it's not a regression, put it there because I had the (incorrect) impression that's where we were putting this kind of 'assert the broken behaviour, fix it and update the test' stuff.
17:17:37 mriedem yeah that's the usual pattern, but doesn't always have to be a regression to do that,
17:17:47 mriedem just nice for the hairier things that need a big functional test
17:24:34 openstackgerrit Matthew Booth proposed openstack/nova master: libvirt: Don't delete disks on shared storage during evacuate https://review.openstack.org/578846
17:24:34 openstack bug 1550919 in OpenStack Compute (nova) "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Matthew Booth (mbooth-9)
17:24:34 openstackgerrit Matthew Booth proposed openstack/nova master: Add BFV, ephemeral, and swap test cases for bug 1550919 https://review.openstack.org/620917
17:24:43 mdbooth mriedem: Thanks.
18:16:00 mriedem jaypipes: dansmith: before yikun spends too much time on writing a PositiveFloatOpt, i'd like to get your input/agreement on it https://review.openstack.org/#/c/602804/12/nova/conf/compute.py@481
18:16:30 mriedem he started that in oslo.config https://review.openstack.org/#/c/620547/
18:19:31 dansmith mriedem: tbh, I'd just do the min=0 thing and just log error and treat the value as 1.0 if it's invalid
18:19:42 dansmith just seems like a really minor detail to go to all this trouble
18:19:42 jaypipes mriedem: ok, I'll try to look at that. right now, just fighting to keep myself from throwing myself off a cliff.
18:19:57 dansmith but if it's really important, I'd say do it in nova as you suggested.
18:22:06 dansmith commented on both
18:57:29 mriedem it's not really important, which is also what i said in my comment. if we were going to ignore <1 and make it 1.0 anyway, then the min should be 1.0
19:01:32 efried jaypipes: Nudge (not off a cliff): Is https://review.openstack.org/#/c/615646/ green?
19:04:19 artom Cliff? That's stephen's thing
19:04:45 dansmith mriedem: I meant ignore if ==0
19:06:42 mriedem yeah i replied in there and just said leave as is and we'll change later if it's a problem
19:12:47 mriedem bauzas: your turn https://review.openstack.org/#/c/599587/9
19:15:20 artom mriedem, cheers!
19:15:43 artom (I wrote it at the end of yesterday, so yeah, your wording is better)
19:29:53 frippe75_ Been bashing #openstack and #rdo about this for a week and hoping since its "nova related" someone here might have more info (thanks in advance!)
19:30:40 frippe75_ Trying to keep it to the point. Should'nt nova-compute service create a row in nova db compute_nodes table during startup ?
19:31:26 frippe75_ Having trouble getting the compute node into the cells_v2 via a "nova-manage cells_v2 discover_hosts" command
19:32:15 frippe75_ ...via the instance_init()
19:33:41 dansmith frippe75_: compute asks conductor put put a row in the compute_nodes table on startup yes
19:33:59 dansmith frippe75_: once that is there, you can do the "cell_v2 discover_hosts" part to put a mapping in the api database
19:34:06 frippe75_ Nova compute service is up listing it via "openstack compute service list --service nova-compute" but not the agent via "openstack compute agent list"
19:34:22 dansmith agent list is legacy and not related
19:34:36 frippe75_ dansmith: exaclty. But I cannot get it into comput_nodes
19:34:41 dansmith unless you're running icehouse and xenserver from five years ago? :)
19:34:55 frippe75_ haha ok. that was a check suggested by #openstack com..
19:35:20 dansmith frippe75_: this sounds like a setup/usage sort of issue then, and that's not what this channel is for (see topic)
19:35:21 frippe75_ No CentOS 7.5.1804 / Rocky stable release
19:36:20 frippe75_ dansmith: Sorry I really know! But I have been banging my head for 30hours+ and then you go off-topic. Ok. understand.
19:41:58 mriedem the services table record exists for the host but not the compute_nodes table record? which release?
19:42:00 mriedem which virt driver?
19:42:09 dansmith mriedem: we switched to #openstack
19:56:12 sean-k-mooney bauzas: thanks for the reivew.
19:56:26 sean-k-mooney ill make some chages and submit again tomorow
21:09:35 mriedem PciDevice objects are used to model a tree, right? where you can have a PciDevice.dev_type = 'type-PF' with children PciDevices that are type-VF, yeah?
21:10:11 mriedem and the allocation of each device is in the 'status' field, so allocated/claimed/available etc
21:11:25 mriedem jaypipes: right? ^
21:12:43 dansmith mriedem: correct as I understand it
21:12:52 dansmith there should be a parent_id relating vf to pf
21:14:09 mriedem yup ok
21:39:26 openstackgerrit Eric Fried proposed openstack/nova master: Use a static resource tracker in compute manager https://review.openstack.org/620711
21:40:37 efried jaypipes: I think this is ready now ^ Lots of test changes. However, I think there's going to be a manual rebase needed when I restack the series.
21:41:32 efried heh, yup
21:45:55 openstackgerrit Eric Fried proposed openstack/nova master: Reduce calls to placement from _ensure https://review.openstack.org/615677
21:45:55 openstackgerrit Eric Fried proposed openstack/nova master: SIGHUP n-cpu to clear provider tree cache https://review.openstack.org/615646
21:45:56 openstackgerrit Eric Fried proposed openstack/nova master: Commonize _update code path https://review.openstack.org/615705
21:45:56 openstackgerrit Eric Fried proposed openstack/nova master: Consolidate inventory refresh https://review.openstack.org/615695
21:45:57 openstackgerrit Eric Fried proposed openstack/nova master: Rip out the SchedulerClient https://review.openstack.org/617049
21:45:57 openstackgerrit Eric Fried proposed openstack/nova master: Rip the report client out of SchedulerClient https://review.openstack.org/617042
21:45:58 openstackgerrit Eric Fried proposed openstack/nova master: Use a static resource tracker in compute manager https://review.openstack.org/620711
21:46:00 efried rebase only ^
22:28:00 mriedem tis your white whale matey
22:29:53 mriedem tonight, during TNF?!
22:30:05 mriedem there will be brees slips all over it
22:32:32 mriedem heh wrong channel
22:56:05 openstackgerrit Eric Fried proposed openstack/nova master: Consolidate inventory refresh https://review.openstack.org/615695
22:56:05 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Reduce calls to placement from _ensure https://review.openstack.org/615677
22:56:06 openstackgerrit Eric Fried proposed openstack/nova master: Rip the report client out of SchedulerClient https://review.openstack.org/617042
22:56:06 openstackgerrit Eric Fried proposed openstack/nova master: Commonize _update code path https://review.openstack.org/615705
22:56:07 openstackgerrit Eric Fried proposed openstack/nova master: Use a static resource tracker in compute manager https://review.openstack.org/620711
22:56:07 openstackgerrit Eric Fried proposed openstack/nova master: Rip out the SchedulerClient https://review.openstack.org/617049
22:57:41 efried jaypipes: Ran out of time tonight, still need to fix up the tests for the now-WIP above. That will cause failures up the chain, and I'm guessing there will be manual rebases needed there once I do fix the tests. But other than that, everything in the series should be ready.

Earlier   Later