| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-11-28 | |||
| 18:13:12 | dansmith | the procedure says "delete the existing volume attachment", | |
| 18:13:27 | dansmith | which I thought meant "the BDM" but that's not the case -- that means the attachment on the cinder side right? | |
| 18:13:52 | mriedem | correct | |
| 18:13:55 | dansmith | I was worried we might lost the linkage to the volume if we failed to create a temporary BDM at the right spot, and/or fail to allow re-replacing that | |
| 18:13:57 | dansmith | but this makes more sense | |
| 18:14:00 | mriedem | and it's what we already do today for rebuild | |
| 18:14:01 | dansmith | okay fair enough | |
| 18:14:09 | dansmith | for non-root you mean | |
| 18:14:13 | mriedem | the rollback procedure wasn't called out | |
| 18:14:19 | mriedem | yes | |
| 18:14:20 | mriedem | well, | |
| 18:14:25 | mriedem | you can rebuild a volume-backed server today too, | |
| 18:14:28 | mriedem | as long as the image doesn't change | |
| 18:14:36 | dansmith | yeah | |
| 18:14:45 | mriedem | we detach all the bdms, destroy the guest, spawn the guest and attach the volumes again | |
| 18:14:46 | dansmith | okay I'm with you, I was just projecting too much bdm in there | |
| 18:14:55 | mriedem | the last part 'completes' the attachment by giving cinder the host connector | |
| 18:15:01 | dansmith | detach or delete/ | |
| 18:15:08 | mriedem | detach | |
| 18:15:10 | mriedem | the bdms are fixed | |
| 18:15:18 | mriedem | the volume attachment record is transitory | |
| 18:15:29 | dansmith | right, so we still have the linkage between the instance and the volume it should be attached to yes? | |
| 18:15:33 | mriedem | so we'll update the bdm.attachment_id during the rebuild | |
| 18:15:36 | mriedem | yes | |
| 18:15:41 | dansmith | right, okay, gotcha | |
| 18:15:44 | mriedem | we do that dance to keep the volume 'ours' | |
| 18:15:49 | dansmith | yeah | |
| 18:21:41 | mriedem | dansmith: do you agree that if the image changes, we should run it through the scheduler as we do for image-backed servers? | |
| 18:21:51 | dansmith | mriedem: yeah I said that didn't I?\ | |
| 18:21:58 | mriedem | you said...something, | |
| 18:22:00 | mriedem | i was trying to confirm | |
| 18:22:33 | dansmith | I said "same policy-enforcment as the image-backed ones" | |
| 18:22:34 | mriedem | but ok i'll update the spec with more wordz | |
| 18:22:39 | dansmith | I ain't speakin' no jive | |
| 18:22:45 | mriedem | you said conflictory | |
| 18:22:52 | mriedem | my nose started bleeding | |
| 18:22:55 | dansmith | haha, okay I was speakin' jive | |
| 18:22:57 | dansmith | haha | |
| 18:50:51 | openstackgerrit | Merged openstack/nova master: Give drop_move_claim() correct docstring https://review.openstack.org/620170 | |
| 18:58:45 | mriedem | dansmith: having thought about this over lunch, i'm not really sure if we can/should try to update the host connector back into the attachments if rebuild fails - the volume would be in 'error' status, so i'm not sure if we should mess with it. rebuilding the server again later would just delete the empty volume attachment and start over with a new one | |
| 18:59:40 | dansmith | mriedem: okay I didn't think we would, because we'd be putting attachment info back in that is no longer valid (i.e. couldn't be deleted again when you retry) right? | |
| 19:00:20 | mriedem | we can delete it again when we retry | |
| 19:00:29 | mriedem | it's just a CRUD operation on the volume attachment record | |
| 19:40:41 | openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Support volume-backed server rebuild https://review.openstack.org/532407 | |
| 19:40:44 | mriedem | dansmith: updated ^ i'll wait to +2 | |
| 20:06:23 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Restore nova-consoleauth to install docs https://review.openstack.org/605154 | |
| 20:14:07 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Restore nova-consoleauth to install docs https://review.openstack.org/605154 | |
| 20:22:13 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Restore nova-consoleauth to install docs https://review.openstack.org/605154 | |
| 20:30:55 | mnaser | simple backport needing some votes - https://review.openstack.org/#/c/619351/ (stable/rocky already merged) | |
| 20:48:44 | melwitt | mriedem: by default, people shouldn't have to install nova-consoleauth on a fresh install _unless_ they've enabled the [workarounds]enable_consoleauth option. I added a comment to the review | |
| 20:49:35 | melwitt | I'm going to compare when those bugs were opened vs when the change that made nova-consoleauth optional merged to stable/rocky | |
| 20:50:44 | mriedem | both were opened this month | |
| 20:50:47 | mriedem | the duplicates | |
| 20:52:47 | melwitt | ok. I had tested that nova-consoleauth is no longer needed via this devstack change https://review.openstack.org/607070 back when I worked on the patch that made it optional | |
| 20:52:58 | melwitt | going to look at the duplicates now | |
| 21:14:50 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Mention size limit on user data in docs https://review.openstack.org/620700 | |
| 21:15:19 | flwang | mriedem: does nova support configuring the volume type when booting? | |
| 21:15:49 | mriedem | flwang: with microversion 2.67 in stein yes https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id60 | |
| 21:16:42 | flwang | is it a big feature? possible to do cherrypick? to old nova version? | |
| 21:20:39 | flwang | mriedem: any chance you know the commit link? | |
| 21:23:56 | mriedem | flwang: you're asking me if we can backport an API feature change? | |
| 21:24:17 | mriedem | you've been around openstack long enough to know that is a blatant violation of stable branch policy | |
| 21:24:40 | mriedem | whatever you want to fork in your product though...go ahead :) | |
| 21:29:54 | flwang | mriedem: no, i'm just lazy, so just ask if it's a big one, so that we can backport it in our private repo | |
| 21:30:06 | flwang | now i have got all the commits | |
| 21:30:17 | flwang | it's big one, seems no chance to backport :( | |
| 21:30:51 | efried | jaypipes: Responded on https://review.openstack.org/#/c/617042/ - lmk if that doesn't make sense. | |
| 21:32:53 | efried | jaypipes: btw, if it's specifically the use of the @property decorator you object to, I can change it to _get_report_client() for consistency with _get_resource_tracker(). I just wanted to take the opportunity to save some horizontal space, since we're already having trouble fitting things like https://review.openstack.org/#/c/617042/6/nova/compute/manager.py@a766 | |
| 21:35:32 | jaypipes | efried: answered. yeah, we can remove all that now and just set reportclient once. | |
| 21:35:45 | efried | jaypipes: Okay, cool. fup? | |
| 21:36:47 | jaypipes | yup. lemme re-vote (though I still think it would be cool to have those two patches separate) | |
| 21:37:32 | jaypipes | efried: +2 | |
| 21:38:01 | efried | jaypipes: Thanks! Re removing that flushing of the RT, I'm slightly leery of trying to do that change myself - how will we know it didn't break things? Though perhaps we could instead just self.reportclient.clear_cache() now that that's a thing. | |
| 21:38:43 | openstack | Launchpad bug 1804125 in OpenStack Compute (nova) "Nova placement disregards nova aggregate metadata" [Medium,Triaged] | |
| 21:38:43 | mriedem | heh, finally got an official bug for the regression in ocata where aggregate allocation ratios are no longer honored https://bugs.launchpad.net/nova/+bug/1804125 | |
| 21:39:08 | jaypipes | efried: maybe. just try it? :) I'm telling you I added that code comment back when the RT was still being converted by me to pass nodename for all the methods and track multiple compute nodes (instead of having multiple instances of the RT) | |
| 21:40:41 | openstackgerrit | Jack Ding proposed openstack/nova master: [WIP] Flavor extra spec and image properties validation https://review.openstack.org/620706 | |
| 21:49:07 | efried | jaypipes: um, afaict, we only get ComputeHostNotFound from get_node_uuid (in resource_tracker.py) - and I can't see where that guy is used at all. So that whole exception path may be completely unreachable. | |
| 21:51:24 | openstackgerrit | Merged openstack/nova-specs master: Support volume-backed server rebuild https://review.openstack.org/532407 | |
| 21:57:13 | jaypipes | efried: not a bit unlikely :) | |
| 22:02:43 | flwang | mriedem: jaypipes: is there a config option in nova.conf to set the default volume type? | |
| 22:04:12 | jaypipes | flwang: sorry, I have node idea :( mriedem probably is your best bet. (I didn't even think we *supported* volume types actually..) | |
| 22:04:32 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Use a static resource tracker in the compute manager https://review.openstack.org/620711 | |
| 22:04:42 | efried | jaypipes: Let's see how the gate feels about that ^ | |
| 22:04:59 | flwang | jaypipes: nova supports it in master(stein) | |
| 22:05:51 | mriedem | flwang: no, cinder has a config for the default volume type | |
| 22:06:12 | mriedem | nova only passes the volume type through, otherwise nova creates volumes w/o any volume type and you get the default from cinder | |
| 22:07:06 | jaypipes | efried: lol nice commit message. | |
| 22:07:10 | efried | :P | |
| 22:07:35 | flwang | mriedem: that makes sense, thank you very much | |
| 22:07:45 | efried | jaypipes: btw, I'm hoping you can review that whole series at some point. You're the A-1 expert in these code paths, I think. | |
| 22:08:12 | efried | jaypipes: This is to solve the whole thing about CERN's traffic problems. | |
| 22:08:48 | efried | ...that we put off in queens with that resource_provider_association_refresh conf var | |
| 22:09:51 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Nova the aggregate allocation ratio restriction in scheduler docs https://review.openstack.org/620713 | |
| 22:11:17 | jaypipes | efried: ack. | |
| 22:11:27 | jaypipes | efried: working on em.... | |
| 22:11:39 | efried | thx | |
| 22:14:39 | mriedem | i have -1ed | |
| 22:15:04 | mriedem | pull that get_node_uuid removal out | |
| 22:20:48 | openstackgerrit | Eric Fried proposed openstack/nova master: Turn off rp association refresh in nova-next https://review.openstack.org/616033 | |