| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-10-30 | |||
| 15:36:41 | bauzas | sean-k-mooney: yup | |
| 15:36:51 | sean-k-mooney | bauzas: ya that is totally undefiened | |
| 15:36:58 | mriedem | bauzas: well that race has never been fixed | |
| 15:37:11 | mriedem | see my comments in the bug about what starlingx did to try and mitigate it | |
| 15:37:18 | bauzas | yup I saw them | |
| 15:37:46 | mriedem | dansmith: yeah maybe, i haven't dug too deep | |
| 15:40:53 | sean-k-mooney | dansmith: well exclutding nfv instnaces we sould have only won the race reliably if there was no race e.g. no concurrent ligrations. even in the singel sechduler case i dont belive we record the instance is on a node untill it boots so there would always be the race between the schduler selecting the node for the second insnance and the first instance booting right | |
| 15:42:00 | dansmith | sean-k-mooney: um, what? | |
| 15:42:29 | dansmith | sean-k-mooney: we talking about the same bug/ | |
| 15:42:35 | tssurya | mriedem: I am catching up on them and addressing them | |
| 15:42:44 | tssurya | I will be working on them this week | |
| 15:43:01 | tssurya | my major concern being https://review.openstack.org/#/c/567785/29/nova/compute/api.py@2658 | |
| 15:43:06 | sean-k-mooney | sorry :) current migration of instance in a server group can race on instance boot even with one scuderler becasue of when we update the instance members https://bugs.launchpad.net/nova/+bug/1600251 | |
| 15:43:07 | openstack | Launchpad bug 1600251 in OpenStack Compute (nova) "live migration does not honor server group policy" [High,Fix released] | |
| 15:43:23 | sean-k-mooney | i was talking about the one bauzas linked so maybe not | |
| 15:43:29 | tssurya | (just back from vacation so excuse me if I am missing something obvious) | |
| 15:43:30 | gibi | mriedem: if you have time to work with those patches then please go ahead. and thank you | |
| 15:45:10 | melwitt | efried: looks like johnthetubaguy already got it :) | |
| 15:49:22 | mriedem | tssurya: i'll reply in the review | |
| 15:49:33 | tssurya | thanks | |
| 15:51:54 | melwitt | kashyap: hey, your review on this tcp-based console log patch would be appreciated https://review.openstack.org/575735 | |
| 15:52:19 | kashyap | melwitt: Morning, will look | |
| 15:52:24 | melwitt | thanks | |
| 15:56:07 | openstackgerrit | Florian Haas proposed openstack/nova master: Explain cpu_model_extra_flags and nested guest support https://review.openstack.org/609788 | |
| 15:57:12 | cfriesen | following a discussion with mriedem late last Friday, the HPET spec has been updated with something much simpler. (Turns out no trait is needed after all.) https://review.openstack.org/#/c/607989 | |
| 15:58:26 | openstackgerrit | Florian Haas proposed openstack/nova stable/rocky: Explain cpu_model_extra_flags and nested guest support https://review.openstack.org/609789 | |
| 15:59:45 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Fail to live migration if instance has a NUMA topology https://review.openstack.org/611088 | |
| 16:00:09 | openstackgerrit | Florian Haas proposed openstack/nova stable/queens: Explain cpu_model_extra_flags and nested guest support https://review.openstack.org/609790 | |
| 16:04:32 | openstackgerrit | Florian Haas proposed openstack/nova master: Explain cpu_model_extra_flags and nested guest support https://review.openstack.org/609788 | |
| 16:05:22 | johnthetubaguy | melwitt: there is a first time for everything :) | |
| 16:05:47 | melwitt | heh :P | |
| 16:06:10 | openstackgerrit | Florian Haas proposed openstack/nova stable/rocky: Explain cpu_model_extra_flags and nested guest support https://review.openstack.org/609789 | |
| 16:07:47 | openstackgerrit | Florian Haas proposed openstack/nova stable/queens: Explain cpu_model_extra_flags and nested guest support https://review.openstack.org/609790 | |
| 16:09:44 | efried | melwitt, johnthetubaguy: Thanks! | |
| 16:10:03 | openstackgerrit | sean mooney proposed openstack/nova master: harden placement init under wsgi https://review.openstack.org/610034 | |
| 16:34:36 | melwitt | johnthetubaguy: hey, thanks for the review! this is the corresponding reno update if you wouldn't mind https://review.openstack.org/613174 | |
| 16:34:57 | johnthetubaguy | melwitt: ah, missed that, looking | |
| 16:35:17 | melwitt | that one has to go direct to stable, in order to update a already release reno | |
| 16:35:25 | melwitt | thanks | |
| 16:36:55 | melwitt | oh, dangit I need to rebase | |
| 16:37:09 | melwitt | [the master change] | |
| 16:38:11 | melwitt | I used to have a master branch reno update on top, then learned it has to go direct to stable, so I abandoned the one on master, but that's preventing the approved bottom change from going to the gate | |
| 16:39:34 | gaudenz | Cloud someone have a look at https://review.openstack.org/#/c/523006/ ? This fixes a bug that has been around for a few releases and I made an effort to rebase it just a few days ago. Now all tests pass again. The bug is about resource usage calculations flapping between what nova calcualtes and what libvirt reports. | |
| 16:40:19 | gaudenz | It would be really nice if this could finally be approved and merged. If you have any comments I'm willing to do further work on the patch until it's acceptable. | |
| 16:45:51 | melwitt | hm, looks like I already orphaned the master branch reno, so not sure what's going on | |
| 16:47:50 | melwitt | a-ha, it's in the gate queue, just hasn't printed "starting gate jobs" on the review yet | |
| 16:51:06 | johnthetubaguy | melwitt: I just assumed I read the related changes the wrong way around again, phew | |
| 16:51:33 | melwitt | johnthetubaguy: nope, you're good! thanks for reviewing those | |
| 16:52:21 | johnthetubaguy | no worries, happened to just review the new console docs sfinucan wrote up, which was handy (but also need fixing due that console-auth changes) | |
| 16:52:42 | melwitt | yeah, I saw you're in console mode today | |
| 16:54:47 | openstackgerrit | Matthew Booth proposed openstack/nova master: Add local_root to block_device_info https://review.openstack.org/529029 | |
| 16:54:47 | openstackgerrit | Matthew Booth proposed openstack/nova master: Add DriverLocalImageBlockDevice https://review.openstack.org/526347 | |
| 16:56:02 | openstackgerrit | sean mooney proposed openstack/nova master: harden placement init under wsgi https://review.openstack.org/610034 | |
| 16:56:45 | sean-k-mooney | sorry for the noise ^ should now be ready for review | |
| 16:56:56 | openstackgerrit | melanie witt proposed openstack/nova stable/rocky: Add nova-status upgrade check for consoles https://review.openstack.org/614302 | |
| 16:58:45 | melwitt | mriedem: I'm not sure if I did that right. if you find other problems in it, let me know and I'll fix at the same time ^ | |
| 17:00:29 | kashyap | melwitt: Just added a bunch of comments in that review after doing some tests with TCP consoles. | |
| 17:00:48 | kashyap | In short, we need to ensure the log file for the TCP char device is created at domain (Nova instance) define time. | |
| 17:01:10 | melwitt | kashyap: ok, I will take a look. thanks for looking into it | |
| 17:01:31 | kashyap | melwitt: FWIW, I also double-checked it w/ a libvirt upstream dev who knows this area | |
| 17:01:44 | kashyap | Will see if I can punch any other holes in this tomm / later this week | |
| 17:04:28 | mriedem | melwitt: looks ok | |
| 17:05:11 | sean-k-mooney | stephenfin: jaypipes can ye take a look at https://review.openstack.org/#/q/topic:bug/1734320+(status:open) when you have time. i would like to try and include these in the next release of os-vif on thusday | |
| 17:05:52 | sean-k-mooney | other core that feel comfortable reivewint os-vif are also welcome | |
| 17:06:00 | openstackgerrit | Matthew Booth proposed openstack/nova master: Pass DriverBlockDevice to driver.attach_volume https://review.openstack.org/528363 | |
| 17:06:00 | openstackgerrit | Matthew Booth proposed openstack/nova master: Add local_root to block_device_info https://review.openstack.org/529029 | |
| 17:06:00 | openstackgerrit | Matthew Booth proposed openstack/nova master: Add DriverLocalImageBlockDevice https://review.openstack.org/526347 | |
| 17:06:01 | openstackgerrit | Matthew Booth proposed openstack/nova master: Fix libvirt volume tests passing invalid disk_info https://review.openstack.org/529328 | |
| 17:06:02 | openstackgerrit | Matthew Booth proposed openstack/nova master: Expose volume host type and path independent of libvirt config https://review.openstack.org/530786 | |
| 17:06:02 | openstackgerrit | Matthew Booth proposed openstack/nova master: Pass disk_info dict to libvirt_info https://review.openstack.org/529329 | |
| 17:06:03 | openstackgerrit | Matthew Booth proposed openstack/nova master: Local disk serial numbers for the libvirt driver https://review.openstack.org/529380 | |
| 17:06:03 | openstackgerrit | Matthew Booth proposed openstack/nova master: Don't generate fake disk_info in swap_volume https://review.openstack.org/530787 | |
| 17:06:21 | melwitt | mriedem: thanks. I wasn't sure if there were any things I missed about backporting a thing that says "Added in Stein" | |
| 17:06:38 | jaypipes | sean-k-mooney: will try. | |
| 17:06:43 | jaypipes | sean-k-mooney: meeting hell day. | |
| 17:07:09 | sean-k-mooney | jaypipes: understood. if it does not make it we can do another release when its ready | |
| 17:07:44 | mriedem | melwitt: you're handling it the same as i did for this https://github.com/openstack/nova/commit/daac9a69500c318b5e9d94be0031a1c9506d0340#diff-019a63548bbf8607e233ccbc6a85b0fc | |
| 17:08:06 | jaypipes | sean-k-mooney: why is the next release of os-vif on thursday? | |
| 17:09:13 | melwitt | mriedem: a-ha, sweet. I managed to not notice it in the upgrade checks list in the file that there was another that said "also useful going back". thanks | |
| 17:09:57 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove legacy request spec compat code from API https://review.openstack.org/614309 | |
| 17:09:57 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Pass request_spec from compute to cell conductor on reschedule https://review.openstack.org/582417 | |
| 17:10:09 | sean-k-mooney | jaypipes: thursday is m1 i think so we have to do a release | |
| 17:10:24 | mriedem | that was last week | |
| 17:10:26 | mriedem | derp | |
| 17:10:38 | sean-k-mooney | jaypipes: atleast that is what i got form https://review.openstack.org/#/c/612844/ | |
| 17:10:45 | sean-k-mooney | mriedem: m1? | |
| 17:11:17 | mriedem | https://wiki.openstack.org/wiki/Nova/Stein_Release_Schedule | |
| 17:11:23 | mriedem | Oct 25: s-1 milestone | |
| 17:11:42 | sean-k-mooney | oh your right then why the november first deadline in https://review.openstack.org/#/c/612844/ | |
| 17:11:54 | mriedem | bauzas made it up i guess | |
| 17:12:39 | mriedem | or is nov 1 related to some cve deadline? | |
| 17:13:32 | sean-k-mooney | mriedem: not that im aware of the cve fix was not meged yet it was the patch sets that i was asking for review on | |
| 17:15:19 | sean-k-mooney | in anycase i cant review my own patches and i would like to get as much of a mitigation into the next release as we can. if it does not make 1.12.0 however we can do a 1.12.1 easilly enough before the end of the year | |
| 17:16:17 | sean-k-mooney | im just going to grab some food but if people do review and want any change ill priotise them when i get back/when the comments are left | |
| 17:16:19 | sean-k-mooney | brb | |
| 17:19:28 | bauzas | mriedem: I made what ? :) | |
| 17:19:53 | bauzas | holidays, internal stuff, french situation ? :p | |
| 17:24:55 | stephenfin | johnthetubaguy: Would you be averse to me addressing your comments in a follow-up? That patch is already quite huge and I'm going to lose my hard-earned +2s on the follow-ups https://review.openstack.org/#/c/606148 | |
| 17:27:35 | stephenfin | Also, does anyone have Visio? We're going to need someone to modify this diagram for us https://docs.openstack.org/nova/queens/_images/SCH_5009_V00_NUAC-VNC_OpenStack.png | |
| 17:32:49 | melwitt | Visio, what a blast from the past | |