| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-10-10 | |||
| 05:56:23 | alex_xu | gmann: yea | |
| 05:56:31 | gmann | cool, | |
| 06:01:53 | gmann | let's start | |
| 06:02:03 | gmann | #startmeeting nova api | |
| 06:02:04 | openstack | Meeting started Wed Oct 10 06:02:03 2018 UTC and is due to finish in 60 minutes. The chair is gmann. Information about MeetBot at http://wiki.debian.org/MeetBot. | |
| 06:02:05 | openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | |
| 06:02:07 | openstack | The meeting name has been set to 'nova_api' | |
| 06:02:38 | gmann | #link https://wiki.openstack.org/wiki/Meetings/NovaAPI#Agenda_for_next_Office_hours | |
| 06:02:41 | gmann | agenda ^^ | |
| 06:03:11 | gmann | i have not got the much time to review for couple of weeks. | |
| 06:03:27 | gmann | #topic API Subteam Tracking | |
| 06:03:34 | gmann | #linkhttps://etherpad.openstack.org/p/stein-nova-subteam-tracking | |
| 06:03:51 | gmann | i added the approved/under review BP related to API on this extherpad | |
| 06:04:01 | gmann | l63 | |
| 06:04:36 | alex_xu | currently we have an api bp in the runway | |
| 06:04:53 | gmann | yeah | |
| 06:05:35 | gmann | #link https://etherpad.openstack.org/p/nova-runways-stein | |
| 06:06:30 | alex_xu | yea, the volume type in boot | |
| 06:07:09 | alex_xu | how much we left for extension merge? | |
| 06:07:29 | gmann | alex_xu: link https://review.openstack.org/#/q/project:openstack/nova+branch:master+topic:bp/api-extensions-merge-stein+status:open | |
| 06:07:34 | gmann | 3-4 patch i will say. | |
| 06:07:40 | gmann | i need to rebase them though | |
| 06:07:43 | alex_xu | cool | |
| 06:08:09 | gmann | this is last patch where i am removing the extensions register logic from wsgi.py - https://review.openstack.org/#/c/607092/ | |
| 06:08:26 | gmann | this is WIP, still mode code to remove | |
| 06:09:31 | alex_xu | cool, simpler code | |
| 06:10:08 | gmann | yeah, i will work on those and finish soon | |
| 06:10:19 | alex_xu | thanks | |
| 06:12:06 | gmann | alex_xu: i think we can remove this too - wsgi_action_extensions | |
| 06:12:25 | gmann | do you remember any of action extensions ? | |
| 06:13:00 | gmann | this one - https://github.com/openstack/nova/blob/master/nova/api/openstack/wsgi.py#L468 | |
| 06:13:04 | alex_xu | https://review.openstack.org/#/c/607092/1/nova/api/openstack/compute/routes.py@252 | |
| 06:13:26 | alex_xu | what benefit we remove it? | |
| 06:14:56 | gmann | humm, i was thinking for same resource side but these are all separate entry point for resource action | |
| 06:15:25 | gmann | agree to keep them separate. | |
| 06:16:13 | alex_xu | still feel a lot of complex thing in https://review.openstack.org/#/c/607092/1/nova/api/openstack/wsgi.py | |
| 06:16:50 | gmann | true, it could be more simpler | |
| 06:17:24 | alex_xu | without extension, does this still useful https://review.openstack.org/#/c/607092/1/nova/api/openstack/wsgi.py@88 | |
| 06:17:36 | alex_xu | gmann: ^ maybe worth to check this in your last patch | |
| 06:17:57 | alex_xu | I remember that is used for cache the response obj for the extension, not sure whether it is used by other place | |
| 06:18:36 | alex_xu | gmann: sorry, I mean those cache interface https://review.openstack.org/#/c/607092/1/nova/api/openstack/wsgi.py@97 | |
| 06:19:17 | gmann | yeah those were mainly used in extensions code but i can check if anywhere we use them | |
| 06:19:34 | gmann | but Request object we need | |
| 06:20:07 | alex_xu | yes, we need Req obj | |
| 06:21:46 | gmann | alex_xu: quickly grep them and it is only extensions code. i will remove them thanks. | |
| 06:22:08 | alex_xu | cool \o/ | |
| 06:22:32 | gmann | alex_xu: i will make this patch up by tonight and make it ready for you by tomorrow so that u can check if any more bits we can remove | |
| 06:22:45 | alex_xu | gmann: yea, will do | |
| 06:23:39 | gmann | thanks | |
| 06:23:46 | gmann | moving next | |
| 06:24:13 | gmann | api cleanup things | |
| 06:24:15 | gmann | #link https://etherpad.openstack.org/p/nova-api-cleanup | |
| 06:24:47 | gmann | and spec which need to include the hypervisor API cleanup - https://review.openstack.org/#/c/603969/ | |
| 06:25:24 | gmann | we need to weight on those with what worth to do and what not | |
| 06:25:58 | gmann | and next question on this is - should we do this in stein ? or wait for T to collect more worthy cleanup ? | |
| 06:27:02 | gmann | i can keep it updated for stein and wait till T if any more related API cleanup. And then we do those in single version bump based on agreement | |
| 06:27:07 | gmann | alex_xu: what u say ? | |
| 06:27:14 | alex_xu | pretty sure we won't get rid of all the cleanup in one microversion | |
| 06:27:30 | alex_xu | see the past, how much microversion we spend on deprecate proxy API :) | |
| 06:27:50 | gmann | :) yeah | |
| 06:28:08 | alex_xu | I will review the spec | |
| 06:28:13 | gmann | all you mean "all listed in etherpad" or all in API (because we do not know them now) | |
| 06:28:33 | alex_xu | all in API | |
| 06:28:59 | gmann | true, so that's is reason i want to wait till T so that we can cover max. | |
| 06:29:39 | alex_xu | maybe based on the requirement, if there is nothing urgent to change, then we needn't do it very soon | |
| 06:29:45 | gmann | and conclude that "this is we are not going to do" "this is ok to do". so that these does not comes again in future | |
| 06:29:52 | gmann | yeah | |
| 06:30:50 | gmann | i do not think anything urgent on those but i will also get opinion from mriedem and melwitt | |
| 06:31:01 | gmann | also | |
| 06:31:20 | alex_xu | I'm afriad another option is microversion shouldn't be huge | |
| 06:31:35 | gmann | humm | |
| 06:32:18 | gmann | i feel it should not be huge in term of complexity but should be ok in term of numbers. | |
| 06:33:54 | gmann | anyways that we can discuss on spec with exact list of changes | |
| 06:34:20 | alex_xu | yea | |
| 06:34:38 | gmann | anything else on this or we move next ? | |
| 06:35:19 | alex_xu | no more from me | |
| 06:35:31 | gmann | ok | |
| 06:35:56 | gmann | i do not have anything else to discuss form API subteam tracking section. | |
| 06:36:02 | gmann | alex_xu: do you have ? | |
| 06:36:13 | alex_xu | no | |
| 06:36:18 | gmann | ok | |
| 06:36:20 | gmann | #topic Bug Triage/Discussion | |
| 06:36:32 | gmann | #link https://etherpad.openstack.org/p/nova-api-weekly-bug-report | |
| 06:37:16 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova-specs master: Spec: Support filtering by forbidden aggregate https://review.openstack.org/603352 | |
| 06:38:12 | gmann | there are 4 new bugs | |
| 06:38:57 | openstack | Launchpad bug 1789382 in OpenStack Compute (nova) "openstack server list error" [Undecided,New] | |
| 06:38:57 | gmann | #link https://bugs.launchpad.net/nova/+bug/1789382 | |
| 06:39:03 | gmann | seems timeout from cell ? | |
| 06:40:54 | alex_xu | also see 'TypeError: 'object' object is not iterable' after cell timeout | |
| 06:41:18 | alex_xu | cell timeout is just a warning | |
| 06:42:32 | alex_xu | sounds like we handle something wrong | |
| 06:43:08 | gmann | humm object is none or something may be | |
| 06:44:31 | gmann | let me ask more log of api and compute | |
| 06:45:00 | gmann | i did not find any other pointer to debug without those | |
| 06:45:37 | alex_xu | yes | |
| 06:49:18 | gmann | done | |
| 06:49:28 | gmann | it seems hitting here - https://github.com/openstack/nova/blob/c6218428e9b29a2c52808ec7d27b4b21aadc0299/nova/compute/multi_cell_list.py#L265 | |
| 06:50:21 | openstack | Launchpad bug 1796132 in OpenStack Compute (nova) "SSL Verification Error on Launch Instance (queens)" [Undecided,New] | |
| 06:50:21 | gmann | #link https://bugs.launchpad.net/nova/+bug/1796132 | |
| 06:50:32 | gmann | "Seems forcing everythign to https isn't the wisest choice and requires more nova specific ssl config, I'll be going back to using http, so this bug may no longer be valid to work on." | |