Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-07-12
19:15:11 mriedem https://github.com/openstack/nova/tree/17.0.5
19:15:21 mriedem i don't know why they don't show up in the dropdown
19:15:35 melwitt oh, weird. I didn't know that hack
19:16:57 melwitt yass
19:33:24 openstackgerrit Eric Fried proposed openstack/nova-specs master: Make reshape-provider-tree reflect reality https://review.openstack.org/582350
20:01:08 mriedem TheJulia: just a few small things in the ironic rescue patch https://review.openstack.org/#/c/416487/ - i'd like to see the ironicclient 2.2.0 version negotiation stuff split out as a dependent change in the series if possible,
20:01:18 mriedem but i'm not married to that if it's more pain than it's worth
20:02:59 TheJulia I guess my real concern with retooling that is that we're less likely to get any traction on negotiation changes, and we'll end up shooting ourselves... again... with a static pin update.
20:03:46 TheJulia then again, I guess it could be before, but then what is the point if we're not actually upping the version in that single patch.
20:07:00 mriedem the point is it's laying the groundwork for a feature that's going to use it
20:07:18 mriedem again, i'm not a hard stop on splitting it out, just seems we could/should
20:07:32 mriedem also, seeing issues in n-cpu logs with StrictVersion usage in there
20:07:54 mriedem http://logs.openstack.org/04/528704/33/check/ironic-tempest-dsvm-ipa-partition-pxe_ipmitool-tinyipa-python3/ec5520f/logs/screen-n-cpu.txt.gz#_Jul_12_18_10_59_143344
20:09:01 mriedem we must be passing in StrictVersion(None) at some point
20:10:22 TheJulia Interesting
20:10:48 mriedem anywho, gotta drop for a bit
20:10:50 TheJulia Great point on the logging, I think. It has been a long time since I looked at this patch
20:11:13 TheJulia oh!
20:11:17 TheJulia i know how :\
20:21:54 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Compute: Handle reshaped provider trees https://review.openstack.org/576236
20:30:32 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Compute: Handle reshaped provider trees https://review.openstack.org/576236
20:31:11 openstackgerrit Eric Fried proposed openstack/nova-specs master: Make reshape-provider-tree reflect reality https://review.openstack.org/582350
20:32:21 openstackgerrit Eric Fried proposed openstack/nova-specs master: Make reshape-provider-tree spec reflect reality https://review.openstack.org/582350
20:43:39 melwitt has anyone gotten this error trying to run functional tests? tox.ConfigError: ConfigError: substitution key 'posargs' not found
20:54:14 efried melwitt: Paste me your [testenv:functional] paragraph from tox.ini
20:54:45 melwitt I just pulled it from master to see if it changed anything and it didn't. I wonder if my tox version is too old or something
20:55:04 efried that would have been my first guess, yeah.
20:55:31 efried melwitt: It's near the top of my todo list to bump our min required tox version to take advantage of the basepython fix anyway...
20:57:23 efried melwitt: What is your tox version?
20:57:35 melwitt 2.3.1
20:57:41 efried there ya go.
20:57:46 efried https://github.com/tox-dev/tox/issues/279
20:57:48 melwitt from whatever's for xenial64
20:57:56 openstackgerrit Jay Pipes proposed openstack/nova master: do not assume 1 consumer in AllocList.delete_all() https://review.openstack.org/582382
20:57:57 openstackgerrit Jay Pipes proposed openstack/nova master: perform reshaper operations in single transaction https://review.openstack.org/582383
20:58:52 melwitt thanx efried
20:58:54 efried melwitt: Be interesting to see if it goes away immediately by upgrading to 2.3.2
20:59:01 efried rather than jumping straight to latest or whatever.
20:59:11 efried make sure it's the same bug and all.
20:59:12 efried but whatevs.
20:59:13 melwitt yeah, lemme see
21:01:30 melwitt yup, 2.3.2 works
21:01:31 melwitt yey
21:01:58 efried sweet
21:02:10 efried I'm going to work on that patch to bump the minimum to 3.1.1 and see if it flies.
21:09:35 melwitt 2.3.2 forever
21:11:17 melwitt just hassling efried
21:15:50 efried TheJulia: Slightly lower down on my to-do list was adding os-ironic-api-version kwargs to more methods in ironicclient. That's not what you're working on, is it?
21:16:51 TheJulia efried: my brain kind of segfaulted upon all of the everyone implement x api features and bump their major versions discussion at the ptg.. and has not revisited versioning since.
21:16:54 TheJulia err
21:16:58 TheJulia s/ptg/summit/
21:17:22 efried TheJulia: ooo, that's also not at all what I'm referring to.
21:18:10 TheJulia oh, I know what your referring to, I'm not sure it is really actually needed for most usage patterns, at least that is what I was thinking about when I added it to a few more
21:18:44 TheJulia I'm just stating, my brain broke later on, and has not revisited the subject.
21:18:55 efried TheJulia: Okay. IIRC it was only needed in a small handful of nova use cases, like half a dozen.
21:19:08 TheJulia I thought it was... 3 or 4
21:19:37 openstackgerrit Eric Fried proposed openstack/nova master: Use tox 3.1.1 and basepython fix https://review.openstack.org/582392
21:19:40 TheJulia anyway, back to splitting it apart which actually makes sense given the fix necessary
21:19:42 efried melwitt: ^
21:20:23 efried stephenfin: https://review.openstack.org/582392
21:32:57 openstackgerrit melanie witt proposed openstack/nova master: DNM: Don't overwrite greenthread-local context in target_cell https://review.openstack.org/582332
22:05:33 openstackgerrit melanie witt proposed openstack/nova master: Add functional regression test for bug 1778305 https://review.openstack.org/582407
22:05:34 openstack bug 1778305 in OpenStack Compute (nova) "Nova may erronously look up service version of a deleted service, when hostname have been reused" [Undecided,New] https://launchpad.net/bugs/1778305
22:05:35 openstackgerrit melanie witt proposed openstack/nova master: Don't generate service UUID for deleted services https://review.openstack.org/582408
22:17:33 mriedem finally re-remembered something i had to learn 9 months ago
22:17:34 mriedem yay
22:17:41 mriedem *re-learned
22:28:47 openstackgerrit Matt Riedemann proposed openstack/nova master: Add note about reschedules and num_attempts in filter_properties https://review.openstack.org/582412
22:49:50 openstackgerrit melanie witt proposed openstack/nova stable/ocata: [stable only] Always commit quota decrement if build request found https://review.openstack.org/582413
22:53:42 melwitt mriedem: I'd appreciate a sanity check from you at your convenience ^ before I open a bug. this came from a customer seeing behavior where they delete an instance and don't see quota usage decrease (in the logs I saw racing creates and deletes)
22:54:43 melwitt I think I've convinced myself that it makes sense to commit the quotas whether we succeed in looking up the instance or not but it would be good to know if you think that's legit too
22:55:57 mriedem seems not crazy, but i'd have to load up all of that terrible context from conductor and such into my brain
22:56:18 mriedem i wish we could remove a lot of that "in the future" and "soon this will happen" stuff in api and conductor
22:56:23 melwitt yeah :( it was painful for me to re-learn that stuff too
22:57:14 melwitt yeah, same. for all I know, we can. honestly don't know where we're at on those
23:02:17 cfriesen re: the issue with service UUIDs and deleted services...you might want to take a look at https://bugs.launchpad.net/nova/+bug/1764556
23:02:18 openstack Launchpad bug 1764556 in OpenStack Compute (nova) ""nova list" fails with exception.ServiceNotFound if service is deleted and has no UUID" [Medium,In progress]
23:04:18 cfriesen not sure if it'll cause problems or not, but it's mucking around in the same area
23:04:27 melwitt yeah, thanks for the heads up. reading through it
23:05:12 openstackgerrit Julia Kreger proposed openstack/nova master: virt/ironic: Implement rescue and unrescue https://review.openstack.org/416487
23:05:13 openstackgerrit Julia Kreger proposed openstack/nova master: ironic: provide facilies to gracefully navigate versions https://review.openstack.org/582416
23:05:18 mriedem melwitt: i've had these forever https://review.openstack.org/#/q/topic:cleanup-update-instance+(status:open+OR+status:merged)
23:05:29 mriedem not in the same stuff you're removing, bu related idea on cleaning up transition code
23:05:31 TheJulia mriedem: ^^^
23:05:42 mriedem TheJulia: ack
23:05:59 TheJulia mriedem: I'm going to go kick the two jobs to recheck
23:06:14 mriedem good idea
23:06:25 melwitt mriedem: gah, I didn't know about those. I've starred them to remind myself to review
23:08:13 TheJulia heh, need to rebase one anyway
23:09:16 melwitt cfriesen: unless I'm all mixed up, it sounds like the patch I've proposed would fix that bug too
23:14:36 cfriesen melwitt: because it will no longer try to generate the new UUID?
23:14:44 melwitt yes
23:15:05 melwitt I'm assuming there's no reason to generate a new UUID for a deleted service, but maybe I'm wrong
23:16:21 melwitt if we want to do that, we'd have to add some conditionals in the Service.save() method to skip things like the version check if self.deleted and do something to handle ServiceNotFound
23:16:36 melwitt *if we want to generate UUID for deleted service
23:16:39 openstackgerrit Matt Riedemann proposed openstack/nova master: Pass request_spec from compute to cell conductor on reschedule https://review.openstack.org/582417
23:16:49 cfriesen melwitt: seems plausible that it'd fix the problem.
23:17:44 melwitt I'm gonna add another functional regression test to the stack for the bug you linked to verify it
23:18:26 melwitt maybe we'll have to do a different approach to fix things but the functional tests should be useful either way
23:27:17 mriedem TheJulia: couple of small things in https://review.openstack.org/#/c/582416/

Earlier   Later