| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-06-28 | |||
| 14:01:45 | mriedem | but it doesn't exist in the model https://review.openstack.org/#/c/563375/17/nova/db/sqlalchemy/api_models.py | |
| 14:01:55 | mriedem | _policies was changed to policy in the model | |
| 14:01:57 | mriedem | for the backref | |
| 14:02:12 | mriedem | crap meeting time | |
| 14:02:29 | dansmith | ohh | |
| 14:02:33 | dansmith | I never got that far | |
| 14:02:36 | dansmith | why is that changing? | |
| 14:02:48 | mriedem | i asked that as well, | |
| 14:03:00 | mriedem | i assume it's for model sanity since we don't have many policies per group, we have one | |
| 14:03:10 | mriedem | it's not a column, just a backref attribute | |
| 14:03:16 | dansmith | I thought we were adding a new backref | |
| 14:03:23 | dansmith | not a column obviously, but a new backreg | |
| 14:03:29 | dansmith | alright, well, nevermind me then | |
| 14:03:37 | mriedem | heh ok :) | |
| 14:03:39 | mriedem | well that was easy | |
| 14:04:17 | mriedem | yikun: so leave it like you have it for that joinedload | |
| 14:04:38 | dansmith | can we break the backref change out to something separate? | |
| 14:04:43 | dansmith | because that would be less confusing | |
| 14:05:00 | mriedem | yeah that would be nice | |
| 14:05:00 | dansmith | 1. refactor the name, 2. make the changes to actually support the new object field | |
| 14:05:55 | mriedem | left a comment | |
| 14:06:07 | jaypipes | mriedem: whatup? | |
| 14:06:08 | mriedem | yikun: ^ let me know if that all makes sense | |
| 14:06:11 | mriedem | jaypipes: nvm | |
| 14:07:56 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Merge server create for security group extension https://review.openstack.org/578714 | |
| 14:09:49 | yikun | yeah, got it, :), put refactor _policies stuff in a separate patch~ | |
| 14:10:04 | yikun | mriedem, dansmith ^ | |
| 14:11:21 | efried | gmann: Having the word "merge" in your commit title, that's great psychology. | |
| 14:11:36 | efried | Like, we had a guy running for mayor in Austin whose name was Will Wynn. | |
| 14:11:56 | mriedem | but he lost right? | |
| 14:12:10 | efried | Heh. I actually don't think so. I don't keep up on politics much though. | |
| 14:12:33 | mriedem | i'll be damned, mayor from 2003 to 2009 | |
| 14:12:34 | efried | mriedem: No, apparently he served as mayor from 2003 to 2009. | |
| 14:12:39 | efried | jynx | |
| 14:12:41 | mriedem | https://en.wikipedia.org/wiki/Will_Wynn#/media/File:Will_Wynn_2005.jpg | |
| 14:12:42 | mriedem | real hair? | |
| 14:12:50 | yikun | mriedem: yeah, maybe go to the vocation. : ) | |
| 14:13:30 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Merge server create for user data extension https://review.openstack.org/578709 | |
| 14:13:56 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Merge server create for security group extension https://review.openstack.org/578714 | |
| 14:14:43 | openstackgerrit | Merged openstack/nova master: Remove compatibility code for instance groups https://review.openstack.org/578192 | |
| 14:14:53 | openstackgerrit | Merged openstack/nova master: Fix the duplicated config options of api_database and placement_database https://review.openstack.org/577023 | |
| 14:19:26 | openstackgerrit | xulei proposed openstack/nova master: Disable limits if force_hosts or force_nodes is set https://review.openstack.org/576693 | |
| 14:26:37 | mriedem | can i get a stable review on this? https://review.openstack.org/#/c/563700/ | |
| 14:26:43 | mriedem | johnthetubaguy: ^? | |
| 14:27:30 | johnthetubaguy | mriedem: oh that is a tasty one, will take a look | |
| 14:36:26 | openstackgerrit | Matthew Booth proposed openstack/nova master: Remove irrelevant comment https://review.openstack.org/578821 | |
| 14:36:27 | openstackgerrit | Matthew Booth proposed openstack/nova master: Move static _get_power_off_values to compute_utils https://review.openstack.org/578822 | |
| 14:44:23 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove 'tools/releasenotes_tox.sh' https://review.openstack.org/534383 | |
| 14:44:24 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Reuse envdirs https://review.openstack.org/534382 | |
| 14:44:25 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Document and dedupe mostly everything https://review.openstack.org/578825 | |
| 14:44:26 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Convert 'placement_api_docs' into a Sphinx extension https://review.openstack.org/578826 | |
| 14:45:30 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Convert 'placement_api_docs' into a Sphinx extension https://review.openstack.org/578826 | |
| 14:51:46 | openstackgerrit | Merged openstack/python-novaclient master: Add release note link in README https://review.openstack.org/578664 | |
| 14:57:22 | efried | stephenfin: You split https://review.openstack.org/#/c/534382/ into https://review.openstack.org/#/c/534382/9 and https://review.openstack.org/#/c/578825/1 right? | |
| 14:57:47 | mnaser | i asked this a bit earlier but | |
| 14:57:54 | mnaser | https://docs.openstack.org/nova/latest/user/cells.html#adding-a-new-cell-to-an-existing-deployment | |
| 14:57:57 | stephenfin | efried: Yes. https://review.openstack.org/#/c/534382/ is the one I really want but I need to sent a note to the mailing lsit first | |
| 14:57:59 | mnaser | "To expand your deployment with a new cell, first follow the usual steps for standing up a new Cells V1 cell." | |
| 14:58:00 | efried | stephenfin: but you moved the larger part of the change to the new change-id, making it harder to diff. | |
| 14:58:00 | stephenfin | *list | |
| 14:58:18 | stephenfin | efried: Sec. I can fix that, if you'd like? | |
| 14:58:20 | mnaser | is that a typo or do we really have to setup cells v1 and upgrade to cells v2... | |
| 14:58:39 | efried | stephenfin: Meh, it'll probably do me good to re-review from scratch anyway. | |
| 14:58:44 | mnaser | i'll be very happy to fix the docs if that's incorrect | |
| 14:58:46 | efried | was just giving you grief | |
| 14:59:13 | mriedem | mnaser: i think that's a typo | |
| 14:59:16 | mriedem | or out of context | |
| 14:59:22 | melwitt | mnaser: uh no, what I meant there was create a new db, mq, etc whatever you would have normally done to set up a new cell | |
| 14:59:56 | mnaser | okay, i'll be working on adding a new cells v2 over the next few days so there might be a bunch of doc patches that hopefully help | |
| 14:59:58 | melwitt | so it should be reworded if that's how it sounds to other people | |
| 14:59:59 | melwitt | (if it sounds like it's saying set up cells v1) | |
| 15:00:05 | melwitt | thanks mnaser | |
| 15:00:21 | mnaser | and hopefully adding cells v2 native support in openstack ansible (not just 1 cell) | |
| 15:01:04 | mriedem | yeah i'd just generalize https://docs.openstack.org/nova/latest/user/cells.html#adding-a-new-cell-to-an-existing-deployment into saying, create new db and mq, sync db, create cell with new db and mq, discover hosts, etc | |
| 15:01:26 | mriedem | don't need to run map_instances if it's a new deploy | |
| 15:01:36 | melwitt | right | |
| 15:02:37 | mriedem | if you're adding existing child cells to cells v2 mappings, then you skip the "create db and mq" part, and just create cell mapping with existing db and mq for child cell, discover hosts and map_instances | |
| 15:03:22 | mriedem | although step 4 in "Upgrade with Cells V1" already says that basically | |
| 15:03:34 | mriedem | "You will need to repeat this step for each cell in your deployment" | |
| 15:04:29 | mriedem | efried: doesn't the in-tree powervm driver support config drive now too? https://docs.openstack.org/nova/latest/user/config-drive.html#requirements-and-guidelines | |
| 15:04:35 | mriedem | "The following hypervisors support the configuration drive: libvirt, XenServer, Hyper-V, and VMware. Also, the Bare Metal service supports the configuration drive. " | |
| 15:05:20 | efried | mriedem: yes. Will propose an update to that, unless you're already in there for some reason. | |
| 15:05:26 | mriedem | go for it | |
| 15:05:39 | mriedem | note the release the support was added for powervm | |
| 15:06:12 | mriedem | looks like queens https://review.openstack.org/#/c/409404/ | |
| 15:07:14 | efried | agree | |
| 15:07:15 | openstack | Launchpad bug 1779159 in OpenStack Compute (nova) "Store metadata on a configuration drive in nova - missing powervm" [Low,Triaged] | |
| 15:07:15 | mriedem | https://bugs.launchpad.net/nova/+bug/1779159 | |
| 15:08:51 | mriedem | hmm, when was xenapi_disable_agent removed? | |
| 15:08:55 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add policy to InstanceGroup object and api models. https://review.openstack.org/563375 | |
| 15:10:06 | openstackgerrit | Eric Fried proposed openstack/nova master: Mention PowerVM support of config drive https://review.openstack.org/578840 | |
| 15:10:13 | efried | mriedem, edmondsw: ^ | |
| 15:10:22 | efried | edmondsw: not sure if there's more stuff we should mention in other places in there. | |
| 15:10:39 | mriedem | +2 | |
| 15:10:40 | mriedem | thanks | |
| 15:11:03 | yikun | mriedem: I upload the recent patch and address comments from you and dans, but still WIP (lack testcase), if you have time can take a look, I will add test case tomorrow. | |
| 15:11:13 | mriedem | yikun: ok | |
| 15:11:33 | mriedem | yikun: were you going to split out the _policies backref modles change? | |
| 15:11:36 | mriedem | *models | |
| 15:11:41 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Correct documentation for '[pci] passthrough_whitelist' https://review.openstack.org/552874 | |