Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-06-19
03:55:37 openstackgerrit zhangyangyang proposed openstack/nova master: Remove os_compute_api:os-extended-status https://review.openstack.org/576340
04:05:31 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.openstack.org/576344
04:55:54 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Add full traceback to ExceptionPayload in versioned notifications https://review.openstack.org/564092
05:16:01 openstackgerrit Dinesh Bhor proposed openstack/nova master: NUMACell, InstanceNUMACell: Adopt 'PCPU' changes https://review.openstack.org/576021
05:39:24 openstackgerrit zhangyangyang proposed openstack/nova master: Remove os_compute_api:os-extended-availability-zone https://review.openstack.org/576331
05:55:19 openstackgerrit zhangyangyang proposed openstack/nova master: Remove os_compute_api:os-extended-status https://review.openstack.org/576340
06:00:54 openstackgerrit zhangyangyang proposed openstack/nova master: Remove useless parameter default_flavor https://review.openstack.org/576318
06:38:02 openstackgerrit zhangyangyang proposed openstack/nova master: Remove Chancefilter https://review.openstack.org/576384
06:48:30 openstackgerrit garyk proposed openstack/nova master: Resource tracker: improve resource tracker periodic task https://review.openstack.org/576052
06:50:11 openstackgerrit garyk proposed openstack/nova master: Resource tracker: remove costly copy https://review.openstack.org/576099
07:27:05 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Optimize member_of check for nested providers https://review.openstack.org/573203
07:32:58 openstackgerrit Zhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.openstack.org/507486
07:36:00 openstackgerrit zhangyangyang proposed openstack/nova master: Remove os_compute_api:os-extended-status https://review.openstack.org/576340
07:45:42 openstackgerrit zhangyangyang proposed openstack/nova master: Remove os_compute_api:os-extended-status https://review.openstack.org/576340
08:17:20 vpc_ hi
08:17:23 vpc_ anyone
08:20:31 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Add full traceback to ExceptionPayload in versioned notifications https://review.openstack.org/564092
08:29:07 openstackgerrit Rajesh Tailor proposed openstack/nova master: Make host_aggregate_map dictionary case-insensitive https://review.openstack.org/498334
08:29:18 gibi Kevin_Zheng: I left couple of comments inline https://review.openstack.org/#/c/564092/
08:29:43 Kevin_Zheng gibi, thanks checking
08:33:03 openstackgerrit zhangyangyang proposed openstack/nova master: Remove os_compute_api:os-extended-availability-zone https://review.openstack.org/576331
08:42:10 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Fix all invalid obj_make_compatible test case https://review.openstack.org/574240
08:47:17 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Add full traceback to ExceptionPayload in versioned notifications https://review.openstack.org/564092
08:47:42 Kevin_Zheng gibi done
08:47:50 gibi Kevin_Zheng: thanks, looking
08:49:59 gibi Kevin_Zheng: I'm +2 thanks for the effort
08:50:28 gibi stephenfin: Could you hit https://review.openstack.org/#/c/564092 again? Kevin_Zheng fixed your comments and it looks good to me
08:50:33 Kevin_Zheng gibi, my pleasure, thank you for the review
08:51:35 vpc_ gibi
08:51:36 vpc_ can i ask
08:51:37 Kevin_Zheng gibi, I would like to help on anything if needed
08:51:53 gibi vpc_: sure, go ahead
08:52:25 vpc_ how can i take a snapshot of an instance with 3 volumes attached on hit
08:53:17 gibi Kevin_Zheng: in Stein I would like to put some extra effort finishing the versioned notification transformation as in Rocky I did not make much progress but only couple of notification is missing
08:53:37 gibi Kevin_Zheng: your work is appriciated there
08:53:44 Kevin_Zheng sure
08:53:48 Kevin_Zheng I would love to
08:53:54 gibi Kevin_Zheng: cool, thanks
08:53:55 vpc_ gibi any thoughts?
08:54:31 gibi vpc_: do you need live snapshot or offline?
08:54:50 vpc_ live snapshot of instance
08:55:16 vpc_ i snapshot my instance but it not get all volume attached on it
08:57:20 openstackgerrit zhangyangyang proposed openstack/nova master: Remove os_compute_api:os-config-drive https://review.openstack.org/576435
08:57:46 gibi vpc_: if you have 3 volumes then I guess you need to create 3 snapshots one for each
08:58:19 gibi vpc_: like calling this https://developer.openstack.org/api-ref/compute/#assisted-volume-snapshots-os-assisted-volume-snapshots 3 times
08:58:51 gibi vpc_: via cinder
08:59:21 vpc_ so i need 4 snapshot?
09:00:31 gibi vpc_: also look at https://docs.openstack.org/cinder/latest/admin/blockstorage-groups.html
09:01:12 vpc_ so this a volume snapshot?
09:01:22 vpc_ how about the instance itself?
09:01:26 gibi https://developer.openstack.org/api-ref/block-storage/v3/index.html#group-snapshots
09:02:28 openstackgerrit jichenjc proposed openstack/nova master: Mention server status in api-ref when rebuild https://review.openstack.org/576438
09:02:43 gibi vpc_: you meant the root fs of the instance?
09:02:54 vpc_ yes sir
09:03:02 vpc_ like in AWS
09:03:11 vpc_ if you take a image of an instance
09:03:21 vpc_ all of its volume will be snapshot too
09:05:01 gibi vpc_: have you tried https://developer.openstack.org/api-ref/compute/#create-image-createimage-action ?
09:07:06 vpc_ yes i already create a snapshot on instance via horizon
09:42:45 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Add rules column to instance_group_policy table. https://review.openstack.org/560832
09:42:46 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Add InstanceGroupPolicy object https://review.openstack.org/573628
09:42:47 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Add policy to InstanceGroup object and api models. https://review.openstack.org/563375
09:42:48 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Add policy field to ServerGroup notification object https://review.openstack.org/563401
09:42:49 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Change the anti-affinity Filter to adapt to new policy https://review.openstack.org/571166
09:42:50 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Adapt _validate_instance_group_policy to new policy model https://review.openstack.org/571465
09:42:51 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/567534
09:43:34 openstackgerrit jichenjc proposed openstack/nova master: Adjust log style and remove ocata support https://review.openstack.org/576462
09:54:32 openstackgerrit Merged openstack/nova-specs master: Spec: Handling Reshaped Provider Trees https://review.openstack.org/572583
10:30:13 openstackgerrit Merged openstack/nova master: Only run placement request filters when Placement will be called https://review.openstack.org/569969
10:53:01 openstackgerrit Merged openstack/nova master: libvirt: remove unused get_ovs_interfaceid() https://review.openstack.org/572699
11:21:34 vpc_ hi nova guys
11:39:11 efried ō/
12:01:14 openstackgerrit Merged openstack/nova master: Add policy rule to block image-backed servers with 0 root disk flavor https://review.openstack.org/561284
12:22:33 openstackgerrit Chris Dent proposed openstack/nova master: Isolate placement database config https://review.openstack.org/541435
12:22:34 openstackgerrit Chris Dent proposed openstack/nova master: Ensure that os-traits sync is attempted only at start of process https://review.openstack.org/553857
13:03:35 mriedem gibi: i answered your questions here https://review.openstack.org/#/c/556334/ - i don't think i have any (obvious to me) changes to make
13:18:08 mriedem sahid: thanks for your reviews on that live migration series of mine, replied in https://review.openstack.org/#/c/515423/ and https://review.openstack.org/#/c/551370/ - it is a bit hairy, i struggled a bit while writing this for what definitely needs to come over from the destination host to build the guest xml
13:19:15 gibi mriedem: here it is binding:host https://review.openstack.org/#/c/523604/18/nova/network/neutronv2/api.py@1223 but here it is binding:host_id https://review.openstack.org/#/c/556334/15/nova/network/neutronv2/api.py@2422 so I'm confused
13:21:32 mriedem gibi: so when we create the port binding, this is checking the host field in the request body https://review.openstack.org/#/c/414251/66/neutron/plugins/ml2/plugin.py@2044
13:21:43 mriedem from neutron-lib, the field names are defined as: https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/portbindings_extended.py#L58
13:22:02 mriedem the binding:host_id is the field on the port resource, not the binding resource
13:22:20 mriedem when you set a port binding resource to active, it atomically updates the port's binding:host_id field
13:22:27 mriedem it's confusing that they are different, but that's the way it is
13:22:52 mriedem re: https://review.openstack.org/#/c/523604/18/nova/network/neutronv2/api.py@1223
13:22:59 gibi Ahh I see now. the difference between the spec and the neutron code did not make this easier :)
13:23:12 mriedem yeah as i said in ^ the spec is outdated
13:23:16 gibi yeah
13:23:27 mriedem and the neutron ml2 plugin and port binding extended api reference doesn't yet have api ref docs
13:23:33 mriedem something i asked mlavalle about
13:24:28 mriedem note that if the binding resource field was 'host_id' rather than 'host' the live migration job would be failing at the top of the series
13:25:00 mriedem hmm, which it is now, /me looks
13:25:49 mriedem haven't seen this before http://logs.openstack.org/37/522537/29/check/nova-live-migration/08534a4/logs/screen-n-cpu.txt.gz?level=TRACE#_Jun_19_01_11_49_573713
13:26:37 mriedem this might be something new in libvirt 4.0.0 using the queens UCA
13:26:43 mriedem which we weren't using last time i checked these job results
13:28:38 gibi having a tempest test at the top helps, thanks
13:29:47 gibi mriedem: regarding the rollback of multiple port activations. I don't know what can we do so let's keep it as is and try to fix it later when we see the real problem
13:30:08 gibi mriedem: I will try to get back to your neutron-new-port-binding-api series to re-review but it might not be today
13:30:48 mriedem gibi: sure, that's ok, thanks for what you've done so far
13:37:23 gibi mriedem: btw, Kevin_Zheng fixed up https://review.openstack.org/#/c/564092/ and I'm +2 so you can send it in
13:37:48 mriedem ok

Earlier   Later