Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-06-12
16:32:41 mnaser https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L8180-L8186
16:33:21 mnaser https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L8235-L8241
16:33:38 mnaser so because it already exists with ceph, it probably doesnt touch it
16:34:12 mnaser (i think..)
16:34:55 tasker hey, good morning. I'm checking up on https://review.openstack.org/#/c/550865/ . is there something else needed before it can be merged? also, is this review a candidate for backport to Pike?
16:34:59 cfriesen mnaser: we're seeing the underlying size change to the "new" size when doing a resize...but the guest needs to re-run "mkswap" to make use of the larger amount of space.
16:36:08 cfriesen mnaser: and if we revert the resize then the underlying size stays at the "new" size even after reverting, which would seem to be a resource tracking bug.
16:37:27 mnaser i can't even find the codebase where nova does mkfs
16:37:31 mnaser i can find the function calls..
16:38:52 mnaser ok _create_swap()
16:39:15 mnaser looks like mkswap only happens in _create_swap and nowhere else
16:39:27 mnaser idk if we want to call that a bug or not
16:39:42 mnaser i'd want to avoid touching underlying fs once something is booted
16:45:26 mriedem jaypipes: i made that server_default=text("0") model change for a reason, to match the db schema migration script; the fact it passes with sqlite and postgresql makes me think it's a bug in whatever mysql comparison code is happening, which zzzeek seems to agree with
16:45:44 tasker https://review.openstack.org/#/dashboard/self is only showing open reviews. isn't there a way to show all reviews that I've submitted?
16:46:21 mriedem tasker: https://review.openstack.org/#/q/owner:eric%2540awnix.com ?
16:46:41 tasker oh.
16:46:44 tasker thanks!
16:51:35 openstackgerrit Matt Riedemann proposed openstack/nova master: api-ref: expand on various bdm parameters https://review.openstack.org/574805
16:53:20 jaypipes mriedem: k. I haven't pushed any further update on that series...
16:53:44 mriedem jaypipes: having said that, i'm not sure what to do here, since i don't want to hold things up while a bug in a dependent library gets fixed
16:53:58 openstackgerrit Simon Dodsley proposed openstack/nova master: Add enhanced KVM storage QoS quotas https://review.openstack.org/558530
16:53:59 mriedem i guess i can respin, remove the model change, add a FIXME and report a bug to oslo.db
16:54:03 jaypipes mriedem: maybe we just put a TODO in there?
16:54:13 mriedem yeah i'll do that quick
16:54:15 jaypipes mriedem: or I can do it. just let me know.
16:54:31 mriedem i've got it local, 2 seconds
16:54:41 jaypipes k, thx mriedem
16:55:55 simondodsley_ mriedem: cinder docs review added https://review.openstack.org/#/c/574804/
16:55:56 cfriesen mnaser: for what it's worth, for "local" filesystems we don't copy over the swap file but instead create a whole new one, so the guest sees the "right" swap size when it boots up after the resize.
16:56:30 mnaser cfriesen: ah you are right about that one, so we do kinda make the drive disappear with resize
17:07:22 openstackgerrit Merged openstack/nova master: Use instance project/user when creating RequestSpec during resize reschedule https://review.openstack.org/571245
17:12:35 openstackgerrit Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766
17:12:36 openstackgerrit Chris Dent proposed openstack/nova master: Isolate placement database config https://review.openstack.org/541435
17:12:37 openstackgerrit Chris Dent proposed openstack/nova master: Ensure that os-traits sync is attempted only at start of process https://review.openstack.org/553857
17:13:21 openstackgerrit Chris Dent proposed openstack/nova master: Add PLACEMENT_DB_ENABLED=True to the nova-next job https://review.openstack.org/564067
17:15:01 openstackgerrit Matt Riedemann proposed openstack/nova master: add consumers generation field https://review.openstack.org/557958
17:15:04 mriedem jaypipes: ^ but i gave up on trying to rebase the series after https://review.openstack.org/#/c/572280/ caused merge conflicts
17:15:08 mriedem i'll leave that rebase to you
17:22:32 jaypipes mriedem: roger
17:24:13 openstackgerrit Merged openstack/nova master: libvirt: Don't report DISK_GB if sharing https://review.openstack.org/560459
17:44:44 tasker mriedem: is there something that needs to be done for https://review.openstack.org/#/c/550865/? also, can it be backported to Pike, or is that window closed? ( re: https://bugs.launchpad.net/nova/+bug/1754360 )
17:44:46 openstack Launchpad bug 1754360 in OpenStack Compute (nova) "no unquiesce for volume backed on quiesce failure" [Medium,In progress] - Assigned to Eric M Gonzalez (egrh3)
17:45:32 cdent mriedem: is "oslo_policy/policy.py:865: UserWarning: Policy placement:resource_providers:traits:update failed scope check. The token used to make the request was project scoped but the policy requires ['system'] scope. This behavior may change in the future where using the intended scope is required" something you're already aware of and I don't need to think about?
17:48:37 mriedem tasker: just requires reviews; pike is open for backports
17:49:13 mriedem tasker: and for a long time https://superuser.openstack.org/articles/extended-maintenance-openstack/
17:51:07 mriedem cdent: i'm aware of it, and slightly annoyed at how verbose that is
17:51:11 mriedem especially if it's not cached
17:51:16 openstackgerrit Chris Dent proposed openstack/nova master: Use nova.db.api directly https://review.openstack.org/543262
17:51:36 mriedem basically if you have a scope type set on a policy rule that gets used, and enable_scope=False (the default) then you get spammed with warnings
17:51:40 cdent mriedem: yeah. you kinda wanna be able to say omg, I know
17:51:50 mriedem probably needs to be a bug in oslo.policy
18:04:46 openstackgerrit Brianna Poulos proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204
18:04:47 openstackgerrit Brianna Poulos proposed openstack/nova master: Add notification support for trusted_certs https://review.openstack.org/563269
18:04:48 openstackgerrit Brianna Poulos proposed openstack/nova master: Add certificate validation docs https://review.openstack.org/560158
18:10:49 mriedem bpoulos: you moved https://review.openstack.org/#/c/479949/76..77/nova/compute/manager.py but didn't move the related unit test
18:13:46 mriedem oh nvm i guess it's here https://review.openstack.org/#/c/561262/26/nova/tests/unit/compute/test_compute_mgr.py
18:17:20 mriedem bpoulos: ok there is just 1 missing test in https://review.openstack.org/#/c/479949/ - i can add that if you like
18:22:38 bpoulos mriedem: that would be great, thanks!
18:43:55 openstackgerrit Simon Dodsley proposed openstack/nova master: Add enhanced KVM storage QoS quotas https://review.openstack.org/558530
18:45:06 openstackgerrit Matt Riedemann proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949
18:45:07 openstackgerrit Matt Riedemann proposed openstack/nova master: Plumb trusted_certs through libvirt driver image paths https://review.openstack.org/561262
18:45:08 openstackgerrit Matt Riedemann proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204
18:45:09 openstackgerrit Matt Riedemann proposed openstack/nova master: Add notification support for trusted_certs https://review.openstack.org/563269
18:45:10 openstackgerrit Matt Riedemann proposed openstack/nova master: Add certificate validation docs https://review.openstack.org/560158
19:13:23 openstackgerrit Jay Pipes proposed openstack/nova master: add consumers generation field https://review.openstack.org/557958
19:13:24 openstackgerrit Jay Pipes proposed openstack/nova master: placement: Allocation.consumer field https://review.openstack.org/565405
19:13:25 openstackgerrit Jay Pipes proposed openstack/nova master: rework allocation handler _allocations_dict() https://review.openstack.org/565407
19:13:26 openstackgerrit Jay Pipes proposed openstack/nova master: Add a microversion for consumer generation support https://review.openstack.org/565604
19:13:27 openstackgerrit Jay Pipes proposed openstack/nova master: Fix nits from change Id609789ef6b4a4c745550cde80dd49cabe03869a https://review.openstack.org/574324
19:13:44 jaypipes mriedem: ^ rebased and merge-conflict-fixed.
19:16:28 mriedem jaypipes: https://review.openstack.org/#/c/557958/29..30/nova/db/sqlalchemy/api_models.py
19:24:35 melwitt mriedem: great, thanks for swapping the runway
19:28:14 openstackgerrit Jay Pipes proposed openstack/nova master: add consumers generation field https://review.openstack.org/557958
19:28:15 openstackgerrit Jay Pipes proposed openstack/nova master: placement: Allocation.consumer field https://review.openstack.org/565405
19:28:16 openstackgerrit Jay Pipes proposed openstack/nova master: rework allocation handler _allocations_dict() https://review.openstack.org/565407
19:28:17 openstackgerrit Jay Pipes proposed openstack/nova master: Add a microversion for consumer generation support https://review.openstack.org/565604
19:28:18 openstackgerrit Jay Pipes proposed openstack/nova master: Fix nits from change Id609789ef6b4a4c745550cde80dd49cabe03869a https://review.openstack.org/574324
19:28:20 jaypipes mriedem: sorry about that. fixed.
19:53:14 openstackgerrit Artom Lifshitz proposed openstack/nova master: DNM: Depends on intel-nfv-ci-tests to test NUMA LM https://review.openstack.org/574872
20:00:20 openstackgerrit Merged openstack/nova master: Refactor libvirt get_memory_used_mb() https://review.openstack.org/571030
20:31:59 mriedem dansmith: i'm assuming you could have cert validation setup on kernel and ramdisk images...?
20:32:12 mriedem because this libvirt driver change isn't passing the trusted certs through in that case
20:32:19 mriedem not sure if that was intentional
20:32:22 dansmith mriedem: um
20:32:37 dansmith mriedem: if you use that kind of image, each would have its own signature
20:32:40 mriedem in general, i assume any image we download from glance could be signed and verified
20:32:50 dansmith aren't we buried deep in the image code enough that we'd verify those like anything else/
20:33:16 mriedem i think so https://review.openstack.org/#/c/561262/27/nova/virt/libvirt/driver.py@7432
20:33:28 mriedem this is the trouble part that's missing passing through trusted_certs
20:34:20 dansmith mriedem: you know I didn't write any of that code right?
20:34:49 mriedem IT'S YOUR GD CODE NOW SMITH
20:34:59 openstackgerrit Artom Lifshitz proposed openstack/nova master: Add InstanceNUMATopology to LibvirtLiveMigrateData https://review.openstack.org/566398
20:35:00 openstackgerrit Artom Lifshitz proposed openstack/nova master: libvirt live migration: fit NUMA topology on dest https://review.openstack.org/567242
20:35:01 openstackgerrit Artom Lifshitz proposed openstack/nova master: Service version check for NUMA live migration https://review.openstack.org/566723
20:35:02 openstackgerrit Artom Lifshitz proposed openstack/nova master: DNM: Depends on intel-nfv-ci-tests to test NUMA LM https://review.openstack.org/574872
20:35:05 mriedem your prints are all over this
20:35:17 mriedem it's 1/8 my baby now too
20:35:22 dansmith I really have lost most of my context on it at this point
20:35:28 dansmith I just split this off from the main patch for them

Earlier   Later