Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-04-19
15:05:16 mriedem stephenfin: as in StrOpt with serialized json?
15:05:18 mriedem i also hate that
15:05:20 takashin python-novaclient stable maintainers for pike, would you review https://review.openstack.org/#/c/562500/ ? This patch fixes pike gate job failure.
15:05:25 mriedem i would rather us load in a yaml file
15:05:28 stephenfin jaypipes: Oh, I'm not planning to keep it
15:05:31 mriedem if that's the alternative
15:05:51 melwitt takashin: I think you need to backport that to queens first, then to pike
15:06:06 stephenfin It just seems like we don't have a decided-upon alternative and I need to load _something_
15:06:11 mriedem takashin: done
15:06:13 dansmith stephenfin: I thought I suggested the cinder model for encoding single-level dicts in config with sections?
15:06:21 dansmith it's stupid simple
15:06:21 mriedem melwitt: fix came from queens
15:06:32 takashin melwitt: it has already merged in queens.
15:06:37 stephenfin dansmith: Yeah, it seems horrible though -> https://github.com/stephenfin/nova/commit/b2c0421e64d627aaad2cf9ac71c6e1c79357a970
15:06:44 melwitt mriedem, takashin: oh, okay. my bad
15:07:05 takashin mriedem: Thank you.
15:07:12 stephenfin dansmith: With cinder, they still know the group names ahead of time. We're having to build that based on another value
15:07:21 stephenfin It works, but it seem...wrong (IMO, anyway)
15:07:42 dansmith stephenfin: eh? they let you set your own section names.. backend_foo and what not
15:08:42 bauzas dansmith: I don't have the context, what were you suggesting and do you think it could apply for https://review.openstack.org/#/c/557065/ ?
15:09:18 dansmith bauzas: stephenfin: https://wiki.openstack.org/wiki/Cinder-multi-backend
15:09:24 mriedem bauzas: http://logs.openstack.org/54/554154/27/check/tempest-full/fbfe7c5/controller/logs/etc/cinder/cinder_conf.txt.gz
15:09:43 mriedem enabled_backends = lvmdriver-1
15:09:47 mriedem [lvmdriver-1]
15:09:51 dansmith exactly that
15:10:03 bauzas I see
15:10:13 bauzas so dynamically importing opt groups ?
15:10:16 mriedem http://logs.openstack.org/54/554154/27/check/legacy-tempest-dsvm-full-devstack-plugin-ceph/b88aa0b/logs/etc/cinder/cinder.conf.txt.gz for ceph
15:10:19 stephenfin dansmith: I need to figure out the heck that is working so. All I could find was this https://github.com/openstack/cinder/blob/master/cinder/volume/configuration.py
15:10:27 stephenfin and all calls to that were statically defined
15:10:44 bauzas mriedem: dansmith: okay, I need to consider that for https://review.openstack.org/#/c/557065/
15:10:47 stephenfin dansmith, mriedem, bauzas: but yeah, my configuration was looking like this http://paste.openstack.org/show/719567/
15:11:09 stephenfin think that was what was proposed in the review
15:11:25 dansmith stephenfin: right I think that's highly desirable over a separate yaml or json blob unless there's a really good reason not to
15:11:34 stephenfin dansmith: I concur
15:12:19 mriedem you could always....ask someone in -cinder about how that impl works
15:12:26 dansmith WAT
15:12:29 dansmith can you do that?
15:12:34 mriedem or if it can be shared into oslo.config so we can re-use it
15:12:39 mriedem remember oslo-incubator?
15:12:44 stephenfin but what if they're mean to me?
15:12:50 mriedem they are pretty nice
15:12:52 mriedem nicer than us
15:12:59 mriedem maybe...too nice
15:15:54 bauzas I have one terrible thought
15:16:08 bauzas if we say we want to configure things on the fly
15:16:22 bauzas wouldn't that be something in nova-manage ?
15:16:46 stephenfin bauzas: Isn't this stuff based on pretty static configuration though?
15:17:07 stephenfin I mean, unless you're hotplugging vGPUs/NICs
15:17:41 bauzas isn't the purpose of nova-manage to make nova aware of things that you want to set either once or multiple times ?
15:19:33 stephenfin OK, solved it (the missing piece was knowing that 'enabled_backends' was where this was used)
15:19:48 stephenfin https://github.com/openstack/cinder/blob/master/cinder/cmd/volume.py#L161-L162 and https://github.com/openstack/cinder/blob/master/cinder/cmd/volume.py#L89 for anyone interested
15:21:30 openstackgerrit Balazs Gibizer proposed openstack/nova-specs master: Suggest when to propose notification changes https://review.openstack.org/562265
15:25:15 arvindn0_ mriedem: i see you replied to https://review.openstack.org/#/c/560718/
15:25:33 arvindn0_ any thoughts on the approach i proposed in the spec?
15:28:45 arvindn0_ trying to reduce the chance of encountering the rebuild bug...but cant seem to avoid the bug completely...
15:28:50 openstackgerrit Eric Fried proposed openstack/nova-specs master: Granular: group_policy={none|isolate} https://review.openstack.org/562687
15:35:03 openstackgerrit sahid proposed openstack/nova master: libvirt: fix wrong driver name for vhostuser interface https://review.openstack.org/561562
15:35:04 openstackgerrit sahid proposed openstack/nova master: libvirt: add support for virtio-net rx/tx queue sizes https://review.openstack.org/484997
15:35:05 openstackgerrit sahid proposed openstack/nova master: libvirt: don't set interface backend for vhostuser https://review.openstack.org/562708
15:36:09 mriedem arvindn0_: i will have to get to it later, but it's in the queue
15:38:06 arvindn0_ got it. i put 2 alternatives in there along with why we may not want to go with them based on previous discussions..fyi
15:52:36 openstackgerrit Balazs Gibizer proposed openstack/nova-specs master: Network bandwidth resource provider https://review.openstack.org/502306
15:58:24 openstackgerrit Merged openstack/nova master: Deduplicate notification samples Rocky - 7 https://review.openstack.org/560748
16:09:10 openstackgerrit zhangyangyang proposed openstack/nova master: Deprecate auth_uri option https://review.openstack.org/562537
16:09:14 openstackgerrit Chris Friesen proposed openstack/nova stable/pike: libvirt: disconnect volume from host during detach https://review.openstack.org/560690
16:09:22 lyarwood http://logs.openstack.org/04/516404/3/gate/legacy-tempest-dsvm-neutron-full/6d5d851/logs/screen-n-cpu.txt.gz?level=ERROR#_2018-04-19_14_41_33_712 - `AttributeError: 'NoneType' object has no attribute 'generation'` is leading to stable/ocata gate failures FWIW
16:10:10 melwitt urgh
16:10:48 melwitt how did that happen
16:12:55 lyarwood https://review.openstack.org/#/c/525309/ maybe?
16:13:02 lyarwood efried: ^ any ideas?
16:19:38 melwitt hm, maybe. a resource provider is ending up as None
16:23:32 efried lyarwood: looking...
16:29:04 openstackgerrit Eric Fried proposed openstack/nova master: WIP: placement: Granular GET /allocation_candidates https://review.openstack.org/517757
16:29:20 openstackgerrit zhangyangyang proposed openstack/nova master: Deprecate auth_uri option https://review.openstack.org/562537
16:30:17 openstack bug 1764556 in OpenStack Compute (nova) queens ""nova list" fails with exception.ServiceNotFound if service is deleted and has no UUID" [Medium,Confirmed] https://launchpad.net/bugs/1764556
16:30:17 cfriesen mriedem: melwitt: Do we want to address bug 1764556? If so, is there a better option than changing the online data migration in Pike to add UUIDs to deleted services?
16:30:56 cfriesen it does require a pretty specific set of actions to reproduce
16:31:24 efried lyarwood: That does seem to be the only possible culprit. Haven't figured out how/why yet, though.
16:31:38 efried lyarwood: Can we propose a revert and see if it fixes?
16:33:18 openstackgerrit Lee Yarwood proposed openstack/nova stable/ocata: Revert "Proper error handling by _ensure_resource_provider" https://review.openstack.org/562739
16:33:26 lyarwood efried: ^ sure, there you go
16:33:31 efried lyarwood: ack
16:33:46 mriedem does that cause CI failures or just ugly logs?
16:33:55 mriedem because https://review.openstack.org/#/c/525309/ itself didn't fail CI
16:33:56 lyarwood efried: and thanks, that was a guess given the change history tbh
16:34:15 mriedem cfriesen: we usually want to fix bugs
16:34:39 efried lyarwood: Right, I'm not basing my opinion on anything deeper at the moment.
16:35:24 lyarwood mriedem: that last check run was in 2017
16:35:37 mriedem lyarwood: it ran through the gate yesterday though
16:35:39 lyarwood mriedem: so maybe this change and another are causing this?
16:36:06 lyarwood mriedem: ah yeah true sorry
16:36:11 mriedem https://review.openstack.org/#/q/openstack/nova+status:merged+branch:stable/ocata
16:40:04 cfriesen mriedem: just thought I'd check given the specific sequence of events needed. I appreciate the time you spent getting the functional test going.
16:40:55 efried jeez, how far back could we go? Are we sure that same exception trace isn't showing up everywhere?
16:41:02 openstackgerrit Merged openstack/python-novaclient stable/pike: Use generic user for both zuul v2 and v3 https://review.openstack.org/562500
16:42:35 mriedem it's not in http://logs.openstack.org/09/525309/1/gate/legacy-tempest-dsvm-neutron-full/ddcc396/logs/screen-n-cpu.txt.gz which was from the gate run
16:43:51 mriedem i don't see anything else remotely close to that same code though in here https://github.com/openstack/nova/commits/stable/ocata
16:46:35 melwitt cfriesen: I agree we need to fix it, just not sure how yet
16:48:22 cfriesen I think tweaking the online data migration for services would prevent the one scenario we know about. the question is whether we need something to deal with clouds that have already upgraded to pike

Earlier   Later