Posted	Nick	Remark
#openstack-nova - 2018-04-12
00:57:58	arvindn05	where is the same host enforced?
00:58:46	arvindn05	in code i mean...all that the manager checks is if the hints have the check_type set to rebuild
00:59:00	arvindn05	as per scheduler.utils.request_is_rebuild
01:02:36	arvindn05	thikning out loud, why would select destination be called in the first place if we dont need to select a host? is it just for some validation?
01:09:05	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration https://review.openstack.org/554154
01:13:52	arvindn05	nvm...we want to run image related filters so thats why we want to call select destination...
01:26:59	Kevin_Zheng	mriedem as for your comments in https://review.openstack.org/#/c/560296/
01:27:43	Kevin_Zheng	I thought that making the order constant in all files make it more easier to read and compare....
01:30:16	mriedem	Kevin_Zheng: i wouldn't mix that into the deduplicate payload change
01:30:35	mriedem	if you want to sort the keys globally for those samples, i'd do that once all of the dedup stuff is done
01:30:52	Kevin_Zheng	OK, then I will undo them
01:31:31	mriedem	arvindn05: for rebuild we set a destination on the request_spec which forces the scheduler to only consider the host that the instance is already one
01:32:10	mriedem	arvindn05: here https://github.com/openstack/nova/blob/master/nova/compute/api.py#L3158
01:34:17	arvindn05	mriedem: thank you. starting to understand more of the workflow
01:35:10	mriedem	arvindn05: np, it only took me about 5 years to understand how rebuild works
01:37:59	arvindn05	mriedem: lol...i am shifting languages as well so its harder to find workflows
01:38:17	openstackgerrit	Matt Riedemann proposed openstack/nova master: Cleanup RP and HM records while deleting a compute service. https://review.openstack.org/554920
01:38:18	openstackgerrit	Matt Riedemann proposed openstack/nova master: Delete allocations from API if nova-compute is down https://review.openstack.org/560706
01:38:59	arvindn05	mriedem: i saw def _reset_image_metadata and did not read any code after since in java world seeing a function definition meant i was done with the original function
01:39:11	mriedem	inner method
01:39:17	mriedem	you can have inline functions in java
01:40:11	arvindn05	inline functions? you mean lambda's?
01:40:29	mriedem	no,
01:40:37	mriedem	maybe i'm thinking of inline class impls, like inline interfaces
01:40:48	mriedem	idk, it's been 7 years since i've written java
01:41:06	arvindn05	yea..anonymous classes you can define them
01:43:38	arvindn05	but cannot define method withhin - quora speaks https://www.quora.com/Can-we-write-a-method-inside-a-method-in-Java
01:45:07	arvindn05	anyway...i learn something new everyday...weird pattern to have methods within methods....havent see it a lot in openstack code either
01:45:16	arvindn05	will keep my eye out from now on
02:16:33	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 1 https://review.openstack.org/560296
02:22:27	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 1 https://review.openstack.org/560296
02:31:22	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 2 https://review.openstack.org/560299
02:32:37	takashin
02:55:32	Spaz-Work	Morning Nova
02:56:42	openstackgerrit	Arvind Nadendla proposed openstack/nova-specs master: Handle rebuild of instance with new image https://review.openstack.org/560718
03:21:17	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 3 https://review.openstack.org/560727
03:31:35	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 4 https://review.openstack.org/560731
03:37:40	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 4 https://review.openstack.org/560734
03:45:18	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 6 https://review.openstack.org/560737
04:04:26	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 7 https://review.openstack.org/560748
04:40:06	openstackgerrit	Merged openstack/nova master: Fix race fail in test_resize_with_reschedule_then_live_migrate https://review.openstack.org/560454
05:11:24	openstackgerrit	jichenjc proposed openstack/nova master: remove ec2 in service and cmd https://review.openstack.org/556778
05:11:25	openstackgerrit	jichenjc proposed openstack/nova master: remove ec2 object definitions https://review.openstack.org/557150
05:11:26	openstackgerrit	jichenjc proposed openstack/nova master: remove ec2 db functions https://review.openstack.org/557572
06:20:13	openstackgerrit	jichenjc proposed openstack/nova master: Avoid live migrate to same host https://review.openstack.org/542689
06:30:45	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 1 https://review.openstack.org/560296
06:41:29	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 2 https://review.openstack.org/560299
06:42:32	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration https://review.openstack.org/554154
06:54:22	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration https://review.openstack.org/554154
07:08:06	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration https://review.openstack.org/554154
07:08:56	openstackgerrit	jichenjc proposed openstack/nova master: Move update_task_state out of try/except https://review.openstack.org/557152
07:14:34	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support compute node resource provider update and create https://review.openstack.org/521041
07:24:57	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 3 https://review.openstack.org/560727
07:25:40	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support compute node resource provider update and create https://review.openstack.org/521041
07:38:23	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 4 https://review.openstack.org/560731
07:55:20	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 4 https://review.openstack.org/560731
07:59:30	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 4 https://review.openstack.org/560731
08:09:29	openstackgerrit	Lee Yarwood proposed openstack/nova stable/pike: libvirt: Block swap volume attempts with encrypted volumes prior to Queens https://review.openstack.org/543569
08:12:43	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in test_serversV21.py (1) https://review.openstack.org/560821
08:14:19	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in test_serversV21.py (1) https://review.openstack.org/560821
08:32:16	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 4 https://review.openstack.org/560731
08:53:37	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in test_serversV21.py (2) https://review.openstack.org/560829
08:58:48	openstackgerrit	Yikun Jiang (Kero) proposed openstack/nova master: WIP: complex policy https://review.openstack.org/553776
08:58:49	openstackgerrit	Yikun Jiang (Kero) proposed openstack/nova master: Add rules column to instance_group_policy table. https://review.openstack.org/560832
09:03:15	openstackgerrit	jichenjc proposed openstack/nova master: remove ec2 object definitions https://review.openstack.org/557150
09:03:16	openstackgerrit	jichenjc proposed openstack/nova master: remove ec2 db functions https://review.openstack.org/557572
09:33:47	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 5 https://review.openstack.org/560734
09:33:51	phuongnh	hi jaypipes, I would like to add one more line in file https://review.openstack.org/#/c/462759/3/os_traits/hw/cpu/x86.py for CPU_FPGA
09:34:10	phuongnh	the link to this is: https://en.wikipedia.org/wiki/Field-programmable_gate_array
09:34:13	phuongnh	Do I need to propose a blueprint in launchpad?
09:50:54	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 6 https://review.openstack.org/560737
11:04:09	openstackgerrit	Merged openstack/nova master: Remove mox in test_virt_drivers.py https://review.openstack.org/559878
11:12:09	Shilpa	stephenfin: Hi
11:20:40	openstackgerrit	Merged openstack/nova master: Remove mox in unit/virt/xenapi/test_vm_utils.py (1) https://review.openstack.org/558704
11:26:58	stephenfin	Shilpa: o/
11:28:22	Shilpa	stephenfin: i have added patch set https://review.openstack.org/#/c/550172/2, and added comment there, can you please go through the same.
11:29:51	Shilpa	stephenfin: its ok to proceed with noVNC v1.0.0 tag, i have seen issue reported here at https://github.com/novnc/noVNC/issues/1034
11:31:27	stephenfin	Shilpa: It looks like the CI is failing though?
11:31:35	stephenfin	with a valid failure, no less
11:32:37	Shilpa	stephenfin: i have noted that, but they were failing on earlier patch set too, so just ignored, will check logs
11:46:31	openstackgerrit	Zhenyu Zheng proposed openstack/nova-specs master: Amend allow abort live migrations in queued status spec https://review.openstack.org/560872
11:58:09	bhagyashris	alex_xu: Hi, I just want to know about the spec https://docs.openstack.org/oslo.config/latest/reference/mutable.html which basically give the provision to make the conf parameter as mutable
11:59:51	Shilpa	stephenfin: checked logs http://logs.openstack.org/72/550172/2/check/tempest-full/f6945b6/job-output.txt.gz, and observed that 1 test case is failed, and that is tempest.api.compute.servers.test_novnc.NoVNCConsoleTestJSON.test_novnc[id-c640fdff-8ab4-45a4-a5d8-7e6146cbd0dc]
11:59:52	alex_xu	bhagyashris: maybe gcb is good person, but looks like he isn't in this channel
11:59:53	bhagyashris	alex_xu: there is one patch submitted in nova https://review.openstack.org/#/c/319203/3 so what are the criteria to make the conf parameter as mutable in any project
12:00:48	alex_xu	bhagyashris: ok
12:01:53	bhagyashris	alex_xu: as per the operators point of view every parameter should be make it as mutable but why only these two parameters are made it as mutable
12:02:01	openstackgerrit	Matthew Booth proposed openstack/nova master: Give volume DriverBlockDevice classes a common prefix https://review.openstack.org/526346
12:02:02	openstackgerrit	Matthew Booth proposed openstack/nova master: Add DriverLocalImageBlockDevice https://review.openstack.org/526347
12:02:03	openstackgerrit	Matthew Booth proposed openstack/nova master: Expose driver_block_device fields consistently https://review.openstack.org/528362
12:02:04	openstackgerrit	Matthew Booth proposed openstack/nova master: Add local_root to block_device_info https://review.openstack.org/529029
12:02:05	openstackgerrit	Matthew Booth proposed openstack/nova master: Pass DriverBlockDevice to driver.attach_volume https://review.openstack.org/528363
12:02:06	openstackgerrit	Matthew Booth proposed openstack/nova master: Fix libvirt volume tests passing invalid disk_info https://review.openstack.org/529328
12:03:06	bhagyashris	alex_xu: in this patch https://review.openstack.org/#/c/319203/3
12:05:28	alex_xu	bhagyashris: I guess that BP only target to something people just need at that point
12:07:28	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Deduplicate notification samples Rocky - 7 https://review.openstack.org/560748
12:07:40	alex_xu	bhagyashris: I'm not sure all the config option works, but I also didn't see any reject for other options other than that BP
12:10:59	bhagyashris	alex_xu: Actually I have few queries in nova only those two parameters are marked as mutable = True in (https://review.openstack.org/#/c/319203/3) so is that means other all the conf parameters are non-mutable.
12:11:40	openstackgerrit	pippo proposed openstack/nova master: Update eventlet https://review.openstack.org/560876
12:32:41	efried	Good UGT morning bhagyashris

Earlier   Later