Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-04-09
22:28:56 dansmith imacdonn: and you could argue that computes being misconfigured for placement would be "okay" in that situation
22:29:12 dansmith imacdonn: however, going forward, we *have* to migrate those people to having data in placement so we can get rid of that situation
22:29:19 imacdonn dansmith: right, I believe that that's the case that mriedem was concerned about
22:29:42 dansmith so that's a reason to hard fail, but again, if we can't reliably detect that except at runtime, then..we don't have much choice
22:30:11 dansmith imacdonn: what about this.. make the compute service self-disable if we fail to update our RPs in placement?
22:30:17 imacdonn I guess we can use auth_type ... It just feels a bit like making the same mistake a second time
22:30:20 dansmith we do that now for transient issues we find out about late, like libvirt stopping
22:30:27 dansmith we self-disable so that no new builds will come to us,
22:30:33 dansmith which is a big fat "I need help" to the operator
22:30:39 imacdonn interesting
22:30:45 dansmith and there's a reason field
22:30:57 dansmith self.disable(reason="you dun fscked up")
22:31:04 imacdonn heh
22:31:45 imacdonn I think I like that idea better
22:32:21 dansmith we also self-disable if too many builds fail for unknown reasons
22:32:39 imacdonn unit-testing for that could be "fun" ...
22:32:48 dansmith https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1701-L1709
22:32:48 dansmith nah, 's easy
22:34:17 dansmith imacdonn: https://review.openstack.org/#/c/463597/
22:34:22 dansmith lots of test examples in there
22:34:30 mriedem just rely on auth_type https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bug/1761487
22:34:35 mriedem we are doing that for neutron and cinder too
22:34:59 dansmith if that's legit, then sure
22:36:32 mriedem let me also state, for the record, that i don't care too much about this and said so awhile back http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2018-03-30.log.html#t2018-03-30T21:39:06
22:37:02 mriedem i definitely didn't think about the compute restart storm
22:38:18 mriedem and now i must attend to 1st grade homework
22:38:42 imacdonn efried: any objection to using auth_type ?
22:39:07 efried imacdonn: No. If they ever make that non-optional, I suspect many unintended side effects will result.
22:39:15 efried s/non-//
22:39:54 imacdonn yeah, and it seems like it'd probably become non-optional for neutron at the same time
22:41:25 efried Oh, it would be a ksa thing, so it would become optional for the world
22:41:52 imacdonn right, that's what I meant
22:42:33 imacdonn so if we do the same for placement as we do for neutron, such a change would break both at the same type
22:43:06 efried more or less. more or less.
22:45:55 imacdonn OK, I'll work on a new PS with that
22:46:02 imacdonn dansmith: thanks for the review
23:00:38 openstackgerrit Eric Berglund proposed openstack/nova master: PowerVM: Add proc_units_factor conf option https://review.openstack.org/554688
23:04:05 openstackgerrit Merged openstack/nova stable/queens: Add __repr__ for NovaException https://review.openstack.org/559158
#openstack-nova - 2018-04-10
01:21:32 openstackgerrit Merged openstack/nova master: Replace mox stubs with stub_out in test_extended_volumes.py https://review.openstack.org/558685
01:39:32 openstackgerrit jichenjc proposed openstack/nova master: WIP: remove ec2 in service and cmd https://review.openstack.org/556778
01:39:33 openstackgerrit jichenjc proposed openstack/nova master: WIP: remove db ec2 https://review.openstack.org/557572
01:39:33 openstackgerrit jichenjc proposed openstack/nova master: WIP: remove Ec2 object https://review.openstack.org/557150
01:39:46 openstackgerrit Jackie Truong proposed openstack/nova master: Implement certificate_utils https://review.openstack.org/479949
01:39:47 openstackgerrit Jackie Truong proposed openstack/nova master: Add trusted_image_certificates to REST API https://review.openstack.org/486204
01:41:50 openstackgerrit jichenjc proposed openstack/nova master: make metadata doc up to date https://review.openstack.org/559613
01:50:45 openstackgerrit Michael Still proposed openstack/nova master: Move xenapi disk resizing to privsep. https://review.openstack.org/552242
01:50:46 openstackgerrit Michael Still proposed openstack/nova master: Move xenapi partition copies to privsep. https://review.openstack.org/553605
01:50:46 openstackgerrit Michael Still proposed openstack/nova master: Sync xenapi and libvirt on what flags to pass e2fsck. https://review.openstack.org/554078
01:50:47 openstackgerrit Michael Still proposed openstack/nova master: We don't need utils.trycmd any more. https://review.openstack.org/554439
01:50:47 openstackgerrit Michael Still proposed openstack/nova master: Move image conversion to privsep. https://review.openstack.org/554437
01:50:48 openstackgerrit Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438
02:03:14 naichuans Hi, efried: do we have the scheduler of to get NRP working through GET /allocation_candidates?
02:05:34 alex_xu kashyap: yea, I think it supports boarder option, but at least for our team, we only use cmt
02:08:57 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in test_virt_drivers.py https://review.openstack.org/559878
02:16:20 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/virt/xenapi/test_vm_utils.py (1) https://review.openstack.org/558704
03:43:22 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Add microversion to support extra_specs in flavor API. https://review.openstack.org/554159
03:51:25 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/virt/xenapi/test_vm_utils.py (2) https://review.openstack.org/558993
03:53:19 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/virt/xenapi/test_vm_utils.py (3) https://review.openstack.org/559258
04:00:15 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Add microversion to support extra_specs in flavor API. https://review.openstack.org/554159
05:39:27 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi: Support live migration in pooled multi-nodes environment https://review.openstack.org/489451
06:03:41 openstackgerrit jichenjc proposed openstack/nova master: remove ec2 object definitions https://review.openstack.org/557150
06:03:41 openstackgerrit jichenjc proposed openstack/nova master: remove ec2 in service and cmd https://review.openstack.org/556778
06:03:42 openstackgerrit jichenjc proposed openstack/nova master: remove ec2 db functions https://review.openstack.org/557572
06:25:16 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/548772
06:45:09 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi: Support live migration in pooled multi-nodes environment https://review.openstack.org/489451
06:54:10 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration https://review.openstack.org/554154
07:13:34 openstackgerrit Tetsuro Nakamura proposed openstack/nova-specs master: Return resources of entire trees in Placement https://review.openstack.org/559466
07:14:21 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION for "Rocky" https://review.openstack.org/558783
07:14:21 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: Pick next minimum libvirt / QEMU versions for "Stein" https://review.openstack.org/558171
07:22:13 kashyap zigo: If you want to re-ACK this -- https://review.openstack.org/#/c/558171/
07:26:30 bauzas good morning nova
08:45:48 openstackgerrit Michael Still proposed openstack/nova master: Move xenapi disk resizing to privsep. https://review.openstack.org/552242
08:45:49 openstackgerrit Michael Still proposed openstack/nova master: Move xenapi partition copies to privsep. https://review.openstack.org/553605
08:45:49 openstackgerrit Michael Still proposed openstack/nova master: Sync xenapi and libvirt on what flags to pass e2fsck. https://review.openstack.org/554078
08:45:50 openstackgerrit Michael Still proposed openstack/nova master: We don't need utils.trycmd any more. https://review.openstack.org/554439
08:45:50 openstackgerrit Michael Still proposed openstack/nova master: Move image conversion to privsep. https://review.openstack.org/554437
08:45:51 openstackgerrit Michael Still proposed openstack/nova master: We no longer need rootwrap. https://review.openstack.org/554438
08:46:17 zigo kashyap: I did it but there are still ci failures.
08:50:33 kashyap zigo: Let me look; this shouldn't certainly cause CI failures
08:51:22 kashyap Hmm, I see "IBM PowerKVM CI" failing
09:14:29 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi: Support live migration in pooled multi-nodes environment https://review.openstack.org/489451
09:28:56 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration https://review.openstack.org/554154
09:53:59 openstackgerrit Chris Dent proposed openstack/nova master: Use nova.db.api directly https://review.openstack.org/543262
10:05:05 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create https://review.openstack.org/520313
10:25:41 Tahvok Should horizon respect the live migration when host aggregates are enabled? Because when I live migrate an instance, it still gives me an option to choose to live migrate an instance to a host not part of the host aggregate
10:46:35 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717
10:52:00 openstackgerrit Petersingh Anburaj proposed openstack/nova master: Making consistent used of GiB and MiB in Doc https://review.openstack.org/559985
11:05:06 openstackgerrit Lee Yarwood proposed openstack/nova stable/queens: libvirt: Block swapping to an encrypted volume when using QEMU to decrypt https://review.openstack.org/559987
12:19:28 openstackgerrit Yikun Jiang (Kero) proposed openstack/osc-placement master: Initialize 'result' variable in functional.base https://review.openstack.org/560004
12:28:31 efried code: https://review.openstack.org/#/q/topic:bp/nested-resource-providers-allocation-candidates+(status:open+OR+status:merged)
12:28:31 efried spec: https://review.openstack.org/#/c/556873/
12:28:31 efried naichuans: No, not yet. Keep an eye on blueprint nested-resource-providers-allocation-candidates
12:49:11 efried claudiub: Does autospec work for method signatures?
12:51:50 efried yes, yes it does.
12:53:06 claudiub sorry, I didn't see it in time. :)
12:53:15 claudiub and yes, it does, that was the whole point of it. :)
12:54:37 claudiub efried: although arguably there is still one case in which it doesn't get applied, one case I've missed in the original implementation: https://review.openstack.org/#/c/557923/
12:54:39 efried claudiub: Knew it worked that way for objects, wasn't sure about methods.
12:56:24 claudiub efried: also, keep in mind that this has a +2, so it might merge soon. Hopefully it won't affect nova_powervm: https://review.openstack.org/#/c/470775/
12:57:26 efried claudiub: If you have a moment, I'm hitting a place where the autospec doesn't seem to be working as expected...

Earlier   Later