Posted	Nick	Remark
#openstack-nova - 2018-04-02
21:05:06	fried_bunny	resize
21:05:10	fried_bunny	and
21:05:14	fried_bunny	symmetry with the RP API
21:05:16	fried_bunny	:P
21:05:45	melwitt	jackie-truong: hi, your blueprint https://blueprints.launchpad.net/nova/+spec/nova-validate-certificates is next in line for a review runway that we're looking to fill. is now a good time to iterate quickly on code review for the next two weeks in a runway?
21:05:47	fried_bunny	Is it possible to GET before PUT every time? Sure. But so easy to avoid, so why?
21:05:59	edleafe	with resize you'd only change the consumer once
21:06:16	edleafe	Symmetry is only important if the things are similar enough
21:06:20	fried_bunny	edleafe: per resize
21:06:45	edleafe	??
21:06:50	fried_bunny	edleafe: or maybe not. Maybe we're passing the allocation around to cinder to change storage allocs, cyborg to change dev allocs, neutron to change net allocs....
21:07:13	fried_bunny	So it's half a dozen times per spawn, per resize, per whatever.
21:07:38	edleafe	fried_bunny: that's the case for adding a generation. These will be presumably done in parallel, so it is racy by desing
21:07:42	edleafe	design, even
21:07:46	fried_bunny	But what's the resistance? Just that it's more code?
21:08:08	edleafe	no, because it doesn't fit how allocations should work
21:08:19	fried_bunny	well, that I disagree with.
21:09:07	fried_bunny	If you had said it's because we don't have an immediate use case for reusing the allocation, I would still argue it's easier to do it now than in a new microversion later.
21:10:28	edleafe	Let's put this on hold and bring in jaypipes and cdent. One of us is not seeing things correctly
21:11:16	fried_bunny	rgr
21:11:25	fried_bunny	I commented in the spec. We can discuss there.
21:15:34	jackie-truong	melwitt: Yes, we can be available for the next two weeks to respond to code reviews
21:16:16	melwitt	jackie-truong: sweet, I shall add the blueprint to the runway then. thanks
21:17:53	jackie-truong	melwitt: Thanks!
21:18:09	arvindn05	are there any guidelines for initialization of datastructures in nova specifically? I have an object with a dictionary which may or may not be populated...
21:18:44	arvindn05	should we always initialize instead of making it None?
21:20:36	dansmith	arvindn05: that's probably too vague to answer without seeing what you're talking about
21:20:49	arvindn05	https://review.openstack.org/#/c/557795/
21:21:22	arvindn05	sorry...here is the review for context. https://review.openstack.org/#/c/557795/7/nova/objects/image_meta.py
21:22:41	arvindn05	i was trying to follow the pattern within the file where complex fields like ListOfSetsOfIntegersField are not initialized if there are no properties
21:25:01	dansmith	arvindn05: I commented
21:25:46	dansmith	arvindn05: you should look at other patches to that object in recent history and see the pattern they use.. it doesn't matter that this is a "complex field"
21:27:29	arvindn05	ok...but was wondering if there were guideline documented somewhere on passing None vs initialized objects...
21:27:53	dansmith	arvindn05: as I commented there, it makes no sense to be concerned that someone would pass None there
21:29:08	arvindn05	so you propose removing the if? I think the if is guarding against both empty properties as well as None
21:30:15	dansmith	arvindn05: did you read my comment?
21:30:22	dansmith	I'm proposing you remove the entire function
21:30:50	arvindn05	yup getting to that :)
21:31:21	arvindn05	Also on the second comment, The method is to initialize/create the image meta props object from the dict
21:32:13	arvindn05	we are adding new attributes in the dict as per the blueprint https://blueprints.launchpad.net/openstack/?searchtext=glance-image-traits
21:33:06	dansmith	arvindn05: none of the other methods called before yours handle that parameter being None, so it will never get to your if condition if the thing is None
21:35:58	arvindn05	yup...but they do handle empty dict...in case of an empty dict, they do not initialize the fields
21:36:14	arvindn05	the if condition there is handling the empty dict case
21:37:29	dansmith	arvindn05: none of this matters since you shouldn't be setting that from from_dict() anyway, per my comment
21:37:58	dansmith	er, wait wait, maybe I'm confused
21:38:07	arvindn05	dansmith: yup...i got that...can we discuss the comment?
21:39:18	arvindn05	http://specs.openstack.org/openstack/nova-specs/specs/rocky/approved/glance-image-traits.html#proposed-change
21:40:36	arvindn05	trait:CUSTOM_TRUSTED_HOST=required
21:40:36	arvindn05	trait:HW_CPU_X86_AVX2=required
21:40:36	arvindn05	we are adding attributes like below to the image dict to support filtering based on traits expressed in images
21:40:53	dansmith	arvindn05: yeah I know that part
21:42:22	dansmith	okay, sorry I had this all tangled in my head
21:42:48	dansmith	I was thinking this was the path in for the legacy dict, but this is actually the path in for image meta itself, which calls the name mapping stuff inside here
21:42:52	arvindn05	no problem...sorry i just threw it over the wall
21:45:45	arvindn05	yes...i think. the methods parses all the properties expressed in the image meta data(as a key:value strings) both legacy and non-legacy and creates the ImageMetaProps out of it
21:46:24	dansmith	arvindn05: replying to try to clean up my mess, hang on
21:52:03	dansmith	arvindn05: see if that makes sense
21:52:27	arvindn05	thx..looking at it now
21:52:28	dansmith	something he said about none-ness sent me down the wrong path in thinking what this was about
21:55:23	arvindn05	got it...makes sense
21:55:56	arvindn05	dansmith: thanks...will make the update
21:56:06	dansmith	ack
22:27:45	openstackgerrit	Eric Fried proposed openstack/nova master: Remove deprecated [placement] opts https://review.openstack.org/557086
22:39:08	openstackgerrit	Arvind Nadendla proposed openstack/nova master: Update ImageMetaProp object to expose traits https://review.openstack.org/557795
22:40:43	openstackgerrit	Eric Berglund proposed openstack/nova master: WIP: PowerVM: Cold Migrate & Resize https://review.openstack.org/553583
22:46:41	openstackgerrit	Arvind Nadendla proposed openstack/nova master: Update ImageMetaProp object to expose traits https://review.openstack.org/557795
#openstack-nova - 2018-04-03
00:26:02	openstackgerrit	Takashi NATSUME proposed openstack/python-novaclient master: Fix validation for command arguments https://review.openstack.org/558324
00:43:49	openstackgerrit	Takashi NATSUME proposed openstack/python-novaclient master: Fix AttributeError in getting a resource ID https://review.openstack.org/558328
01:31:58	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create https://review.openstack.org/520313
01:33:11	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717
01:48:00	openstackgerrit	Merged openstack/nova master: doc: Upgrade placement first https://review.openstack.org/556631
01:48:09	openstackgerrit	Merged openstack/nova master: SchedulerReportClient.update_from_provider_tree https://review.openstack.org/533821
02:20:41	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Fix the request context in ServiceFixture https://review.openstack.org/558160
03:38:38	openstackgerrit	Yikun Jiang (Kero) proposed openstack/nova master: Add host/hostId to instance action events API https://review.openstack.org/557145
05:07:31	openstackgerrit	Naichuan Sun proposed openstack/nova master: (WIP)xenapi(N-R-P): Add API to support compute node resource provider update and create https://review.openstack.org/521041
05:16:25	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration https://review.openstack.org/554154
05:18:58	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support vgpu resource provider create https://review.openstack.org/520313
05:24:18	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi(N-R-P):Get vgpu info from `allocations` https://review.openstack.org/521717
05:24:51	openstackgerrit	Naichuan Sun proposed openstack/nova master: (WIP)xenapi(N-R-P): Add API to support compute node resource provider update and create https://review.openstack.org/521041
05:25:45	openstackgerrit	jichenjc proposed openstack/nova master: z/VM Driver: Initial change set of z/VM driver https://review.openstack.org/523387
05:25:46	openstackgerrit	jichenjc proposed openstack/nova master: z/VM Driver: Spawn and destroy function of z/VM driver https://review.openstack.org/527658
05:27:20	openstackgerrit	jichenjc proposed openstack/nova master: z/VM Driver: add snapshot function https://review.openstack.org/534240
05:27:30	openstackgerrit	jichenjc proposed openstack/nova master: z/VM Driver: add power actions https://review.openstack.org/543340
05:27:45	openstackgerrit	jichenjc proposed openstack/nova master: z/VM Driver: add get console output https://review.openstack.org/543344
05:34:58	openstackgerrit	Takashi NATSUME proposed openstack/python-novaclient master: Replace GB with GiB https://review.openstack.org/558364
05:36:22	openstackgerrit	Takashi NATSUME proposed openstack/python-novaclient master: Replace GB with GiB https://review.openstack.org/558364
05:36:48	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi(N-R-P): Add API to support compute node resource provider update and create https://review.openstack.org/521041
07:08:24	openstackgerrit	Tetsuro Nakamura proposed openstack/nova master: trivial: Fix nits in code comments https://review.openstack.org/558133
07:08:25	openstackgerrit	Tetsuro Nakamura proposed openstack/nova master: Complement tests in allocation candidates https://review.openstack.org/558135
07:11:08	openstackgerrit	OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/548772
07:27:08	openstackgerrit	Naichuan Sun proposed openstack/nova master: xenapi: Use XAPI pool instead of aggregate pool for shared SR migration https://review.openstack.org/554154
07:28:29	openstackgerrit	Fan Zhang proposed openstack/nova master: [Trivial]Add missing blank space in conf description https://review.openstack.org/558414
08:02:59	tetsuro	@efied(fried_bunny), jaypipes, edleafe, alex_xu_ : I read through the IRC log in Monday and evacuated https://review.openstack.org/558133 , and https://review.openstack.org/558135 from the “anchor” branch since they can be merged now.
08:03:21	tetsuro	But I think exposing unrequested resources in prov_sum is necessary change for NRP cases, too, if we are going to expose all the NRPs in the tree.
08:03:37	tetsuro	Without this change, how do NRPs that don’t have requested resources appear in prov_sum? Are we going to expose them without resource information?
08:04:12	tetsuro	Could you tell me why we need all the NRPs in the tree? If there aren’t specific and concrete usecase so far, I even don’t think we have to support that all NRP in prov_sum since the design depends on the usecase.
08:04:27	tetsuro	I’m also asking the same question in https://review.openstack.org/#/c/556873/.
08:10:25	openstackgerrit	Takashi NATSUME proposed openstack/nova master: [placement] api-ref: Fix parameters https://review.openstack.org/558142
08:29:54	bauzas	good morning Novaers
08:35:30	fanzhang	oh hi bauzas, sorry to bother. I accidentally found this trivial bug, https://review.openstack.org/#/c/558414/, should I add CI manually to reviewer or just wait? Kind a new to post patch to nova. :)

Earlier   Later