| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-03-28 | |||
| 20:55:05 | efried | mriedem: I was pointing out the bug fix patch I just posted. But crossed streams with dansmith, so it looked like I was bringing your attention to the fact that dansmith, by his own admission, sucks. | |
| 20:55:13 | mikal | ./nova/tests/unit/virt/libvirt/volume/test_quobyte.py:230:18: E211 whitespace before '(' | |
| 20:55:13 | mikal | Running flake8 on all files | |
| 20:55:16 | mikal | ./nova/virt/libvirt/guest.py:664:68: F821 undefined name 'unicode' | |
| 20:55:34 | mriedem | mikal: nope | |
| 20:55:41 | dansmith | efried: I ain't swordfightin' with you dude.. ever. | |
| 20:55:41 | mikal | Herm, how odd. | |
| 20:55:58 | efried | Promises promises. | |
| 20:55:58 | openstackgerrit | Merged openstack/nova stable/pike: Avoid exploding if guest refuses to detach a volume https://review.openstack.org/551950 | |
| 20:56:07 | openstack | bug 1746509 in OpenStack Compute (nova) pike "TypeError: Can't upgrade a READER transaction to a WRITER mid-transaction" [High,In progress] https://launchpad.net/bugs/1746509 - Assigned to melanie witt (melwitt) | |
| 20:56:07 | openstackgerrit | Merged openstack/nova stable/queens: Add functional regression test for bug 1746509 https://review.openstack.org/555914 | |
| 20:56:13 | openstackgerrit | Merged openstack/nova stable/queens: Move _make_instance_list call outside of DB transaction context https://review.openstack.org/555915 | |
| 20:56:22 | openstackgerrit | Merged openstack/nova master: tox: Make everything work with Python 3 https://review.openstack.org/556894 | |
| 20:56:52 | openstackgerrit | Merged openstack/nova master: tests: fixes mock autospec usage https://review.openstack.org/447505 | |
| 20:57:28 | openstackgerrit | Merged openstack/nova stable/queens: Save admin password to sysmeta in libvirt driver https://review.openstack.org/550489 | |
| 20:57:51 | mriedem | mordred must have just flushed the zuul toilet | |
| 20:59:57 | melwitt | mriedem, dansmith: pike backports ready2rock https://review.openstack.org/#/c/555058 | |
| 21:00:04 | efried | dansmith: Did you mean to do this or not? https://review.openstack.org/#/c/544730/15..16/nova/scheduler/manager.py | |
| 21:00:19 | efried | Am I just failing to detect sarcasm via gerrit? | |
| 21:00:37 | dansmith | efried: no, I meant I meant to do what mriedem was suggesting | |
| 21:00:43 | efried | ight | |
| 21:00:58 | efried | cause he seems to have taken you at face value also. | |
| 21:02:25 | dansmith | ? | |
| 21:02:25 | dansmith | melwitt: why is that patch strikeouted | |
| 21:03:09 | melwitt | I dunno. usually that means it merged but it didn't merge | |
| 21:03:23 | melwitt | or no, that's the dot that means it merged. | |
| 21:04:05 | melwitt | it's not strikeouted anymore now. not sure what that was | |
| 21:04:35 | efried | Were you looking at the cherry-picks tabbydoo? | |
| 21:04:42 | melwitt | yes | |
| 21:04:50 | melwitt | Related Changes | |
| 21:05:06 | melwitt | so no, but similar | |
| 21:05:41 | efried | The Cherry Picks one (rightly) shows black-dotted patches from the other branches. I don't see black dots under Related Changes. | |
| 21:05:55 | mriedem | dansmith: one more time through the ringer https://review.openstack.org/#/c/547990/ | |
| 21:06:03 | efried | You say temporary glitch. I say it never happened. Need new glasses. | |
| 21:06:10 | melwitt | earlier before mriedem +2ed it, it was strikeouted in the Related Changes tabbydoo | |
| 21:06:27 | mriedem | i saw it | |
| 21:09:21 | mriedem | efried: since we don't have that https failure in devstack, we'll likely need divya to assert it fixes the bug | |
| 21:09:25 | mriedem | i don't have the setup for it | |
| 21:09:50 | efried | mriedem: Roger that. If it looks okay to you at a glance, I'll send it that way. | |
| 21:10:15 | mikal | mriedem: its not just unit tests, look at nova.virt.xenapi.firewall for example. | |
| 21:11:15 | mriedem | mikal: yeah linux_net is going to be mingled into everything | |
| 21:11:51 | mriedem | so i'm not really sure what the best way is to unwind the nova-net stuff since it's mixed into everything | |
| 21:12:00 | mikal | Orbital nukes? | |
| 21:12:25 | mikal | For a start, do we even know if xen people still use the dom0 firewalling stuff? Its copyright 8 years ago now. | |
| 21:12:27 | mriedem | well, what i know i don't want to see is a single giant patch that just deletes everything | |
| 21:12:40 | mriedem | mikal: would have to ask BobBall or jianghuaw_ | |
| 21:12:49 | mikal | I think you just did? | |
| 21:13:56 | openstack | Launchpad bug 1759689 in oslo.config "In 1.6.0 startup can be extremely slow when checking many config items" [Undecided,New] | |
| 21:13:56 | cdent | dansmith or mriedem : were either of you aware of jaypipes-away asking about some tweaks to oslo config to know if an option's value was coming from a default or elsewhere (even if the value was the same)? dhellman implemented a feature to support that in oslo_config but it seems to have bad mojo and maybe it can die: https://bugs.launchpad.net/oslo.config/+bug/1759689 | |
| 21:14:27 | mikal | This nova.virt.firewall thing is news to me and is going to be an issue I think | |
| 21:14:32 | mikal | Its used quite widely. | |
| 21:14:36 | mriedem | cdent: nope | |
| 21:14:39 | cdent | (sorry that's 6.0.0 above, not 1.6.0) | |
| 21:14:52 | mriedem | i saw the ML thread | |
| 21:15:02 | mikal | Oh, its security groups | |
| 21:15:09 | mikal | That makes sense. Why not just call it that then? | |
| 21:15:39 | mriedem | i will be amused when i found out that you wrote most of this mikal | |
| 21:15:50 | mikal | I did not | |
| 21:16:33 | mikal | I am innocent. My tech debt is elsewhere. | |
| 21:22:22 | mriedem | efried: i think https://review.openstack.org/#/c/557508/ looks ok for the most part | |
| 21:22:29 | efried | mriedem: Thanks. | |
| 21:22:35 | mriedem | i think the diff could be smaller, | |
| 21:22:42 | mriedem | but it's ready for divya to test | |
| 21:24:40 | efried | mriedem: It's really just gerrit being silly. I didn't move the method - just put the new stuff in front of it (because it makes more sense ordered that way). | |
| 21:25:08 | mriedem | ok | |
| 21:25:25 | mriedem | or, | |
| 21:25:28 | mikal | mriedem: looking at this, I think the first step is like privsep. Remove nova-net support from just one driver (presumably libvirt). Learn what it looks like by doing that, and then repeat for other drivers. | |
| 21:25:33 | openstackgerrit | Ed Leafe proposed openstack/nova master: Address issues raised in adding member_of to GET /a-c https://review.openstack.org/554357 | |
| 21:25:33 | mriedem | you're anal about functions being defined before they are used, like in | |
| 21:25:34 | mriedem | c | |
| 21:25:53 | mriedem | mikal: yeah you're probably right | |
| 21:25:58 | mriedem | also, | |
| 21:26:12 | mriedem | the apis that are solely nova-net only will need to be cleansed to just fast-fail at any microversion | |
| 21:26:32 | mriedem | can't remember if we 404 or 405 for those today after the deprecation versions | |
| 21:27:28 | mikal | It looks to me like linux_net and nova-net are also not synonyms like I thought they were. nova.virt.libvirt.vif uses linux-net to plug devices for example. | |
| 21:27:37 | mriedem | yes, dansmith loves that | |
| 21:28:17 | mriedem | i think for the deprecated apis, you get a 404 https://github.com/openstack/nova/blob/master/nova/api/openstack/wsgi.py#L739 | |
| 21:28:27 | mriedem | so one thing one could start with, is neutering all of those APIs | |
| 21:29:31 | mikal | I had assumed for privsep I could ignore nova-net, but I don't think that's true now that I learn that vif plugging calls into it. | |
| 21:29:36 | mikal | This is a tangled mess. | |
| 21:30:04 | mikal | i.e. I might be forced to privsep a bunch of "nova-net" in order to land the final couple of privsep patches. | |
| 21:31:25 | mriedem | mikal: or just help with the nova-net removal | |
| 21:32:11 | mikal | Perhaps, but I'm a hobbyist. Any critical part of nova's roadmap depending on me is going to be a problem. | |
| 21:39:25 | mriedem | ok, let's drop privsep from runways then :) | |
| 21:39:52 | mriedem | or, be OK with saying privsep won't be done by the end of your runway | |
| 21:39:53 | mikal | mriedem: sure, if you want. You've been saying its a low priority the whole time though. You can't have it both ways. | |
| 21:39:56 | mriedem | b/c of the nova-net stuff | |
| 21:40:22 | mriedem | what do i want both ways? | |
| 21:40:31 | mriedem | my point is, | |
| 21:40:42 | mriedem | i don't think you should do more privsep stuff for nova-net specific things when we're going to drop nova-net, | |
| 21:40:44 | mikal | Either you want privsep or you don't. I don't really care either way any more. | |
| 21:40:56 | mriedem | and if that means the privsep conversion isn't done at the end of your current runway, i think that's ok | |
| 21:41:26 | mriedem | also, i'm not the only person here | |
| 21:41:30 | mikal | I've said all along that privsep wouldn't be done at the end of the runway. The last couple of patches which need nova-net to go can just sit around until someone removes nova-net. | |
| 21:46:59 | efried | This seems simple to me. The scope of the runway is the privsep series up to but not including the patches that require nova-net removal. Runways don't have to encompass an entire blueprint. That was something we talked about early on, but later relaxed our stance on. | |
| 21:59:39 | melwitt | agreed, privsep up until the nova-net requiring ones can be done as part of the runway and that's it | |
| 22:07:11 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add nova-status check for ironic flavor migration https://review.openstack.org/527541 | |
| 22:10:14 | openstackgerrit | Eric Fried proposed openstack/nova master: Slugification utilities for placement names https://review.openstack.org/556628 | |
| 22:14:51 | mriedem | efried: maybe you'd like to rev https://review.openstack.org/#/c/546813/ ? | |
| 22:14:57 | mriedem | i'm itching to +2 that | |