| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-03-26 | |||
| 18:25:43 | cdent | ? | |
| 18:25:58 | melwitt | tssurya: hey, thanks for bringing up the user_id column in instance_mappings table thing. I agree it should be a separate spec to handle the "quota when cell-down" issue. I have an old spec for it that I can resurrect. my spec will depend on yours because I also need the queued_for_delete column | |
| 18:27:05 | tssurya | melwitt: okay, :) I guess we can co-ordinate on this then, I will let you know as soon as I put up a spec for it then. | |
| 18:27:27 | melwitt | tssurya: cool, thank you :) | |
| 18:27:38 | efried | cdent: Not quite. I was reviewing 520313 which has code that will wind up sending down an RP name that will fail - https://review.openstack.org/#/c/520313/23/nova/tests/unit/virt/xenapi/test_driver.py@443. Letting the API fail in this case will be worse than suboptimal, because by the time that happens, we're outside of where virt can do anything about it. | |
| 18:27:58 | efried | cdent: This isn't the first time I've seen a need for a method to "slugify" a placement identifier, so I thought I would write it. | |
| 18:28:01 | tssurya | melwitt: the only concern I have is that at the PTG, we discussed that we would not use placement and do a solution of allowing the users to create VMs if they don't have any in the down cell | |
| 18:28:07 | cdent | efried: I was teasing | |
| 18:28:12 | cdent | gentle ribbing and all that | |
| 18:28:38 | tssurya | melwitt: however if we are going to use placement, then this changes things i guess | |
| 18:28:38 | melwitt | tssurya: you mean disallowing? | |
| 18:28:47 | efried | cdent: It's a valid concern that you should check me on constantly, even though (or perhaps especially because) you and I fundamentally disagree on whether such pre-optimizations are desirable. | |
| 18:29:02 | efried | cdent: But in this case, it's more than that. | |
| 18:29:08 | tssurya | melwitt: no, I mean allowing VM creation as long as there are no living VMs in the down cell | |
| 18:29:23 | tssurya | melwitt: since in that case the quota calculation will be correct | |
| 18:29:46 | melwitt | tssurya: yeah, that was when we had thought being able to count instances while cells are down would require adding a "type" to placement allocations. that is something that will take a lot of work to figure out | |
| 18:29:50 | sean-k-mooney | efried: maybe just take the lenght as an optional param that you defalt to 255 and the caller can set 200 or what ever if they no its less for that field | |
| 18:29:50 | cdent | Fair enough. I never really said they are not desierable, I suggested that they should wait for the road to show they are needed. | |
| 18:30:46 | tssurya | melwitt: ah okay, so then I will do a spec for queued_for_delete and we can take it from there then | |
| 18:31:33 | melwitt | tssurya: yeah. we had said that because at the time we were thinking to remove the dependency on reading cell databases, we would have to add a "type" to placement allocations and that was not going to be straightforward and needed a lot more time and design | |
| 18:32:17 | tssurya | melwitt: hmm yea now I remember, thanks! | |
| 18:32:26 | melwitt | tssurya: but when I was thinking about it later, if we have queued_for_delete (from your spec) that was the main missing piece preventing us from being able to count instances in the instance_mappings table. the other piece is user_id | |
| 18:33:21 | melwitt | the "queued_for_delete" column was controversial in the past, but now that it's not, it opens that door again | |
| 18:33:38 | tssurya | melwitt: yea I agree, I guess I will go ahead with the queued_for_delete and will leave out the user_id for a separate spec and we (you) can battle out adding the "type" with the placement guys later | |
| 18:33:50 | melwitt | user_id I think is not controversial because we already have project_id, I'm actually not sure why we didn't add user_id too | |
| 18:34:27 | tssurya | melwitt: the reason I was asking for the user_id is because I could do these two in the same spec if you want like dansmith said its one migration | |
| 18:34:48 | melwitt | tssurya: sounds good | |
| 18:35:15 | melwitt | tssurya: yeah, I agree with him that it can be one migration, just two specs where each problem being solved for down cells is described in detail separately | |
| 18:35:23 | melwitt | just so it's easier to organize | |
| 18:36:30 | tssurya | melwitt: cool, I was waiting to get your opinion too, so I will do it in two specs, one for nova-list/service-list when a cell is down, second for quotas when a cell goes down, however I won't touch any from placement | |
| 18:36:39 | tssurya | calculations since you already have a spec | |
| 18:37:45 | melwitt | tssurya: okay, won't that mean we would have three specs then? I was thinking I would just roll the "add user_id column" stuff into the spec I have https://review.openstack.org/#/c/509042 | |
| 18:38:23 | melwitt | and then also add reference to your spec where it depends on your queued_for_delete column | |
| 18:38:35 | tssurya | melwitt: oh yes that's fine with me | |
| 18:38:54 | tssurya | melwitt: so I will do one single spec with queued_for_delete, | |
| 18:39:06 | tssurya | melwitt: sounds good ? | |
| 18:39:11 | melwitt | tssurya: yep sounds good | |
| 18:39:30 | tssurya | melwitt: thank you | |
| 18:40:37 | openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: Localdisk https://review.openstack.org/549300 | |
| 18:52:11 | openstackgerrit | Dan Smith proposed openstack/nova master: Add aggregates list to Destination object https://review.openstack.org/544729 | |
| 18:52:11 | openstackgerrit | Dan Smith proposed openstack/nova master: Add request filter functionality to scheduler https://review.openstack.org/544730 | |
| 18:52:12 | openstackgerrit | Dan Smith proposed openstack/nova master: Add an index on aggregate_metadata.value https://review.openstack.org/555851 | |
| 18:52:12 | openstackgerrit | Dan Smith proposed openstack/nova master: Make get_allocation_candidates() honor aggregate restrictions https://review.openstack.org/547990 | |
| 18:52:13 | openstackgerrit | Dan Smith proposed openstack/nova master: Add require_tenant_aggregate request filter https://review.openstack.org/545002 | |
| 18:52:13 | openstackgerrit | Dan Smith proposed openstack/nova master: Add AggregateList.get_by_metadata() query method https://review.openstack.org/544728 | |
| 18:52:14 | openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Honor availability_zone hint via placement https://review.openstack.org/546282 | |
| 19:16:00 | imacdonn | mriedem or toabctl : either of you around ? | |
| 19:19:47 | imacdonn | mriedem toabctl In case you show up while I'm at lunch:) Regarding https://github.com/openstack/nova/commit/3a3b0f09db318faf1a1ea711a73bb365cab8b233 - I think we have the same issue with the "image" service, if glance.api_servers is not configured (which is recommended) | |
| 19:21:54 | imacdonn | efried: your name is on this too :) https://github.com/openstack/nova/blob/master/nova/image/glance.py#L114-L116 | |
| 19:23:03 | mriedem | imacdonn: 'image' is already in that list https://github.com/openstack/nova/commit/3a3b0f09db318faf1a1ea711a73bb365cab8b233#diff-c83f1fae2a677ed29036e293dd0e63caR121 | |
| 19:23:09 | efried | yeah, what he said. | |
| 19:23:19 | mriedem | devstack doesn't set glance.api_servers either | |
| 19:23:47 | imacdonn | oh yeah, I'm blind | |
| 19:23:53 | imacdonn | I wonder why I'm getting this, then... | |
| 19:24:23 | imacdonn | 2018-03-26 19:00:54.238 46339 ERROR nova.compute.manager [instance: 41164565-c7a2-4f96-9fcf-222847ecf113] "interfaces: %s" % interfaces) | |
| 19:24:23 | imacdonn | 2018-03-26 19:00:54.238 46339 ERROR nova.compute.manager [instance: 41164565-c7a2-4f96-9fcf-222847ecf113] File "/usr/lib/python2.7/site-packages/nova/utils.py", line 1373, in get_endpoint | |
| 19:24:23 | imacdonn | 2018-03-26 19:00:54.238 46339 ERROR nova.compute.manager [instance: 41164565-c7a2-4f96-9fcf-222847ecf113] endpoint = utils.get_endpoint(ksa_adap) | |
| 19:24:23 | imacdonn | 2018-03-26 19:00:54.238 46339 ERROR nova.compute.manager [instance: 41164565-c7a2-4f96-9fcf-222847ecf113] File "/usr/lib/python2.7/site-packages/nova/image/glance.py", line 126, in get_api_servers | |
| 19:24:27 | imacdonn | 2018-03-26 19:00:54.238 46339 ERROR nova.compute.manager [instance: 41164565-c7a2-4f96-9fcf-222847ecf113] EndpointNotFound: Could not find requested endpoint for any of the following interfaces: ['internal', 'public'] | |
| 19:24:41 | mriedem | i probably know why | |
| 19:24:54 | mriedem | https://review.openstack.org/#/c/554703/ | |
| 19:25:32 | imacdonn | 4 days ago, eh? that seems plausible | |
| 19:26:57 | imacdonn | will have to see if I'm doing something "the old way" ... removed the api_servers option to try to be current :) | |
| 19:27:59 | imacdonn | I guess maybe it's the code, not me ... not using versioned notifications | |
| 19:31:44 | mriedem | this isn't about versioned notifications | |
| 19:31:56 | mriedem | it's about notifications sent during periodic tasks where we don't have a token | |
| 19:32:26 | imacdonn | You comment says "there isn't much the operator can do about it outside of (1) switching entirely to versioned notifications, which not many people are using yet if at all, or ...." | |
| 19:32:27 | openstackgerrit | Eric Fried proposed openstack/nova master: Slugification utilities for placement names https://review.openstack.org/556628 | |
| 19:32:32 | efried | cdent: For nosey parkers ^ | |
| 19:39:35 | openstackgerrit | melanie witt proposed openstack/nova master: Migrate tempest-dsvm-multinode-live-migration job in-tree https://review.openstack.org/555945 | |
| 19:42:29 | openstackgerrit | Eric Fried proposed openstack/nova master: doc: Upgrade placement first https://review.openstack.org/556631 | |
| 19:42:40 | efried | mriedem, jaypipes, dansmith, sean-k-mooney cdent edleafe ^ | |
| 19:57:06 | openstackgerrit | Eric Fried proposed openstack/nova master: Get rid of 406 paths in report client https://review.openstack.org/556633 | |
| 19:57:17 | efried | mriedem, jaypipes, dansmith, sean-k-mooney cdent edleafe and ^ | |
| 19:57:27 | efried | dev ML note coming soon | |
| 19:57:56 | cdent | efried is a stack not a queue | |
| 19:58:26 | efried | cdent: Too true, much to my dismay. | |
| 19:58:48 | cdent | takes all kinds | |
| 20:02:48 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "bind_ports_to_host" neutron API method https://review.openstack.org/523604 | |
| 20:02:49 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: libvirt: use dest host vif migrate details for live migration https://review.openstack.org/551370 | |
| 20:02:49 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add VIFMigrateData object for live migration https://review.openstack.org/515423 | |
| 20:02:50 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "activate_port_binding" neutron API method https://review.openstack.org/555947 | |
| 20:02:50 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add "delete_port_binding" network API method https://review.openstack.org/552170 | |
| 20:02:51 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Implement migrate_instance_start method for neutron https://review.openstack.org/556334 | |
| 20:02:51 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Delete port bindings in setup_networks_on_host if teardown=True https://review.openstack.org/556333 | |
| 20:02:52 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Port binding based on events during live migration https://review.openstack.org/434870 | |
| 20:02:52 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: compute: use port binding extended API during live migration https://review.openstack.org/551371 | |
| 20:02:53 | openstackgerrit | Matt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate https://review.openstack.org/522537 | |
| 20:05:09 | openstackgerrit | Matt Riedemann proposed openstack/osc-placement stable/queens: Migrate legacy-osc-placement-dsvm-functional job in-tree https://review.openstack.org/556635 | |
| 20:09:48 | mriedem | esberglu: why is tempest.api.compute.servers.test_attach_interfaces.AttachInterfacesTestJSON.test_create_list_show_delete_interfaces_by_network_port[id-73fe8f02-590d-4bf1-b184-e9ca81065051,network] skipped in https://review.openstack.org/#/c/546813/ ? | |
| 20:15:32 | openstackgerrit | Merged openstack/nova master: Standardize '_get_XXX_constraint' functions https://review.openstack.org/385071 | |
| 20:23:40 | cfriesen | Suppose I have a stopped instance. I then restart nova-compute. It appears that _init_instance() will call self.driver.plug_vifs() unconditionally. Is this expected/necessary? Won't we call plug_vifs from the power_on() code anyways? | |
| 20:36:31 | openstackgerrit | Merged openstack/nova master: tox: Fix indentation https://review.openstack.org/556543 | |
| 20:38:15 | esberglu | mriedem: We're working on a solution to that. Right now to attach interfaces we need to wait for the RMC connection to become active for the instance | |
| 20:38:32 | esberglu | Which takes a really long time (like 10 minutes) | |
| 20:39:01 | esberglu | We're trying to get something going in our CI that will pre-spawn the instances so that they are ready by the time tempest gets to that test | |
| 20:41:59 | mriedem | esberglu: ok then you just have some small things to update in that patch and i'll be +2 on it | |
| 20:43:06 | esberglu | mriedem: ack. Thanks for the review | |
| 20:47:36 | efried | mriedem: D'oh, I totally shoulda thought to send that mail to the ops list. Thanks for forwarding. | |
| 20:59:19 | imacdonn | mriedem efried Another stupid question.... for things like neutron, placement, etc., is it reasonable to assume that if I don't need to override them, the keystone stuff from [keystone_authtoken] (auth_url, auth_type, etc.) should apply? It seems somewhat inconsistent .. e.g. it seems to work for cinder, but not for neutron | |