| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-02-22 | |||
| 17:49:33 | claudiub | mriedem: then, if I may abuse your not that generous-ness, can you take a look at the autospec stuff? :D | |
| 17:54:18 | cfriesen | jaypipes: in the context of the "shared/dedicated on one host", I just added some comments. If we're going to allow both on one host then I think it would make sense to have the usage numbers ("vcpus_used" in "nova hypervisor-show" for example) accurately reflect what's on the system. | |
| 17:54:59 | jaypipes | cfriesen: yeah, I saw your comments. this is definitely something to talk about next week... | |
| 17:55:05 | jaypipes | cfriesen: will you be there? | |
| 17:55:18 | cfriesen | yep, starting monday afternoon | |
| 17:55:35 | jaypipes | cfriesen: also, keep in mind vcpus_used has absolutely nothing to do with pCPUs. | |
| 17:55:43 | mriedem | umm wtf - flavor doesn't show up in the server response? http://paste.openstack.org/show/682314/ | |
| 17:55:49 | jaypipes | cfriesen: ne'er the two shall meet. ;) | |
| 17:56:14 | jaypipes | mriedem: lol. | |
| 17:56:20 | mriedem | oh i bet i know what it is, | |
| 17:56:29 | mriedem | osc can't handle microversion>=2.47 responses | |
| 17:56:33 | mriedem | where the flavor is a dict instead of a string | |
| 17:56:59 | jaypipes | mriedem: an awkward dict? | |
| 17:57:06 | cfriesen | jaypipes: hypervisor-show has "vcpus" and "vcpus_used". in our case we made it such that "vcpus" is len(vcpu_pin_set). This makes it easy to see how "full" your hypervisor is. | |
| 17:57:16 | mriedem | yup http://paste.openstack.org/show/682315/ | |
| 17:57:49 | jaypipes | cfriesen: that is an abuse. | |
| 17:57:55 | jaypipes | cfriesen: and completely incorrect :) | |
| 17:58:48 | openstack | Launchpad bug 1751104 in python-openstackclient "openstack server show with --os-compute-api-version >= 2.47 doesn't show the flavor" [Undecided,New] | |
| 17:58:48 | mriedem | cfriesen: since you delt it, maybe you'd like to fix this https://bugs.launchpad.net/python-openstackclient/+bug/1751104 | |
| 17:59:43 | cfriesen | ooo, fun | |
| 18:00:12 | cfriesen | yah, I think I can take that. | |
| 18:02:00 | mriedem | mdbooth: i think removing that would be wrong, and it's likely there for non-volume-backed instances anyway (like everything in nova) | |
| 18:02:29 | mriedem | mdbooth: i created a 20gb flavor instance from the devstack cirros image which has min_disk=0, and the resulting snapshot has min_disk=20 to match the flavor root_gb | |
| 18:03:28 | mdbooth | Right. So the 20GB restriction here should be because that's how many bits are physically required, which is represented in 'size'. | |
| 18:03:54 | mdbooth | IMHO min_disk should still be unset. | |
| 18:04:05 | mriedem | for the volume-backed snapshot you mean? | |
| 18:04:10 | mdbooth | Yeah. | |
| 18:04:10 | mriedem | i.e. exactly what this patch is doing? | |
| 18:05:11 | mdbooth | That patch is arbitrarily popping min_disk out of image metadata. | |
| 18:05:25 | mdbooth | I don't think it should have been in there in the first place. | |
| 18:05:40 | mdbooth | min_disk is analogous to min_ram here | |
| 18:09:46 | mriedem | mdbooth: i don't really agree, | |
| 18:09:57 | mriedem | for a volume-backed instance, the disk is what matters (or doesn't) | |
| 18:10:31 | mriedem | if i have a 20gb flavor instance and snapshot it to get a 20gb image, then the image should say that you need a flavor of a minimum of 20gb to boot an instance with that image, right? | |
| 18:10:52 | mriedem | but that's not true with a volume, since the flavor.root_gb isn't used for the volume | |
| 18:14:08 | dansmith | mriedem: min_disk should be the size of the volume in that case when you snapshot I think | |
| 18:14:15 | dansmith | flavor.root_gb if ephemeral | |
| 18:14:30 | mriedem | dansmith: that's what i originally asked in the patch | |
| 18:14:36 | mriedem | rather than pop off min_disk, | |
| 18:14:40 | mriedem | why not just set it to root_bdm.size | |
| 18:15:21 | mriedem | good point though | |
| 18:15:37 | dansmith | I haven't been following the discussion or the patch really, but .. yeah | |
| 18:16:47 | mdbooth | size != min_disk | |
| 18:16:47 | mdbooth | dansmith: That's size | |
| 18:17:03 | mdbooth | Size can be expanded, min_disk is what it is | |
| 18:17:18 | mriedem | another good point, i was combining those image attrs in my head | |
| 18:18:40 | cfriesen | do I need to do something special for "nova get-serial-console" to support the socat console used by ironic? | |
| 18:19:13 | mriedem | check the ironic docs | |
| 18:19:28 | mriedem | https://docs.openstack.org/ironic/pike/admin/console.html | |
| 18:19:36 | mriedem | cfriesen: man that google search was hard... | |
| 18:22:03 | cfriesen | the "ironic node-get-console" command is working and gives a URL, but "nova get-serial-console" returns an error. | |
| 18:32:51 | melwitt | I'm off to the airport o/ seeya at the PTG | |
| 18:36:24 | mriedem | lyarwood: if you're around still, i'm going to be going through this pike backport series which is pretty important, starting at https://review.openstack.org/#/c/546218/ | |
| 18:47:20 | mriedem | mnaser: wondering about some missing compute api unit tests in this pike backport https://review.openstack.org/#/c/546221/4 | |
| 18:48:47 | efried | jaypipes: Do you want me to remove "in the Traits database" everywhere or just that one spot? | |
| 18:48:54 | efried | jaypipes: E.g. in the reno | |
| 18:49:25 | jaypipes | efried: everywhere. that's just implementation detail that isn't relevant. | |
| 18:49:27 | mriedem | heh, i can see ops freaking out now | |
| 18:49:34 | mriedem | "nova added *another* database?!" | |
| 18:49:34 | efried | ight | |
| 18:49:38 | jaypipes | right. | |
| 18:50:29 | mnaser | mriedem: thank you for reviewing the patches meticulously. i made sure to leave the conflicts because i don't trust my git conflict resolution stuff :< | |
| 18:50:35 | mnaser | ill update it now | |
| 18:51:51 | openstackgerrit | Eric Fried proposed openstack/nova master: rp: GET /resource_providers?required= |
|
| 18:51:52 | efried | edleafe, jaypipes: All done ^ | |
| 18:51:52 | openstackgerrit | Eric Fried proposed openstack/nova master: Make _get_sharing_providers more efficient https://review.openstack.org/547008 | |
| 18:54:37 | edleafe | efried: thx | |
| 18:54:49 | efried | My pleasure. | |
| 18:54:58 | efried | Except for the part where I had to delete that sqla block | |
| 18:55:02 | efried | That was pain | |
| 18:55:04 | efried | pure pain | |
| 18:57:11 | openstackgerrit | Mohammed Naser proposed openstack/nova stable/pike: Add functional test for deleting BFV server with old attach flow https://review.openstack.org/546812 | |
| 18:57:11 | openstackgerrit | Mohammed Naser proposed openstack/nova stable/pike: Clean up ports and volumes when deleting ERROR instance https://review.openstack.org/546221 | |
| 18:57:12 | openstackgerrit | Mohammed Naser proposed openstack/nova stable/pike: Ensure attachment_id always exists for block device mapping https://review.openstack.org/546275 | |
| 18:57:49 | mnaser | mriedem: fixed + rebased stuff on top | |
| 18:58:39 | mriedem | mnaser: i see you've mastered git review -R :) | |
| 18:58:55 | mnaser | mriedem: yes, got to keep my +2 with a rebase :p | |
| 18:59:46 | mnaser | cherry picking skills still need a bit more work though | |
| 19:00:45 | mriedem | mnaser: +2s up and down | |
| 19:01:07 | mnaser | mriedem: nice, bauzas mentioned he would have a look at backports when he's back on thursday :P | |
| 19:01:08 | mriedem | bauzas: if you're still around https://review.openstack.org/#/q/topic:bug/1750666+branch:stable/pike | |
| 19:01:16 | mnaser | 2 seconds apart, ha | |
| 19:02:23 | jaypipes | efried: +2 from me on both. nice work. | |
| 19:02:29 | efried | Thanks jaypipes | |
| 19:03:04 | jaypipes | lol | |
| 19:03:25 | jaypipes | efried: dansmith is somewhere over the Atlantic I think. | |
| 19:04:00 | jaypipes | hehe | |
| 19:04:26 | gryf | don't be afraid. just increase the frequency of the shots ;) | |
| 19:49:21 | mriedem | cfriesen: we don't support live migration with sriov ports attached right? | |
| 19:52:27 | mriedem | i guess i'm thinking about https://review.openstack.org/#/c/286744/ | |
| 19:57:37 | mriedem | jay-afk-2: this should be a simple spec re-approval https://review.openstack.org/#/c/543578/ | |
| 20:24:43 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add code to bind a port against a dest host during live migration https://review.openstack.org/523604 | |
| 20:24:43 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add check if neutron "binding-extended" extension is available https://review.openstack.org/523548 | |
| 20:34:45 | dansmith | mriedem: looking at the glance docs, I'm not sure I understand what you and mdbooth said earlier while I was landing.. min_disk should be the minimum size disk you can boot it on, which would be defined by the filesystem in the image | |
| 20:35:38 | mriedem | he left a comment in that patch if that helps | |
| 20:37:22 | dansmith | mriedem: the glance docs say --size is deprecated | |
| 20:37:32 | dansmith | https://docs.openstack.org/python-openstackclient/pike/cli/command-objects/image.html | |
| 20:37:39 | dansmith | "Image version 1 only." | |
| 20:38:17 | mriedem | ah | |
| 20:38:20 | mriedem | didn't realize that | |