Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-02-14
23:47:54 mnaser ok awesome, i have to fix a few unit tests because of the changes in _bury_in_cell0 which now create bdms and should be ready for review soon
23:53:10 openstackgerrit Murali Annamneni proposed openstack/nova master: Enables MySQL Cluster Support for Nova https://review.openstack.org/446643
#openstack-nova - 2018-02-15
00:02:15 mriedem melwitt: this is what i wanted the retrospective link for http://lists.openstack.org/pipermail/openstack-dev/2018-February/127402.html
00:02:51 melwitt mriedem: a-ha, nice. I was just looking for that email to link in the agenda for tomorrow's meeting
00:06:32 mnaser here goes nothing :>
00:08:30 openstackgerrit Mohammed Naser proposed openstack/nova master: Clean up ports and volumes when deleting ERROR instance https://review.openstack.org/340614
00:08:30 openstackgerrit Mohammed Naser proposed openstack/nova master: Drop extra loop which modifies Cinder volume status https://review.openstack.org/539758
00:08:31 openstackgerrit Mohammed Naser proposed openstack/nova master: Store block device mappings in cell0 https://review.openstack.org/544748
00:08:31 openstackgerrit Mohammed Naser proposed openstack/nova master: Add functional tests to ensure BDM removal on delete https://review.openstack.org/544747
00:14:16 mnaser i guess at some point we'll have to squash the func. tests and clean up commit to get them to merge
00:15:06 melwitt mriedem: just updated the agenda for tomorrow's meeting https://wiki.openstack.org/wiki/Meetings/Nova
00:15:53 mriedem mnaser: what we usually do,
00:16:01 mriedem is land the regression test that asserts the failre,
00:16:03 melwitt mnaser: why? the way we do that is the func test is introduced with the after-bug-fix asserts commented out with a note (and I'll let mriedem finish)
00:16:11 mriedem then the patch that fixes it changes the functional test to show it's passing
00:17:02 mnaser ok i see so then my functional test is wrong
00:17:14 mnaser because it is a failing one (which will pass in the patch above of it)
00:18:19 mnaser so i will switch the best to make it assert the failure and then change the fixing patch as explained
00:19:53 melwitt mnaser: that's nearly there, just have to comment out the failing assert and add TODO(mnaser) above it to explain it should be uncommented in the same patch as the fix, then add an assert for the wrong (but expected) thing with a TODO to remove it in the fix patch
00:26:17 openstackgerrit Mohammed Naser proposed openstack/nova master: Store block device mappings in cell0 https://review.openstack.org/544748
00:26:18 openstackgerrit Mohammed Naser proposed openstack/nova master: Clean up ports and volumes when deleting ERROR instance https://review.openstack.org/340614
00:26:18 openstackgerrit Mohammed Naser proposed openstack/nova master: Add functional tests to ensure BDM removal on delete https://review.openstack.org/544747
00:26:28 mnaser that should do it
00:27:46 openstackgerrit Mohammed Naser proposed openstack/nova master: Drop extra loop which modifies Cinder volume status https://review.openstack.org/539758
00:27:47 openstackgerrit Mohammed Naser proposed openstack/nova master: Add functional tests to ensure BDM removal on delete https://review.openstack.org/544747
00:27:47 openstackgerrit Mohammed Naser proposed openstack/nova master: Store block device mappings in cell0 https://review.openstack.org/544748
00:27:48 openstackgerrit Mohammed Naser proposed openstack/nova master: Clean up ports and volumes when deleting ERROR instance https://review.openstack.org/340614
00:36:32 openstackgerrit Tetsuro Nakamura proposed openstack/nova-specs master: Enable NUMA Features for Libvirt/QEMU Driver https://review.openstack.org/533077
00:39:44 mriedem mnaser: melwitt: ok i've gone through the first 3, left some nits but nothing major
00:40:01 mriedem i can get the final big patch in the morning
00:42:04 melwitt thanks
00:43:15 mnaser mriedem: thanks, im addressing them now and rebasing
00:53:41 tonyb melwitt: It is indeed confusing. The "next pahse" shoudl just go strainght to EOL but there is a window in there where it's in Phase III while we do the EOLing ... and then we went and confused ourselves with the Long lived stable branches so I don't know what'll happen
00:54:14 tonyb melwitt: but there's a session at the PTG to discuss it so hopefully shortly after that I can at least make that table look more sane
00:54:45 melwitt tonyb: thanks for the glimpse at what it means :)
00:55:08 tonyb melwitt: ;P I guess you have to care more about that stuff now:)
00:55:29 melwitt nah, total coincidence
00:55:31 tonyb melwitt: anytime I can help you know where I am
00:55:35 melwitt :) thanks
00:55:39 tonyb melwitt: ohh my bad ;P
00:56:39 melwitt heh
01:09:29 openstackgerrit Mohammed Naser proposed openstack/nova master: Store block device mappings in cell0 https://review.openstack.org/544748
01:09:30 openstackgerrit Mohammed Naser proposed openstack/nova master: Add functional tests to ensure BDM removal on delete https://review.openstack.org/544747
01:09:31 openstackgerrit Mohammed Naser proposed openstack/nova master: Clean up ports and volumes when deleting ERROR instance https://review.openstack.org/340614
01:10:28 mnaser addressed all comments ^
01:46:10 openstackgerrit Mohammed Naser proposed openstack/nova master: Store block device mappings in cell0 https://review.openstack.org/544748
01:46:11 openstackgerrit Mohammed Naser proposed openstack/nova master: Clean up ports and volumes when deleting ERROR instance https://review.openstack.org/340614
01:46:11 openstackgerrit Mohammed Naser proposed openstack/nova master: Add functional tests to ensure BDM removal on delete https://review.openstack.org/544747
01:46:12 mnaser ..broke some functional tests and fixed them..
02:04:17 openstackgerrit melanie witt proposed openstack/nova master: Add periodic task to clean expired console tokens https://review.openstack.org/325381
02:04:18 openstackgerrit melanie witt proposed openstack/nova master: Convert websocketproxy to use db for token validation https://review.openstack.org/333990
02:04:18 openstackgerrit melanie witt proposed openstack/nova master: Use ConsoleAuthToken object to generate authorizations https://review.openstack.org/325414
02:18:23 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: [libvirt] Add _get_vcpu_realtime_scheduler() https://review.openstack.org/527630
02:18:24 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: [libvirt] Add _get_XXXpin_cpuset() https://review.openstack.org/527631
02:18:24 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: [libvirt] Add _get_numa_memnode() https://review.openstack.org/529906
02:18:25 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: disable cpu pinning with libvirt/qemu driver https://review.openstack.org/531049
02:18:25 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Add NumaTopology support for libvirt/qemu driver https://review.openstack.org/530451
03:54:32 openstackgerrit Hironori Shiina proposed openstack/nova master: ironic: Clean up resources after unprovision fails https://review.openstack.org/544772
04:13:14 openstackgerrit Merged openstack/nova master: Fix nits in allocation candidate limit handling https://review.openstack.org/536784
05:10:24 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Add NumaTopology support for libvirt/qemu driver https://review.openstack.org/530451
05:10:24 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: [libvirt] Add _get_XXXpin_cpuset() https://review.openstack.org/527631
05:10:25 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: disable cpu pinning with libvirt/qemu driver https://review.openstack.org/531049
05:17:54 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: [libvirt] Add _get_numa_memnode() https://review.openstack.org/529906
05:17:54 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: [libvirt] Add _get_vcpu_realtime_scheduler() https://review.openstack.org/527630
05:17:55 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Add NumaTopology support for libvirt/qemu driver https://review.openstack.org/530451
05:17:55 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: [libvirt] Add _get_XXXpin_cpuset() https://review.openstack.org/527631
05:17:56 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: disable cpu pinning with libvirt/qemu driver https://review.openstack.org/531049
07:22:21 openstackgerrit Merged openstack/nova master: Avoid inventory DELETE API (no conflict detection) https://review.openstack.org/539712
08:01:11 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/541561
08:13:54 gibi good morning
08:23:50 hrw morning
08:42:20 ameeda morning :)
08:43:36 ameeda gibi: thanks for reviews. what about this https://review.openstack.org/#/c/542378/ ? I am not sure why bug reporter asked to add this file, do you guess that I have to remove it ?
08:44:59 ameeda also regarding this https://review.openstack.org/#/c/543348/, I will ask openstack-requirements channel to get suitable answer
08:47:02 gibi ameeda: by reading the bug report I think dhellmann wants to move the doc only requirements to a separate file and _then_ change tox to use that requirement file for doc generation
08:48:19 gibi ameeda: I think you missed that second part
08:48:57 ameeda gibi: let me check. brb
08:55:31 ameeda gibi: thank for the update, I guess the edit of tox.ini will be here https://review.openstack.org/#/c/543348/1/tox.ini , so the old tox.ini was running correctly since the test-requirements have all requirements.
08:55:39 ameeda gibi: it make since ?
09:01:11 gmann_ gibi: your fix looks fine just comment for newton branch - https://review.openstack.org/#/c/538908/3
09:04:18 gibi ameeda: I don't get it. This patch https://review.openstack.org/#/c/543348/1/tox.ini still does not refer to the doc/requirements.txt you created in https://review.openstack.org/#/c/542378/
09:04:34 gibi ameeda: so something is missing
09:06:16 ameeda gibi: so I have to edit this https://review.openstack.org/#/c/543348/1/tox.ini to have -r{toxinidir}/doc/requirements.txt ? so my edit must be in this review https://review.openstack.org/#/c/543348/ to avoid merge conflict ?
09:09:18 gibi ameeda: I would keep your two change separate. I would change the tox.ini in https://review.openstack.org/#/c/542378/ to use the new doc/requirements.txt
09:09:58 gibi ameeda: for the testenv:docs and the testenv:releasenotes target
09:10:39 ameeda gibi: what should I write to use it ?
09:11:18 ameeda gibi: deps = -r{toxinidir}/doc/requirements.txt, right ?
09:11:22 gibi ameeda: I guess deps = -r{toxinidir}/doc/test-requirements.txt
09:11:28 gibi ameeda: yes
09:11:40 ameeda okay, Thanks for help ^_^
09:13:26 gibi gmann_: looking
09:13:39 ameeda gibi: is this correct https://pasteboard.co/H7JnfYu.png ?
09:14:25 gibi ameeda: at least that is what I would try :)
09:15:08 ameeda gibi: so I will upload new patch now ^_^
09:15:20 openstackgerrit Ameed Ashour proposed openstack/osc-placement master: Change documentation theme https://review.openstack.org/542378
09:26:39 openstackgerrit Ameed Ashour proposed openstack/osc-placement master: Change documentation theme https://review.openstack.org/542378
09:32:05 openstackgerrit Ameed Ashour proposed openstack/osc-placement master: Change documentation theme https://review.openstack.org/542378
09:40:12 bauzas morning Nova
09:41:07 ameeda bauzas: morning :)
09:43:51 gibi gmann_: I removed the newton branches from https://review.openstack.org/#/c/538908/

Earlier   Later